RFR: SKARA-758: Add /check pull request command
Kartik Ohri
github.com+27751938+amcap1712 at openjdk.java.net
Fri Nov 20 12:30:48 UTC 2020
On Tue, 17 Nov 2020 16:11:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:
>> Hi!
>> Kindly review the patch to allow manual execution of jcheck. I think it might be worthwhile to restrict this command to some specific people but I am not sure who that should be (maybe restricting to the author is enough but a reviewer might want to execute it as well in case its urgent).
>>
>> I wanted to test this locally by setting up the skara bots on my own repository but was unable to figure out how to do so due to lack of documentation.
>> Thanks.
>> Regards,
>> Kartik
>
> Hi @amCap1712, thanks for working on this!
>
> Please consider adding a unit test for the `/check` command, see e.g. [SummaryTests.java](https://github.com/openjdk/skara/blob/master/bots/pr/src/test/java/org/openjdk/skara/bots/pr/SummaryTests.java) for an example of a unit test for a pull request command.
>
> Thanks,
> Erik
Hi @edvbld,
Thanks for the review. I have added a unit test as you asked. Let me know if any other changes are required.
Regards,
Kartik.
-------------
PR: https://git.openjdk.java.net/skara/pull/954
More information about the skara-dev
mailing list