RFR: Move testing information from the PR body to checks [v2]

Jorn Vernee jvernee at openjdk.java.net
Fri Nov 27 17:04:03 UTC 2020


On Thu, 26 Nov 2020 16:14:25 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> When summarizing pre-submit test results for a PR, show the results as a number of checks instead of a table in the PR body. This makes them more similar to the source information, and avoids excessive PR body updates.
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only create summarized checks and put the individual job details in the check summary

Marked as reviewed by jvernee (Reviewer).

bots/testinfo/src/main/java/org/openjdk/skara/bots/testinfo/TestInfoBot.java line 37:

> 35:     private final Map<String, Instant> expirations = new HashMap<>();
> 36: 
> 37:     private static final Logger log = Logger.getLogger("org.openjdk.skara.bots");;

Nit: double semi-colon
Suggestion:

    private static final Logger log = Logger.getLogger("org.openjdk.skara.bots");

-------------

PR: https://git.openjdk.java.net/skara/pull/962


More information about the skara-dev mailing list