From rwestberg at openjdk.java.net Thu Oct 1 08:48:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 1 Oct 2020 08:48:37 GMT Subject: RFR: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums Message-ID: At least for GitLab, the body of a pull request can be amended server side with additional newlines. Ensure that this does not affect the metadata calculation. ------------- Commit messages: - Ensure that spurious newlines added by the hosted provider does not give different metadata checksums Changes: https://git.openjdk.java.net/skara/pull/857/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=857&range=00 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/857.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/857/head:pull/857 PR: https://git.openjdk.java.net/skara/pull/857 From rwestberg at openjdk.java.net Fri Oct 2 07:56:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 2 Oct 2020 07:56:08 GMT Subject: RFR: Avoid potentially moving folders across volume boundaries Message-ID: When a checked out repository cannot be cleaned, the folder is moved to a separate location to allow further manual inspection. Avoid moving them across volume boundaries. ------------- Commit messages: - Avoid potentially moving folders across volume boundaries Changes: https://git.openjdk.java.net/skara/pull/858/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=858&range=00 Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/858.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/858/head:pull/858 PR: https://git.openjdk.java.net/skara/pull/858 From ehelin at openjdk.java.net Mon Oct 5 07:08:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 5 Oct 2020 07:08:49 GMT Subject: RFR: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums In-Reply-To: References: Message-ID: <7WO0ZNzwshAj-_PXIa9fqWe060jVXmzb66wDZtETTWs=.07f4d06d-6fed-4592-a546-d0813a3b7e22@github.com> On Thu, 1 Oct 2020 08:45:32 GMT, Robin Westberg wrote: > At least for GitLab, the body of a pull request can be amended server side with additional newlines. Ensure that this > does not affect the metadata calculation. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/857 From ehelin at openjdk.java.net Mon Oct 5 07:09:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 5 Oct 2020 07:09:09 GMT Subject: RFR: Avoid potentially moving folders across volume boundaries In-Reply-To: References: Message-ID: On Fri, 2 Oct 2020 07:53:25 GMT, Robin Westberg wrote: > When a checked out repository cannot be cleaned, the folder is moved to a separate location to allow further manual > inspection. Avoid moving them across volume boundaries. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/858 From rwestberg at openjdk.java.net Mon Oct 5 09:31:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 09:31:50 GMT Subject: Integrated: Ensure that spurious newlines added by the hosted provider does not give different metadata checksums In-Reply-To: References: Message-ID: On Thu, 1 Oct 2020 08:45:32 GMT, Robin Westberg wrote: > At least for GitLab, the body of a pull request can be amended server side with additional newlines. Ensure that this > does not affect the metadata calculation. This pull request has now been integrated. Changeset: 4678f1ab Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/4678f1ab Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Ensure that spurious newlines added by the hosted provider does not give different metadata checksums Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/857 From rwestberg at openjdk.java.net Mon Oct 5 09:32:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 09:32:41 GMT Subject: Integrated: Avoid potentially moving folders across volume boundaries In-Reply-To: References: Message-ID: On Fri, 2 Oct 2020 07:53:25 GMT, Robin Westberg wrote: > When a checked out repository cannot be cleaned, the folder is moved to a separate location to allow further manual > inspection. Avoid moving them across volume boundaries. This pull request has now been integrated. Changeset: 3a8e3170 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/3a8e3170 Stats: 9 lines in 1 file changed: 0 ins; 8 del; 1 mod Avoid potentially moving folders across volume boundaries Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/858 From rwestberg at openjdk.java.net Mon Oct 5 12:50:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 12:50:40 GMT Subject: RFR: Show a summary of pre-submit testing results in the PR body (if any) [v2] In-Reply-To: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> References: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> Message-ID: > Now that we are executing pre-submit tests for certain OpenJDK repositories, we can also display a summary of the > results in the PR body, to help reviewers determine the test status of a change. Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: - Final adjustments - Updated after off-line review comments ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/855/files - new: https://git.openjdk.java.net/skara/pull/855/files/223de8e3..1f843be5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=855&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=855&range=00-01 Stats: 425 lines in 4 files changed: 363 ins; 54 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/855.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/855/head:pull/855 PR: https://git.openjdk.java.net/skara/pull/855 From rwestberg at openjdk.java.net Mon Oct 5 13:01:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 13:01:11 GMT Subject: Integrated: Show a summary of pre-submit testing results in the PR body (if any) In-Reply-To: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> References: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> Message-ID: On Wed, 30 Sep 2020 10:48:21 GMT, Robin Westberg wrote: > Now that we are executing pre-submit tests for certain OpenJDK repositories, we can also display a summary of the > results in the PR body, to help reviewers determine the test status of a change. This pull request has now been integrated. Changeset: 343c512a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/343c512a Stats: 515 lines in 13 files changed: 507 ins; 3 del; 5 mod Show a summary of pre-submit testing results in the PR body (if any) Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/855 From rwestberg at openjdk.java.net Mon Oct 5 13:28:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 13:28:47 GMT Subject: RFR: Adjust test result headings Message-ID: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> Adjust the generic heading as well as the platform-specific ones (for the Skara repo). ------------- Commit messages: - Adjust test headings Changes: https://git.openjdk.java.net/skara/pull/859/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=859&range=00 Stats: 13 lines in 4 files changed: 3 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/859.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/859/head:pull/859 PR: https://git.openjdk.java.net/skara/pull/859 From rwestberg at openjdk.java.net Mon Oct 5 13:37:02 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 13:37:02 GMT Subject: RFR: Adjust test result headings [v2] In-Reply-To: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> References: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> Message-ID: <9vzOgwnMR_KXxY4ubIdRdLABF5HxYgIvO8qm54RW5cg=.692a2196-6912-4abe-a516-d972afb70581@github.com> > Adjust the generic heading as well as the platform-specific ones (for the Skara repo). Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: In progress -> running ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/859/files - new: https://git.openjdk.java.net/skara/pull/859/files/593e99e3..1eec6938 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=859&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=859&range=00-01 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/859.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/859/head:pull/859 PR: https://git.openjdk.java.net/skara/pull/859 From ehelin at openjdk.java.net Mon Oct 5 13:37:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 5 Oct 2020 13:37:03 GMT Subject: RFR: Adjust test result headings [v2] In-Reply-To: <9vzOgwnMR_KXxY4ubIdRdLABF5HxYgIvO8qm54RW5cg=.692a2196-6912-4abe-a516-d972afb70581@github.com> References: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> <9vzOgwnMR_KXxY4ubIdRdLABF5HxYgIvO8qm54RW5cg=.692a2196-6912-4abe-a516-d972afb70581@github.com> Message-ID: On Mon, 5 Oct 2020 13:34:43 GMT, Robin Westberg wrote: >> Adjust the generic heading as well as the platform-specific ones (for the Skara repo). > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > In progress -> running Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/859 From rwestberg at openjdk.java.net Mon Oct 5 13:48:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 5 Oct 2020 13:48:00 GMT Subject: Integrated: Adjust test result headings In-Reply-To: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> References: <0BO6rhaH6p2-eM4p4tcYH3IVRoKoL8dVWKS2bUxq-EA=.22e9e191-e861-4ec5-8d47-96d04b8748ba@github.com> Message-ID: <3xkqsyarP8BagWZhvARwD2Zzs-HOwNOiO-xeiY35p78=.a161b1af-0573-4931-ac2f-3775b03ef45a@github.com> On Mon, 5 Oct 2020 13:26:09 GMT, Robin Westberg wrote: > Adjust the generic heading as well as the platform-specific ones (for the Skara repo). This pull request has now been integrated. Changeset: 4d35cb11 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/4d35cb11 Stats: 15 lines in 4 files changed: 3 ins; 0 del; 12 mod Adjust test result headings Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/859 From rwestberg at openjdk.java.net Tue Oct 6 07:51:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 07:51:00 GMT Subject: RFR: Improve PR bot startup performance Message-ID: The PR bot can start with only looking at recently updated PRs while caches are being populated due to a restart. This will improve response times after new code is deployed. ------------- Commit messages: - Improve PR bot startup performance Changes: https://git.openjdk.java.net/skara/pull/860/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=860&range=00 Stats: 34 lines in 2 files changed: 29 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/860.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/860/head:pull/860 PR: https://git.openjdk.java.net/skara/pull/860 From ehelin at openjdk.java.net Tue Oct 6 08:00:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 6 Oct 2020 08:00:13 GMT Subject: RFR: Improve PR bot startup performance In-Reply-To: References: Message-ID: On Tue, 6 Oct 2020 07:48:19 GMT, Robin Westberg wrote: > The PR bot can start with only looking at recently updated PRs while caches are being populated due to a restart. This > will improve response times after new code is deployed. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/860 From rwestberg at openjdk.java.net Tue Oct 6 08:10:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 08:10:03 GMT Subject: Integrated: Improve PR bot startup performance In-Reply-To: References: Message-ID: On Tue, 6 Oct 2020 07:48:19 GMT, Robin Westberg wrote: > The PR bot can start with only looking at recently updated PRs while caches are being populated due to a restart. This > will improve response times after new code is deployed. This pull request has now been integrated. Changeset: 245fd4ae Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/245fd4ae Stats: 34 lines in 2 files changed: 29 ins; 0 del; 5 mod Improve PR bot startup performance Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/860 From rwestberg at openjdk.java.net Tue Oct 6 08:56:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 08:56:47 GMT Subject: RFR: Use separate timestamps for updated at and expires at Message-ID: The updatedAt timestamp comes from the server, so use a separate timestamp to determine cache expiration. ------------- Commit messages: - Use separate timestamps for updated at (which comes from the server) and the expires at (which is local) Changes: https://git.openjdk.java.net/skara/pull/861/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=861&range=00 Stats: 11 lines in 1 file changed: 7 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/861.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/861/head:pull/861 PR: https://git.openjdk.java.net/skara/pull/861 From ehelin at openjdk.java.net Tue Oct 6 09:02:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 6 Oct 2020 09:02:57 GMT Subject: RFR: Use separate timestamps for updated at and expires at In-Reply-To: References: Message-ID: On Tue, 6 Oct 2020 08:51:40 GMT, Robin Westberg wrote: > The updatedAt timestamp comes from the server, so use a separate timestamp to determine cache expiration. Looks good ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/861 From rwestberg at openjdk.java.net Tue Oct 6 09:11:22 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 09:11:22 GMT Subject: Integrated: Use separate timestamps for updated at and expires at In-Reply-To: References: Message-ID: <7F1lBwdHQg4j1DJKyQMgJMSNIxSFqZ2PhshpS7eLvmc=.a6d61ae8-05c5-4c05-8635-998fc680cee4@github.com> On Tue, 6 Oct 2020 08:51:40 GMT, Robin Westberg wrote: > The updatedAt timestamp comes from the server, so use a separate timestamp to determine cache expiration. This pull request has now been integrated. Changeset: 516583d5 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/516583d5 Stats: 11 lines in 1 file changed: 7 ins; 0 del; 4 mod Use separate timestamps for updated at and expires at Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/861 From ehelin at openjdk.java.net Tue Oct 6 09:36:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 6 Oct 2020 09:36:37 GMT Subject: Integrated: vcs: introduce "Backport-of" trailer In-Reply-To: <7UyqIrSeV2v0IvjdAnxgcpvaBCxFpmIC7vSz9Ruhq2s=.4f115732-0f7a-41e3-85b7-a8cb35687b54@github.com> References: <7UyqIrSeV2v0IvjdAnxgcpvaBCxFpmIC7vSz9Ruhq2s=.4f115732-0f7a-41e3-85b7-a8cb35687b54@github.com> Message-ID: On Wed, 30 Sep 2020 13:45:34 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that adds support for the "Backport-of" trailer to commit messages. > > Testing: > - [x] Added three new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: ee633eef Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ee633eef Stats: 91 lines in 8 files changed: 85 ins; 0 del; 6 mod vcs: introduce "Backport-of" trailer Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/856 From rwestberg at openjdk.java.net Tue Oct 6 13:19:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 13:19:04 GMT Subject: RFR: Add support for marking PR body content with an expiration time Message-ID: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> For information in the PR body that is calculated using data from external sources (like Jira, another personal fork, etc.) we need to perform a periodical refresh, as our normal way of detecting updates cannot be used (the updatedAt field of a pull request). ------------- Commit messages: - Add support for marking PR body content with an expiration time, for data that comes from "external" sources Changes: https://git.openjdk.java.net/skara/pull/862/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=862&range=00 Stats: 143 lines in 7 files changed: 133 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/862.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/862/head:pull/862 PR: https://git.openjdk.java.net/skara/pull/862 From ehelin at openjdk.java.net Tue Oct 6 13:33:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 6 Oct 2020 13:33:47 GMT Subject: RFR: Add support for marking PR body content with an expiration time In-Reply-To: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> References: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> Message-ID: <-vY8A7Oq1BqBg-8iYLGdGhLI7jNc54wAgidd7CiJ6rs=.d0b358b6-adf4-42f4-b199-d662ddc71706@github.com> On Tue, 6 Oct 2020 13:16:27 GMT, Robin Westberg wrote: > For information in the PR body that is calculated using data from external sources (like Jira, another personal fork, > etc.) we need to perform a periodical refresh, as our normal way of detecting updates cannot be used (the updatedAt > field of a pull request). Looks good, just a small suggestion to simplify returning a random string ?? bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 71: > 69: var hasExpired = ExpirationTracker.hasExpired(body); > 70: if (hasExpired) { > 71: return > Base64.getUrlEncoder().encodeToString(UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8)); Suggestion: return String.valueOf(Math.random()); ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/862 From rwestberg at openjdk.java.net Tue Oct 6 13:37:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 13:37:32 GMT Subject: RFR: Add support for marking PR body content with an expiration time [v2] In-Reply-To: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> References: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> Message-ID: > For information in the PR body that is calculated using data from external sources (like Jira, another personal fork, > etc.) we need to perform a periodical refresh, as our normal way of detecting updates cannot be used (the updatedAt > field of a pull request). Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java Co-authored-by: Erik Duveblad ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/862/files - new: https://git.openjdk.java.net/skara/pull/862/files/cd19ac11..1d6b7d42 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=862&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=862&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/862.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/862/head:pull/862 PR: https://git.openjdk.java.net/skara/pull/862 From rwestberg at openjdk.java.net Tue Oct 6 13:37:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 13:37:35 GMT Subject: RFR: Add support for marking PR body content with an expiration time [v2] In-Reply-To: <-vY8A7Oq1BqBg-8iYLGdGhLI7jNc54wAgidd7CiJ6rs=.d0b358b6-adf4-42f4-b199-d662ddc71706@github.com> References: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> <-vY8A7Oq1BqBg-8iYLGdGhLI7jNc54wAgidd7CiJ6rs=.d0b358b6-adf4-42f4-b199-d662ddc71706@github.com> Message-ID: On Tue, 6 Oct 2020 13:31:08 GMT, Erik Helin wrote: >> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: >> >> Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java >> >> Co-authored-by: Erik Duveblad > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 71: > >> 69: var hasExpired = ExpirationTracker.hasExpired(body); >> 70: if (hasExpired) { >> 71: return >> Base64.getUrlEncoder().encodeToString(UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8)); > > Suggestion: > > return String.valueOf(Math.random()); Guess that makes sense. :) ------------- PR: https://git.openjdk.java.net/skara/pull/862 From rwestberg at openjdk.java.net Tue Oct 6 13:37:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 13:37:35 GMT Subject: Integrated: Add support for marking PR body content with an expiration time In-Reply-To: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> References: <7CuZ5JlzQThDt91kiqd3h1DWzf5xfscWfe6uSyf9IwA=.2341e40f-91e3-4a00-8739-2fb42b073a78@github.com> Message-ID: On Tue, 6 Oct 2020 13:16:27 GMT, Robin Westberg wrote: > For information in the PR body that is calculated using data from external sources (like Jira, another personal fork, > etc.) we need to perform a periodical refresh, as our normal way of detecting updates cannot be used (the updatedAt > field of a pull request). This pull request has now been integrated. Changeset: 49cddf49 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/49cddf49 Stats: 143 lines in 7 files changed: 133 ins; 0 del; 10 mod Add support for marking PR body content with an expiration time Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/862 From rwestberg at openjdk.java.net Tue Oct 6 15:44:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 6 Oct 2020 15:44:35 GMT Subject: RFR: 756: Fix action platform names Message-ID: The latest update to the GitHub Actions file accidentally swapped windows and mac. ------------- Commit messages: - Fix action platform names Changes: https://git.openjdk.java.net/skara/pull/863/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=863&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-756 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/863.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/863/head:pull/863 PR: https://git.openjdk.java.net/skara/pull/863 From ehelin at openjdk.java.net Tue Oct 6 15:44:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 6 Oct 2020 15:44:37 GMT Subject: RFR: 756: Fix action platform names In-Reply-To: References: Message-ID: <4Z-CCyJqhtRXMWWWyDBmBWDNlfUA586PEqhtSc2hm9Q=.f3a5c2ee-c335-40d6-87e2-ecd8d90d8479@github.com> On Tue, 6 Oct 2020 13:47:37 GMT, Robin Westberg wrote: > The latest update to the GitHub Actions file accidentally swapped windows and mac. Looks good ?? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/863 From rwestberg at openjdk.java.net Wed Oct 7 08:10:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 08:10:05 GMT Subject: RFR: Store the check expiration info in the metadata Message-ID: Move the check expiration info into the metadata instead. ------------- Commit messages: - Store the check expiration info in the metadata Changes: https://git.openjdk.java.net/skara/pull/864/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=864&range=00 Stats: 295 lines in 8 files changed: 141 ins; 119 del; 35 mod Patch: https://git.openjdk.java.net/skara/pull/864.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/864/head:pull/864 PR: https://git.openjdk.java.net/skara/pull/864 From ehelin at openjdk.java.net Wed Oct 7 08:15:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 08:15:17 GMT Subject: RFR: Store the check expiration info in the metadata In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 07:22:23 GMT, Robin Westberg wrote: > Move the check expiration info into the metadata instead. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/864 From rwestberg at openjdk.java.net Wed Oct 7 08:19:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 08:19:57 GMT Subject: Integrated: Store the check expiration info in the metadata In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 07:22:23 GMT, Robin Westberg wrote: > Move the check expiration info into the metadata instead. This pull request has now been integrated. Changeset: 40950429 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/40950429 Stats: 295 lines in 8 files changed: 141 ins; 119 del; 35 mod Store the check expiration info in the metadata Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/864 From rwestberg at openjdk.java.net Wed Oct 7 08:30:45 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 08:30:45 GMT Subject: Integrated: 756: Fix action platform names In-Reply-To: References: Message-ID: <6IACqT4BvvqwlQ2MVt4D4aU6oaVV53vCWalWRdZMEso=.fffc01e1-4f95-41bd-8ebb-5bd52ebc8ecc@github.com> On Tue, 6 Oct 2020 13:47:37 GMT, Robin Westberg wrote: > The latest update to the GitHub Actions file accidentally swapped windows and mac. This pull request has now been integrated. Changeset: c31b1a95 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/c31b1a95 Stats: 2 lines in 1 file changed: 0 ins; 0 del; 2 mod 756: Fix action platform names Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/863 From rwestberg at openjdk.java.net Wed Oct 7 09:21:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 09:21:38 GMT Subject: Integrated: Metadata cache expiration makes the generic expiration in the PR update cache unnecessary Message-ID: There's no need to expire all PRs periodically now that it's possible to determine this depending on PR content. ------------- Commit messages: - Metadata cache expiration makes the generic expiration in the PR update cache unnecessary Changes: https://git.openjdk.java.net/skara/pull/866/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=866&range=00 Stats: 22 lines in 2 files changed: 0 ins; 18 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/866.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/866/head:pull/866 PR: https://git.openjdk.java.net/skara/pull/866 From ehelin at openjdk.java.net Wed Oct 7 09:21:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 09:21:39 GMT Subject: Integrated: Metadata cache expiration makes the generic expiration in the PR update cache unnecessary In-Reply-To: References: Message-ID: <69gFURtT3awPMFkTKnYISmfi_v9BAuxsgItQMKiapi8=.a9c915e4-c06f-462a-8d8f-ebfed61d7b90@github.com> On Wed, 7 Oct 2020 09:16:59 GMT, Robin Westberg wrote: > There's no need to expire all PRs periodically now that it's possible to determine this depending on PR content. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/866 From rwestberg at openjdk.java.net Wed Oct 7 09:21:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 09:21:40 GMT Subject: Integrated: Metadata cache expiration makes the generic expiration in the PR update cache unnecessary In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 09:16:59 GMT, Robin Westberg wrote: > There's no need to expire all PRs periodically now that it's possible to determine this depending on PR content. This pull request has now been integrated. Changeset: 15f2b463 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/15f2b463 Stats: 22 lines in 2 files changed: 0 ins; 18 del; 4 mod Metadata cache expiration makes the generic expiration in the PR update cache unnecessary Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/866 From rwestberg at openjdk.java.net Wed Oct 7 09:32:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 09:32:39 GMT Subject: Integrated: Avoid checking closed PRs, handle the "skipped" state of a GitHub check Message-ID: This small fix avoids a few problems with the latest check updates. ------------- Commit messages: - Merge remote-tracking branch 'upstream/master' into check_states - Avoid checking closed PRs, handle the "skipped" state of a GitHub check Changes: https://git.openjdk.java.net/skara/pull/865/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=865&range=00 Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/865.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/865/head:pull/865 PR: https://git.openjdk.java.net/skara/pull/865 From ehelin at openjdk.java.net Wed Oct 7 09:32:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 09:32:39 GMT Subject: Integrated: Avoid checking closed PRs, handle the "skipped" state of a GitHub check In-Reply-To: References: Message-ID: <5gjzE2MwOfMM-I4P6QGEu_AVfMo0q0AzdbBFELJU8Kc=.3a4946ef-b011-4792-b99a-bffd8bd53b8d@github.com> On Wed, 7 Oct 2020 09:04:01 GMT, Robin Westberg wrote: > This small fix avoids a few problems with the latest check updates. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/865 From rwestberg at openjdk.java.net Wed Oct 7 09:32:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 09:32:39 GMT Subject: Integrated: Avoid checking closed PRs, handle the "skipped" state of a GitHub check In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 09:04:01 GMT, Robin Westberg wrote: > This small fix avoids a few problems with the latest check updates. This pull request has now been integrated. Changeset: 71b68cad Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/71b68cad Stats: 5 lines in 2 files changed: 4 ins; 0 del; 1 mod Avoid checking closed PRs, handle the "skipped" state of a GitHub check Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/865 From rwestberg at openjdk.java.net Wed Oct 7 11:57:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 11:57:56 GMT Subject: Integrated: Cache check expiration times Message-ID: Caching the check expiration times avoids a per-PR network request. ------------- Commit messages: - Cache check expiration times Changes: https://git.openjdk.java.net/skara/pull/867/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=867&range=00 Stats: 34 lines in 4 files changed: 16 ins; 12 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/867.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/867/head:pull/867 PR: https://git.openjdk.java.net/skara/pull/867 From ehelin at openjdk.java.net Wed Oct 7 11:57:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 11:57:57 GMT Subject: Integrated: Cache check expiration times In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 11:27:35 GMT, Robin Westberg wrote: > Caching the check expiration times avoids a per-PR network request. Marked as reviewed by ehelin (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/867 From rwestberg at openjdk.java.net Wed Oct 7 11:57:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 11:57:58 GMT Subject: Integrated: Cache check expiration times In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 11:27:35 GMT, Robin Westberg wrote: > Caching the check expiration times avoids a per-PR network request. This pull request has now been integrated. Changeset: 7c414b56 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/7c414b56 Stats: 34 lines in 4 files changed: 16 ins; 12 del; 6 mod Cache check expiration times Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/867 From ehelin at openjdk.java.net Wed Oct 7 14:03:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 14:03:05 GMT Subject: Integrated: pr: introduce backport pull requests Message-ID: <83g-jyYF2soE65TggsEcMAWGDAb7x_b1BCZJQ0b-A78=.add3d94c-a8e9-4db9-bbc3-abc25a2ed18f@github.com> Hi all, please review this patch that introduces the concepts of "backport style" pull requests. If a pull request title matches `Backport ` then issues and summaries from `` will be added to the current pull request. If the "backport style" pull request is integrated then a `Backport-of: ` trailer will also be automatically added to the commit message. Testing: - [x] Added four new unit tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - pr: introduce backport pull requests Changes: https://git.openjdk.java.net/skara/pull/868/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=868&range=00 Stats: 489 lines in 7 files changed: 484 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/868.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/868/head:pull/868 PR: https://git.openjdk.java.net/skara/pull/868 From rwestberg at openjdk.java.net Wed Oct 7 14:03:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 14:03:05 GMT Subject: Integrated: pr: introduce backport pull requests In-Reply-To: <83g-jyYF2soE65TggsEcMAWGDAb7x_b1BCZJQ0b-A78=.add3d94c-a8e9-4db9-bbc3-abc25a2ed18f@github.com> References: <83g-jyYF2soE65TggsEcMAWGDAb7x_b1BCZJQ0b-A78=.add3d94c-a8e9-4db9-bbc3-abc25a2ed18f@github.com> Message-ID: <-K2lb6HYcCXzSKkFgxmllCE9OYKNTm0GSFBSmKqck1k=.a72ed56a-9f82-4a89-b9bd-35a99e73cc0b@github.com> On Wed, 7 Oct 2020 13:50:43 GMT, Erik Helin wrote: > Hi all, > > please review this patch that introduces the concepts of "backport style" pull requests. If a pull request title > matches `Backport ` then issues and summaries from `` will be added to the current pull request. If the > "backport style" pull request is integrated then a `Backport-of: ` trailer will also be automatically added to > the commit message. Testing: > - [x] Added four new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/868 From ehelin at openjdk.java.net Wed Oct 7 14:03:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 14:03:05 GMT Subject: Integrated: pr: introduce backport pull requests In-Reply-To: <83g-jyYF2soE65TggsEcMAWGDAb7x_b1BCZJQ0b-A78=.add3d94c-a8e9-4db9-bbc3-abc25a2ed18f@github.com> References: <83g-jyYF2soE65TggsEcMAWGDAb7x_b1BCZJQ0b-A78=.add3d94c-a8e9-4db9-bbc3-abc25a2ed18f@github.com> Message-ID: <6B12wm4wu7lqTl9dDOGH2podrwtxgCkGc5zIxMwqUNw=.788db264-c0b8-44f3-acb0-10ea84a45bf0@github.com> On Wed, 7 Oct 2020 13:50:43 GMT, Erik Helin wrote: > Hi all, > > please review this patch that introduces the concepts of "backport style" pull requests. If a pull request title > matches `Backport ` then issues and summaries from `` will be added to the current pull request. If the > "backport style" pull request is integrated then a `Backport-of: ` trailer will also be automatically added to > the commit message. Testing: > - [x] Added four new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 26e6b8b8 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/26e6b8b8 Stats: 489 lines in 7 files changed: 484 ins; 0 del; 5 mod pr: introduce backport pull requests Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/868 From aph at redhat.com Wed Oct 7 14:14:49 2020 From: aph at redhat.com (Andrew Haley) Date: Wed, 7 Oct 2020 15:14:49 +0100 Subject: Automagcially generated Skara emails look like they've been through a trash compactor Message-ID: <011286f1-84bf-ffd4-722a-83aeff012629@redhat.com> Please compare the beautifully formatted fourth comment of https://github.com/openjdk/jdk/pull/542 with the unreadable generated email at https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-October/069705.html Can anything be done? -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From rwestberg at openjdk.java.net Wed Oct 7 15:02:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 15:02:11 GMT Subject: Integrated: Adjust expiration times for checking external data Message-ID: This minor change adjusts the expiration times for a few external data sources, to avoid too frequent polling. ------------- Commit messages: - Decrease polling intervals Changes: https://git.openjdk.java.net/skara/pull/869/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=869&range=00 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/869.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/869/head:pull/869 PR: https://git.openjdk.java.net/skara/pull/869 From ehelin at openjdk.java.net Wed Oct 7 15:02:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 7 Oct 2020 15:02:12 GMT Subject: Integrated: Adjust expiration times for checking external data In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 13:51:21 GMT, Robin Westberg wrote: > This minor change adjusts the expiration times for a few external data sources, to avoid too frequent polling. ?? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/869 From rwestberg at openjdk.java.net Wed Oct 7 15:02:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 7 Oct 2020 15:02:12 GMT Subject: Integrated: Adjust expiration times for checking external data In-Reply-To: References: Message-ID: On Wed, 7 Oct 2020 13:51:21 GMT, Robin Westberg wrote: > This minor change adjusts the expiration times for a few external data sources, to avoid too frequent polling. This pull request has now been integrated. Changeset: 53f86042 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/53f86042 Stats: 3 lines in 2 files changed: 0 ins; 0 del; 3 mod Adjust expiration times for checking external data Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/869 From shade at redhat.com Wed Oct 7 18:21:43 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 7 Oct 2020 20:21:43 +0200 Subject: Leftover .hgtags, .hgignore Message-ID: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> Hi, What is the story about leftover .hgtags and .hgignore in the repos that went through the Git transition? I was asking myself this about openjdk/jmh, openjdk/jcstress, openjdk/jol repos, but it is equally related to openjdk/jdk. I submitted this for openjdk/jdk, and can RFR the removal: https://bugs.openjdk.java.net/browse/JDK-8254178 Thoughts? -- Thanks, -Aleksey From rwestberg at openjdk.java.net Thu Oct 8 09:35:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 8 Oct 2020 09:35:39 GMT Subject: RFR: Ignore cancelled checks when summarizing results Message-ID: Cancelled (or skipped) checks can lead to empty lines in the summary, so just ignore those. ------------- Commit messages: - Ignore cancelled checks when summarizing results Changes: https://git.openjdk.java.net/skara/pull/870/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=870&range=00 Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/870.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/870/head:pull/870 PR: https://git.openjdk.java.net/skara/pull/870 From ehelin at openjdk.java.net Thu Oct 8 09:44:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 8 Oct 2020 09:44:02 GMT Subject: RFR: Ignore cancelled checks when summarizing results In-Reply-To: References: Message-ID: On Thu, 8 Oct 2020 09:32:57 GMT, Robin Westberg wrote: > Cancelled (or skipped) checks can lead to empty lines in the summary, so just ignore those. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/870 From ehelin at openjdk.java.net Thu Oct 8 10:53:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 8 Oct 2020 10:53:21 GMT Subject: RFR: git-pr-create: support --backport option Message-ID: Hi all, please review this patch that adds the `--backport=HASH` option to `git pr create` to make it a bit easier to create a "backport style" pull request from the CLI. A backporter can now only has to run: $ git checkout -b backport-8123456 $ git cherry-pick $ git pr create --backport= Thanks, Erik ------------- Commit messages: - git-pr-create: support --backport option Changes: https://git.openjdk.java.net/skara/pull/871/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=871&range=00 Stats: 30 lines in 1 file changed: 18 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/871.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/871/head:pull/871 PR: https://git.openjdk.java.net/skara/pull/871 From rwestberg at openjdk.java.net Thu Oct 8 11:04:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 8 Oct 2020 11:04:51 GMT Subject: RFR: git-pr-create: support --backport option In-Reply-To: References: Message-ID: On Thu, 8 Oct 2020 10:50:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--backport=HASH` option to `git pr create` to make it a bit easier to create a > "backport style" pull request from the CLI. A backporter can now only has to run: > $ git checkout -b backport-8123456 > $ git cherry-pick > $ git pr create --backport= > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/871 From shade at redhat.com Fri Oct 9 06:20:33 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 9 Oct 2020 08:20:33 +0200 Subject: Leftover .hgtags, .hgignore In-Reply-To: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> References: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> Message-ID: <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> On 10/7/20 8:21 PM, Aleksey Shipilev wrote: > What is the story about leftover .hgtags and .hgignore in the repos that went through the Git > transition? I was asking myself this about openjdk/jmh, openjdk/jcstress, openjdk/jol repos, but it > is equally related to openjdk/jdk. > > I submitted this for openjdk/jdk, and can RFR the removal: > https://bugs.openjdk.java.net/browse/JDK-8254178 > > Thoughts? No opinions? Is there a use for these .hg* leftovers that I am overlooking? -- Thanks, -Aleksey From rwestberg at openjdk.java.net Fri Oct 9 07:06:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 9 Oct 2020 07:06:29 GMT Subject: RFR: Keep checking for incoming test results for a while Message-ID: When a PR is updated with additional commits, test results may not yet be available when the summary is created. Keep checking for a while in case they are just about to be triggered. ------------- Commit messages: - Keep checking for incoming test results for a while Changes: https://git.openjdk.java.net/skara/pull/872/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=872&range=00 Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/872.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/872/head:pull/872 PR: https://git.openjdk.java.net/skara/pull/872 From ehelin at openjdk.java.net Fri Oct 9 07:47:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 9 Oct 2020 07:47:13 GMT Subject: Integrated: git-pr-create: support --backport option In-Reply-To: References: Message-ID: On Thu, 8 Oct 2020 10:50:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--backport=HASH` option to `git pr create` to make it a bit easier to create a > "backport style" pull request from the CLI. A backporter can now only has to run: > $ git checkout -b backport-8123456 > $ git cherry-pick > $ git pr create --backport= > > Thanks, > Erik This pull request has now been integrated. Changeset: d1f714d0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d1f714d0 Stats: 30 lines in 1 file changed: 18 ins; 3 del; 9 mod git-pr-create: support --backport option Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/871 From ehelin at openjdk.java.net Fri Oct 9 07:48:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 9 Oct 2020 07:48:12 GMT Subject: RFR: Keep checking for incoming test results for a while In-Reply-To: References: Message-ID: <2Fb3rUWlyJTGbjo_AK_MUeXlVlxHCvuEUgd2CtSjZ_4=.54751c3e-5846-4fbb-9ffe-2461c83b6a51@github.com> On Fri, 9 Oct 2020 07:03:37 GMT, Robin Westberg wrote: > When a PR is updated with additional commits, test results may not yet be available when the summary is created. Keep > checking for a while in case they are just about to be triggered. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/872 From rwestberg at openjdk.java.net Fri Oct 9 08:40:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 9 Oct 2020 08:40:51 GMT Subject: Integrated: Ignore cancelled checks when summarizing results In-Reply-To: References: Message-ID: <2m5Nz3yoEassBVKgyP0cO5bUcSKdq3-lOjzx2xACTKk=.c3298350-8c0a-4f12-be87-35e431caf6d5@github.com> On Thu, 8 Oct 2020 09:32:57 GMT, Robin Westberg wrote: > Cancelled (or skipped) checks can lead to empty lines in the summary, so just ignore those. This pull request has now been integrated. Changeset: a98c415b Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/a98c415b Stats: 15 lines in 2 files changed: 15 ins; 0 del; 0 mod Ignore cancelled checks when summarizing results Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/870 From rwestberg at openjdk.java.net Fri Oct 9 08:41:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 9 Oct 2020 08:41:10 GMT Subject: Integrated: Keep checking for incoming test results for a while In-Reply-To: References: Message-ID: On Fri, 9 Oct 2020 07:03:37 GMT, Robin Westberg wrote: > When a PR is updated with additional commits, test results may not yet be available when the summary is created. Keep > checking for a while in case they are just about to be triggered. This pull request has now been integrated. Changeset: 98ce949f Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/98ce949f Stats: 11 lines in 1 file changed: 11 ins; 0 del; 0 mod Keep checking for incoming test results for a while Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/872 From shade at redhat.com Fri Oct 9 10:44:29 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 9 Oct 2020 12:44:29 +0200 Subject: Git repos and protected branches Message-ID: <043335e1-1b61-9507-cee2-409cd55903ce@redhat.com> Hi, I was wondering if repos configuration had changed recently. I have been using self-PRs in JMH repo to get tests running: https://github.com/openjdk/jmh/pull/5 ...but I cannot delete the branch after I am done with it: $ git push origin --delete gh-actions remote: error: GH006: Protected branch update failed for refs/heads/gh-actions. remote: error: Cannot delete this protected branch To github.com:openjdk/jmh.git ! [remote rejected] gh-actions (protected branch hook declined) error: failed to push some refs to 'git at github.com:openjdk/jmh.git' Is this something expected? Are we expected not to use/delete branches in Git repos? Or are we supposed to only use branches in our private forks? -- Thanks, -Aleksey From kevin.rushforth at oracle.com Fri Oct 9 11:45:45 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Fri, 9 Oct 2020 04:45:45 -0700 Subject: Leftover .hgtags, .hgignore In-Reply-To: <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> References: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> Message-ID: <4420eb24-080b-5b0c-4e05-1eddb7802c52@oracle.com> I also see no value in keeping the .hgignore file. Your post prompted me to remove the .hgignore from the openjdk/jfx repo. There might be some value in retaining the .hgtags, so I decided to keep that around for now (for jfx), although I suspect it could be removed as well and no one would notice. -- Kevin On 10/8/2020 11:20 PM, Aleksey Shipilev wrote: > On 10/7/20 8:21 PM, Aleksey Shipilev wrote: >> What is the story about leftover .hgtags and .hgignore in the repos >> that went through the Git >> transition? I was asking myself this about openjdk/jmh, >> openjdk/jcstress, openjdk/jol repos, but it >> is equally related to openjdk/jdk. >> >> I submitted this for openjdk/jdk, and can RFR the removal: >> ??? https://bugs.openjdk.java.net/browse/JDK-8254178 >> >> Thoughts? > > No opinions? Is there a use for these .hg* leftovers that I am > overlooking? > From erik.helin at oracle.com Fri Oct 9 12:03:02 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 9 Oct 2020 14:03:02 +0200 Subject: Git repos and protected branches In-Reply-To: <043335e1-1b61-9507-cee2-409cd55903ce@redhat.com> References: <043335e1-1b61-9507-cee2-409cd55903ce@redhat.com> Message-ID: On 10/9/20 12:44 PM, Aleksey Shipilev wrote: > Hi, > > I was wondering if repos configuration had changed recently. > > I have been using self-PRs in JMH repo to get tests running: > ? https://github.com/openjdk/jmh/pull/5 > > ...but I cannot delete the branch after I am done with it: > > $ git push origin --delete gh-actions > remote: error: GH006: Protected branch update failed for > refs/heads/gh-actions. > remote: error: Cannot delete this protected branch > To github.com:openjdk/jmh.git > ?! [remote rejected]?? gh-actions (protected branch hook declined) > error: failed to push some refs to 'git at github.com:openjdk/jmh.git' > > Is this something expected? Are we expected not to use/delete branches > in Git repos? Or are we supposed to only use branches in our private forks? We have fairly strict branch protection rules by default, including disallowing you to delete branches in the upstream repository (openjdk/jmh in this case). This policy stems from the jdk repository and the only reasons that openjdk/jmh has the same branch protection rules is because we use the same defaults when setting up repositories. We are happy to either: - delete the branch for you - allow users with direct write access to delete branches in the openjdk/jmh repository Feel free to reach out to me and/or Robin off-list and we can help you out! Thanks, Erk From erik.helin at oracle.com Fri Oct 9 12:08:16 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 9 Oct 2020 14:08:16 +0200 Subject: Leftover .hgtags, .hgignore In-Reply-To: <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> References: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> Message-ID: On 10/9/20 8:20 AM, Aleksey Shipilev wrote: > On 10/7/20 8:21 PM, Aleksey Shipilev wrote: >> What is the story about leftover .hgtags and .hgignore in the repos >> that went through the Git >> transition? I was asking myself this about openjdk/jmh, >> openjdk/jcstress, openjdk/jol repos, but it >> is equally related to openjdk/jdk. >> >> I submitted this for openjdk/jdk, and can RFR the removal: >> ??? https://bugs.openjdk.java.net/browse/JDK-8254178 >> >> Thoughts? > > No opinions? Is there a use for these .hg* leftovers that I am overlooking? Opinions, but limited time, hence this somewhat late reply :) I agree that there is little to no value in keeping the .hgignore file, we kept it around in case people had personal scripts that used the .hgignore file in some way. The .hgtags file has a bit more value, as it allows someone to compare the Mercurial and Git commits that have the same tag (i.e. can be used for verification purposes). But it is not like removing it will make it go away forever, it will still be present in the VCS history and can re-materialized in case someone wants to use it. So, to summarize, I agree that both files can be removed. I don't mind if anyone wants to keep them around for a while longer, they aren't that distracting :) Thanks, Erik From shade at redhat.com Fri Oct 9 12:26:16 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 9 Oct 2020 14:26:16 +0200 Subject: Git repos and protected branches In-Reply-To: References: <043335e1-1b61-9507-cee2-409cd55903ce@redhat.com> Message-ID: <802c0091-3141-05a9-3b8a-d40a6d6ca46b@redhat.com> On 10/9/20 2:03 PM, Erik Helin wrote: > We have fairly strict branch protection rules by default, including > disallowing you to delete branches in the upstream repository > (openjdk/jmh in this case). This policy stems from the jdk repository > and the only reasons that openjdk/jmh has the same branch protection > rules is because we use the same defaults when setting up repositories. I see! > We are happy to either: > > - delete the branch for you Okay, please delete openjdk/jmh/gh-actions branch for now. I'll try to think through if we want to accept branches in jmh/jol/jcstress repos going forward. -- Thanks, -Aleksey From erik.helin at oracle.com Fri Oct 9 13:11:38 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 9 Oct 2020 15:11:38 +0200 Subject: Git repos and protected branches In-Reply-To: <802c0091-3141-05a9-3b8a-d40a6d6ca46b@redhat.com> References: <043335e1-1b61-9507-cee2-409cd55903ce@redhat.com> <802c0091-3141-05a9-3b8a-d40a6d6ca46b@redhat.com> Message-ID: <5899c375-b544-9055-5f8d-2eb8be3b21fb@oracle.com> On 10/9/20 2:26 PM, Aleksey Shipilev wrote: >> We are happy to either: >> >> - delete the branch for you > > Okay, please delete openjdk/jmh/gh-actions branch for now. Done. Thanks, Erik From ehelin at openjdk.java.net Fri Oct 9 13:31:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 9 Oct 2020 13:31:19 GMT Subject: RFR: pr: add config option for 24h hint Message-ID: Hi all, please review this patch that adds a config option for the pr bot for the 24h hint in the integration message. Thanks, Erik ------------- Commit messages: - pr: add config option for 24h hint Changes: https://git.openjdk.java.net/skara/pull/873/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=873&range=00 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/873.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/873/head:pull/873 PR: https://git.openjdk.java.net/skara/pull/873 From rwestberg at openjdk.java.net Fri Oct 9 13:31:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 9 Oct 2020 13:31:20 GMT Subject: RFR: pr: add config option for 24h hint In-Reply-To: References: Message-ID: On Fri, 9 Oct 2020 13:27:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a config option for the pr bot for the 24h hint in the integration message. > > Thanks, > Erik Looks excellent! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/873 From ehelin at openjdk.java.net Fri Oct 9 13:39:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 9 Oct 2020 13:39:28 GMT Subject: Integrated: pr: add config option for 24h hint In-Reply-To: References: Message-ID: On Fri, 9 Oct 2020 13:27:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a config option for the pr bot for the 24h hint in the integration message. > > Thanks, > Erik This pull request has now been integrated. Changeset: 3c839769 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/3c839769 Stats: 7 lines in 1 file changed: 7 ins; 0 del; 0 mod pr: add config option for 24h hint Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/873 From shade at redhat.com Fri Oct 9 14:34:09 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Fri, 9 Oct 2020 16:34:09 +0200 Subject: Leftover .hgtags, .hgignore In-Reply-To: References: <415939e0-8449-635f-b244-b19d0c62fc4e@redhat.com> <67fd156c-3ce1-2c5c-442a-4e741690f688@redhat.com> Message-ID: On 10/9/20 2:08 PM, Erik Helin wrote: > I agree that there is little to no value in keeping the .hgignore file, > we kept it around in case people had personal scripts that used the > .hgignore file in some way. > > The .hgtags file has a bit more value, as it allows someone to compare > the Mercurial and Git commits that have the same tag (i.e. can be used > for verification purposes). But it is not like removing it will make it > go away forever, it will still be present in the VCS history and can > re-materialized in case someone wants to use it. I see, thanks. I split the removal in two: https://bugs.openjdk.java.net/browse/JDK-8254178 https://bugs.openjdk.java.net/browse/JDK-8254318 ...and RFR-ed the removal of .hgignore. I'll also proceed to remove .hgignores from codetools repos of mine. -- Thanks, -Aleksey From volker.simonis at gmail.com Fri Oct 9 15:47:50 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Fri, 9 Oct 2020 17:47:50 +0200 Subject: Questions about pre-submit testing using GitHub Actions Message-ID: Hi, first of all thanks a lot for adding support for pre-submit testing using GitHub Actions. I think this is a really useful feature! Unfortunately, I couldn't find much documentation about it except some emails on this list and the initial PR [1], so I still have a few questions :) 1. All the pre-submit test that have been run for me until now (e.g. [2]) have failed for "Windows x64 (hs/tier1 gc)" presumably because of a generic "out of disc space" error: Error: There is not enough space on the disk. : 'D:\a\_temp\_runner_file_commands\add_path_1a4cdd0c-7bc7-4870-9105-dd1bb009be71' This starts at "TEST: gc/shenandoah/compiler/TestClone.java#id5" after which all subsequent tests fail because of insufficient disc space: 2020-10-09T12:03:09.6467073Z D:\a\jdk\jdk\test\hotspot\jtreg\gc\shenandoah\compiler\TestClone.java:209: error: error while writing TestClone: There is not enough space on the disk ... 2020-10-09T12:03:09.6475592Z TEST RESULT: Error. Write to temp. JTR file failed (old JTR intact): D:\a\jdk\jdk\build\run-test-prebuilt\test-support\jtreg_test_hotspot_jtreg_tier1_gc\gc\shenandoah\compiler\TestClone_id5.jtr.0.tmp Is this a known problem? Is somebody working on fixing it? 2. When looking at "Linux x64 (hs/tier1 gc)" Ican see that there are 44 test failures: 2020-10-09T11:40:16.8365547Z Test results: passed: 255; failed: 44 2020-10-09T11:40:22.0971166Z ============================== 2020-10-09T11:40:22.0973305Z Test summary 2020-10-09T11:40:22.0973969Z ============================== 2020-10-09T11:40:22.0974393Z TEST TOTAL PASS FAIL ERROR 2020-10-09T11:40:22.0974844Z >> jtreg:test/hotspot/jtreg:tier1_gc 299 255 44 0 << 2020-10-09T11:40:22.0975267Z ============================== But the test group has a green check mark and is flagged as passed in the report: "Linux x64 (hs/tier1 gc) succeeded (3 annotations)". How can this happen? Is this a known problem? By the way, the 44 failing test all fail on Windows and MacOS as well because of a crash in: 2020-10-09T12:03:06.0162304Z # Internal Error (d:\a\jdk\jdk\jdk\src\hotspot\share\runtime/vmThread.hpp:103), pid=6344, tid=3700 2020-10-09T12:03:06.0163057Z # assert(Thread::current()->is_VM_thread()) failed: Must be It looks like the framework only recognizes jtReg "Errors" but not "Failures" as errors. 3. Would it be possible to save the hs_err files along with the .jtr files in the case of crashes? I think this would be extremely useful for quickly diagnosing problems. 4. I don't exactly understand the "free tier" you mention in your PR [1]. From the GitHub actions side as described in their "Usage limits" documentation [3] it seems we're on the safe side. But that information somehow contradicts with the information about "GitHub Free for user accounts" [4] which mentions that free user accounts only have 2000 free GitHub Actions minutes per month. In addition "About billing for GitHub Actions" [5] mentions that these free minutes are subject to a multiplier which is one for Linux, two for Windows and ten for macOS which effectively means that after running 200 minutes on macOS our personal free minutes for a month will already be consumed. So to me it seems that GitHub Actions "Usage limits" documentation [3] only sets an upper bound for job and workflow execution time of Actions but this has to be interpreted in the context of the totally available, free minutes for Actions. But maybe I'm wrong? If you know better :) could you please explain which of these limits apply and how many automatic tests jobs they are approximately covering? Thank you and best regards, Volker [1] https://github.com/openjdk/jdk/pull/284 [2] https://github.com/simonis/jdk/runs/1230911240 [3] https://docs.github.com/en/free-pro-team at latest/actions/reference/usage-limits-billing-and-administration#usage-limits [4] https://docs.github.com/en/free-pro-team at latest/github/getting-started-with-github/githubs-products#github-free-for-user-accounts [5] https://docs.github.com/en/free-pro-team at latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions#about-billing-for-github-actions From robin.westberg at oracle.com Mon Oct 12 07:16:55 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Mon, 12 Oct 2020 09:16:55 +0200 Subject: Questions about pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: Hi Volker, > On 9 Oct 2020, at 17:47, Volker Simonis wrote: > > Hi, > > first of all thanks a lot for adding support for pre-submit testing > using GitHub Actions. I think this is a really useful feature! > > Unfortunately, I couldn't find much documentation about it except some > emails on this list and the initial PR [1], so I still have a few > questions :) Thanks! We?re working on documenting it a bit better on the Skara OpenJDK wiki page which should be ready for publication soon. :) > 1. All the pre-submit test that have been run for me until now (e.g. > [2]) have failed for "Windows x64 (hs/tier1 gc)" presumably because of > a generic "out of disc space" error: > > Error: There is not enough space on the disk. : > 'D:\a\_temp\_runner_file_commands\add_path_1a4cdd0c-7bc7-4870-9105-dd1bb009be71' > > This starts at "TEST: gc/shenandoah/compiler/TestClone.java#id5" after > which all subsequent tests fail because of insufficient disc space: > 2020-10-09T12:03:09.6467073Z > D:\a\jdk\jdk\test\hotspot\jtreg\gc\shenandoah\compiler\TestClone.java:209: > error: error while writing TestClone: There is not enough space on the > disk > ... > 2020-10-09T12:03:09.6475592Z TEST RESULT: Error. Write to temp. JTR > file failed (old JTR intact): > D:\a\jdk\jdk\build\run-test-prebuilt\test-support\jtreg_test_hotspot_jtreg_tier1_gc\gc\shenandoah\compiler\TestClone_id5.jtr.0.tmp > > Is this a known problem? Is somebody working on fixing it? Yep, this was fixed by https://bugs.openjdk.java.net/browse/JDK-8253778. If you are still seeing these errors in a PR, you will most likely want to merge the latest upstream ?master? into your branch so that the fixes gets applied. > 2. When looking at "Linux x64 (hs/tier1 gc)" Ican see that there are > 44 test failures: > > 2020-10-09T11:40:16.8365547Z Test results: passed: 255; failed: 44 > 2020-10-09T11:40:22.0971166Z ============================== > 2020-10-09T11:40:22.0973305Z Test summary > 2020-10-09T11:40:22.0973969Z ============================== > 2020-10-09T11:40:22.0974393Z TEST > TOTAL PASS FAIL ERROR > 2020-10-09T11:40:22.0974844Z >> jtreg:test/hotspot/jtreg:tier1_gc > 299 255 44 0 << > 2020-10-09T11:40:22.0975267Z ============================== > > But the test group has a green check mark and is flagged as passed in > the report: "Linux x64 (hs/tier1 gc) succeeded (3 annotations)". How > can this happen? Is this a known problem? > > By the way, the 44 failing test all fail on Windows and MacOS as well > because of a crash in: > 2020-10-09T12:03:06.0162304Z # Internal Error > (d:\a\jdk\jdk\jdk\src\hotspot\share\runtime/vmThread.hpp:103), > pid=6344, tid=3700 > 2020-10-09T12:03:06.0163057Z # > assert(Thread::current()->is_VM_thread()) failed: Must be > > It looks like the framework only recognizes jtReg "Errors" but not > "Failures" as errors. Yep, this was a problem with the GitHub Actions definitions themselves, and was fixed by https://bugs.openjdk.java.net/browse/JDK-8253865. But again, as the jobs run with the version of the definitions that are present in your branch, you?ll need to refresh it for the fix to be applied. > 3. Would it be possible to save the hs_err files along with the .jtr > files in the case of crashes? I think this would be extremely useful > for quickly diagnosing problems. Sure, that makes sense! Filed https://bugs.openjdk.java.net/browse/JDK-8254561. > 4. I don't exactly understand the "free tier" you mention in your PR > [1]. From the GitHub actions side as described in their "Usage limits" > documentation [3] it seems we're on the safe side. But that > information somehow contradicts with the information about "GitHub > Free for user accounts" [4] which mentions that free user accounts > only have 2000 free GitHub Actions minutes per month. In addition > "About billing for GitHub Actions" [5] mentions that these free > minutes are subject to a multiplier which is one for Linux, two for > Windows and ten for macOS which effectively means that after running > 200 minutes on macOS our personal free minutes for a month will > already be consumed. So to me it seems that GitHub Actions "Usage > limits" documentation [3] only sets an upper bound for job and > workflow execution time of Actions but this has to be interpreted in > the context of the totally available, free minutes for Actions. But > maybe I'm wrong? > > If you know better :) could you please explain which of these limits > apply and how many automatic tests jobs they are approximately > covering? The pricing and usage documentation is indeed a bit confusing as it is split in several parts. The part that is relevant for us is slightly higher up in the link you referenced as [3] - https://docs.github.com/en/free-pro-team at latest/actions/reference/usage-limits-billing-and-administration#about-billing-for-github-actions - which says: "GitHub Actions usage is free for public repositories and self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.? So the limits and billing you see in [4] and [5] refers to what you can use with private repositories if you have a free account, which I guess most of us have. But public repositories like your fork of the JDK are subject to the limits in [3] which basically means that you can run up to 20 jobs in parallel all day long. Best regards, Robin > > Thank you and best regards, > Volker > > [1] https://github.com/openjdk/jdk/pull/284 > [2] https://github.com/simonis/jdk/runs/1230911240 > [3] https://docs.github.com/en/free-pro-team at latest/actions/reference/usage-limits-billing-and-administration#usage-limits > [4] https://docs.github.com/en/free-pro-team at latest/github/getting-started-with-github/githubs-products#github-free-for-user-accounts > [5] https://docs.github.com/en/free-pro-team at latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions#about-billing-for-github-actions From rwestberg at openjdk.java.net Mon Oct 12 12:02:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 12:02:31 GMT Subject: RFR: Allow a HostedRepositoryPool to refresh the seed from upstream Message-ID: Add support for periodically refreshing the seed repository used with the HostedRepositoryPool remote repository cache. Also allow the refresh to fail (and instead just use the latest cache) which can be used for operations that can tolerate a delayed update (for example, determining the project name from the jcheck configuration file which rarely changes). ------------- Commit messages: - Allow a HostedRepositoryPool to refresh the seed from upstream Changes: https://git.openjdk.java.net/skara/pull/874/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=874&range=00 Stats: 110 lines in 5 files changed: 41 ins; 42 del; 27 mod Patch: https://git.openjdk.java.net/skara/pull/874.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/874/head:pull/874 PR: https://git.openjdk.java.net/skara/pull/874 From rwestberg at openjdk.java.net Mon Oct 12 13:11:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 13:11:48 GMT Subject: RFR: Allow a HostedRepositoryPool to refresh the seed from upstream [v2] In-Reply-To: References: Message-ID: > Add support for periodically refreshing the seed repository used with the HostedRepositoryPool remote repository cache. > Also allow the refresh to fail (and instead just use the latest cache) which can be used for operations that can > tolerate a delayed update (for example, determining the project name from the jcheck configuration file which rarely > changes). Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Fix failing tests ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/874/files - new: https://git.openjdk.java.net/skara/pull/874/files/11b658e2..52f6c1c1 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=874&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=874&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/874.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/874/head:pull/874 PR: https://git.openjdk.java.net/skara/pull/874 From ehelin at openjdk.java.net Mon Oct 12 13:11:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 12 Oct 2020 13:11:49 GMT Subject: RFR: Allow a HostedRepositoryPool to refresh the seed from upstream [v2] In-Reply-To: References: Message-ID: On Mon, 12 Oct 2020 13:09:28 GMT, Robin Westberg wrote: >> Add support for periodically refreshing the seed repository used with the HostedRepositoryPool remote repository cache. >> Also allow the refresh to fail (and instead just use the latest cache) which can be used for operations that can >> tolerate a delayed update (for example, determining the project name from the jcheck configuration file which rarely >> changes). > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Fix failing tests Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/874 From rwestberg at openjdk.java.net Mon Oct 12 13:20:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 13:20:55 GMT Subject: RFR: Allow a HostedRepositoryPool to refresh the seed from upstream [v3] In-Reply-To: References: Message-ID: > Add support for periodically refreshing the seed repository used with the HostedRepositoryPool remote repository cache. > Also allow the refresh to fail (and instead just use the latest cache) which can be used for operations that can > tolerate a delayed update (for example, determining the project name from the jcheck configuration file which rarely > changes). Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Always fetch when stale content is not allowed ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/874/files - new: https://git.openjdk.java.net/skara/pull/874/files/52f6c1c1..99b05e7c Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=874&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=874&range=01-02 Stats: 12 lines in 1 file changed: 5 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/874.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/874/head:pull/874 PR: https://git.openjdk.java.net/skara/pull/874 From rwestberg at openjdk.java.net Mon Oct 12 13:48:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 13:48:44 GMT Subject: Integrated: Allow a HostedRepositoryPool to refresh the seed from upstream In-Reply-To: References: Message-ID: On Mon, 12 Oct 2020 11:59:37 GMT, Robin Westberg wrote: > Add support for periodically refreshing the seed repository used with the HostedRepositoryPool remote repository cache. > Also allow the refresh to fail (and instead just use the latest cache) which can be used for operations that can > tolerate a delayed update (for example, determining the project name from the jcheck configuration file which rarely > changes). This pull request has now been integrated. Changeset: 6a697404 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/6a697404 Stats: 115 lines in 5 files changed: 46 ins; 42 del; 27 mod Allow a HostedRepositoryPool to refresh the seed from upstream Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/874 From rwestberg at openjdk.java.net Mon Oct 12 13:55:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 13:55:13 GMT Subject: RFR: Read jcheck configuration directly from the seed repository Message-ID: <8OW2UpZh0uDfWvHZ0GW0InqsT9L1RerNWECEY7c9oVg=.7b3ed584-e446-4248-aedb-cd6e17538baa@github.com> There's no need to materialize a seeded hosted repository just to read a single file. ------------- Commit messages: - Read jcheck configuration directly from the seed repository Changes: https://git.openjdk.java.net/skara/pull/875/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=875&range=00 Stats: 21 lines in 2 files changed: 13 ins; 3 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/875.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/875/head:pull/875 PR: https://git.openjdk.java.net/skara/pull/875 From ehelin at openjdk.java.net Mon Oct 12 13:55:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 12 Oct 2020 13:55:13 GMT Subject: RFR: Read jcheck configuration directly from the seed repository In-Reply-To: <8OW2UpZh0uDfWvHZ0GW0InqsT9L1RerNWECEY7c9oVg=.7b3ed584-e446-4248-aedb-cd6e17538baa@github.com> References: <8OW2UpZh0uDfWvHZ0GW0InqsT9L1RerNWECEY7c9oVg=.7b3ed584-e446-4248-aedb-cd6e17538baa@github.com> Message-ID: On Mon, 12 Oct 2020 13:50:30 GMT, Robin Westberg wrote: > There's no need to materialize a seeded hosted repository just to read a single file. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/875 From rwestberg at openjdk.java.net Mon Oct 12 14:38:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 12 Oct 2020 14:38:16 GMT Subject: Integrated: Read jcheck configuration directly from the seed repository In-Reply-To: <8OW2UpZh0uDfWvHZ0GW0InqsT9L1RerNWECEY7c9oVg=.7b3ed584-e446-4248-aedb-cd6e17538baa@github.com> References: <8OW2UpZh0uDfWvHZ0GW0InqsT9L1RerNWECEY7c9oVg=.7b3ed584-e446-4248-aedb-cd6e17538baa@github.com> Message-ID: On Mon, 12 Oct 2020 13:50:30 GMT, Robin Westberg wrote: > There's no need to materialize a seeded hosted repository just to read a single file. This pull request has now been integrated. Changeset: ed353708 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ed353708 Stats: 21 lines in 2 files changed: 13 ins; 3 del; 5 mod Read jcheck configuration directly from the seed repository Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/875 From ehelin at openjdk.java.net Tue Oct 13 12:00:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 12:00:21 GMT Subject: RFR: vcs: split unified and git raw diff parser Message-ID: <52vy-725A1B2ey7KoYh0O5sFgGr4se8hBwMC8fBkgHA=.649c613a-97c3-4d98-9de9-a3fc949156dc@github.com> Hi all, please review this refactoring that splits the `UnifiedDiffParser` classes into the classes `UnifiedDiffParser` and `GitRawParser`. Thanks, Erik ------------- Commit messages: - vcs: split unified and git raw diff parser Changes: https://git.openjdk.java.net/skara/pull/876/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=876&range=00 Stats: 761 lines in 10 files changed: 392 ins; 359 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/876.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/876/head:pull/876 PR: https://git.openjdk.java.net/skara/pull/876 From rwestberg at openjdk.java.net Tue Oct 13 12:00:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 12:00:21 GMT Subject: RFR: vcs: split unified and git raw diff parser In-Reply-To: <52vy-725A1B2ey7KoYh0O5sFgGr4se8hBwMC8fBkgHA=.649c613a-97c3-4d98-9de9-a3fc949156dc@github.com> References: <52vy-725A1B2ey7KoYh0O5sFgGr4se8hBwMC8fBkgHA=.649c613a-97c3-4d98-9de9-a3fc949156dc@github.com> Message-ID: On Tue, 13 Oct 2020 11:55:38 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that splits the `UnifiedDiffParser` classes into the classes `UnifiedDiffParser` and > `GitRawParser`. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/876 From ehelin at openjdk.java.net Tue Oct 13 12:10:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 12:10:50 GMT Subject: Integrated: vcs: split unified and git raw diff parser In-Reply-To: <52vy-725A1B2ey7KoYh0O5sFgGr4se8hBwMC8fBkgHA=.649c613a-97c3-4d98-9de9-a3fc949156dc@github.com> References: <52vy-725A1B2ey7KoYh0O5sFgGr4se8hBwMC8fBkgHA=.649c613a-97c3-4d98-9de9-a3fc949156dc@github.com> Message-ID: <07LdAaHM0r8i-bmRv1U7LBSjuvZyoZoZpzjtCRv90G8=.6fd21b63-2a9f-4b7c-947b-bbe216ac76f4@github.com> On Tue, 13 Oct 2020 11:55:38 GMT, Erik Helin wrote: > Hi all, > > please review this refactoring that splits the `UnifiedDiffParser` classes into the classes `UnifiedDiffParser` and > `GitRawParser`. > Thanks, > Erik This pull request has now been integrated. Changeset: 8ec9eb63 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/8ec9eb63 Stats: 761 lines in 10 files changed: 392 ins; 359 del; 10 mod vcs: split unified and git raw diff parser Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/876 From rwestberg at openjdk.java.net Tue Oct 13 12:22:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 12:22:00 GMT Subject: RFR: Ensure that seeded checkouts can be preserved Message-ID: Preserving a seeded clone that fails checkout should not move files across volume boundaries. Also ensure that seeds are only updated periodically. ------------- Commit messages: - Always fetch conditionally - Repositories meant to be kept for later debugging should not be moved across volume boundaries Changes: https://git.openjdk.java.net/skara/pull/877/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=877&range=00 Stats: 91 lines in 2 files changed: 78 ins; 6 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/877.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/877/head:pull/877 PR: https://git.openjdk.java.net/skara/pull/877 From ehelin at openjdk.java.net Tue Oct 13 12:22:00 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 12:22:00 GMT Subject: RFR: Ensure that seeded checkouts can be preserved In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 12:18:10 GMT, Robin Westberg wrote: > Preserving a seeded clone that fails checkout should not move files across volume boundaries. Also ensure that seeds > are only updated periodically. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/877 From rwestberg at openjdk.java.net Tue Oct 13 12:37:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 12:37:30 GMT Subject: Integrated: Ensure that seeded checkouts can be preserved In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 12:18:10 GMT, Robin Westberg wrote: > Preserving a seeded clone that fails checkout should not move files across volume boundaries. Also ensure that seeds > are only updated periodically. This pull request has now been integrated. Changeset: 3a0dacec Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/3a0dacec Stats: 91 lines in 2 files changed: 78 ins; 6 del; 7 mod Ensure that seeded checkouts can be preserved Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/877 From ehelin at openjdk.java.net Tue Oct 13 13:25:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 13:25:43 GMT Subject: RFR: vcs: add method Patch.toString Message-ID: Hi all, please review this small patch that adds the method `Patch.toString`. Thanks, Erik ------------- Commit messages: - vcs: add method Patch.toString Changes: https://git.openjdk.java.net/skara/pull/878/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=878&range=00 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/878.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/878/head:pull/878 PR: https://git.openjdk.java.net/skara/pull/878 From rwestberg at openjdk.java.net Tue Oct 13 13:33:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 13:33:15 GMT Subject: RFR: vcs: add method Patch.toString In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 13:23:01 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds the method `Patch.toString`. > > Thanks, > Erik Looks nice! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/878 From ehelin at openjdk.java.net Tue Oct 13 13:38:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 13:38:35 GMT Subject: Integrated: vcs: add method Patch.toString In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 13:23:01 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds the method `Patch.toString`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 057c1e34 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/057c1e34 Stats: 15 lines in 1 file changed: 15 ins; 0 del; 0 mod vcs: add method Patch.toString Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/878 From ehelin at openjdk.java.net Tue Oct 13 13:48:07 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 13:48:07 GMT Subject: RFR: forge: rename HostedCommitMetadata to HostedCommit Message-ID: Hi all, please review this patch that refactors `HostedCommitMetadata` to `HostedCommit`. The changes are primarily in fetching the diff for the commit in addition to the metadata already being fetched. Thanks, Erik ------------- Commit messages: - forge: rename HostedCommitMetadata to HostedCommit Changes: https://git.openjdk.java.net/skara/pull/879/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=879&range=00 Stats: 287 lines in 7 files changed: 174 ins; 105 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/879.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/879/head:pull/879 PR: https://git.openjdk.java.net/skara/pull/879 From rwestberg at openjdk.java.net Tue Oct 13 14:33:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 14:33:50 GMT Subject: RFR: The checkout method should always checkout what was fetched Message-ID: The checkout method of HostedRepositoryPool should always checkout what was just fetched, to ensure no local ref interferes. ------------- Commit messages: - The checkout method should always checkout what was fetched Changes: https://git.openjdk.java.net/skara/pull/880/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=880&range=00 Stats: 57 lines in 2 files changed: 55 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/880.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/880/head:pull/880 PR: https://git.openjdk.java.net/skara/pull/880 From rwestberg at openjdk.java.net Tue Oct 13 14:34:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 14:34:35 GMT Subject: RFR: forge: rename HostedCommitMetadata to HostedCommit In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 13:45:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostedCommitMetadata` to `HostedCommit`. The changes are primarily in fetching > the diff for the commit in addition to the metadata already being fetched. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/879 From ehelin at openjdk.java.net Tue Oct 13 14:53:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 14:53:35 GMT Subject: Integrated: forge: rename HostedCommitMetadata to HostedCommit In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 13:45:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostedCommitMetadata` to `HostedCommit`. The changes are primarily in fetching > the diff for the commit in addition to the metadata already being fetched. > Thanks, > Erik This pull request has now been integrated. Changeset: 579eab66 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/579eab66 Stats: 287 lines in 7 files changed: 174 ins; 105 del; 8 mod forge: rename HostedCommitMetadata to HostedCommit Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/879 From ehelin at openjdk.java.net Tue Oct 13 14:55:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 13 Oct 2020 14:55:05 GMT Subject: RFR: The checkout method should always checkout what was fetched In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 14:30:57 GMT, Robin Westberg wrote: > The checkout method of HostedRepositoryPool should always checkout what was just fetched, to ensure no local ref > interferes. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/880 From rwestberg at openjdk.java.net Tue Oct 13 14:55:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 13 Oct 2020 14:55:05 GMT Subject: Integrated: The checkout method should always checkout what was fetched In-Reply-To: References: Message-ID: On Tue, 13 Oct 2020 14:30:57 GMT, Robin Westberg wrote: > The checkout method of HostedRepositoryPool should always checkout what was just fetched, to ensure no local ref > interferes. This pull request has now been integrated. Changeset: 541a4aa3 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/541a4aa3 Stats: 57 lines in 2 files changed: 55 ins; 1 del; 1 mod The checkout method should always checkout what was fetched Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/880 From rwestberg at openjdk.java.net Wed Oct 14 07:59:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 14 Oct 2020 07:59:48 GMT Subject: RFR: Ensure that the seed repo fetches everything when refreshing Message-ID: Ensure that the seed repo fetches everything from the correct upstream when refreshing. ------------- Commit messages: - Ensure that the seed repo fetches everything when refreshing Changes: https://git.openjdk.java.net/skara/pull/881/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=881&range=00 Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/881.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/881/head:pull/881 PR: https://git.openjdk.java.net/skara/pull/881 From ehelin at openjdk.java.net Wed Oct 14 07:59:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 07:59:48 GMT Subject: RFR: Ensure that the seed repo fetches everything when refreshing In-Reply-To: References: Message-ID: On Wed, 14 Oct 2020 07:54:30 GMT, Robin Westberg wrote: > Ensure that the seed repo fetches everything from the correct upstream when refreshing. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/881 From ehelin at openjdk.java.net Wed Oct 14 08:01:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 08:01:57 GMT Subject: RFR: forge: add method PullRequest.diff Message-ID: <2BieP-DF3ZYoKmEEOjKD5hAn1F7XPZ8GRPNHgpR0Q4Q=.532fe4d8-4242-4052-8c36-f33d762155d2@github.com> Hi all, please review this patch that adds the method `PullRequest.diff` for fetching the diff between a pull request's `HEAD` and target branch. Thanks, Erik ------------- Commit messages: - forge: add method PullRequest.diff Changes: https://git.openjdk.java.net/skara/pull/882/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=882&range=00 Stats: 51 lines in 6 files changed: 46 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/882.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/882/head:pull/882 PR: https://git.openjdk.java.net/skara/pull/882 From rwestberg at openjdk.java.net Wed Oct 14 08:01:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 14 Oct 2020 08:01:58 GMT Subject: RFR: forge: add method PullRequest.diff In-Reply-To: <2BieP-DF3ZYoKmEEOjKD5hAn1F7XPZ8GRPNHgpR0Q4Q=.532fe4d8-4242-4052-8c36-f33d762155d2@github.com> References: <2BieP-DF3ZYoKmEEOjKD5hAn1F7XPZ8GRPNHgpR0Q4Q=.532fe4d8-4242-4052-8c36-f33d762155d2@github.com> Message-ID: On Wed, 14 Oct 2020 07:56:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `PullRequest.diff` for fetching the diff between a pull request's `HEAD` > and target branch. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/882 From ehelin at openjdk.java.net Wed Oct 14 08:07:18 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 08:07:18 GMT Subject: Integrated: forge: add method PullRequest.diff In-Reply-To: <2BieP-DF3ZYoKmEEOjKD5hAn1F7XPZ8GRPNHgpR0Q4Q=.532fe4d8-4242-4052-8c36-f33d762155d2@github.com> References: <2BieP-DF3ZYoKmEEOjKD5hAn1F7XPZ8GRPNHgpR0Q4Q=.532fe4d8-4242-4052-8c36-f33d762155d2@github.com> Message-ID: On Wed, 14 Oct 2020 07:56:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `PullRequest.diff` for fetching the diff between a pull request's `HEAD` > and target branch. > Thanks, > Erik This pull request has now been integrated. Changeset: 2ead5955 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2ead5955 Stats: 51 lines in 6 files changed: 46 ins; 0 del; 5 mod forge: add method PullRequest.diff Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/882 From rwestberg at openjdk.java.net Wed Oct 14 09:05:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 14 Oct 2020 09:05:09 GMT Subject: Integrated: Ensure that the seed repo fetches everything when refreshing In-Reply-To: References: Message-ID: On Wed, 14 Oct 2020 07:54:30 GMT, Robin Westberg wrote: > Ensure that the seed repo fetches everything from the correct upstream when refreshing. This pull request has now been integrated. Changeset: 6209b952 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/6209b952 Stats: 9 lines in 2 files changed: 6 ins; 0 del; 3 mod Ensure that the seed repo fetches everything when refreshing Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/881 From ehelin at openjdk.java.net Wed Oct 14 12:36:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 12:36:36 GMT Subject: RFR: git-info: add --upstream flag Message-ID: <3Bp4t2Cm9oYhWEWxQiCGYU6omdqi7VwdEO6CM0HR974=.50cdb65f-0ce7-4bb5-85da-044dc9491cdd@github.com> Hi all, please review this patch that adds the `--upstream` flag to `git-info` to show the hash for the original (upstream) commit that that provided commit was backported from. For example, if commit `B` has been backported from commit `A`, then a user can run: $ git info --upstream B A Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - git-info: add --upstream flag Changes: https://git.openjdk.java.net/skara/pull/883/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=883&range=00 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/883.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/883/head:pull/883 PR: https://git.openjdk.java.net/skara/pull/883 From rwestberg at openjdk.java.net Wed Oct 14 12:36:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 14 Oct 2020 12:36:37 GMT Subject: RFR: git-info: add --upstream flag In-Reply-To: <3Bp4t2Cm9oYhWEWxQiCGYU6omdqi7VwdEO6CM0HR974=.50cdb65f-0ce7-4bb5-85da-044dc9491cdd@github.com> References: <3Bp4t2Cm9oYhWEWxQiCGYU6omdqi7VwdEO6CM0HR974=.50cdb65f-0ce7-4bb5-85da-044dc9491cdd@github.com> Message-ID: <_6IEm0pf7v1zyXvZ7cSrwC-rlZpv2nDzAitlBYHQHBg=.48403f9a-3922-4721-8926-c68eb70e807a@github.com> On Wed, 14 Oct 2020 12:32:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--upstream` flag to `git-info` to show the hash for the original (upstream) > commit that that provided commit was backported from. For example, if commit `B` has been backported from commit `A`, > then a user can run: $ git info --upstream B > A > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/883 From ehelin at openjdk.java.net Wed Oct 14 12:58:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 12:58:16 GMT Subject: Integrated: git-info: add --upstream flag In-Reply-To: <3Bp4t2Cm9oYhWEWxQiCGYU6omdqi7VwdEO6CM0HR974=.50cdb65f-0ce7-4bb5-85da-044dc9491cdd@github.com> References: <3Bp4t2Cm9oYhWEWxQiCGYU6omdqi7VwdEO6CM0HR974=.50cdb65f-0ce7-4bb5-85da-044dc9491cdd@github.com> Message-ID: On Wed, 14 Oct 2020 12:32:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--upstream` flag to `git-info` to show the hash for the original (upstream) > commit that that provided commit was backported from. For example, if commit `B` has been backported from commit `A`, > then a user can run: $ git info --upstream B > A > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: e6939012 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/e6939012 Stats: 13 lines in 1 file changed: 12 ins; 0 del; 1 mod git-info: add --upstream flag Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/883 From volker.simonis at gmail.com Wed Oct 14 13:02:16 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Wed, 14 Oct 2020 15:02:16 +0200 Subject: Questions about pre-submit testing using GitHub Actions In-Reply-To: References: Message-ID: Hi Robin, thanks a lot for your answer. Please find my comments inline: On Mon, Oct 12, 2020 at 9:17 AM Robin Westberg wrote: > > Hi Volker, > > > On 9 Oct 2020, at 17:47, Volker Simonis wrote: > > > > Hi, > > > > first of all thanks a lot for adding support for pre-submit testing > > using GitHub Actions. I think this is a really useful feature! > > > > Unfortunately, I couldn't find much documentation about it except some > > emails on this list and the initial PR [1], so I still have a few > > questions :) > > Thanks! We?re working on documenting it a bit better on the Skara OpenJDK wiki page which should be ready for publication soon. :) > > > 1. All the pre-submit test that have been run for me until now (e.g. > > [2]) have failed for "Windows x64 (hs/tier1 gc)" presumably because of > > a generic "out of disc space" error: > > > > Error: There is not enough space on the disk. : > > 'D:\a\_temp\_runner_file_commands\add_path_1a4cdd0c-7bc7-4870-9105-dd1bb009be71' > > > > This starts at "TEST: gc/shenandoah/compiler/TestClone.java#id5" after > > which all subsequent tests fail because of insufficient disc space: > > 2020-10-09T12:03:09.6467073Z > > D:\a\jdk\jdk\test\hotspot\jtreg\gc\shenandoah\compiler\TestClone.java:209: > > error: error while writing TestClone: There is not enough space on the > > disk > > ... > > 2020-10-09T12:03:09.6475592Z TEST RESULT: Error. Write to temp. JTR > > file failed (old JTR intact): > > D:\a\jdk\jdk\build\run-test-prebuilt\test-support\jtreg_test_hotspot_jtreg_tier1_gc\gc\shenandoah\compiler\TestClone_id5.jtr.0.tmp > > > > Is this a known problem? Is somebody working on fixing it? > > Yep, this was fixed by https://bugs.openjdk.java.net/browse/JDK-8253778. If you are still seeing these errors in a PR, you will most likely want to merge the latest upstream ?master? into your branch so that the fixes gets applied. > You're right. After pulling and merging from upstream, the test now run perfectly. The fact that the new Git workflow now automatically rebases my changes before a commit made mit a little bit lazy with merges from upstream :) > > 2. When looking at "Linux x64 (hs/tier1 gc)" Ican see that there are > > 44 test failures: > > > > 2020-10-09T11:40:16.8365547Z Test results: passed: 255; failed: 44 > > 2020-10-09T11:40:22.0971166Z ============================== > > 2020-10-09T11:40:22.0973305Z Test summary > > 2020-10-09T11:40:22.0973969Z ============================== > > 2020-10-09T11:40:22.0974393Z TEST > > TOTAL PASS FAIL ERROR > > 2020-10-09T11:40:22.0974844Z >> jtreg:test/hotspot/jtreg:tier1_gc > > 299 255 44 0 << > > 2020-10-09T11:40:22.0975267Z ============================== > > > > But the test group has a green check mark and is flagged as passed in > > the report: "Linux x64 (hs/tier1 gc) succeeded (3 annotations)". How > > can this happen? Is this a known problem? > > > > By the way, the 44 failing test all fail on Windows and MacOS as well > > because of a crash in: > > 2020-10-09T12:03:06.0162304Z # Internal Error > > (d:\a\jdk\jdk\jdk\src\hotspot\share\runtime/vmThread.hpp:103), > > pid=6344, tid=3700 > > 2020-10-09T12:03:06.0163057Z # > > assert(Thread::current()->is_VM_thread()) failed: Must be > > > > It looks like the framework only recognizes jtReg "Errors" but not > > "Failures" as errors. > > Yep, this was a problem with the GitHub Actions definitions themselves, and was fixed by https://bugs.openjdk.java.net/browse/JDK-8253865. But again, as the jobs run with the version of the definitions that are present in your branch, you?ll need to refresh it for the fix to be applied. > Yes, can confirm that this now works as well after merging from upstream. > > 3. Would it be possible to save the hs_err files along with the .jtr > > files in the case of crashes? I think this would be extremely useful > > for quickly diagnosing problems. > > Sure, that makes sense! Filed https://bugs.openjdk.java.net/browse/JDK-8254561. > > > 4. I don't exactly understand the "free tier" you mention in your PR > > [1]. From the GitHub actions side as described in their "Usage limits" > > documentation [3] it seems we're on the safe side. But that > > information somehow contradicts with the information about "GitHub > > Free for user accounts" [4] which mentions that free user accounts > > only have 2000 free GitHub Actions minutes per month. In addition > > "About billing for GitHub Actions" [5] mentions that these free > > minutes are subject to a multiplier which is one for Linux, two for > > Windows and ten for macOS which effectively means that after running > > 200 minutes on macOS our personal free minutes for a month will > > already be consumed. So to me it seems that GitHub Actions "Usage > > limits" documentation [3] only sets an upper bound for job and > > workflow execution time of Actions but this has to be interpreted in > > the context of the totally available, free minutes for Actions. But > > maybe I'm wrong? > > > > If you know better :) could you please explain which of these limits > > apply and how many automatic tests jobs they are approximately > > covering? > > The pricing and usage documentation is indeed a bit confusing as it is split in several parts. The part that is relevant for us is slightly higher up in the link you referenced as [3] - https://docs.github.com/en/free-pro-team at latest/actions/reference/usage-limits-billing-and-administration#about-billing-for-github-actions - which says: > > "GitHub Actions usage is free for public repositories and self-hosted runners. For private repositories, each GitHub account receives a certain amount of free minutes and storage, depending on the product used with the account.? > > So the limits and billing you see in [4] and [5] refers to what you can use with private repositories if you have a free account, which I guess most of us have. But public repositories like your fork of the JDK are subject to the limits in [3] which basically means that you can run up to 20 jobs in parallel all day long. > That's great news! Thank you and the Skara team one more time for your great work, Volker > Best regards, > Robin > > > > > Thank you and best regards, > > Volker > > > > [1] https://github.com/openjdk/jdk/pull/284 > > [2] https://github.com/simonis/jdk/runs/1230911240 > > [3] https://docs.github.com/en/free-pro-team at latest/actions/reference/usage-limits-billing-and-administration#usage-limits > > [4] https://docs.github.com/en/free-pro-team at latest/github/getting-started-with-github/githubs-products#github-free-for-user-accounts > > [5] https://docs.github.com/en/free-pro-team at latest/github/setting-up-and-managing-billing-and-payments-on-github/about-billing-for-github-actions#about-billing-for-github-actions > From ehelin at openjdk.java.net Wed Oct 14 14:33:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 14 Oct 2020 14:33:17 GMT Subject: RFR: jcheck: conditionally check backport reviewers Message-ID: Hi all, please review this patch that makes it possible to configure whether reviewers are required or not for backport commits. The `reviewers` check now supports the configuration `backports=check` or `backports=ignore` with `backports=ignore` being the default. We will still check for invalid reviewers and self-reviews, it is just the "number of reviewers" that can be disabled for backport commits. Testing: - [x] Added three new unit tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - jcheck: conditionally check backport reviewers Changes: https://git.openjdk.java.net/skara/pull/884/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=884&range=00 Stats: 73 lines in 3 files changed: 59 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/884.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/884/head:pull/884 PR: https://git.openjdk.java.net/skara/pull/884 From rwestberg at openjdk.java.net Wed Oct 14 15:01:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 14 Oct 2020 15:01:10 GMT Subject: RFR: jcheck: conditionally check backport reviewers In-Reply-To: References: Message-ID: On Wed, 14 Oct 2020 14:30:11 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible to configure whether reviewers are required or not for backport > commits. The `reviewers` check now supports the configuration `backports=check` or `backports=ignore` with > `backports=ignore` being the default. We will still check for invalid reviewers and self-reviews, it is just the > "number of reviewers" that can be disabled for backport commits. Testing: > - [x] Added three new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/884 From thomas.stuefe at gmail.com Thu Oct 15 06:15:01 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 15 Oct 2020 08:15:01 +0200 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> Message-ID: Hi Tim, anything new on that front? I keep replying to RFR threads only for the mails to bounce back because I always forget to manually change the mail addresses back to the real ones (e..g @oracle.com). Thank you, Thomas On Thu, Sep 24, 2020 at 4:53 PM Thomas St?fe wrote: > Thank you Tim! > > On Thu, Sep 24, 2020, 16:49 Tim Bell wrote: > >> On 2020-09-24 06:56, Volker Simonis wrote: >> > The "Volker Simonis" seems indeed strange. >> > Maybe they have a magic mail server which translates all >> > "@openjdk.java.net" addresses into real addresses? >> >> That is exactly what I am working on. My initial testing was >> encouraging, so stay tuned. I need another day or two to work on the >> mapping of OpenJDK id strings to Github membership information. In many >> cases it is not 1:1. >> >> Tim Bell >> > From ehelin at openjdk.java.net Thu Oct 15 12:39:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 15 Oct 2020 12:39:24 GMT Subject: RFR: pr: detect clean backports Message-ID: Hi all, please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a fuzzing factor via `--fuzz` that is the same as the number of context lines. A clean backport also doesn't require reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch. Testing: - [x] Added a bunch of tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - pr: detect clean backports Changes: https://git.openjdk.java.net/skara/pull/885/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=885&range=00 Stats: 634 lines in 5 files changed: 609 ins; 12 del; 13 mod Patch: https://git.openjdk.java.net/skara/pull/885.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/885/head:pull/885 PR: https://git.openjdk.java.net/skara/pull/885 From rwestberg at openjdk.java.net Fri Oct 16 07:18:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 16 Oct 2020 07:18:54 GMT Subject: RFR: Initial implementation of dependent pull requests Message-ID: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> This is the initial implementation of the support for creating a follow-up pull request while the first one is still out for review. This will allow having multiple dependent changes out for review simultaneously, which is something that was possible during the hg/webrev era. To use it, first create a pull request from the first change. In that pull request, issue the `/preintegrate` command. This will publish the current contents to a new branch in the *target* repository named `pr//`. Now any follow-up work can target this branch instead, which contains the dependent work. When the first pull request is `/integrate`d, any follow-up pull requests will automatically be retargeted to the original target branch. It will not be possible to `/integrate` the follow-up pull request until the first one has been integrated. ------------- Commit messages: - Initial implementation Changes: https://git.openjdk.java.net/skara/pull/886/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=886&range=00 Stats: 460 lines in 18 files changed: 429 ins; 12 del; 19 mod Patch: https://git.openjdk.java.net/skara/pull/886.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/886/head:pull/886 PR: https://git.openjdk.java.net/skara/pull/886 From ehelin at openjdk.java.net Fri Oct 16 10:02:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 16 Oct 2020 10:02:22 GMT Subject: RFR: pr: detect clean backports [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport > pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines > being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the > changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a > fuzzing factor via `--fuzz` that is the same as the number of context lines. A clean backport also doesn't require > reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch. > Testing: > - [x] Added a bunch of tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Fix spelling Co-authored-by: Robin Westberg ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/885/files - new: https://git.openjdk.java.net/skara/pull/885/files/c33ec6fe..49542d66 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=885&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=885&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/885.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/885/head:pull/885 PR: https://git.openjdk.java.net/skara/pull/885 From rwestberg at openjdk.java.net Fri Oct 16 10:02:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 16 Oct 2020 10:02:25 GMT Subject: RFR: pr: detect clean backports [v2] In-Reply-To: References: Message-ID: On Fri, 16 Oct 2020 09:59:58 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport >> pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines >> being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the >> changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a >> fuzzing factor via `--fuzz` that is the same as the number of context lines. A clean backport also doesn't require >> reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch. >> Testing: >> - [x] Added a bunch of tests >> - [x] `make test` passes on Linux x64 >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Fix spelling > > Co-authored-by: Robin Westberg Looks good! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 962: > 960: try { > 961: // Do not pass eventual original commit even for backports since it will cause > 962: // the reviwer check to be ignored. Suggestion: // the reviewer check to be ignored. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/885 From rwestberg at openjdk.java.net Fri Oct 16 13:34:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 16 Oct 2020 13:34:21 GMT Subject: RFR: Initial implementation of dependent pull requests [v2] In-Reply-To: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> References: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> Message-ID: > This is the initial implementation of the support for creating a follow-up pull request while the first one is still > out for review. This will allow having multiple dependent changes out for review simultaneously, which is something > that was possible during the hg/webrev era. To use it, first create a pull request from the first change. In that pull > request, issue the `/preintegrate` command. This will publish the current contents to a new branch in the *target* > repository named `pr//`. Now any follow-up work can target this branch instead, which contains the > dependent work. When the first pull request is `/integrate`d, any follow-up pull requests will automatically be > retargeted to the original target branch. It will not be possible to `/integrate` the follow-up pull request until the > first one has been integrated. Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Update pre-integration target branches automatically ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/886/files - new: https://git.openjdk.java.net/skara/pull/886/files/24270bf0..45ca450e Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=886&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=886&range=00-01 Stats: 492 lines in 13 files changed: 336 ins; 137 del; 19 mod Patch: https://git.openjdk.java.net/skara/pull/886.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/886/head:pull/886 PR: https://git.openjdk.java.net/skara/pull/886 From ehelin at openjdk.java.net Fri Oct 16 13:46:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 16 Oct 2020 13:46:39 GMT Subject: RFR: Initial implementation of dependent pull requests [v2] In-Reply-To: References: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> Message-ID: On Fri, 16 Oct 2020 13:34:21 GMT, Robin Westberg wrote: >> This is the initial implementation of the support for creating a follow-up pull request while the first one is still >> out for review. This will allow having multiple dependent changes out for review simultaneously, which is something >> that was possible during the hg/webrev era. To use it, first create a pull request from the first change. In that pull >> request, issue the `/preintegrate` command. This will publish the current contents to a new branch in the *target* >> repository named `pr//`. Now any follow-up work can target this branch instead, which contains the >> dependent work. When the first pull request is `/integrate`d, any follow-up pull requests will automatically be >> retargeted to the original target branch. It will not be possible to `/integrate` the follow-up pull request until the >> first one has been integrated. > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Update pre-integration target branches automatically Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/886 From ehelin at openjdk.java.net Sat Oct 17 07:49:18 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 17 Oct 2020 07:49:18 GMT Subject: Integrated: pr: detect clean backports In-Reply-To: References: Message-ID: On Thu, 15 Oct 2020 12:36:49 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport > pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines > being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the > changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a > fuzzing factor via `--fuzz` that is the same as the number of context lines. A clean backport also doesn't require > reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch. > Testing: > - [x] Added a bunch of tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 7774dcdb Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/7774dcdb Stats: 634 lines in 5 files changed: 609 ins; 12 del; 13 mod pr: detect clean backports Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/885 From rwestberg at openjdk.java.net Mon Oct 19 07:14:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 07:14:51 GMT Subject: RFR: Initial implementation of dependent pull requests [v3] In-Reply-To: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> References: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> Message-ID: > This is the initial implementation of the support for creating a follow-up pull request while the first one is still > out for review. This will allow having multiple dependent changes out for review simultaneously, which is something > that was possible during the hg/webrev era. To use it, first create a pull request from the first change. In that pull > request, issue the `/preintegrate` command. This will publish the current contents to a new branch in the *target* > repository named `pr//`. Now any follow-up work can target this branch instead, which contains the > dependent work. When the first pull request is `/integrate`d, any follow-up pull requests will automatically be > retargeted to the original target branch. It will not be possible to `/integrate` the follow-up pull request until the > first one has been integrated. Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Move filtering of pre-integration branches a bit higher up ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/886/files - new: https://git.openjdk.java.net/skara/pull/886/files/45ca450e..0d849bb5 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=886&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=886&range=01-02 Stats: 9 lines in 5 files changed: 4 ins; 4 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/886.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/886/head:pull/886 PR: https://git.openjdk.java.net/skara/pull/886 From rwestberg at openjdk.java.net Mon Oct 19 07:53:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 07:53:08 GMT Subject: Integrated: Initial implementation of dependent pull requests In-Reply-To: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> References: <3L2nC-eyf_LX70zhCj3-8HSwRyR_GnyM7wyQO3YEFXE=.5c5dc845-7354-443d-a16c-edc79a4b94fd@github.com> Message-ID: On Fri, 16 Oct 2020 07:16:06 GMT, Robin Westberg wrote: > This is the initial implementation of the support for creating a follow-up pull request while the first one is still > out for review. This will allow having multiple dependent changes out for review simultaneously, which is something > that was possible during the hg/webrev era. To use it, first create a pull request from the first change. In that pull > request, issue the `/preintegrate` command. This will publish the current contents to a new branch in the *target* > repository named `pr//`. Now any follow-up work can target this branch instead, which contains the > dependent work. When the first pull request is `/integrate`d, any follow-up pull requests will automatically be > retargeted to the original target branch. It will not be possible to `/integrate` the follow-up pull request until the > first one has been integrated. This pull request has now been integrated. Changeset: f38ef5ab Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f38ef5ab Stats: 671 lines in 23 files changed: 628 ins; 12 del; 31 mod Initial implementation of dependent pull requests Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/886 From rwestberg at openjdk.java.net Mon Oct 19 08:31:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 08:31:51 GMT Subject: RFR: 612: Missing blank lines from quotation in e-mail Message-ID: At one point in time, the mailman archive on openjdk.java.net did not word-wrap long lines. To make emails sent by Skara look nice in the archive, word wrapping was done before sending. However, this have now changed serverside, and the archive now includes `white-space: pre-wrap;` for the body. See for example https://mail.openjdk.java.net/pipermail/openjfx-dev/2017-December/021059.html vs https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-October/027909.html. Therefore we can simply drop the wordwrapping and avoid the associated bugs. ------------- Commit messages: - Remove word-wrapping code Changes: https://git.openjdk.java.net/skara/pull/887/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=887&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-612 Stats: 199 lines in 3 files changed: 0 ins; 198 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/887.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/887/head:pull/887 PR: https://git.openjdk.java.net/skara/pull/887 From ehelin at openjdk.java.net Mon Oct 19 09:59:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 09:59:19 GMT Subject: RFR: 612: Missing blank lines from quotation in e-mail In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 08:29:01 GMT, Robin Westberg wrote: > At one point in time, the mailman archive on openjdk.java.net did not word-wrap long lines. To make emails sent by > Skara look nice in the archive, word wrapping was done before sending. > However, this have now changed serverside, and the archive now includes `white-space: pre-wrap;` for the body. See for > example https://mail.openjdk.java.net/pipermail/openjfx-dev/2017-December/021059.html vs > https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-October/027909.html. Therefore we can simply drop the > wordwrapping and avoid the associated bugs. Looks good ?? ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/887 From ehelin at openjdk.java.net Mon Oct 19 12:44:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 12:44:37 GMT Subject: RFR: all: username is one word Message-ID: Hi all, please review this patch that is a refactoring to always use `username` instead of `userName`. Thanks, Erik ------------- Commit messages: - host: rename HostUser.userName -> HostUser.username Changes: https://git.openjdk.java.net/skara/pull/888/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=888&range=00 Stats: 127 lines in 39 files changed: 0 ins; 0 del; 127 mod Patch: https://git.openjdk.java.net/skara/pull/888.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/888/head:pull/888 PR: https://git.openjdk.java.net/skara/pull/888 From rwestberg at openjdk.java.net Mon Oct 19 12:49:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 12:49:36 GMT Subject: RFR: all: username is one word In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 12:41:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that is a refactoring to always use `username` instead of `userName`. > > Thanks, > Erik Looks marvelous! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/888 From ehelin at openjdk.java.net Mon Oct 19 12:49:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 12:49:37 GMT Subject: Integrated: all: username is one word In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 12:41:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that is a refactoring to always use `username` instead of `userName`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 89235b55 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/89235b55 Stats: 127 lines in 39 files changed: 0 ins; 0 del; 127 mod all: username is one word Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/888 From ehelin at openjdk.java.net Mon Oct 19 12:59:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 12:59:53 GMT Subject: Integrated: forge: refactor HostUser constructor to static methods Message-ID: <4MMqCyjWlVElWwzf_V-myxTJnaeQcxtL7jzVhcqNk9w=.7795bf71-9141-41ca-b2fa-562e6ae75bbe@github.com> Hi all, please review this patch that refactors `HostUser` to get have private constructors and instead use public static creator functions. This is in preparation for a refactoring to using a "builder" for the `HostUser` class. Thanks, Erik ------------- Commit messages: - forge: refactor HostUser constructor to static method Changes: https://git.openjdk.java.net/skara/pull/889/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=889&range=00 Stats: 151 lines in 19 files changed: 9 ins; 0 del; 142 mod Patch: https://git.openjdk.java.net/skara/pull/889.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/889/head:pull/889 PR: https://git.openjdk.java.net/skara/pull/889 From rwestberg at openjdk.java.net Mon Oct 19 12:59:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 12:59:54 GMT Subject: Integrated: forge: refactor HostUser constructor to static methods In-Reply-To: <4MMqCyjWlVElWwzf_V-myxTJnaeQcxtL7jzVhcqNk9w=.7795bf71-9141-41ca-b2fa-562e6ae75bbe@github.com> References: <4MMqCyjWlVElWwzf_V-myxTJnaeQcxtL7jzVhcqNk9w=.7795bf71-9141-41ca-b2fa-562e6ae75bbe@github.com> Message-ID: On Mon, 19 Oct 2020 12:54:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostUser` to get have private constructors and instead use public static > creator functions. This is in preparation for a refactoring to using a "builder" for the `HostUser` class. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/889 From ehelin at openjdk.java.net Mon Oct 19 12:59:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 12:59:55 GMT Subject: Integrated: forge: refactor HostUser constructor to static methods In-Reply-To: <4MMqCyjWlVElWwzf_V-myxTJnaeQcxtL7jzVhcqNk9w=.7795bf71-9141-41ca-b2fa-562e6ae75bbe@github.com> References: <4MMqCyjWlVElWwzf_V-myxTJnaeQcxtL7jzVhcqNk9w=.7795bf71-9141-41ca-b2fa-562e6ae75bbe@github.com> Message-ID: On Mon, 19 Oct 2020 12:54:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostUser` to get have private constructors and instead use public static > creator functions. This is in preparation for a refactoring to using a "builder" for the `HostUser` class. > Thanks, > Erik This pull request has now been integrated. Changeset: 5fa4d6e3 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5fa4d6e3 Stats: 151 lines in 19 files changed: 9 ins; 0 del; 142 mod forge: refactor HostUser constructor to static methods Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/889 From ehelin at openjdk.java.net Mon Oct 19 13:04:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 13:04:33 GMT Subject: RFR: forge: add builder for HostUser Message-ID: Hi all, please review this patch that adds "builder" for the class `HostUser`. The builder also generalizes the concept of fetching missing information for a `HostUser` so that any username, id and full name now can fetched lazily. Thanks, Erik ------------- Commit messages: - forge: add builder for HostUser Changes: https://git.openjdk.java.net/skara/pull/890/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=890&range=00 Stats: 125 lines in 5 files changed: 63 ins; 15 del; 47 mod Patch: https://git.openjdk.java.net/skara/pull/890.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/890/head:pull/890 PR: https://git.openjdk.java.net/skara/pull/890 From rwestberg at openjdk.java.net Mon Oct 19 13:15:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 13:15:27 GMT Subject: RFR: forge: add builder for HostUser In-Reply-To: References: Message-ID: <4_JQmUYRxRjOrbKPTwP1CnKQjLLwfXCxvsyro92dzw4=.4cacb769-5551-470a-a07d-3779e801b624@github.com> On Mon, 19 Oct 2020 13:01:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds "builder" for the class `HostUser`. The builder also generalizes the concept of > fetching missing information for a `HostUser` so that any username, id and full name now can fetched lazily. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/890 From rwestberg at openjdk.java.net Mon Oct 19 13:24:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 19 Oct 2020 13:24:43 GMT Subject: Integrated: 612: Missing blank lines from quotation in e-mail In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 08:29:01 GMT, Robin Westberg wrote: > At one point in time, the mailman archive on openjdk.java.net did not word-wrap long lines. To make emails sent by > Skara look nice in the archive, word wrapping was done before sending. > However, this have now changed serverside, and the archive now includes `white-space: pre-wrap;` for the body. See for > example https://mail.openjdk.java.net/pipermail/openjfx-dev/2017-December/021059.html vs > https://mail.openjdk.java.net/pipermail/openjfx-dev/2020-October/027909.html. Therefore we can simply drop the > wordwrapping and avoid the associated bugs. This pull request has now been integrated. Changeset: 72c9b1a0 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/72c9b1a0 Stats: 199 lines in 3 files changed: 0 ins; 198 del; 1 mod 612: Missing blank lines from quotation in e-mail 679: Extraneous newlines in RFR mails 739: Improve formatting of PR comments bridged to mailing list Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/887 From ehelin at openjdk.java.net Mon Oct 19 13:33:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 13:33:41 GMT Subject: RFR: forge: add HostedRepository.recentCommitComments Message-ID: Hi all, please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make `CommitComment` support lazily fetching the hash for the commit. Thanks, Erik ------------- Commit messages: - forge: add HostedRepository.recentCommitComments Changes: https://git.openjdk.java.net/skara/pull/891/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=00 Stats: 213 lines in 7 files changed: 176 ins; 20 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/891.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/891/head:pull/891 PR: https://git.openjdk.java.net/skara/pull/891 From ehelin at openjdk.java.net Mon Oct 19 14:33:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 14:33:13 GMT Subject: Integrated: forge: add builder for HostUser In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 13:01:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds "builder" for the class `HostUser`. The builder also generalizes the concept of > fetching missing information for a `HostUser` so that any username, id and full name now can fetched lazily. > Thanks, > Erik This pull request has now been integrated. Changeset: b52c8a05 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b52c8a05 Stats: 125 lines in 5 files changed: 63 ins; 15 del; 47 mod forge: add builder for HostUser Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/890 From ehelin at openjdk.java.net Mon Oct 19 14:33:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 14:33:37 GMT Subject: RFR: forge: add HostedRepository.recentCommitComments [v2] In-Reply-To: References: Message-ID: <29BaKwQJmXS5MjqVUG4lMI2OCyyF8R46e1rdBx0XJ0c=.9e561d54-28c7-4531-a5a4-32752437297c@github.com> > Hi all, > > please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit > comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are > very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it > doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make > `CommitComment` support lazily fetching the hash for the commit. Thanks, Erik Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/891/files - new: https://git.openjdk.java.net/skara/pull/891/files/d5a7d603..d5a7d603 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=00-01 Stats: 0 lines in 0 files changed: 0 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/891.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/891/head:pull/891 PR: https://git.openjdk.java.net/skara/pull/891 From ehelin at openjdk.java.net Mon Oct 19 14:58:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 19 Oct 2020 14:58:45 GMT Subject: RFR: forge: add HostedRepository.recentCommitComments [v3] In-Reply-To: References: Message-ID: <6mH5m_e6QVK-HBctlWuGgtLvHncP7EQPa8AslEVMOUY=.d34ebc3d-fed5-4a01-b242-b1589b81f190@github.com> > Hi all, > > please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit > comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are > very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it > doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make > `CommitComment` support lazily fetching the hash for the commit. Thanks, Erik Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: - Merge master - forge: add HostedRepository.recentCommitComments - forge: add builder for HostUser ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/891/files - new: https://git.openjdk.java.net/skara/pull/891/files/d5a7d603..5e04fea7 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=891&range=01-02 Stats: 199 lines in 3 files changed: 0 ins; 198 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/891.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/891/head:pull/891 PR: https://git.openjdk.java.net/skara/pull/891 From rwestberg at openjdk.java.net Tue Oct 20 08:21:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 08:21:03 GMT Subject: RFR: Allow a remote pre-integration branch to be missing Message-ID: If a pre-integration branch doesn't exist remotely, there's no need to try to delete it. ------------- Commit messages: - Allow a remote pre-integration branch to be missing Changes: https://git.openjdk.java.net/skara/pull/892/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=892&range=00 Stats: 51 lines in 2 files changed: 49 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/892.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/892/head:pull/892 PR: https://git.openjdk.java.net/skara/pull/892 From ehelin at openjdk.java.net Tue Oct 20 08:21:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 20 Oct 2020 08:21:03 GMT Subject: RFR: Allow a remote pre-integration branch to be missing In-Reply-To: References: Message-ID: <96n_QFeHn9jxR6VVWTGBzeSRjLILcCFYQr3XAEkGwfg=.a7039330-419d-4b72-843b-5fcc527ef785@github.com> On Tue, 20 Oct 2020 08:17:27 GMT, Robin Westberg wrote: > If a pre-integration branch doesn't exist remotely, there's no need to try to delete it. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/892 From rwestberg at openjdk.java.net Tue Oct 20 08:23:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 08:23:36 GMT Subject: Integrated: Allow a remote pre-integration branch to be missing In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 08:17:27 GMT, Robin Westberg wrote: > If a pre-integration branch doesn't exist remotely, there's no need to try to delete it. This pull request has now been integrated. Changeset: 8f29ac91 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/8f29ac91 Stats: 51 lines in 2 files changed: 49 ins; 0 del; 2 mod Allow a remote pre-integration branch to be missing Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/892 From rwestberg at openjdk.java.net Tue Oct 20 12:13:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 12:13:58 GMT Subject: RFR: Avoid storing empty files Message-ID: There should not be any need to push empty files to RepositoryStorage. ------------- Commit messages: - Avoid storing empty files Changes: https://git.openjdk.java.net/skara/pull/893/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=893&range=00 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/893.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/893/head:pull/893 PR: https://git.openjdk.java.net/skara/pull/893 From rwestberg at openjdk.java.net Tue Oct 20 12:16:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 12:16:14 GMT Subject: RFR: forge: add HostedRepository.recentCommitComments [v3] In-Reply-To: <6mH5m_e6QVK-HBctlWuGgtLvHncP7EQPa8AslEVMOUY=.d34ebc3d-fed5-4a01-b242-b1589b81f190@github.com> References: <6mH5m_e6QVK-HBctlWuGgtLvHncP7EQPa8AslEVMOUY=.d34ebc3d-fed5-4a01-b242-b1589b81f190@github.com> Message-ID: <_XALAlH7wXNsOnd2TRD6JsUL2l0unjaWSUV9aNjEmeo=.4f73d867-fbc1-4628-b3c4-902484ca223c@github.com> On Mon, 19 Oct 2020 14:58:45 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make `CommitComment` support lazily fetching the hash for the commit. >> >> Thanks, >> Erik > > Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision: > > - Merge master > - forge: add HostedRepository.recentCommitComments > - forge: add builder for HostUser Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/891 From rwestberg at openjdk.java.net Tue Oct 20 13:12:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 13:12:09 GMT Subject: RFR: Use a separate watchdog thread for the WorkItem scheduler Message-ID: Use a separate watchdog thread to be able to detect if our ForkJoinPool stops executing tasks (which we've seen happen a few times). Not much to do in that case, just let the process restart. ------------- Commit messages: - Use a separate watchdog thread Changes: https://git.openjdk.java.net/skara/pull/894/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=894&range=00 Stats: 63 lines in 2 files changed: 61 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/894.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/894/head:pull/894 PR: https://git.openjdk.java.net/skara/pull/894 From rwestberg at openjdk.java.net Tue Oct 20 13:42:59 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 13:42:59 GMT Subject: RFR: Give up waiting for the auth lock after a while Message-ID: If a RestRequest never completes (this has happened a few times) we give up after a while to allow the process to be restarted. ------------- Commit messages: - Give up waiting for the auth lock after a while Changes: https://git.openjdk.java.net/skara/pull/895/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=895&range=00 Stats: 44 lines in 1 file changed: 24 ins; 13 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/895.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/895/head:pull/895 PR: https://git.openjdk.java.net/skara/pull/895 From ehelin at openjdk.java.net Tue Oct 20 14:36:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 20 Oct 2020 14:36:59 GMT Subject: RFR: Avoid storing empty files In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 12:11:12 GMT, Robin Westberg wrote: > There should not be any need to push empty files to RepositoryStorage. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/893 From ehelin at openjdk.java.net Tue Oct 20 14:38:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 20 Oct 2020 14:38:13 GMT Subject: RFR: Use a separate watchdog thread for the WorkItem scheduler In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 13:09:13 GMT, Robin Westberg wrote: > Use a separate watchdog thread to be able to detect if our ForkJoinPool stops executing tasks (which we've seen happen a few times). Not much to do in that case, just let the process restart. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/894 From ehelin at openjdk.java.net Tue Oct 20 14:39:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 20 Oct 2020 14:39:43 GMT Subject: RFR: Give up waiting for the auth lock after a while In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 13:40:01 GMT, Robin Westberg wrote: > If a RestRequest never completes (this has happened a few times) we give up after a while to allow the process to be restarted. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/895 From rwestberg at openjdk.java.net Tue Oct 20 14:52:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 14:52:42 GMT Subject: Integrated: Give up waiting for the auth lock after a while In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 13:40:01 GMT, Robin Westberg wrote: > If a RestRequest never completes (this has happened a few times) we give up after a while to allow the process to be restarted. This pull request has now been integrated. Changeset: 313e7e10 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/313e7e10 Stats: 44 lines in 1 file changed: 24 ins; 13 del; 7 mod Give up waiting for the auth lock after a while Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/895 From rwestberg at openjdk.java.net Tue Oct 20 14:52:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 14:52:51 GMT Subject: Integrated: Use a separate watchdog thread for the WorkItem scheduler In-Reply-To: References: Message-ID: On Tue, 20 Oct 2020 13:09:13 GMT, Robin Westberg wrote: > Use a separate watchdog thread to be able to detect if our ForkJoinPool stops executing tasks (which we've seen happen a few times). Not much to do in that case, just let the process restart. This pull request has now been integrated. Changeset: c596e457 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/c596e457 Stats: 63 lines in 2 files changed: 61 ins; 0 del; 2 mod Use a separate watchdog thread for the WorkItem scheduler Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/894 From rwestberg at openjdk.java.net Tue Oct 20 14:53:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 20 Oct 2020 14:53:12 GMT Subject: Integrated: Avoid storing empty files In-Reply-To: References: Message-ID: <6mHJe2NCRffUie7G0FMOMMnuXuiA1Ij6QyMbCZ1cyPo=.05635687-e12c-4e18-a411-7604b76e75f8@github.com> On Tue, 20 Oct 2020 12:11:12 GMT, Robin Westberg wrote: > There should not be any need to push empty files to RepositoryStorage. This pull request has now been integrated. Changeset: 797ac2c5 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/797ac2c5 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Avoid storing empty files Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/893 From ehelin at openjdk.java.net Wed Oct 21 07:48:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 07:48:20 GMT Subject: Integrated: forge: add HostedRepository.recentCommitComments In-Reply-To: References: Message-ID: On Mon, 19 Oct 2020 13:30:42 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `HostedRepository.recentCommitComments` for fetching recent commit comments. "Recent" is somewhat fuzzy and is up to the forge to decide, because the REST APIs for GitHub and GitLab are very different for retrieving recent commit comments. The GitLab REST API in particular is a bit annoying since it doesn't provide a `noteable_id` with the commit's hash for commit comment events. I therefore hade to make `CommitComment` support lazily fetching the hash for the commit. > > Thanks, > Erik This pull request has now been integrated. Changeset: 63e61c95 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/63e61c95 Stats: 213 lines in 7 files changed: 176 ins; 20 del; 17 mod forge: add HostedRepository.recentCommitComments Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/891 From rwestberg at openjdk.java.net Wed Oct 21 09:57:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 09:57:46 GMT Subject: RFR: Better retry logic for the mlbridge archiver Message-ID: If the mlbridge fails to push to the archive, it should not try to recreate the commit after rebase. ------------- Commit messages: - Better retry logic Changes: https://git.openjdk.java.net/skara/pull/896/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=896&range=00 Stats: 131 lines in 3 files changed: 120 ins; 9 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/896.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/896/head:pull/896 PR: https://git.openjdk.java.net/skara/pull/896 From ehelin at openjdk.java.net Wed Oct 21 09:57:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 09:57:46 GMT Subject: RFR: Better retry logic for the mlbridge archiver In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 09:53:32 GMT, Robin Westberg wrote: > If the mlbridge fails to push to the archive, it should not try to recreate the commit after rebase. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/896 From rwestberg at openjdk.java.net Wed Oct 21 10:01:07 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 10:01:07 GMT Subject: Integrated: Better retry logic for the mlbridge archiver In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 09:53:32 GMT, Robin Westberg wrote: > If the mlbridge fails to push to the archive, it should not try to recreate the commit after rebase. This pull request has now been integrated. Changeset: d81bde09 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/d81bde09 Stats: 131 lines in 3 files changed: 120 ins; 9 del; 2 mod Better retry logic for the mlbridge archiver Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/896 From ehelin at openjdk.java.net Wed Oct 21 10:09:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 10:09:39 GMT Subject: RFR: vcs: fix hunk line parsing in UnifiedDiffParser Message-ID: Hi all, please review this patch that fixes the parsing in `UnifiedDiffParser.parseSingleFileDiff` a bit. The parser now understands Git's extended headers and also properly moves past a hunk start lines (lines starting with `@@`). Testing: - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - vcs: fix hunk line parsing in UnifiedDiffParser Changes: https://git.openjdk.java.net/skara/pull/897/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=897&range=00 Stats: 425 lines in 2 files changed: 423 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/897.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/897/head:pull/897 PR: https://git.openjdk.java.net/skara/pull/897 From rwestberg at openjdk.java.net Wed Oct 21 10:11:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 10:11:42 GMT Subject: RFR: vcs: fix hunk line parsing in UnifiedDiffParser In-Reply-To: References: Message-ID: <2vY6zWis3NJsai2isqovTl_j7MrRlN7nmuaHPdaXv6Q=.b3bbec68-fe5d-4746-99f6-cf34e7fc87a0@github.com> On Wed, 21 Oct 2020 10:07:06 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes the parsing in `UnifiedDiffParser.parseSingleFileDiff` a bit. The parser now understands Git's extended headers and also properly moves past a hunk start lines (lines starting with `@@`). > > Testing: > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/897 From ehelin at openjdk.java.net Wed Oct 21 10:31:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 10:31:45 GMT Subject: Integrated: vcs: fix hunk line parsing in UnifiedDiffParser In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 10:07:06 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes the parsing in `UnifiedDiffParser.parseSingleFileDiff` a bit. The parser now understands Git's extended headers and also properly moves past a hunk start lines (lines starting with `@@`). > > Testing: > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 90b785a1 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/90b785a1 Stats: 425 lines in 2 files changed: 423 ins; 0 del; 2 mod vcs: fix hunk line parsing in UnifiedDiffParser Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/897 From ehelin at openjdk.java.net Wed Oct 21 11:52:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 11:52:09 GMT Subject: RFR: vcs: lookup does not handle non-existing commits Message-ID: Hi all, please review this patch that makes `ReadOnlyRepository.lookup` handle hashes that do not exist in the repository. I also added a unit test for this scenario. Thanks, Erik ------------- Commit messages: - vcs: lookup does not handle non-existing commits Changes: https://git.openjdk.java.net/skara/pull/898/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=898&range=00 Stats: 38 lines in 3 files changed: 38 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/898.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/898/head:pull/898 PR: https://git.openjdk.java.net/skara/pull/898 From rwestberg at openjdk.java.net Wed Oct 21 11:59:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 11:59:34 GMT Subject: RFR: vcs: lookup does not handle non-existing commits In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 11:49:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `ReadOnlyRepository.lookup` handle hashes that do not exist in the repository. I also added a unit test for this scenario. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/898 From ehelin at openjdk.java.net Wed Oct 21 12:00:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:00:34 GMT Subject: RFR: forge: make HostedCommit extend Commit Message-ID: <1GoMU3IYoriCKffO-LQ6fmBH86dNKy9eDCoPdZLtoME=.4744df28-fc7c-45e3-b213-2cc34780e213@github.com> Hi all, please review this small refactoring that makes `HostedCommit` extend `Commit`. Thanks, Erik ------------- Commit messages: - forge: make HostedCommit extend Commit Changes: https://git.openjdk.java.net/skara/pull/899/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=899&range=00 Stats: 53 lines in 1 file changed: 0 ins; 49 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/899.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/899/head:pull/899 PR: https://git.openjdk.java.net/skara/pull/899 From rwestberg at openjdk.java.net Wed Oct 21 12:00:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 12:00:34 GMT Subject: RFR: forge: make HostedCommit extend Commit In-Reply-To: <1GoMU3IYoriCKffO-LQ6fmBH86dNKy9eDCoPdZLtoME=.4744df28-fc7c-45e3-b213-2cc34780e213@github.com> References: <1GoMU3IYoriCKffO-LQ6fmBH86dNKy9eDCoPdZLtoME=.4744df28-fc7c-45e3-b213-2cc34780e213@github.com> Message-ID: On Wed, 21 Oct 2020 11:56:11 GMT, Erik Helin wrote: > Hi all, > > please review this small refactoring that makes `HostedCommit` extend `Commit`. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/899 From ehelin at openjdk.java.net Wed Oct 21 12:02:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:02:33 GMT Subject: Integrated: vcs: lookup does not handle non-existing commits In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 11:49:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `ReadOnlyRepository.lookup` handle hashes that do not exist in the repository. I also added a unit test for this scenario. > > Thanks, > Erik This pull request has now been integrated. Changeset: b2b5358b Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b2b5358b Stats: 38 lines in 3 files changed: 38 ins; 0 del; 0 mod vcs: lookup does not handle non-existing commits Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/898 From ehelin at openjdk.java.net Wed Oct 21 12:03:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:03:05 GMT Subject: Integrated: forge: make HostedCommit extend Commit In-Reply-To: <1GoMU3IYoriCKffO-LQ6fmBH86dNKy9eDCoPdZLtoME=.4744df28-fc7c-45e3-b213-2cc34780e213@github.com> References: <1GoMU3IYoriCKffO-LQ6fmBH86dNKy9eDCoPdZLtoME=.4744df28-fc7c-45e3-b213-2cc34780e213@github.com> Message-ID: On Wed, 21 Oct 2020 11:56:11 GMT, Erik Helin wrote: > Hi all, > > please review this small refactoring that makes `HostedCommit` extend `Commit`. > > Thanks, > Erik This pull request has now been integrated. Changeset: c72344cf Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/c72344cf Stats: 53 lines in 1 file changed: 0 ins; 49 del; 4 mod forge: make HostedCommit extend Commit Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/899 From ehelin at openjdk.java.net Wed Oct 21 12:06:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:06:19 GMT Subject: Integrated: forge: add Accept HTTP headers for GitHub search API Message-ID: <64li1TjTfUeWHRgv4TdRnbjfFEHe5imbwDPumEGLhsE=.29b7dda6-8588-457d-8229-e0b5611bfbd7@github.com> Hi all, please review this patch that adds the appropriate HTTP headers for using GitHub's search REST endpoint. I also that the `RestRequest`s created in different constructors specify the same `Accept` headers. Thanks, Erik ------------- Commit messages: - forge: add Accept HTTP headers for GitHub search API Changes: https://git.openjdk.java.net/skara/pull/900/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=900&range=00 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/900.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/900/head:pull/900 PR: https://git.openjdk.java.net/skara/pull/900 From rwestberg at openjdk.java.net Wed Oct 21 12:06:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 12:06:19 GMT Subject: Integrated: forge: add Accept HTTP headers for GitHub search API In-Reply-To: <64li1TjTfUeWHRgv4TdRnbjfFEHe5imbwDPumEGLhsE=.29b7dda6-8588-457d-8229-e0b5611bfbd7@github.com> References: <64li1TjTfUeWHRgv4TdRnbjfFEHe5imbwDPumEGLhsE=.29b7dda6-8588-457d-8229-e0b5611bfbd7@github.com> Message-ID: On Wed, 21 Oct 2020 11:59:21 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the appropriate HTTP headers for using GitHub's search REST endpoint. I also that the `RestRequest`s created in different constructors specify the same `Accept` headers. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/900 From ehelin at openjdk.java.net Wed Oct 21 12:06:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:06:19 GMT Subject: Integrated: forge: add Accept HTTP headers for GitHub search API In-Reply-To: <64li1TjTfUeWHRgv4TdRnbjfFEHe5imbwDPumEGLhsE=.29b7dda6-8588-457d-8229-e0b5611bfbd7@github.com> References: <64li1TjTfUeWHRgv4TdRnbjfFEHe5imbwDPumEGLhsE=.29b7dda6-8588-457d-8229-e0b5611bfbd7@github.com> Message-ID: On Wed, 21 Oct 2020 11:59:21 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the appropriate HTTP headers for using GitHub's search REST endpoint. I also that the `RestRequest`s created in different constructors specify the same `Accept` headers. > > Thanks, > Erik This pull request has now been integrated. Changeset: 2c9bf768 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2c9bf768 Stats: 8 lines in 1 file changed: 6 ins; 0 del; 2 mod forge: add Accept HTTP headers for GitHub search API Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/900 From ehelin at openjdk.java.net Wed Oct 21 12:16:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:16:09 GMT Subject: RFR: forge: refactor HostedRepository.commitMetadata to commit Message-ID: Hi all, please review this patch that refactors `HostedRepository.commitMetadata` to `HostedRepository.commit`. This also allows `Forge.search` to be simplified for both `GitLabHost` and `GitHubHost`. Thanks, Erik ------------- Commit messages: - forge: refactor HostedRepository.commitMetadata to HostedRepository.commit Changes: https://git.openjdk.java.net/skara/pull/901/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=901&range=00 Stats: 238 lines in 13 files changed: 104 ins; 108 del; 26 mod Patch: https://git.openjdk.java.net/skara/pull/901.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/901/head:pull/901 PR: https://git.openjdk.java.net/skara/pull/901 From rwestberg at openjdk.java.net Wed Oct 21 12:18:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 12:18:13 GMT Subject: RFR: forge: refactor HostedRepository.commitMetadata to commit In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 12:13:12 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostedRepository.commitMetadata` to `HostedRepository.commit`. This also allows `Forge.search` to be simplified for both `GitLabHost` and `GitHubHost`. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/901 From ehelin at openjdk.java.net Wed Oct 21 12:21:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 12:21:41 GMT Subject: Integrated: forge: refactor HostedRepository.commitMetadata to commit In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 12:13:12 GMT, Erik Helin wrote: > Hi all, > > please review this patch that refactors `HostedRepository.commitMetadata` to `HostedRepository.commit`. This also allows `Forge.search` to be simplified for both `GitLabHost` and `GitHubHost`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 3d979be0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/3d979be0 Stats: 238 lines in 13 files changed: 104 ins; 108 del; 26 mod forge: refactor HostedRepository.commitMetadata to commit Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/901 From rwestberg at openjdk.java.net Wed Oct 21 12:41:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 12:41:40 GMT Subject: RFR: Retry updating seed if needed, avoid unnecessary fetching Message-ID: Retry fetching a few times if a seed is not allowed to be stale, but otherwise ignore and continue. ------------- Commit messages: - Retry updating seed if needed, avoid unnecessary fetching Changes: https://git.openjdk.java.net/skara/pull/902/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=902&range=00 Stats: 41 lines in 1 file changed: 24 ins; 3 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/902.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/902/head:pull/902 PR: https://git.openjdk.java.net/skara/pull/902 From ehelin at openjdk.java.net Wed Oct 21 14:30:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 14:30:22 GMT Subject: RFR: Retry updating seed if needed, avoid unnecessary fetching In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 12:38:57 GMT, Robin Westberg wrote: > Retry fetching a few times if a seed is not allowed to be stale, but otherwise ignore and continue. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/902 From ehelin at openjdk.java.net Wed Oct 21 14:36:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 14:36:19 GMT Subject: RFR: forge: only updated HostUser once Message-ID: <3oh0XECDh92VsL401lkzFqIdhVMcOISwbGvhLkOuQe8=.2a140281-ebf0-433d-a965-089865f3fd53@github.com> Hi all, please review this patch that ensures that `HostUser` only lazily updates fields once. Thanks, Erik ------------- Commit messages: - forge: only updated HostUser once Changes: https://git.openjdk.java.net/skara/pull/903/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=903&range=00 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/903.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/903/head:pull/903 PR: https://git.openjdk.java.net/skara/pull/903 From ehelin at openjdk.java.net Wed Oct 21 14:40:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 14:40:49 GMT Subject: RFR: forge: fix recentCommitComments for GitHub Message-ID: Hi all, please review this patch that fixes `recentCommitComments` for `GitHubRepository` via tweaking the GraphQL query a bit. Thanks, Erik ------------- Commit messages: - forge: fix recentCommitComments for GitHub Changes: https://git.openjdk.java.net/skara/pull/904/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=904&range=00 Stats: 57 lines in 2 files changed: 17 ins; 7 del; 33 mod Patch: https://git.openjdk.java.net/skara/pull/904.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/904/head:pull/904 PR: https://git.openjdk.java.net/skara/pull/904 From rwestberg at openjdk.java.net Wed Oct 21 14:57:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 14:57:43 GMT Subject: RFR: forge: only updated HostUser once In-Reply-To: <3oh0XECDh92VsL401lkzFqIdhVMcOISwbGvhLkOuQe8=.2a140281-ebf0-433d-a965-089865f3fd53@github.com> References: <3oh0XECDh92VsL401lkzFqIdhVMcOISwbGvhLkOuQe8=.2a140281-ebf0-433d-a965-089865f3fd53@github.com> Message-ID: <6UowwSmAHN44Tgn2DqlWdReTQ9fNqxe7fENSKKhjFd4=.2779660e-ec11-47c1-b9dc-6380150cc814@github.com> On Wed, 21 Oct 2020 14:33:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that `HostUser` only lazily updates fields once. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/903 From rwestberg at openjdk.java.net Wed Oct 21 14:58:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 14:58:32 GMT Subject: Integrated: Retry updating seed if needed, avoid unnecessary fetching In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 12:38:57 GMT, Robin Westberg wrote: > Retry fetching a few times if a seed is not allowed to be stale, but otherwise ignore and continue. This pull request has now been integrated. Changeset: f75ed0a5 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f75ed0a5 Stats: 41 lines in 1 file changed: 24 ins; 3 del; 14 mod Retry updating seed if needed, avoid unnecessary fetching Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/902 From rwestberg at openjdk.java.net Wed Oct 21 14:59:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 14:59:03 GMT Subject: RFR: forge: fix recentCommitComments for GitHub In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 14:38:11 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes `recentCommitComments` for `GitHubRepository` via tweaking the GraphQL query a bit. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/904 From ehelin at openjdk.java.net Wed Oct 21 16:05:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 16:05:31 GMT Subject: Integrated: forge: only update HostUser once In-Reply-To: <3oh0XECDh92VsL401lkzFqIdhVMcOISwbGvhLkOuQe8=.2a140281-ebf0-433d-a965-089865f3fd53@github.com> References: <3oh0XECDh92VsL401lkzFqIdhVMcOISwbGvhLkOuQe8=.2a140281-ebf0-433d-a965-089865f3fd53@github.com> Message-ID: <74ThIcE0Ngtb2UQvtRMYDq12xmDKMvsMjwOxCTFXt7E=.8487ca70-de33-407f-8851-9a79acbd05a0@github.com> On Wed, 21 Oct 2020 14:33:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that `HostUser` only lazily updates fields once. > > Thanks, > Erik This pull request has now been integrated. Changeset: 5d0ea654 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5d0ea654 Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod forge: only update HostUser once Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/903 From ehelin at openjdk.java.net Wed Oct 21 16:05:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 16:05:42 GMT Subject: Integrated: forge: fix recentCommitComments for GitHub In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 14:38:11 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes `recentCommitComments` for `GitHubRepository` via tweaking the GraphQL query a bit. > > Thanks, > Erik This pull request has now been integrated. Changeset: bf1ab1ea Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/bf1ab1ea Stats: 57 lines in 2 files changed: 17 ins; 7 del; 33 mod forge: fix recentCommitComments for GitHub Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/904 From rwestberg at openjdk.java.net Wed Oct 21 17:09:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 21 Oct 2020 17:09:19 GMT Subject: RFR: Make fetchAll the opposite of pushAll Message-ID: Since pushAll pushes all refs, rename fetchAll to fetchAllRemotes and create fetchAll that fetches all refs. ------------- Commit messages: - Make fetchAll the opposite of pushAll Changes: https://git.openjdk.java.net/skara/pull/905/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=905&range=00 Stats: 38 lines in 8 files changed: 28 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/905.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/905/head:pull/905 PR: https://git.openjdk.java.net/skara/pull/905 From ehelin at openjdk.java.net Wed Oct 21 17:30:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 17:30:24 GMT Subject: RFR: Make fetchAll the opposite of pushAll In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 17:06:30 GMT, Robin Westberg wrote: > Since pushAll pushes all refs, rename fetchAll to fetchAllRemotes and create fetchAll that fetches all refs. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/905 From ehelin at openjdk.java.net Wed Oct 21 18:02:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 18:02:20 GMT Subject: RFR: 584: additional check for "git sync" Message-ID: <9waKZdEg1HAJ1U7uG14we26qchvXax9xkN_OWqAraxs=.ef5cb163-8859-4310-accc-b81fc4975ba5@github.com> Hi all, please review this patch that makes `git-sync` check if the `--from` and `--to` arguments refer to the same repository. If they do, then `git-sync` exits with an error. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - 584 Changes: https://git.openjdk.java.net/skara/pull/906/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=906&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-584 Stats: 14 lines in 2 files changed: 14 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/906.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/906/head:pull/906 PR: https://git.openjdk.java.net/skara/pull/906 From ehelin at openjdk.java.net Wed Oct 21 18:16:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 21 Oct 2020 18:16:30 GMT Subject: RFR: cli: add --ignore flag to git-sync Message-ID: Hi all, please review this patch that adds the `--ignore` flag to `git-sync`. The `--ignore` flag is a regular expression for branches that should *not* be synced. The default value for `--ignore` is `pr/.*` to avoid sync branches created by Skara to facilitate pull requests with dependencies. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - cli: add --ignore flag to git-sync Changes: https://git.openjdk.java.net/skara/pull/907/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=907&range=00 Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/907.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/907/head:pull/907 PR: https://git.openjdk.java.net/skara/pull/907 From rwestberg at openjdk.java.net Thu Oct 22 04:28:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 04:28:17 GMT Subject: RFR: Make fetchAll the opposite of pushAll [v2] In-Reply-To: References: Message-ID: <5DDN7cI55qLH9LbPXjQLarfsxLTbyRrKzl-ERP1xVyU=.cc66b598-ff7a-40cb-98ca-adc5dda6c635@github.com> > Since pushAll pushes all refs, rename fetchAll to fetchAllRemotes and create fetchAll that fetches all refs. Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Fix failing test ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/905/files - new: https://git.openjdk.java.net/skara/pull/905/files/d52d95dc..c96908dd Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=905&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=905&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/905.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/905/head:pull/905 PR: https://git.openjdk.java.net/skara/pull/905 From rwestberg at openjdk.java.net Thu Oct 22 07:09:52 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 07:09:52 GMT Subject: Integrated: Make fetchAll the opposite of pushAll In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 17:06:30 GMT, Robin Westberg wrote: > Since pushAll pushes all refs, rename fetchAll to fetchAllRemotes and create fetchAll that fetches all refs. This pull request has now been integrated. Changeset: 975fe286 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/975fe286 Stats: 38 lines in 8 files changed: 28 ins; 0 del; 10 mod Make fetchAll the opposite of pushAll Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/905 From rwestberg at openjdk.java.net Thu Oct 22 08:00:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 08:00:27 GMT Subject: RFR: 584: additional check for "git sync" In-Reply-To: <9waKZdEg1HAJ1U7uG14we26qchvXax9xkN_OWqAraxs=.ef5cb163-8859-4310-accc-b81fc4975ba5@github.com> References: <9waKZdEg1HAJ1U7uG14we26qchvXax9xkN_OWqAraxs=.ef5cb163-8859-4310-accc-b81fc4975ba5@github.com> Message-ID: On Wed, 21 Oct 2020 17:59:20 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` check if the `--from` and `--to` arguments refer to the same repository. If they do, then `git-sync` exits with an error. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/906 From rwestberg at openjdk.java.net Thu Oct 22 08:02:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 08:02:12 GMT Subject: RFR: cli: add --ignore flag to git-sync In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 18:13:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--ignore` flag to `git-sync`. The `--ignore` flag is a regular expression for branches that should *not* be synced. The default value for `--ignore` is `pr/.*` to avoid sync branches created by Skara to facilitate pull requests with dependencies. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/907 From rwestberg at openjdk.java.net Thu Oct 22 08:15:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 08:15:30 GMT Subject: RFR: Use a bare repo for notifier Message-ID: <_QoD6RrRhAjHY0YMKKhQTthEYx0_-FEwYZ8jhZZvU9E=.374c862d-5f8a-4c72-8eb1-85678cab59db@github.com> The local repo needs to be bare to allow fetching refs ------------- Commit messages: - Use a bare repo for notifier Changes: https://git.openjdk.java.net/skara/pull/908/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=908&range=00 Stats: 16 lines in 2 files changed: 5 ins; 0 del; 11 mod Patch: https://git.openjdk.java.net/skara/pull/908.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/908/head:pull/908 PR: https://git.openjdk.java.net/skara/pull/908 From ehelin at openjdk.java.net Thu Oct 22 08:28:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 22 Oct 2020 08:28:31 GMT Subject: Integrated: cli: add --ignore flag to git-sync In-Reply-To: References: Message-ID: On Wed, 21 Oct 2020 18:13:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--ignore` flag to `git-sync`. The `--ignore` flag is a regular expression for branches that should *not* be synced. The default value for `--ignore` is `pr/.*` to avoid sync branches created by Skara to facilitate pull requests with dependencies. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 8814a401 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/8814a401 Stats: 22 lines in 1 file changed: 22 ins; 0 del; 0 mod cli: add --ignore flag to git-sync Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/907 From ehelin at openjdk.java.net Thu Oct 22 08:28:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 22 Oct 2020 08:28:52 GMT Subject: RFR: Use a bare repo for notifier In-Reply-To: <_QoD6RrRhAjHY0YMKKhQTthEYx0_-FEwYZ8jhZZvU9E=.374c862d-5f8a-4c72-8eb1-85678cab59db@github.com> References: <_QoD6RrRhAjHY0YMKKhQTthEYx0_-FEwYZ8jhZZvU9E=.374c862d-5f8a-4c72-8eb1-85678cab59db@github.com> Message-ID: On Thu, 22 Oct 2020 08:12:42 GMT, Robin Westberg wrote: > The local repo needs to be bare to allow fetching refs Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/908 From rwestberg at openjdk.java.net Thu Oct 22 08:28:52 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 08:28:52 GMT Subject: Integrated: Use a bare repo for notifier In-Reply-To: <_QoD6RrRhAjHY0YMKKhQTthEYx0_-FEwYZ8jhZZvU9E=.374c862d-5f8a-4c72-8eb1-85678cab59db@github.com> References: <_QoD6RrRhAjHY0YMKKhQTthEYx0_-FEwYZ8jhZZvU9E=.374c862d-5f8a-4c72-8eb1-85678cab59db@github.com> Message-ID: On Thu, 22 Oct 2020 08:12:42 GMT, Robin Westberg wrote: > The local repo needs to be bare to allow fetching refs This pull request has now been integrated. Changeset: 38f04d0d Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/38f04d0d Stats: 16 lines in 2 files changed: 5 ins; 0 del; 11 mod Use a bare repo for notifier Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/908 From ehelin at openjdk.java.net Thu Oct 22 08:29:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 22 Oct 2020 08:29:33 GMT Subject: Integrated: 584: additional check for "git sync" In-Reply-To: <9waKZdEg1HAJ1U7uG14we26qchvXax9xkN_OWqAraxs=.ef5cb163-8859-4310-accc-b81fc4975ba5@github.com> References: <9waKZdEg1HAJ1U7uG14we26qchvXax9xkN_OWqAraxs=.ef5cb163-8859-4310-accc-b81fc4975ba5@github.com> Message-ID: On Wed, 21 Oct 2020 17:59:20 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` check if the `--from` and `--to` arguments refer to the same repository. If they do, then `git-sync` exits with an error. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: b56141b8 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b56141b8 Stats: 14 lines in 2 files changed: 14 ins; 0 del; 0 mod 584: additional check for "git sync" Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/906 From rwestberg at openjdk.java.net Thu Oct 22 09:08:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 09:08:42 GMT Subject: RFR: No point in cleaning a bare materialization Message-ID: We can skip the cleaning step when reusing a bare materialization. ------------- Commit messages: - No point in cleaning a bare materialization Changes: https://git.openjdk.java.net/skara/pull/909/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=909&range=00 Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/909.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/909/head:pull/909 PR: https://git.openjdk.java.net/skara/pull/909 From ehelin at openjdk.java.net Thu Oct 22 09:30:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 22 Oct 2020 09:30:13 GMT Subject: RFR: No point in cleaning a bare materialization In-Reply-To: References: Message-ID: <7RUQFTeIhg6whhiqX8v9OqoIf0SymtUG_OIN4jv-_yU=.9ae509c4-e599-4c6d-833c-12038157bbcb@github.com> On Thu, 22 Oct 2020 09:05:40 GMT, Robin Westberg wrote: > We can skip the cleaning step when reusing a bare materialization. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/909 From rwestberg at openjdk.java.net Thu Oct 22 10:10:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 22 Oct 2020 10:10:43 GMT Subject: Integrated: No point in cleaning a bare materialization In-Reply-To: References: Message-ID: <4FW42spLDNJv_TbD18j2FnygF8QWaxWFYz9ybYtxSoQ=.1ea840b9-f5e5-4566-a1b9-79710afcf721@github.com> On Thu, 22 Oct 2020 09:05:40 GMT, Robin Westberg wrote: > We can skip the cleaning step when reusing a bare materialization. This pull request has now been integrated. Changeset: 720efe5b Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/720efe5b Stats: 36 lines in 2 files changed: 35 ins; 0 del; 1 mod No point in cleaning a bare materialization Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/909 From ehelin at openjdk.java.net Fri Oct 23 08:31:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 08:31:46 GMT Subject: RFR: forge: fix check in GitLabRepository.commit Message-ID: Hi all, please review this small patch that fixes a bad check in `GitLabRepository.commit`. Thanks, Erik ------------- Commit messages: - forge: fix check in GitLabRepository.commit Changes: https://git.openjdk.java.net/skara/pull/910/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=910&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/910.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/910/head:pull/910 PR: https://git.openjdk.java.net/skara/pull/910 From ehelin at openjdk.java.net Fri Oct 23 08:34:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 08:34:01 GMT Subject: RFR: forge: fix type of id in GitLabHost.search Message-ID: Hi all, please review this small patch that fixes `id` to be of correct type `int` in `GitLabHost.search`. Thanks, Erik ------------- Commit messages: - forge: fix id type in GitLabHost.search Changes: https://git.openjdk.java.net/skara/pull/911/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=911&range=00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/911.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/911/head:pull/911 PR: https://git.openjdk.java.net/skara/pull/911 From ehelin at openjdk.java.net Fri Oct 23 08:36:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 08:36:59 GMT Subject: RFR: forge: fix GitLabRepository.recentCommitComments Message-ID: <3qtum-AZAsIlgx5uu2RqdBpKPIwXiH9dnC_4qJnwlBg=.9d89bfb4-8b6e-4c49-afbf-d90f1ede2def@github.com> Hi all, please review this patch that fixes `recentCommitsComments` for `GitLabRepository`. The formatting of the `after` parameter was wrong (used day of year instead of day of month) and the `id` was using `String` instead of `int` as type. Thanks, Erik - Fix formatting of "after" - Fix type of "id" ------------- Commit messages: - forge: fix GitLabRepository.recentCommitComments Changes: https://git.openjdk.java.net/skara/pull/912/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=912&range=00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/912.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/912/head:pull/912 PR: https://git.openjdk.java.net/skara/pull/912 From rwestberg at openjdk.java.net Fri Oct 23 09:09:01 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 09:09:01 GMT Subject: RFR: forge: fix check in GitLabRepository.commit In-Reply-To: References: Message-ID: <72wmB8cOd6ya1EXQh0OmrXGQ1ZwrOZy1p55noLWBcwI=.bf80f702-7314-4756-942c-b8e66531e690@github.com> On Fri, 23 Oct 2020 08:28:41 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes a bad check in `GitLabRepository.commit`. > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/910 From rwestberg at openjdk.java.net Fri Oct 23 09:09:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 09:09:41 GMT Subject: RFR: forge: fix type of id in GitLabHost.search In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 08:30:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes `id` to be of correct type `int` in `GitLabHost.search`. > > Thanks, > Erik Looks nice! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/911 From rwestberg at openjdk.java.net Fri Oct 23 09:10:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 09:10:11 GMT Subject: RFR: forge: fix GitLabRepository.recentCommitComments In-Reply-To: <3qtum-AZAsIlgx5uu2RqdBpKPIwXiH9dnC_4qJnwlBg=.9d89bfb4-8b6e-4c49-afbf-d90f1ede2def@github.com> References: <3qtum-AZAsIlgx5uu2RqdBpKPIwXiH9dnC_4qJnwlBg=.9d89bfb4-8b6e-4c49-afbf-d90f1ede2def@github.com> Message-ID: On Fri, 23 Oct 2020 08:33:59 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes `recentCommitsComments` for `GitLabRepository`. The formatting of the `after` parameter was wrong (used day of year instead of day of month) and the `id` was using `String` instead of `int` as type. > > Thanks, > Erik > > - Fix formatting of "after" > - Fix type of "id" Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/912 From ehelin at openjdk.java.net Fri Oct 23 09:58:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 09:58:40 GMT Subject: Integrated: forge: fix check in GitLabRepository.commit In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 08:28:41 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes a bad check in `GitLabRepository.commit`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 21dfe82d Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/21dfe82d Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod forge: fix check in GitLabRepository.commit Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/910 From ehelin at openjdk.java.net Fri Oct 23 09:58:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 09:58:50 GMT Subject: Integrated: forge: fix type of id in GitLabHost.search In-Reply-To: References: Message-ID: <3LhVMxDEE09lYMIrV--9rYbg4kA7TLERDX39B6NJbOg=.8377cf5b-a330-4742-a3ab-a993cf34c668@github.com> On Fri, 23 Oct 2020 08:30:58 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes `id` to be of correct type `int` in `GitLabHost.search`. > > Thanks, > Erik This pull request has now been integrated. Changeset: ca704788 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ca704788 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod forge: fix type of id in GitLabHost.search Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/911 From ehelin at openjdk.java.net Fri Oct 23 09:59:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 09:59:10 GMT Subject: Integrated: forge: fix GitLabRepository.recentCommitComments In-Reply-To: <3qtum-AZAsIlgx5uu2RqdBpKPIwXiH9dnC_4qJnwlBg=.9d89bfb4-8b6e-4c49-afbf-d90f1ede2def@github.com> References: <3qtum-AZAsIlgx5uu2RqdBpKPIwXiH9dnC_4qJnwlBg=.9d89bfb4-8b6e-4c49-afbf-d90f1ede2def@github.com> Message-ID: On Fri, 23 Oct 2020 08:33:59 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes `recentCommitsComments` for `GitLabRepository`. The formatting of the `after` parameter was wrong (used day of year instead of day of month) and the `id` was using `String` instead of `int` as type. > > Thanks, > Erik > > - Fix formatting of "after" > - Fix type of "id" This pull request has now been integrated. Changeset: 4ad66ac7 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/4ad66ac7 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod forge: fix GitLabRepository.recentCommitComments - Fix formatting of "after" - Fix type of "id" Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/912 From rwestberg at openjdk.java.net Fri Oct 23 10:50:59 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 10:50:59 GMT Subject: RFR: Initial implementation of commit commands Message-ID: This is the initial implementation of support for commands issued directly on commits (and integrated pull requests). ------------- Commit messages: - Fix trailing whitespace - Missing copyright headers - Initial implementation of commit commands Changes: https://git.openjdk.java.net/skara/pull/913/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=913&range=00 Stats: 624 lines in 10 files changed: 528 ins; 77 del; 19 mod Patch: https://git.openjdk.java.net/skara/pull/913.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/913/head:pull/913 PR: https://git.openjdk.java.net/skara/pull/913 From ehelin at openjdk.java.net Fri Oct 23 11:32:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 11:32:51 GMT Subject: RFR: Initial implementation of commit commands In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 10:43:50 GMT, Robin Westberg wrote: > This is the initial implementation of support for commands issued directly on commits (and integrated pull requests). Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/913 From rwestberg at openjdk.java.net Fri Oct 23 11:38:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 11:38:11 GMT Subject: Integrated: Initial implementation of commit commands In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 10:43:50 GMT, Robin Westberg wrote: > This is the initial implementation of support for commands issued directly on commits (and integrated pull requests). This pull request has now been integrated. Changeset: 38ff0c55 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/38ff0c55 Stats: 624 lines in 10 files changed: 528 ins; 77 del; 19 mod Initial implementation of commit commands Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/913 From ehelin at openjdk.java.net Fri Oct 23 14:27:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 14:27:22 GMT Subject: RFR: forge: patch for commit can be null Message-ID: <2LvpnyB6RzrNSjkfWPGucNsZo4zGYz8DtuHqPXJ2Jlg=.de108d8c-63a0-4027-b468-923bb0608dda@github.com> Hi all, please review this patch that handles cases where the GitHub REST API returns `null` for the `"patch"` field for a `commit` object. This seems to primarily happen for very large merges that changes 200+ files. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - forge: patch for commit can be null Changes: https://git.openjdk.java.net/skara/pull/914/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=914&range=00 Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/914.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/914/head:pull/914 PR: https://git.openjdk.java.net/skara/pull/914 From rwestberg at openjdk.java.net Fri Oct 23 14:52:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 14:52:12 GMT Subject: RFR: forge: patch for commit can be null In-Reply-To: <2LvpnyB6RzrNSjkfWPGucNsZo4zGYz8DtuHqPXJ2Jlg=.de108d8c-63a0-4027-b468-923bb0608dda@github.com> References: <2LvpnyB6RzrNSjkfWPGucNsZo4zGYz8DtuHqPXJ2Jlg=.de108d8c-63a0-4027-b468-923bb0608dda@github.com> Message-ID: On Fri, 23 Oct 2020 14:24:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles cases where the GitHub REST API returns `null` for the `"patch"` field for a `commit` object. This seems to primarily happen for very large merges that changes 200+ files. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/914 From ehelin at openjdk.java.net Fri Oct 23 14:55:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 14:55:32 GMT Subject: Integrated: vcs: handle "No newline at end of file" in UnifiedDiffParser Message-ID: Hi all, please review this patch that handles a `\ No newline at end of file` line in a unified diff. Testing: - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - vcs: handle "No newline at end of file" in UnifiedDiffParser Changes: https://git.openjdk.java.net/skara/pull/915/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=915&range=00 Stats: 47 lines in 2 files changed: 40 ins; 1 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/915.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/915/head:pull/915 PR: https://git.openjdk.java.net/skara/pull/915 From rwestberg at openjdk.java.net Fri Oct 23 14:55:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 23 Oct 2020 14:55:33 GMT Subject: Integrated: vcs: handle "No newline at end of file" in UnifiedDiffParser In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 14:51:56 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles a `\ No newline at end of file` line in a unified diff. > > Testing: > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/915 From ehelin at openjdk.java.net Fri Oct 23 14:55:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 14:55:33 GMT Subject: Integrated: vcs: handle "No newline at end of file" in UnifiedDiffParser In-Reply-To: References: Message-ID: <_kC7PvkLWqThjTCOrQtRfTWlvlV4cyom1R887cBanr8=.be6d6a71-ddad-4610-b88a-b4e9b3f37a62@github.com> On Fri, 23 Oct 2020 14:51:56 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles a `\ No newline at end of file` line in a unified diff. > > Testing: > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 5649dc1e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5649dc1e Stats: 47 lines in 2 files changed: 40 ins; 1 del; 6 mod vcs: handle "No newline at end of file" in UnifiedDiffParser Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/915 From ehelin at openjdk.java.net Fri Oct 23 14:55:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 23 Oct 2020 14:55:51 GMT Subject: Integrated: forge: patch for commit can be null In-Reply-To: <2LvpnyB6RzrNSjkfWPGucNsZo4zGYz8DtuHqPXJ2Jlg=.de108d8c-63a0-4027-b468-923bb0608dda@github.com> References: <2LvpnyB6RzrNSjkfWPGucNsZo4zGYz8DtuHqPXJ2Jlg=.de108d8c-63a0-4027-b468-923bb0608dda@github.com> Message-ID: On Fri, 23 Oct 2020 14:24:25 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles cases where the GitHub REST API returns `null` for the `"patch"` field for a `commit` object. This seems to primarily happen for very large merges that changes 200+ files. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: d91f3ebd Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d91f3ebd Stats: 5 lines in 1 file changed: 3 ins; 0 del; 2 mod forge: patch for commit can be null Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/914 From christoph.langer at sap.com Fri Oct 23 16:02:45 2020 From: christoph.langer at sap.com (Langer, Christoph) Date: Fri, 23 Oct 2020 16:02:45 +0000 Subject: Skara Workflow for Update releases Message-ID: Hi Erik, Robin, now that project Skara has hit mainline OpenJDK for quite a while, I?m starting to think more closely about how the workflow for backports and update releases will be. I have lately recognized some activity in the Skara project to add functionality for the backport scenario flying by. I also understand that Yan and the folks maintaining 13u started using Skara already. I have a few questions however. 1. About the workflow for backports: I have seen that you?ve added the option ?git pr create --backport REV?. So I take that this would be the canonical way to do a backport from an upstream change. Is there also support for cherry-picking changes from upstream via pure git and creating a PR from the backport, such that the Skara bots will recognize that the patch proposed is a backport? 2. What?s the workflow for merging between repositories? E.g. in 11u, we have 2 repos, one is jdk11u, the other is jdk11u-dev. We?re currently merging those repos once in a while in either direction. How is this supported by Skara? I guess I can add both remotes to my local repository and then merge branches and create PRs. However, what?ll happen then? Will the skara bots accept merging these branches (without squashing). What kind of checking will be in place? Can you please shed some light on how you imagine that process. I?m asking because I?d like to see Skara being used consistently, also in JDK 11 Updates and I want to understand how far we?re away from that. ?? Thank you and best regards Christoph From clanger at openjdk.java.net Fri Oct 23 21:30:31 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Fri, 23 Oct 2020 21:30:31 GMT Subject: RFR: Fix skara update on Windows when CWD is not skara repository dir Message-ID: On my windows client, I'm running in an issue when updating the skara tools. I see the following output/exception: Checking for updates ... Found the following updates: - forge: patch for commit can be null Rebuilding ... Exception in thread "main" java.io.IOException: Cannot run program "gradlew.bat" (in directory "C:\git\OpenJDK\skara"): CreateProcess error=2, The system cannot find the file specified at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128) at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.update(GitSkara.java:176) at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:230) Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified at java.base/java.lang.ProcessImpl.create(Native Method) at java.base/java.lang.ProcessImpl.(ProcessImpl.java:483) at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:158) at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1107) ... 3 more The issue seems to be that only "gradlew.bat" is added as command to the gradle call (https://github.com/openjdk/skara/blob/master/cli/src/main/java/org/openjdk/skara/cli/GitSkara.java#L168). The process directory is set to the skara repository directory. However, "gradlew.bat" isn't resolved against the working directory by Processbuilder, but probably only against the current %PATH%. Currently, when running "git skara update" out of the skara repository path, it'll work. With the proposed tiny fix to resolve gradlew.bat before starting the Processbuilder it can be run from any working directory. ------------- Commit messages: - Fix skara update on Windows when CWD is not skara repository dir Changes: https://git.openjdk.java.net/skara/pull/916/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=916&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/916.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/916/head:pull/916 PR: https://git.openjdk.java.net/skara/pull/916 From ehelin at openjdk.java.net Sat Oct 24 07:21:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 24 Oct 2020 07:21:04 GMT Subject: RFR: Fix skara update on Windows when CWD is not skara repository dir In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 21:25:39 GMT, Christoph Langer wrote: > On my windows client, I'm running in an issue when updating the skara tools. I see the following output/exception: > > Checking for updates ... > Found the following updates: > - forge: patch for commit can be null > Rebuilding ... > Exception in thread "main" java.io.IOException: Cannot run program "gradlew.bat" (in directory "C:\git\OpenJDK\skara"): CreateProcess error=2, The system cannot find the file specified > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128) > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.update(GitSkara.java:176) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:230) > Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified > at java.base/java.lang.ProcessImpl.create(Native Method) > at java.base/java.lang.ProcessImpl.(ProcessImpl.java:483) > at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:158) > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1107) > ... 3 more > > The issue seems to be that only "gradlew.bat" is added as command to the gradle call (https://github.com/openjdk/skara/blob/master/cli/src/main/java/org/openjdk/skara/cli/GitSkara.java#L168). The process directory is set to the skara repository directory. However, "gradlew.bat" isn't resolved against the working directory by Processbuilder, but probably only against the current %PATH%. > > Currently, when running "git skara update" out of the skara repository path, it'll work. > > With the proposed tiny fix to resolve gradlew.bat before starting the Processbuilder it can be run from any working directory. Looks good, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/916 From clanger at openjdk.java.net Sat Oct 24 10:02:33 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Sat, 24 Oct 2020 10:02:33 GMT Subject: RFR: Fix skara update on Windows when CWD is not skara repository dir In-Reply-To: References: Message-ID: On Sat, 24 Oct 2020 07:18:56 GMT, Erik Helin wrote: > Looks good, thanks for fixing! Thanks, Erik. In case everything looks good from your end, please sponsor :) ------------- PR: https://git.openjdk.java.net/skara/pull/916 From clanger at openjdk.java.net Mon Oct 26 07:52:24 2020 From: clanger at openjdk.java.net (Christoph Langer) Date: Mon, 26 Oct 2020 07:52:24 GMT Subject: Integrated: Fix skara update on Windows when CWD is not skara repository dir In-Reply-To: References: Message-ID: On Fri, 23 Oct 2020 21:25:39 GMT, Christoph Langer wrote: > On my windows client, I'm running in an issue when updating the skara tools. I see the following output/exception: > > Checking for updates ... > Found the following updates: > - forge: patch for commit can be null > Rebuilding ... > Exception in thread "main" java.io.IOException: Cannot run program "gradlew.bat" (in directory "C:\git\OpenJDK\skara"): CreateProcess error=2, The system cannot find the file specified > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1128) > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1071) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.update(GitSkara.java:176) > at org.openjdk.skara.cli/org.openjdk.skara.cli.GitSkara.main(GitSkara.java:230) > Caused by: java.io.IOException: CreateProcess error=2, The system cannot find the file specified > at java.base/java.lang.ProcessImpl.create(Native Method) > at java.base/java.lang.ProcessImpl.(ProcessImpl.java:483) > at java.base/java.lang.ProcessImpl.start(ProcessImpl.java:158) > at java.base/java.lang.ProcessBuilder.start(ProcessBuilder.java:1107) > ... 3 more > > The issue seems to be that only "gradlew.bat" is added as command to the gradle call (https://github.com/openjdk/skara/blob/master/cli/src/main/java/org/openjdk/skara/cli/GitSkara.java#L168). The process directory is set to the skara repository directory. However, "gradlew.bat" isn't resolved against the working directory by Processbuilder, but probably only against the current %PATH%. > > Currently, when running "git skara update" out of the skara repository path, it'll work. > > With the proposed tiny fix to resolve gradlew.bat before starting the Processbuilder it can be run from any working directory. This pull request has now been integrated. Changeset: bd4cc7e9 Author: Christoph Langer Committer: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/bd4cc7e9 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Fix skara update on Windows when CWD is not skara repository dir Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/916 From ehelin at openjdk.java.net Mon Oct 26 09:08:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 09:08:53 GMT Subject: RFR: forge: more precise status for GitHub diff Message-ID: <9Z1tFG6JsTfROENv-swo-Z2QqsClgiuyl3xtqTpqB54=.b65698d5-08f7-4ef5-ba51-03bff09ddc2f@github.com> Hi all, please review this patch that makes the parsing of the `"status"` field from GitHub for diffs more precise. Thanks, Erik ------------- Commit messages: - forge: more precise status for GitHub diff Changes: https://git.openjdk.java.net/skara/pull/917/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=917&range=00 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/917.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/917/head:pull/917 PR: https://git.openjdk.java.net/skara/pull/917 From rwestberg at openjdk.java.net Mon Oct 26 09:08:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 09:08:53 GMT Subject: RFR: forge: more precise status for GitHub diff In-Reply-To: <9Z1tFG6JsTfROENv-swo-Z2QqsClgiuyl3xtqTpqB54=.b65698d5-08f7-4ef5-ba51-03bff09ddc2f@github.com> References: <9Z1tFG6JsTfROENv-swo-Z2QqsClgiuyl3xtqTpqB54=.b65698d5-08f7-4ef5-ba51-03bff09ddc2f@github.com> Message-ID: On Mon, 26 Oct 2020 09:05:24 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the parsing of the `"status"` field from GitHub for diffs more precise. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/917 From ehelin at openjdk.java.net Mon Oct 26 09:11:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 09:11:43 GMT Subject: Integrated: forge: more precise status for GitHub diff In-Reply-To: <9Z1tFG6JsTfROENv-swo-Z2QqsClgiuyl3xtqTpqB54=.b65698d5-08f7-4ef5-ba51-03bff09ddc2f@github.com> References: <9Z1tFG6JsTfROENv-swo-Z2QqsClgiuyl3xtqTpqB54=.b65698d5-08f7-4ef5-ba51-03bff09ddc2f@github.com> Message-ID: <7LgPbeJdovmMzsdUqzzVZGLbAljPWcrE4xBc7-3uNQU=.90c43165-551a-4b86-b341-9a17cbd5503a@github.com> On Mon, 26 Oct 2020 09:05:24 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the parsing of the `"status"` field from GitHub for diffs more precise. > > Thanks, > Erik This pull request has now been integrated. Changeset: 28cea609 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/28cea609 Stats: 18 lines in 1 file changed: 17 ins; 0 del; 1 mod forge: more precise status for GitHub diff Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/917 From rwestberg at openjdk.java.net Mon Oct 26 11:22:48 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 11:22:48 GMT Subject: RFR: Ensure that the pr head is present locally when pushing a dependency branch Message-ID: When the pull request branch notifier creates a dependency target branch, we need to ensure that the head commit is actually present locally. ------------- Commit messages: - Ensure that the pr head is present locally Changes: https://git.openjdk.java.net/skara/pull/918/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=918&range=00 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/918.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/918/head:pull/918 PR: https://git.openjdk.java.net/skara/pull/918 From ehelin at openjdk.java.net Mon Oct 26 12:39:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 12:39:31 GMT Subject: RFR: Ensure that the pr head is present locally when pushing a dependency branch In-Reply-To: References: Message-ID: <0_58sB_5jLaumqKmSNu3fFmyhRN0zJC2LZY0TMQo7hY=.cd72d76e-9efc-4050-8b29-60b44523af38@github.com> On Mon, 26 Oct 2020 11:20:04 GMT, Robin Westberg wrote: > When the pull request branch notifier creates a dependency target branch, we need to ensure that the head commit is actually present locally. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/918 From rwestberg at openjdk.java.net Mon Oct 26 14:26:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 14:26:04 GMT Subject: Integrated: Ensure that the pr head is present locally when pushing a dependency branch In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 11:20:04 GMT, Robin Westberg wrote: > When the pull request branch notifier creates a dependency target branch, we need to ensure that the head commit is actually present locally. This pull request has now been integrated. Changeset: 75ace750 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/75ace750 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Ensure that the pr head is present locally when pushing a dependency branch Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/918 From rwestberg at openjdk.java.net Mon Oct 26 14:28:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 14:28:11 GMT Subject: RFR: 760: Wrong "On ..., XXX wrote:" in comment on PR Message-ID: The mailing list bridge bot could fail to match quoted text and `@mentions`. This improves the matching. ------------- Commit messages: - Improve parent detection Changes: https://git.openjdk.java.net/skara/pull/919/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=919&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-760 Stats: 94 lines in 2 files changed: 85 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/919.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/919/head:pull/919 PR: https://git.openjdk.java.net/skara/pull/919 From ehelin at openjdk.java.net Mon Oct 26 14:50:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 14:50:09 GMT Subject: RFR: forge: better metadata parsing for GitLab patches Message-ID: Hi all, please review this patch that makes the metadata parsing for diffs from GitLab more robust. Thanks, Erik ------------- Commit messages: - forge: better metadata parsing for GitLab patches Changes: https://git.openjdk.java.net/skara/pull/920/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=920&range=00 Stats: 23 lines in 1 file changed: 17 ins; 4 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/920.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/920/head:pull/920 PR: https://git.openjdk.java.net/skara/pull/920 From ehelin at openjdk.java.net Mon Oct 26 14:50:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 14:50:24 GMT Subject: RFR: 760: Wrong "On ..., XXX wrote:" in comment on PR In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 14:25:04 GMT, Robin Westberg wrote: > The mailing list bridge bot could fail to match quoted text and `@mentions`. This improves the matching. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/919 From rwestberg at openjdk.java.net Mon Oct 26 15:15:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 15:15:43 GMT Subject: RFR: forge: better metadata parsing for GitLab patches In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 14:47:35 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the metadata parsing for diffs from GitLab more robust. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/920 From rwestberg at openjdk.java.net Mon Oct 26 15:23:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 15:23:42 GMT Subject: Integrated: 760: Wrong "On ..., XXX wrote:" in comment on PR In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 14:25:04 GMT, Robin Westberg wrote: > The mailing list bridge bot could fail to match quoted text and `@mentions`. This improves the matching. This pull request has now been integrated. Changeset: 7fc69de8 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/7fc69de8 Stats: 94 lines in 2 files changed: 85 ins; 0 del; 9 mod 760: Wrong "On ..., XXX wrote:" in comment on PR Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/919 From ehelin at openjdk.java.net Mon Oct 26 15:26:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 15:26:51 GMT Subject: Integrated: forge: better metadata parsing for GitLab patches In-Reply-To: References: Message-ID: <7myw9uRoriDIcUHMM1rKYHgPWwiLEdWbBH5FpGBKnvg=.ef957bc2-9d71-45fd-a704-0556589d7c87@github.com> On Mon, 26 Oct 2020 14:47:35 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the metadata parsing for diffs from GitLab more robust. > > Thanks, > Erik This pull request has now been integrated. Changeset: 8b163458 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/8b163458 Stats: 23 lines in 1 file changed: 17 ins; 4 del; 2 mod forge: better metadata parsing for GitLab patches Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/920 From ehelin at openjdk.java.net Mon Oct 26 15:58:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 26 Oct 2020 15:58:04 GMT Subject: RFR: vcs: add support for cherry picking Message-ID: Hi all, please review this patch that adds support for "cherry picking" commits to `Repository`. Testing: - [x] Added two new unit tests Thanks, Erik ------------- Commit messages: - vcs: add support for cherry picking Changes: https://git.openjdk.java.net/skara/pull/921/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=921&range=00 Stats: 100 lines in 4 files changed: 100 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/921.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/921/head:pull/921 PR: https://git.openjdk.java.net/skara/pull/921 From rwestberg at openjdk.java.net Mon Oct 26 16:00:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 26 Oct 2020 16:00:57 GMT Subject: RFR: vcs: add support for cherry picking In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 15:55:15 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for "cherry picking" commits to `Repository`. > > Testing: > - [x] Added two new unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/921 From ehelin at openjdk.java.net Tue Oct 27 07:47:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 07:47:48 GMT Subject: Integrated: vcs: add support for cherry picking In-Reply-To: References: Message-ID: On Mon, 26 Oct 2020 15:55:15 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds support for "cherry picking" commits to `Repository`. > > Testing: > - [x] Added two new unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: 7235ab1d Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/7235ab1d Stats: 100 lines in 4 files changed: 100 ins; 0 del; 0 mod vcs: add support for cherry picking Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/921 From ehelin at openjdk.java.net Tue Oct 27 08:23:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 08:23:28 GMT Subject: RFR: host: add method Host.hostname Message-ID: Hi all, please review this patch that adds the method `Host.hostname`. Thanks, Erik ------------- Commit messages: - host: add method Host.hostname Changes: https://git.openjdk.java.net/skara/pull/922/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=922&range=00 Stats: 31 lines in 7 files changed: 31 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/922.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/922/head:pull/922 PR: https://git.openjdk.java.net/skara/pull/922 From rwestberg at openjdk.java.net Tue Oct 27 08:23:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 27 Oct 2020 08:23:28 GMT Subject: RFR: host: add method Host.hostname In-Reply-To: References: Message-ID: <_nK5WWgZAxkgTUn2UlV3PEdTPhhaI8FPxVkprYZP2DY=.fed4365d-198a-491b-99f2-53332a88bebf@github.com> On Tue, 27 Oct 2020 08:19:41 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `Host.hostname`. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/922 From ehelin at openjdk.java.net Tue Oct 27 08:52:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 08:52:28 GMT Subject: Integrated: host: add method Host.hostname In-Reply-To: References: Message-ID: On Tue, 27 Oct 2020 08:19:41 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the method `Host.hostname`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 474f6f3e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/474f6f3e Stats: 31 lines in 7 files changed: 31 ins; 0 del; 0 mod host: add method Host.hostname Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/922 From ehelin at openjdk.java.net Tue Oct 27 09:12:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 09:12:46 GMT Subject: RFR: pr: add "backport" label for backports Message-ID: Hi all, please review this patch that adds the label "backport" for backport-style pull requests. Testing: - [x] Updated a number of unit tests Thanks, Erik ------------- Commit messages: - Updates - pr: add "backport" label for backports Changes: https://git.openjdk.java.net/skara/pull/923/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=923&range=00 Stats: 11 lines in 2 files changed: 11 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/923.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/923/head:pull/923 PR: https://git.openjdk.java.net/skara/pull/923 From rwestberg at openjdk.java.net Tue Oct 27 09:12:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 27 Oct 2020 09:12:46 GMT Subject: RFR: pr: add "backport" label for backports In-Reply-To: References: Message-ID: <9LRYCysckyPcOKU95yxs0Rhb3J1fQRYC_m6tLTfwmpE=.e89b92db-f191-4ec6-8e35-45557f617482@github.com> On Tue, 27 Oct 2020 09:08:43 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the label "backport" for backport-style pull requests. > > Testing: > - [x] Updated a number of unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/923 From ehelin at openjdk.java.net Tue Oct 27 11:07:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 11:07:40 GMT Subject: Integrated: pr: add "backport" label for backports In-Reply-To: References: Message-ID: <6992SGLkugLffzpGYgtdcX5Gi7FIDP62c07pujiLaoc=.b1bd654b-b8fc-4e7a-9887-41071dbbf31e@github.com> On Tue, 27 Oct 2020 09:08:43 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the label "backport" for backport-style pull requests. > > Testing: > - [x] Updated a number of unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: 0265c54a Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/0265c54a Stats: 11 lines in 2 files changed: 11 ins; 0 del; 0 mod pr: add "backport" label for backports Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/923 From rwestberg at openjdk.java.net Tue Oct 27 12:49:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 27 Oct 2020 12:49:09 GMT Subject: RFR: Fix refreshing of existing seeded folder Message-ID: When a potentially stale materialization is used, we must ensure that the seed is still refreshed periodically. ------------- Commit messages: - Fix refreshing of existing seeded folder Changes: https://git.openjdk.java.net/skara/pull/924/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=924&range=00 Stats: 33 lines in 1 file changed: 3 ins; 15 del; 15 mod Patch: https://git.openjdk.java.net/skara/pull/924.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/924/head:pull/924 PR: https://git.openjdk.java.net/skara/pull/924 From ehelin at openjdk.java.net Tue Oct 27 13:47:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 27 Oct 2020 13:47:39 GMT Subject: RFR: Fix refreshing of existing seeded folder In-Reply-To: References: Message-ID: On Tue, 27 Oct 2020 12:46:05 GMT, Robin Westberg wrote: > When a potentially stale materialization is used, we must ensure that the seed is still refreshed periodically. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/924 From rwestberg at openjdk.java.net Tue Oct 27 14:06:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 27 Oct 2020 14:06:55 GMT Subject: RFR: Fix refreshing of existing seeded folder [v2] In-Reply-To: References: Message-ID: <0yvhPjmM9Gz3pkRgGHxB1uctlHbE4H635Rm6eXAW82o=.57a397fa-f4a7-4eb4-9347-6f6816a309b0@github.com> > When a potentially stale materialization is used, we must ensure that the seed is still refreshed periodically. Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: When accessing the seed directly, do a fetch as it may not be used for cloning ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/924/files - new: https://git.openjdk.java.net/skara/pull/924/files/8beeff43..13d4f842 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=924&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=924&range=00-01 Stats: 5 lines in 1 file changed: 4 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/924.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/924/head:pull/924 PR: https://git.openjdk.java.net/skara/pull/924 From erik.helin at oracle.com Tue Oct 27 15:11:06 2020 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 27 Oct 2020 16:11:06 +0100 Subject: Skara Workflow for Update releases In-Reply-To: References: Message-ID: <88e3794c-3bfc-868e-9337-cc5699682e7e@oracle.com> On 10/23/20 6:02 PM, Langer, Christoph wrote: > Hi Erik, Robin, Hey Christoph, thanks for reaching out! > now that project Skara has hit mainline OpenJDK for quite a while, I?m > starting to think more closely about how the workflow for backports and > update releases will be. > > I have lately recognized some activity in the Skara project to add > functionality for the backport scenario flying by. I also understand > that Yan and the folks maintaining 13u started using Skara already. I > have a few questions however. > > 1. About the workflow for backports: I have seen that you?ve added the > option ?git pr create --backport REV?. So I take that this would be the > canonical way to do a backport from an upstream change. Is there also > support for cherry-picking changes from upstream via pure git and > creating a PR from the backport, such that the Skara bots will recognize > that the patch proposed is a backport? Yuri and the 13u people were kind enough to be the first JDK Updates to transition to Skara and they immediately found some issues. Fortunately we have now resolved almost all of them, I only have one or two left to fix. > 2. What?s the workflow for merging between repositories? E.g. in 11u, we > have 2 repos, one is jdk11u, the other is jdk11u-dev. We?re currently > merging those repos once in a while in either direction. How is this > supported by Skara? I guess I can add both remotes to my local > repository and then merge branches and create PRs. However, what?ll > happen then? Will the skara bots accept merging these branches (without > squashing). What kind of checking will be in place? Can you please shed > some light on how you imagine that process. > > I?m asking because I?d like to see Skara being used consistently, also > in JDK 11 Updates and I want to understand how far we?re away from that. ?? You are very close :) I've just started documenting the intended workflow for backports, I will have more to share closer to the end of this week. Thanks! Erik > Thank you and best regards > > Christoph > From rwestberg at openjdk.java.net Tue Oct 27 16:53:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 27 Oct 2020 16:53:50 GMT Subject: RFR: Fix refreshing of existing seeded folder [v3] In-Reply-To: References: Message-ID: > When a potentially stale materialization is used, we must ensure that the seed is still refreshed periodically. Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Same for reading lines ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/924/files - new: https://git.openjdk.java.net/skara/pull/924/files/13d4f842..9c10d57b Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=924&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=924&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/924.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/924/head:pull/924 PR: https://git.openjdk.java.net/skara/pull/924 From rwestberg at openjdk.java.net Wed Oct 28 07:48:02 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 07:48:02 GMT Subject: Integrated: Fix refreshing of existing seeded folder In-Reply-To: References: Message-ID: <_1n8FOFkhO7sPUinNq3e4qvZHG6sKPj-ZJRjAbR2HdQ=.6d9c671b-c65a-467a-9d25-42e78d73fdd7@github.com> On Tue, 27 Oct 2020 12:46:05 GMT, Robin Westberg wrote: > When a potentially stale materialization is used, we must ensure that the seed is still refreshed periodically. This pull request has now been integrated. Changeset: 30426551 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/30426551 Stats: 39 lines in 1 file changed: 7 ins; 15 del; 17 mod Fix refreshing of existing seeded folder Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/924 From ehelin at openjdk.java.net Wed Oct 28 10:05:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 10:05:55 GMT Subject: Integrated: vcs: add ReadOnlyRepository.contains for Hash Message-ID: <292-nbGJoE-FX6VmbzI7vCYOq5KutUg2Hww3gwFmRYQ=.948b848b-fe79-435f-9b0b-886c6b2c5115@github.com> Hi all, please review this small patch that adds an overload `ReadOnlyRepository.contains` for just a `Hash` that checks if the repository does contain the given hash. Testing: - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - vcs: add ReadOnlyRepository.exists Changes: https://git.openjdk.java.net/skara/pull/925/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=925&range=00 Stats: 28 lines in 5 files changed: 24 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/925.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/925/head:pull/925 PR: https://git.openjdk.java.net/skara/pull/925 From rwestberg at openjdk.java.net Wed Oct 28 10:05:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 10:05:56 GMT Subject: Integrated: vcs: add ReadOnlyRepository.contains for Hash In-Reply-To: <292-nbGJoE-FX6VmbzI7vCYOq5KutUg2Hww3gwFmRYQ=.948b848b-fe79-435f-9b0b-886c6b2c5115@github.com> References: <292-nbGJoE-FX6VmbzI7vCYOq5KutUg2Hww3gwFmRYQ=.948b848b-fe79-435f-9b0b-886c6b2c5115@github.com> Message-ID: On Wed, 28 Oct 2020 09:59:39 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds an overload `ReadOnlyRepository.contains` for just a `Hash` that checks if the repository does contain the given hash. > > Testing: > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/925 From ehelin at openjdk.java.net Wed Oct 28 10:05:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 10:05:56 GMT Subject: Integrated: vcs: add ReadOnlyRepository.contains for Hash In-Reply-To: <292-nbGJoE-FX6VmbzI7vCYOq5KutUg2Hww3gwFmRYQ=.948b848b-fe79-435f-9b0b-886c6b2c5115@github.com> References: <292-nbGJoE-FX6VmbzI7vCYOq5KutUg2Hww3gwFmRYQ=.948b848b-fe79-435f-9b0b-886c6b2c5115@github.com> Message-ID: On Wed, 28 Oct 2020 09:59:39 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds an overload `ReadOnlyRepository.contains` for just a `Hash` that checks if the repository does contain the given hash. > > Testing: > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: fb991fbc Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fb991fbc Stats: 28 lines in 5 files changed: 24 ins; 0 del; 4 mod vcs: add ReadOnlyRepository.contains for Hash Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/925 From thomas.stuefe at gmail.com Wed Oct 28 10:38:26 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Wed, 28 Oct 2020 11:38:26 +0100 Subject: commits not associated with github user? Message-ID: Hi, a small question: I associated my OpenJDK user with my GitHub user as explained in [1]. But I still do not see my github user associated with commits in the OpenJDK, e.g. for https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe#diff-40f3361acaecc2d05896655fa532ab5b6cba2885cbcc5796cac4e81d010763ba It says my name, fully written, not clickable. Seems to be the case for many developers, but not all of them. For some, the commit is actually linked to the Github user. Did I miss some step somewhere when setting up my user? Thanks! Thomas [1] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-GettingStarted From ehelin at openjdk.java.net Wed Oct 28 10:45:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 10:45:01 GMT Subject: Integrated: pr: align handleCommit and handle Message-ID: <4MR_jsQ_gKceHu2Db6yUB8O2pDbh6f1hddPD_xrr9Yc=.9184007e-cdf4-4bd2-90ee-2b72563a0ba6@github.com> Hi all, please review this patch that aligns `handleCommit` and `handle` in `CommandHandler`. This gives handlers for commit commands access to the commit, a census instance, etc. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - forge: align handleCommit and handle Changes: https://git.openjdk.java.net/skara/pull/926/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=926&range=00 Stats: 45 lines in 5 files changed: 24 ins; 4 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/926.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/926/head:pull/926 PR: https://git.openjdk.java.net/skara/pull/926 From rwestberg at openjdk.java.net Wed Oct 28 10:45:01 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 10:45:01 GMT Subject: Integrated: pr: align handleCommit and handle In-Reply-To: <4MR_jsQ_gKceHu2Db6yUB8O2pDbh6f1hddPD_xrr9Yc=.9184007e-cdf4-4bd2-90ee-2b72563a0ba6@github.com> References: <4MR_jsQ_gKceHu2Db6yUB8O2pDbh6f1hddPD_xrr9Yc=.9184007e-cdf4-4bd2-90ee-2b72563a0ba6@github.com> Message-ID: On Wed, 28 Oct 2020 10:37:47 GMT, Erik Helin wrote: > Hi all, > > please review this patch that aligns `handleCommit` and `handle` in `CommandHandler`. This gives handlers for commit commands access to the commit, a census instance, etc. > > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/926 From ehelin at openjdk.java.net Wed Oct 28 10:45:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 10:45:01 GMT Subject: Integrated: pr: align handleCommit and handle In-Reply-To: <4MR_jsQ_gKceHu2Db6yUB8O2pDbh6f1hddPD_xrr9Yc=.9184007e-cdf4-4bd2-90ee-2b72563a0ba6@github.com> References: <4MR_jsQ_gKceHu2Db6yUB8O2pDbh6f1hddPD_xrr9Yc=.9184007e-cdf4-4bd2-90ee-2b72563a0ba6@github.com> Message-ID: On Wed, 28 Oct 2020 10:37:47 GMT, Erik Helin wrote: > Hi all, > > please review this patch that aligns `handleCommit` and `handle` in `CommandHandler`. This gives handlers for commit commands access to the commit, a census instance, etc. > > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: a394135a Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/a394135a Stats: 45 lines in 5 files changed: 24 ins; 4 del; 17 mod pr: align handleCommit and handle Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/926 From rwestberg at openjdk.java.net Wed Oct 28 15:22:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 15:22:39 GMT Subject: RFR: forge: initial support for updating review comments Message-ID: Initial implementation of review comment updates for GitHub. ------------- Commit messages: - Support updating commit comments - Add support for updating review bodies - GitHub support for updating review comments Changes: https://git.openjdk.java.net/skara/pull/927/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=927&range=00 Stats: 63 lines in 10 files changed: 61 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/927.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/927/head:pull/927 PR: https://git.openjdk.java.net/skara/pull/927 From ehelin at openjdk.java.net Wed Oct 28 15:26:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 15:26:41 GMT Subject: RFR: forge: initial support for updating review comments In-Reply-To: References: Message-ID: On Wed, 28 Oct 2020 15:19:53 GMT, Robin Westberg wrote: > Initial implementation of review comment updates for GitHub. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/927 From rwestberg at openjdk.java.net Wed Oct 28 15:47:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 15:47:29 GMT Subject: Integrated: forge: initial support for updating review comments In-Reply-To: References: Message-ID: On Wed, 28 Oct 2020 15:19:53 GMT, Robin Westberg wrote: > Initial implementation of review comment updates for GitHub. This pull request has now been integrated. Changeset: 77e96f0e Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/77e96f0e Stats: 63 lines in 10 files changed: 61 ins; 0 del; 2 mod forge: initial support for updating review comments Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/927 From rwestberg at openjdk.java.net Wed Oct 28 16:03:49 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 16:03:49 GMT Subject: RFR: jira: skip security check for labels Message-ID: Labels themselves do not have a security level, so don't have to check that when setting them. ------------- Commit messages: - Skip security check for labels Changes: https://git.openjdk.java.net/skara/pull/928/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=928&range=00 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/928.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/928/head:pull/928 PR: https://git.openjdk.java.net/skara/pull/928 From ehelin at openjdk.java.net Wed Oct 28 16:03:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 28 Oct 2020 16:03:49 GMT Subject: RFR: jira: skip security check for labels In-Reply-To: References: Message-ID: On Wed, 28 Oct 2020 15:58:13 GMT, Robin Westberg wrote: > Labels themselves do not have a security level, so don't have to check that when setting them. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/928 From rwestberg at openjdk.java.net Wed Oct 28 16:06:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 28 Oct 2020 16:06:30 GMT Subject: Integrated: jira: skip security check for labels In-Reply-To: References: Message-ID: On Wed, 28 Oct 2020 15:58:13 GMT, Robin Westberg wrote: > Labels themselves do not have a security level, so don't have to check that when setting them. This pull request has now been integrated. Changeset: e583ed5a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/e583ed5a Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod jira: skip security check for labels Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/928 From ihse at openjdk.java.net Thu Oct 29 00:56:01 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Thu, 29 Oct 2020 00:56:01 GMT Subject: RFR: Add tabfiles to jcheck configuration Message-ID: The tabfiles setting is just like the files setting, but it lists files in which tabs are allowed. (This is to support makefiles) ------------- Commit messages: - Add tabfiles to jcheck configuration Changes: https://git.openjdk.java.net/skara/pull/929/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=929&range=00 Stats: 22 lines in 2 files changed: 9 ins; 7 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/929.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/929/head:pull/929 PR: https://git.openjdk.java.net/skara/pull/929 From thomas.stuefe at gmail.com Thu Oct 29 09:30:07 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 29 Oct 2020 10:30:07 +0100 Subject: Draft PRs generate mails to ML? Message-ID: Hi, When working on https://github.com/openjdk/jdk/pull/839, I reverted the PR back to draft to temporarily stop mail delivery, then pushed a new commit ( https://github.com/openjdk/jdk/pull/839/commits/8d86e25a89e7e7f7af463a6bc9a58cb57fb63d05 ) This caused a new mail though to hotspot-runtime-dev, even though the PR was back in Draft state: https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-October/043132.html Is this expected behaviour? I thought we do not generate mails when working on Draft PRs. Thanks, Thomas From robin.westberg at oracle.com Thu Oct 29 09:42:47 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Thu, 29 Oct 2020 10:42:47 +0100 Subject: Draft PRs generate mails to ML? In-Reply-To: References: Message-ID: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> Hi Thomas, > On 29 Oct 2020, at 10:30, Thomas St?fe wrote: > > Hi, > > When working on https://github.com/openjdk/jdk/pull/839, I reverted the PR > back to draft to temporarily stop mail delivery, then pushed a new commit ( > https://github.com/openjdk/jdk/pull/839/commits/8d86e25a89e7e7f7af463a6bc9a58cb57fb63d05 > ) > > This caused a new mail though to hotspot-runtime-dev, even though the PR > was back in Draft state: > https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-October/043132.html > > Is this expected behaviour? I thought we do not generate mails when working > on Draft PRs. This is by design, once a PR has been made ?public? by an initial RFR mail, it will continue to be bridged. We could change that, but it may be a bit strange for those who participate through the mailing list if the discussion continues ?invisibly? on GitHub.. If you really want to withdraw an RFR you can also just close the PR and open a new one when/if it becomes ready for another round.. Best regards, Robin > > Thanks, Thomas From ehelin at openjdk.java.net Thu Oct 29 10:58:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 29 Oct 2020 10:58:37 GMT Subject: RFR: Add tabfiles to jcheck configuration In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 00:53:16 GMT, Magnus Ihse Bursie wrote: > The tabfiles setting is just like the files setting, but it lists files in which tabs are allowed. > > (This is to support makefiles) How about naming the configuration `ignore-tabs` instead? To make it a bit more clear what it does :) ------------- PR: https://git.openjdk.java.net/skara/pull/929 From thomas.stuefe at gmail.com Thu Oct 29 11:53:46 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 29 Oct 2020 12:53:46 +0100 Subject: Draft PRs generate mails to ML? In-Reply-To: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> References: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> Message-ID: Hi Robin, Thanks for the answer! On Thu, Oct 29, 2020 at 10:42 AM Robin Westberg wrote: > Hi Thomas, > > > On 29 Oct 2020, at 10:30, Thomas St?fe wrote: > > > > Hi, > > > > When working on https://github.com/openjdk/jdk/pull/839, I reverted the > PR > > back to draft to temporarily stop mail delivery, then pushed a new > commit ( > > > https://github.com/openjdk/jdk/pull/839/commits/8d86e25a89e7e7f7af463a6bc9a58cb57fb63d05 > > ) > > > > This caused a new mail though to hotspot-runtime-dev, even though the PR > > was back in Draft state: > > > https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-October/043132.html > > > > Is this expected behaviour? I thought we do not generate mails when > working > > on Draft PRs. > > This is by design, once a PR has been made ?public? by an initial RFR > mail, it will continue to be bridged. We could change that, but it may be a > bit strange for those who participate through the mailing list if the > discussion continues ?invisibly? on GitHub.. If you really want to withdraw > an RFR you can also just close the PR and open a new one when/if it becomes > ready for another round.. > I see you point. I try to work in a way which minimizes unnecessary ML traffic, but still want to be able to do fine-granular commits. So this generates a lot of ML traffic (where before I would just work several days on a webrev until I am fine with the new version, then send a single mail). "Going dark" for a while would really help. I guess what I'll do is to continue work in a separate branch, then merge all the commits back to the original PR branch once I am done. Also means I can squash if needed. Thanks, Thomas > > Best regards, > Robin > > > > > Thanks, Thomas > > From aph at redhat.com Thu Oct 29 12:27:22 2020 From: aph at redhat.com (Andrew Haley) Date: Thu, 29 Oct 2020 12:27:22 +0000 Subject: Draft PRs generate mails to ML? In-Reply-To: References: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> Message-ID: On 29/10/2020 11:53, Thomas St?fe wrote: > I try to work in a way which minimizes unnecessary ML traffic, but still > want to be able to do fine-granular commits. So this generates a lot of ML > traffic (where before I would just work several days on a webrev until I am > fine with the new version, then send a single mail). "Going dark" for a > while would really help. I agree. I believe that generating emails for PRs in draft state is unnecessary and fails the principle of least surprise; therefore it should not be done. -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671 From erikj at openjdk.java.net Thu Oct 29 12:49:47 2020 From: erikj at openjdk.java.net (Erik Joelsson) Date: Thu, 29 Oct 2020 12:49:47 GMT Subject: RFR: Add tabfiles to jcheck configuration In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 00:53:16 GMT, Magnus Ihse Bursie wrote: > The tabfiles setting is just like the files setting, but it lists files in which tabs are allowed. > > (This is to support makefiles) jcheck/src/main/java/org/openjdk/skara/jcheck/WhitespaceCheck.java line 58: > 56: var crIndex = line.indexOf('\r'); > 57: var ignoreTab = tabPattern.matcher(path.toString()).matches(); > 58: if ((tabIndex >= 0 && !ignoreTab) || crIndex >= 0 || line.endsWith(" ")) { This won't catch if a tabFile has a trailing tab. ------------- PR: https://git.openjdk.java.net/skara/pull/929 From ehelin at openjdk.java.net Thu Oct 29 15:35:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 29 Oct 2020 15:35:04 GMT Subject: RFR: vcs: handle binary files in UnifiedDiffParser Message-ID: Hi all, please review this patch that handles binary files in the `UnifiedDiffParser`. Testing: - [x] Added a unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: handle binary files in UnifiedDiffParser Changes: https://git.openjdk.java.net/skara/pull/930/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=930&range=00 Stats: 17 lines in 2 files changed: 17 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/930.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/930/head:pull/930 PR: https://git.openjdk.java.net/skara/pull/930 From ehelin at openjdk.java.net Thu Oct 29 15:43:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 29 Oct 2020 15:43:04 GMT Subject: RFR: checkout: use HostedRepository instead of URI Message-ID: <0sJaTKXwTr3dIZY2yBf9yPQQzn2VZb5gNz3L3AgMb30=.445e7070-b05f-4630-8a16-82327ff94358@github.com> Hi all, please review this patch that makes the `checkout` bot use `HostedRepository` instead of `URI` for the `from` repository. Testing: - [x] Updated unit tests Thanks, Erik ------------- Commit messages: - checkout: use HostedRepository instead of URI Changes: https://git.openjdk.java.net/skara/pull/931/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=931&range=00 Stats: 33 lines in 3 files changed: 19 ins; 2 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/931.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/931/head:pull/931 PR: https://git.openjdk.java.net/skara/pull/931 From ehelin at openjdk.java.net Thu Oct 29 16:06:46 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 29 Oct 2020 16:06:46 GMT Subject: RFR: forge: diff for GitLab commits can be empty Message-ID: Hi all, please review this patch that handles an edge case when the `"diff"` for a commit from GitLab can be empty (the case for a renamed file for example). Thanks, Erik ------------- Commit messages: - forge: diff for GitLab commits can be empty Changes: https://git.openjdk.java.net/skara/pull/932/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=932&range=00 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/932.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/932/head:pull/932 PR: https://git.openjdk.java.net/skara/pull/932 From christoph.langer at sap.com Thu Oct 29 16:11:07 2020 From: christoph.langer at sap.com (Langer, Christoph) Date: Thu, 29 Oct 2020 16:11:07 +0000 Subject: Skara Workflow for Update releases In-Reply-To: <88e3794c-3bfc-868e-9337-cc5699682e7e@oracle.com> References: <88e3794c-3bfc-868e-9337-cc5699682e7e@oracle.com> Message-ID: Hi Erik, > > now that project Skara has hit mainline OpenJDK for quite a while, I?m > > starting to think more closely about how the workflow for backports and > > update releases will be. > > > > I have lately recognized some activity in the Skara project to add > > functionality for the backport scenario flying by. I also understand > > that Yan and the folks maintaining 13u started using Skara already. I > > have a few questions however. > > > > 1. About the workflow for backports: I have seen that you?ve added the > > option ?git pr create --backport REV?. So I take that this would be the > > canonical way to do a backport from an upstream change. Is there also > > support for cherry-picking changes from upstream via pure git and > > creating a PR from the backport, such that the Skara bots will recognize > > that the patch proposed is a backport? > > Yuri and the 13u people were kind enough to be the first JDK Updates to > transition to Skara and they immediately found some issues. Fortunately > we have now resolved almost all of them, I only have one or two left to fix. > > > 2. What?s the workflow for merging between repositories? E.g. in 11u, we > > have 2 repos, one is jdk11u, the other is jdk11u-dev. We?re currently > > merging those repos once in a while in either direction. How is this > > supported by Skara? I guess I can add both remotes to my local > > repository and then merge branches and create PRs. However, what?ll > > happen then? Will the skara bots accept merging these branches (without > > squashing). What kind of checking will be in place? Can you please shed > > some light on how you imagine that process. > > > > I?m asking because I?d like to see Skara being used consistently, also > > in JDK 11 Updates and I want to understand how far we?re away from that. > ?? > > You are very close :) I've just started documenting the intended > workflow for backports, I will have more to share closer to the end of > this week. Eagerly looking forward to your update then ?? Thanks Christoph From rwestberg at openjdk.java.net Thu Oct 29 17:50:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 29 Oct 2020 17:50:30 GMT Subject: RFR: vcs: handle binary files in UnifiedDiffParser In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 15:32:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles binary files in the `UnifiedDiffParser`. > > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/930 From rwestberg at openjdk.java.net Thu Oct 29 17:51:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 29 Oct 2020 17:51:53 GMT Subject: RFR: checkout: use HostedRepository instead of URI In-Reply-To: <0sJaTKXwTr3dIZY2yBf9yPQQzn2VZb5gNz3L3AgMb30=.445e7070-b05f-4630-8a16-82327ff94358@github.com> References: <0sJaTKXwTr3dIZY2yBf9yPQQzn2VZb5gNz3L3AgMb30=.445e7070-b05f-4630-8a16-82327ff94358@github.com> Message-ID: On Thu, 29 Oct 2020 15:40:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the `checkout` bot use `HostedRepository` instead of `URI` for the `from` repository. > > Testing: > - [x] Updated unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/931 From rwestberg at openjdk.java.net Thu Oct 29 17:53:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 29 Oct 2020 17:53:30 GMT Subject: RFR: forge: diff for GitLab commits can be empty In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 16:03:58 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles an edge case when the `"diff"` for a commit from GitLab can be empty (the case for a renamed file for example). > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/932 From jai.forums2013 at gmail.com Fri Oct 30 01:56:49 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Fri, 30 Oct 2020 07:26:49 +0530 Subject: Draft PRs generate mails to ML? In-Reply-To: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> References: <24EAF395-7860-4433-B9FE-3C6D65E54BFA@oracle.com> Message-ID: <2494ea9d-645e-1084-a102-962d641c461e@gmail.com> Hello Robin, On 29/10/20 3:12 pm, Robin Westberg wrote: > Hi Thomas, > >> On 29 Oct 2020, at 10:30, Thomas St?fe wrote: >> >> Hi, >> >> When working on https://github.com/openjdk/jdk/pull/839, I reverted the PR >> back to draft to temporarily stop mail delivery, then pushed a new commit ( >> https://github.com/openjdk/jdk/pull/839/commits/8d86e25a89e7e7f7af463a6bc9a58cb57fb63d05 >> ) >> >> This caused a new mail though to hotspot-runtime-dev, even though the PR >> was back in Draft state: >> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-October/043132.html >> >> Is this expected behaviour? I thought we do not generate mails when working >> on Draft PRs. > This is by design, once a PR has been made ?public? by an initial RFR mail, it will continue to be bridged. We could change that, but it may be a bit strange for those who participate through the mailing list if the discussion continues ?invisibly? on GitHub.. Perhaps the skara tool could generate a mail which clearly states that the PR has now been put into Draft state and users need to watch the linked GitHub PR for any updates/comments? Kind of similar to the mail that says PR has been withdrawn without being merged, when someone closes the PR. -Jaikiran From ehelin at openjdk.java.net Fri Oct 30 08:49:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 30 Oct 2020 08:49:35 GMT Subject: Integrated: vcs: handle binary files in UnifiedDiffParser In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 15:32:18 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles binary files in the `UnifiedDiffParser`. > > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: daa3c93e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/daa3c93e Stats: 17 lines in 2 files changed: 17 ins; 0 del; 0 mod vcs: handle binary files in UnifiedDiffParser Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/930 From ehelin at openjdk.java.net Fri Oct 30 08:50:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 30 Oct 2020 08:50:03 GMT Subject: Integrated: forge: diff for GitLab commits can be empty In-Reply-To: References: Message-ID: On Thu, 29 Oct 2020 16:03:58 GMT, Erik Helin wrote: > Hi all, > > please review this patch that handles an edge case when the `"diff"` for a commit from GitLab can be empty (the case for a renamed file for example). > > Thanks, > Erik This pull request has now been integrated. Changeset: b4bc1918 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b4bc1918 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod forge: diff for GitLab commits can be empty Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/932 From ehelin at openjdk.java.net Fri Oct 30 08:50:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 30 Oct 2020 08:50:14 GMT Subject: Integrated: checkout: use HostedRepository instead of URI In-Reply-To: <0sJaTKXwTr3dIZY2yBf9yPQQzn2VZb5gNz3L3AgMb30=.445e7070-b05f-4630-8a16-82327ff94358@github.com> References: <0sJaTKXwTr3dIZY2yBf9yPQQzn2VZb5gNz3L3AgMb30=.445e7070-b05f-4630-8a16-82327ff94358@github.com> Message-ID: <_g3KlvbVeKFtxeSrvQd5vm6Q2xlsGJAAWblvz4QaA8k=.508af53b-2c72-4394-abf0-cb0ca4f1718c@github.com> On Thu, 29 Oct 2020 15:40:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the `checkout` bot use `HostedRepository` instead of `URI` for the `from` repository. > > Testing: > - [x] Updated unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: 352c2768 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/352c2768 Stats: 33 lines in 3 files changed: 19 ins; 2 del; 12 mod checkout: use HostedRepository instead of URI Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/931 From rwestberg at openjdk.java.net Fri Oct 30 09:39:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 30 Oct 2020 09:39:57 GMT Subject: RFR: Avoid resetting an existing storage file Message-ID: If a materialization of a HostedRepositoryStorage fails due to an intermittent problem, we must ensure that we do not incorrectly try to create the ref as if it did not yet exist. ------------- Commit messages: - Avoid resetting an existing storage file Changes: https://git.openjdk.java.net/skara/pull/933/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=933&range=00 Stats: 14 lines in 2 files changed: 13 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/933.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/933/head:pull/933 PR: https://git.openjdk.java.net/skara/pull/933 From ehelin at openjdk.java.net Fri Oct 30 09:56:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 30 Oct 2020 09:56:51 GMT Subject: RFR: Avoid resetting an existing storage file In-Reply-To: References: Message-ID: On Fri, 30 Oct 2020 09:36:52 GMT, Robin Westberg wrote: > If a materialization of a HostedRepositoryStorage fails due to an intermittent problem, we must ensure that we do not incorrectly try to create the ref as if it did not yet exist. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/933 From rwestberg at openjdk.java.net Fri Oct 30 09:56:51 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 30 Oct 2020 09:56:51 GMT Subject: Integrated: Avoid resetting an existing storage file In-Reply-To: References: Message-ID: On Fri, 30 Oct 2020 09:36:52 GMT, Robin Westberg wrote: > If a materialization of a HostedRepositoryStorage fails due to an intermittent problem, we must ensure that we do not incorrectly try to create the ref as if it did not yet exist. This pull request has now been integrated. Changeset: e261f30c Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/e261f30c Stats: 14 lines in 2 files changed: 13 ins; 0 del; 1 mod Avoid resetting an existing storage file Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/933 From ehelin at openjdk.java.net Fri Oct 30 14:30:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 30 Oct 2020 14:30:21 GMT Subject: Integrated: Use proper build number formatting In-Reply-To: References: Message-ID: On Fri, 30 Oct 2020 14:25:48 GMT, Robin Westberg wrote: > Low build numbers should use a leading 0 for the custom field. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/934 From rwestberg at openjdk.java.net Fri Oct 30 14:30:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 30 Oct 2020 14:30:21 GMT Subject: Integrated: Use proper build number formatting Message-ID: Low build numbers should use a leading 0 for the custom field. ------------- Commit messages: - Use proper build number formatting Changes: https://git.openjdk.java.net/skara/pull/934/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=934&range=00 Stats: 21 lines in 2 files changed: 19 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/934.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/934/head:pull/934 PR: https://git.openjdk.java.net/skara/pull/934 From rwestberg at openjdk.java.net Fri Oct 30 14:30:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 30 Oct 2020 14:30:21 GMT Subject: Integrated: Use proper build number formatting In-Reply-To: References: Message-ID: <6yEioqGSsKrDJEc52T3wauNORrAjMp5XxUwtGI38dRk=.d256cf67-42cf-4ed8-a318-7d650dafa9d7@github.com> On Fri, 30 Oct 2020 14:25:48 GMT, Robin Westberg wrote: > Low build numbers should use a leading 0 for the custom field. This pull request has now been integrated. Changeset: 07742a0c Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/07742a0c Stats: 21 lines in 2 files changed: 19 ins; 0 del; 2 mod Use proper build number formatting Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/934 From erik.helin at oracle.com Fri Oct 30 14:39:59 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 30 Oct 2020 15:39:59 +0100 Subject: Skara Workflow for Update releases In-Reply-To: References: <88e3794c-3bfc-868e-9337-cc5699682e7e@oracle.com> Message-ID: <67979038-ca37-4996-7bf2-c43f55e6c28e@oracle.com> On 10/29/20 5:11 PM, Langer, Christoph wrote: >>> I?m asking because I?d like to see Skara being used consistently, also >>> in JDK 11 Updates and I want to understand how far we?re away from that. >> ?? >> >> You are very close :) I've just started documenting the intended >> workflow for backports, I will have more to share closer to the end of >> this week. > > Eagerly looking forward to your update then ?? I've started documenting the workflow on the Skara wiki [0]. Note that all pieces are not in place yet, the following issues still needs to be implemented: - SKARA-795: Add /backport commit command [1] - SKARA-796: Add backport CLI command [2] - SKARA-797: Show "diff of diffs" for non-clean backports [3] I'm almost done with SKARA-795 and hope to wrap up all of this next week. Thanks, Erik [0]: https://wiki.openjdk.java.net/display/SKARA/Backports [1]: https://bugs.openjdk.java.net/browse/SKARA-795 [2]: https://bugs.openjdk.java.net/browse/SKARA-796 [3]: https://bugs.openjdk.java.net/browse/SKARA-797 From powers.anirvan at gmail.com Sat Oct 31 08:16:01 2020 From: powers.anirvan at gmail.com (Anirvan Sarkar) Date: Sat, 31 Oct 2020 17:16:01 +0900 Subject: commits not associated with github user? In-Reply-To: References: Message-ID: Hi Thomas, I had also observed the same behaviour. Then I noticed that OpenJDK commits are committed with OpenJDK email address [1]. So I added my OpenJDK email address to GitHub email settings [2] and after some days when I checked again, I found my commit was linked to my GitHub user [3]. Can you add your OpenJDK email address in your GitHub settings and see if it works for you? If it works then we can ask the Skara team to add this step in the Wiki. [1] https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a.patch [2] https://github.com/settings/emails [3] https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a On Wed, 28 Oct 2020 at 19:40, Thomas St?fe wrote: > Hi, > > a small question: I associated my OpenJDK user with my GitHub user as > explained in [1]. But I still do not see my github user associated with > commits in the OpenJDK, e.g. for > > https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe#diff-40f3361acaecc2d05896655fa532ab5b6cba2885cbcc5796cac4e81d010763ba > > It says my name, fully written, not clickable. Seems to be the case for > many developers, but not all of them. For some, the commit is actually > linked to the Github user. > > Did I miss some step somewhere when setting up my user? > > Thanks! > Thomas > > [1] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-GettingStarted > -- Anirvan From thomas.stuefe at gmail.com Sat Oct 31 09:49:40 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Sat, 31 Oct 2020 10:49:40 +0100 Subject: commits not associated with github user? In-Reply-To: References: Message-ID: Hi Anirvan, interesting idea, thank you! But the openjdk mail addresses are not valid. I hesitate to add an invalid mail address to my Github profile. I'd rather that the correct mail addresses be used by the Skara tools, those we are registered in the census with and which are used by the Github account. Especially since these fake addresses also add confusion to mailing list traffic. Thanks, Thomas On Sat, Oct 31, 2020 at 9:16 AM Anirvan Sarkar wrote: > Hi Thomas, > > I had also observed the same behaviour. > Then I noticed that OpenJDK commits are committed with OpenJDK email > address [1]. > So I added my OpenJDK email address to GitHub email settings [2] and after > some days when I checked again, I found my commit was linked to my GitHub > user [3]. > > Can you add your OpenJDK email address in your GitHub settings and see if > it works for you? > If it works then we can ask the Skara team to add this step in the Wiki. > > [1] > https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a.patch > [2] https://github.com/settings/emails > [3] > https://github.com/openjdk/jdk/commit/7a937e0ddedbb06e18196b6c3f4170e98fc2936a > > On Wed, 28 Oct 2020 at 19:40, Thomas St?fe > wrote: > >> Hi, >> >> a small question: I associated my OpenJDK user with my GitHub user as >> explained in [1]. But I still do not see my github user associated with >> commits in the OpenJDK, e.g. for >> >> https://github.com/openjdk/jdk/commit/7ba6a6bf003b810e9f48cb755abe39b1376ad3fe#diff-40f3361acaecc2d05896655fa532ab5b6cba2885cbcc5796cac4e81d010763ba >> >> It says my name, fully written, not clickable. Seems to be the case for >> many developers, but not all of them. For some, the commit is actually >> linked to the Github user. >> >> Did I miss some step somewhere when setting up my user? >> >> Thanks! >> Thomas >> >> [1] >> https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-GettingStarted >> > > > -- > Anirvan >