RFR: Add support for marking PR body content with an expiration time [v2]

Robin Westberg rwestberg at openjdk.java.net
Tue Oct 6 13:37:35 UTC 2020


On Tue, 6 Oct 2020 13:31:08 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>>   
>>   Co-authored-by: Erik Duveblad <erik.helin at oracle.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 71:
> 
>> 69:             var hasExpired = ExpirationTracker.hasExpired(body);
>> 70:             if (hasExpired) {
>> 71:                 return
>> Base64.getUrlEncoder().encodeToString(UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8));
> 
> Suggestion:
> 
>                 return String.valueOf(Math.random());

Guess that makes sense. :)

-------------

PR: https://git.openjdk.java.net/skara/pull/862


More information about the skara-dev mailing list