Integrated: pr: detect clean backports

Erik Helin ehelin at openjdk.java.net
Sat Oct 17 07:49:18 UTC 2020


On Thu, 15 Oct 2020 12:36:49 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that adds support to `CheckRun` for identifying "clean" backport pull requests. A backport
> pull request is "clean" if the diff of the pull request is the same as the diff for the original _modulo_ exact lines
> being changed. That is, the same backport pull request must contain the same _changes_ as the original commit, but the
> changes don't have to be applied to the exact same lines. The result is equivalent to running `patch` and passing a
> fuzzing factor via `--fuzz` that is the same as the number of context lines.  A clean backport also doesn't require
> reviews. Note though that non-Committers still need a sponsor. I plan to make this configurable in a follow-up patch.
> Testing:
> - [x] Added a bunch of tests
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 7774dcdb
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/7774dcdb
Stats:     634 lines in 5 files changed: 609 ins; 12 del; 13 mod

pr: detect clean backports

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/885


More information about the skara-dev mailing list