RFR: forge: patch for commit can be null

Robin Westberg rwestberg at openjdk.java.net
Fri Oct 23 14:52:12 UTC 2020


On Fri, 23 Oct 2020 14:24:25 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that handles cases where the GitHub REST API returns `null` for the `"patch"` field for a `commit` object. This seems to primarily happen for very large merges that changes 200+ files.
> 
> Testing:
> - [x] Manual testing on Linux x64
> 
> Thanks,
> Erik

Looks good!

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/914


More information about the skara-dev mailing list