Draft PRs generate mails to ML?
thomas.stuefe at gmail.com
Thu Oct 29 11:53:46 UTC 2020
Thanks for the answer!
On Thu, Oct 29, 2020 at 10:42 AM Robin Westberg <robin.westberg at oracle.com>
> Hi Thomas,
> > On 29 Oct 2020, at 10:30, Thomas Stüfe <thomas.stuefe at gmail.com> wrote:
> > Hi,
> > When working on https://github.com/openjdk/jdk/pull/839, I reverted the
> > back to draft to temporarily stop mail delivery, then pushed a new
> commit (
> > )
> > This caused a new mail though to hotspot-runtime-dev, even though the PR
> > was back in Draft state:
> > Is this expected behaviour? I thought we do not generate mails when
> > on Draft PRs.
> This is by design, once a PR has been made “public” by an initial RFR
> mail, it will continue to be bridged. We could change that, but it may be a
> bit strange for those who participate through the mailing list if the
> discussion continues “invisibly” on GitHub.. If you really want to withdraw
> an RFR you can also just close the PR and open a new one when/if it becomes
> ready for another round..
I see you point.
I try to work in a way which minimizes unnecessary ML traffic, but still
want to be able to do fine-granular commits. So this generates a lot of ML
traffic (where before I would just work several days on a webrev until I am
fine with the new version, then send a single mail). "Going dark" for a
while would really help.
I guess what I'll do is to continue work in a separate branch, then merge
all the commits back to the original PR branch once I am done. Also means I
can squash if needed.
> Best regards,
> > Thanks, Thomas
More information about the skara-dev