RFR: Add tabfiles to jcheck configuration

Erik Joelsson erikj at openjdk.java.net
Thu Oct 29 12:49:47 UTC 2020


On Thu, 29 Oct 2020 00:53:16 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:

> The tabfiles setting is just like the files setting, but it lists files in which tabs are allowed.
> 
> (This is to support makefiles)

jcheck/src/main/java/org/openjdk/skara/jcheck/WhitespaceCheck.java line 58:

> 56:                             var crIndex = line.indexOf('\r');
> 57:                             var ignoreTab = tabPattern.matcher(path.toString()).matches();
> 58:                             if ((tabIndex >= 0 && !ignoreTab) || crIndex >= 0 || line.endsWith(" ")) {

This won't catch if a tabFile has a trailing tab.

-------------

PR: https://git.openjdk.java.net/skara/pull/929


More information about the skara-dev mailing list