From rwestberg at openjdk.java.net Tue Sep 1 08:40:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 1 Sep 2020 08:40:11 GMT Subject: Withdrawn: 409: pr set --no-draft fails on gitlab provider In-Reply-To: References: Message-ID: On Mon, 21 Oct 2019 15:22:47 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that skips creating repository lock files when using the TestHostedRepository, as it uses > unique temporary folders anyway. This makes the tests run a little bit faster. > Best regards, > Robin This pull request has been closed without being integrated. ------------- PR: https://git.openjdk.java.net/skara/pull/219 From ehelin at openjdk.java.net Tue Sep 1 08:51:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 08:51:05 GMT Subject: RFR: checkout-bot: remote leading slash from path Message-ID: Hi all, please review this patch that removes the leading slash from the path to the marks file for the checkout bot. Testing: - `make test` passes on Linux x64 - Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - checkout-bot: remote leading slash from path Changes: https://git.openjdk.java.net/skara/pull/759/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=759&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/759.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/759/head:pull/759 PR: https://git.openjdk.java.net/skara/pull/759 From rwestberg at openjdk.java.net Tue Sep 1 08:51:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 1 Sep 2020 08:51:06 GMT Subject: RFR: checkout-bot: remote leading slash from path In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 08:47:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the leading slash from the path to the marks file for the checkout bot. > > Testing: > - `make test` passes on Linux x64 > - Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/759 From ehelin at openjdk.java.net Tue Sep 1 08:55:58 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 08:55:58 GMT Subject: Integrated: checkout-bot: remote leading slash from path In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 08:47:53 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the leading slash from the path to the marks file for the checkout bot. > > Testing: > - `make test` passes on Linux x64 > - Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 931a0b12 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/931a0b12 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod checkout-bot: remote leading slash from path Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/759 From ehelin at openjdk.java.net Tue Sep 1 09:15:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 09:15:15 GMT Subject: RFR: storage: support nested paths in file storage Message-ID: Hi all, please review this path that makes `FileStorage` with files in nested directories. Testing: - `make test` passes on Linux x64 - Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - storage: support nested paths in file storage Changes: https://git.openjdk.java.net/skara/pull/760/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=760&range=00 Stats: 4 lines in 1 file changed: 4 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/760.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/760/head:pull/760 PR: https://git.openjdk.java.net/skara/pull/760 From rwestberg at openjdk.java.net Tue Sep 1 09:15:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 1 Sep 2020 09:15:17 GMT Subject: RFR: storage: support nested paths in file storage In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 09:11:11 GMT, Erik Helin wrote: > Hi all, > > please review this path that makes `FileStorage` with files in nested directories. > > Testing: > - `make test` passes on Linux x64 > - Manual testing on Linux x64 > > Thanks, > Erik Looks good! storage/src/main/java/org/openjdk/skara/storage/FileStorage.java line 68: > 67: Files.createDirectories(file.getParent()); > 68: if (!Files.exists(file)) { > 69: Files.createFile(file); Doesn't hurt, but Files.writeString should create it if it doesn't exist as well I think. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/760 From ehelin at openjdk.java.net Tue Sep 1 09:36:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 09:36:20 GMT Subject: RFR: storage: support nested paths in file storage In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 09:12:37 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this path that makes `FileStorage` with files in nested directories. >> >> Testing: >> - `make test` passes on Linux x64 >> - Manual testing on Linux x64 >> >> Thanks, >> Erik > > storage/src/main/java/org/openjdk/skara/storage/FileStorage.java line 68: > >> 67: Files.createDirectories(file.getParent()); >> 68: if (!Files.exists(file)) { >> 69: Files.createFile(file); > > Doesn't hurt, but Files.writeString should create it if it doesn't exist as well I think. It didn't for nested paths, so the `Files.createDirectories` is definitely needed. The `if (!Files.exists)` could potentially be left out, but otoh it doesn't hurt to be explicit here. ------------- PR: https://git.openjdk.java.net/skara/pull/760 From ehelin at openjdk.java.net Tue Sep 1 09:36:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 09:36:20 GMT Subject: Integrated: storage: support nested paths in file storage In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 09:11:11 GMT, Erik Helin wrote: > Hi all, > > please review this path that makes `FileStorage` with files in nested directories. > > Testing: > - `make test` passes on Linux x64 > - Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 59448e72 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/59448e72 Stats: 4 lines in 1 file changed: 0 ins; 4 del; 0 mod storage: support nested paths in file storage Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/760 From weijun at openjdk.java.net Tue Sep 1 11:58:32 2020 From: weijun at openjdk.java.net (Weijun Wang) Date: Tue, 1 Sep 2020 11:58:32 GMT Subject: Integrated: Update jdk.json In-Reply-To: References: Message-ID: On Thu, 27 Aug 2020 12:41:42 GMT, Weijun Wang wrote: > Add two lines and expand one. This pull request has now been integrated. Changeset: d533135b Author: Weijun Wang Committer: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/d533135b Stats: 3 lines in 1 file changed: 0 ins; 2 del; 1 mod Update jdk.json Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/747 From ehelin at openjdk.java.net Tue Sep 1 15:22:08 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 15:22:08 GMT Subject: RFR: test-bot: make it configurable to check committer status Message-ID: Hi all, please review this patch that add a configurable validation check to the test bot: check if the requester is Committer in the project. Testing: - `make test` on Linux x64 - Added an additional unit test Thanks, Erik ------------- Commit messages: - test-bot: make it configurable to check committer status Changes: https://git.openjdk.java.net/skara/pull/761/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=761&range=00 Stats: 170 lines in 7 files changed: 150 ins; 0 del; 20 mod Patch: https://git.openjdk.java.net/skara/pull/761.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/761/head:pull/761 PR: https://git.openjdk.java.net/skara/pull/761 From rwestberg at openjdk.java.net Tue Sep 1 15:27:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 1 Sep 2020 15:27:13 GMT Subject: RFR: test-bot: make it configurable to check committer status In-Reply-To: References: Message-ID: On Tue, 1 Sep 2020 15:19:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that add a configurable validation check to the test bot: check if the requester is Committer > in the project. > Testing: > - `make test` on Linux x64 > - Added an additional unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/761 From darcy at openjdk.java.net Tue Sep 1 15:35:52 2020 From: darcy at openjdk.java.net (Joe Darcy) Date: Tue, 1 Sep 2020 15:35:52 GMT Subject: Integrated: Small updates to jdk.json mapping In-Reply-To: References: Message-ID: On Fri, 28 Aug 2020 21:35:50 GMT, Joe Darcy wrote: > Simplify AIX libjli mapping and remove various HotSpot regression tests from core-libs-dev. This pull request has now been integrated. Changeset: 3746ea5e Author: Joe Darcy URL: https://git.openjdk.java.net/skara/commit/3746ea5e Stats: 60 lines in 1 file changed: 24 ins; 30 del; 6 mod Small updates to jdk.json mapping Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/751 From ehelin at openjdk.java.net Tue Sep 1 15:51:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 15:51:55 GMT Subject: git: openjdk/skara: test-bot: make it configurable to check committer status Message-ID: <313356f0-d85b-4ac3-a36e-a9ccfad24bb2@openjdk.org> Changeset: adb24861 Author: Erik Helin Date: 2020-09-01 15:51:46 +0000 URL: https://git.openjdk.java.net/skara/commit/adb24861 test-bot: make it configurable to check committer status Reviewed-by: rwestberg ! bots/tester/build.gradle ! bots/tester/src/main/java/module-info.java ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBot.java ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestBotFactory.java ! bots/tester/src/main/java/org/openjdk/skara/bots/tester/TestWorkItem.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestBotTests.java ! bots/tester/src/test/java/org/openjdk/skara/bots/tester/TestWorkItemTests.java From ehelin at openjdk.java.net Tue Sep 1 15:54:00 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 1 Sep 2020 15:54:00 GMT Subject: Integrated: test-bot: make it configurable to check committer status In-Reply-To: References: Message-ID: <6Wz7aWE9AryKaOn9dGyAzsJr4A8BZygJnf0aXGhEu_8=.dca07deb-db43-462e-ae62-bd798e91c8af@github.com> On Tue, 1 Sep 2020 15:19:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that add a configurable validation check to the test bot: check if the requester is Committer > in the project. > Testing: > - `make test` on Linux x64 > - Added an additional unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: adb24861 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/adb24861 Stats: 170 lines in 7 files changed: 0 ins; 150 del; 20 mod test-bot: make it configurable to check committer status Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/761 From rwestberg at openjdk.java.net Wed Sep 2 07:59:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 2 Sep 2020 07:59:19 GMT Subject: RFR: A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) Message-ID: Hi all, Please review this change that ensures that the source repository of a GitLab merge request is accessible before attempting to use it. Best regards, Robin ------------- Commit messages: - A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) Changes: https://git.openjdk.java.net/skara/pull/762/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=762&range=00 Stats: 29 lines in 3 files changed: 15 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/762.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/762/head:pull/762 PR: https://git.openjdk.java.net/skara/pull/762 From ehelin at openjdk.java.net Wed Sep 2 08:48:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 2 Sep 2020 08:48:04 GMT Subject: RFR: A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) In-Reply-To: References: Message-ID: <0dIuxCWqsCjidRz8tXKDu5tBzC1nQLH_wvodI9_TVXs=.a1830db4-8b4d-4f14-af72-2a4524b04ed6@github.com> On Wed, 2 Sep 2020 07:56:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the source repository of a GitLab merge request is accessible before > attempting to use it. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/762 From erik.helin at oracle.com Wed Sep 2 08:58:14 2020 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 2 Sep 2020 10:58:14 +0200 Subject: RFR: A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) In-Reply-To: References: Message-ID: On 9/2/20 9:59 AM, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the source repository of a GitLab merge request is accessible before > attempting to use it. Thanks for fixing this Robin! Erik From rwestberg at openjdk.java.net Wed Sep 2 09:05:03 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 2 Sep 2020 09:05:03 GMT Subject: Integrated: A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) In-Reply-To: References: Message-ID: On Wed, 2 Sep 2020 07:56:42 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that ensures that the source repository of a GitLab merge request is accessible before > attempting to use it. > Best regards, > Robin This pull request has now been integrated. Changeset: 614cb720 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/614cb720 Stats: 29 lines in 3 files changed: 0 ins; 15 del; 14 mod A GitLab merge request source repo may have an ID but still be inaccessible (due to permissions) Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/762 From rwestberg at openjdk.java.net Wed Sep 2 13:23:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 2 Sep 2020 13:23:17 GMT Subject: RFR: 549: Links to users under Reviewers lead to a 404 page Message-ID: Hi all, Please review this change that improves the formatting of user names / link listed under Reviewers in the PR body. With proper configuration, it will look something like this: * [Robin Westberg](https://openjdk.java.net/census#rwestberg) (@rwestberg - **Reviewer**) Best regards, Robin ------------- Commit messages: - Improve formatting of reviewer names in PR body Changes: https://git.openjdk.java.net/skara/pull/763/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=763&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-549 Stats: 53 lines in 5 files changed: 45 ins; 1 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/763.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/763/head:pull/763 PR: https://git.openjdk.java.net/skara/pull/763 From ehelin at openjdk.java.net Wed Sep 2 13:36:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 2 Sep 2020 13:36:19 GMT Subject: RFR: 549: Links to users under Reviewers lead to a 404 page In-Reply-To: References: Message-ID: On Wed, 2 Sep 2020 13:20:17 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the formatting of user names / link listed under Reviewers in the PR body. With > proper configuration, it will look something like this: > * [Robin Westberg](https://openjdk.java.net/census#rwestberg) (@rwestberg - **Reviewer**) > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/763 From rwestberg at openjdk.java.net Thu Sep 3 07:34:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 07:34:38 GMT Subject: Integrated: 549: Links to users under Reviewers lead to a 404 page In-Reply-To: References: Message-ID: <1Ers-w_sOspSS3ZXfMsqmOTkkKMpNM8ouhOnGZmN4jw=.f47e1887-a997-4bea-ab3e-1b66a8cf3d82@github.com> On Wed, 2 Sep 2020 13:20:17 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the formatting of user names / link listed under Reviewers in the PR body. With > proper configuration, it will look something like this: > * [Robin Westberg](https://openjdk.java.net/census#rwestberg) (@rwestberg - **Reviewer**) > > Best regards, > Robin This pull request has now been integrated. Changeset: 30f1d045 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/30f1d045 Stats: 53 lines in 5 files changed: 1 ins; 45 del; 7 mod 549: Links to users under Reviewers lead to a 404 page Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/763 From ehelin at openjdk.java.net Thu Sep 3 08:07:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 3 Sep 2020 08:07:42 GMT Subject: RFR: webrev: do not use follow for ranges with merges Message-ID: <5YtH4_WmOIvj2zm66tcDzzjrlx8QX3mE0dVA1VeTC_4=.26cd38ce-6e50-465e-8ca3-4b05067eb3f6@github.com> Hi all, please review this patch that makes JSON webrev use plain `git log` if the range of commits include a merge commits. This is needed because `git log -c --follow` can be extremely slow for commit ranges with a lot of merge commits. Testing: - `make test` on Linux x64 - Manual verification of performance Thanks, Erik ------------- Commit messages: - webrev: do not use follow for ranges with merges Changes: https://git.openjdk.java.net/skara/pull/764/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=764&range=00 Stats: 8 lines in 1 file changed: 7 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/764.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/764/head:pull/764 PR: https://git.openjdk.java.net/skara/pull/764 From rwestberg at openjdk.java.net Thu Sep 3 08:12:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 08:12:56 GMT Subject: RFR: webrev: do not use follow for ranges with merges In-Reply-To: <5YtH4_WmOIvj2zm66tcDzzjrlx8QX3mE0dVA1VeTC_4=.26cd38ce-6e50-465e-8ca3-4b05067eb3f6@github.com> References: <5YtH4_WmOIvj2zm66tcDzzjrlx8QX3mE0dVA1VeTC_4=.26cd38ce-6e50-465e-8ca3-4b05067eb3f6@github.com> Message-ID: On Thu, 3 Sep 2020 08:05:08 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes JSON webrev use plain `git log` if the range of commits include a merge commits. > This is needed because `git log -c --follow` can be extremely slow for commit ranges with a lot of merge commits. > Testing: > - `make test` on Linux x64 > - Manual verification of performance > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/764 From ehelin at openjdk.java.net Thu Sep 3 08:12:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 3 Sep 2020 08:12:56 GMT Subject: Integrated: webrev: do not use follow for ranges with merges In-Reply-To: <5YtH4_WmOIvj2zm66tcDzzjrlx8QX3mE0dVA1VeTC_4=.26cd38ce-6e50-465e-8ca3-4b05067eb3f6@github.com> References: <5YtH4_WmOIvj2zm66tcDzzjrlx8QX3mE0dVA1VeTC_4=.26cd38ce-6e50-465e-8ca3-4b05067eb3f6@github.com> Message-ID: On Thu, 3 Sep 2020 08:05:08 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes JSON webrev use plain `git log` if the range of commits include a merge commits. > This is needed because `git log -c --follow` can be extremely slow for commit ranges with a lot of merge commits. > Testing: > - `make test` on Linux x64 > - Manual verification of performance > > Thanks, > Erik This pull request has now been integrated. Changeset: a3d4b353 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/a3d4b353 Stats: 8 lines in 1 file changed: 0 ins; 7 del; 1 mod webrev: do not use follow for ranges with merges Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/764 From rwestberg at openjdk.java.net Thu Sep 3 08:17:22 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 08:17:22 GMT Subject: RFR: Fix markdown mistake in reviewer link Message-ID: Hi all, Please review this trivial fix that creates proper markdown for the reviewer links. Best regards, Robin ------------- Commit messages: - Fix markdown mistake Changes: https://git.openjdk.java.net/skara/pull/765/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=765&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/765.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/765/head:pull/765 PR: https://git.openjdk.java.net/skara/pull/765 From ehelin at openjdk.java.net Thu Sep 3 08:20:26 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 3 Sep 2020 08:20:26 GMT Subject: RFR: Fix markdown mistake in reviewer link In-Reply-To: References: Message-ID: <7NDMJt-WHMEerOVMyb4ZWpdmQtCGldh5CHMu-PFtvw8=.8ec8168f-e644-41ed-99ed-66ef05dc9213@github.com> On Thu, 3 Sep 2020 08:14:31 GMT, Robin Westberg wrote: > Hi all, > > Please review this trivial fix that creates proper markdown for the reviewer links. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/765 From rwestberg at openjdk.java.net Thu Sep 3 08:20:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 08:20:26 GMT Subject: Integrated: Fix markdown mistake in reviewer link In-Reply-To: References: Message-ID: <0xsdb-idnBbj1iwfizAUTrUg4nNcKcGAed3duA_ycJc=.f02c74f4-7045-4039-a1dd-79bd628301a3@github.com> On Thu, 3 Sep 2020 08:14:31 GMT, Robin Westberg wrote: > Hi all, > > Please review this trivial fix that creates proper markdown for the reviewer links. > > Best regards, > Robin This pull request has now been integrated. Changeset: d15626cd Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/d15626cd Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Fix markdown mistake in reviewer link Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/765 From rwestberg at openjdk.java.net Thu Sep 3 11:46:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 11:46:29 GMT Subject: RFR: 545: Support additional forms of labels for the /cc command Message-ID: Hi all, Please review this small change that makes the `/cc` command a bit more intuitive. Best regards, Robin ------------- Commit messages: - Add support for ignoring certain label suffixes Changes: https://git.openjdk.java.net/skara/pull/766/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=766&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-545 Stats: 59 lines in 2 files changed: 57 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/766.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/766/head:pull/766 PR: https://git.openjdk.java.net/skara/pull/766 From ehelin at openjdk.java.net Thu Sep 3 12:05:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 3 Sep 2020 12:05:34 GMT Subject: RFR: 545: Support additional forms of labels for the /cc command In-Reply-To: References: Message-ID: On Thu, 3 Sep 2020 11:43:28 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that makes the `/cc` command a bit more intuitive. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/766 From rwestberg at openjdk.java.net Thu Sep 3 13:37:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 13:37:41 GMT Subject: RFR: Allow reading label configuration from a hosted repository file Message-ID: Hi all, Please review this change that allows the PR bot to read (and reread on updates) label configuration from a file instead of storing it in the configuration. Best regards, Robin ------------- Commit messages: - Allow reading label configuration from a hosted repository file Changes: https://git.openjdk.java.net/skara/pull/767/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=767&range=00 Stats: 420 lines in 9 files changed: 241 ins; 127 del; 52 mod Patch: https://git.openjdk.java.net/skara/pull/767.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/767/head:pull/767 PR: https://git.openjdk.java.net/skara/pull/767 From ehelin at openjdk.java.net Thu Sep 3 13:37:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 3 Sep 2020 13:37:42 GMT Subject: RFR: Allow reading label configuration from a hosted repository file In-Reply-To: References: Message-ID: On Thu, 3 Sep 2020 13:34:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the PR bot to read (and reread on updates) label configuration from a file > instead of storing it in the configuration. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/767 From rwestberg at openjdk.java.net Thu Sep 3 13:44:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 13:44:26 GMT Subject: RFR: Allow reading label configuration from a hosted repository file [v2] In-Reply-To: References: Message-ID: > Hi all, > > Please review this change that allows the PR bot to read (and reread on updates) label configuration from a file > instead of storing it in the configuration. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Do case-insensitive matching like the mlrules debug command ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/767/files - new: https://git.openjdk.java.net/skara/pull/767/files/f1015814..0e67f6c4 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=767&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=767&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/767.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/767/head:pull/767 PR: https://git.openjdk.java.net/skara/pull/767 From rwestberg at openjdk.java.net Thu Sep 3 15:08:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 3 Sep 2020 15:08:46 GMT Subject: Integrated: Allow reading label configuration from a hosted repository file In-Reply-To: References: Message-ID: On Thu, 3 Sep 2020 13:34:14 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that allows the PR bot to read (and reread on updates) label configuration from a file > instead of storing it in the configuration. > Best regards, > Robin This pull request has now been integrated. Changeset: 8d5ddd38 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/8d5ddd38 Stats: 420 lines in 9 files changed: 127 ins; 241 del; 52 mod Allow reading label configuration from a hosted repository file Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/767 From rwestberg at openjdk.java.net Fri Sep 4 07:39:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 07:39:34 GMT Subject: Integrated: 545: Support additional forms of labels for the /cc command In-Reply-To: References: Message-ID: On Thu, 3 Sep 2020 11:43:28 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that makes the `/cc` command a bit more intuitive. > > Best regards, > Robin This pull request has now been integrated. Changeset: 7a18b0b8 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/7a18b0b8 Stats: 59 lines in 2 files changed: 0 ins; 57 del; 2 mod 545: Support additional forms of labels for the /cc command Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/766 From rwestberg at openjdk.java.net Fri Sep 4 07:40:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 07:40:30 GMT Subject: Integrated: Cache the result of GitLab's current user Message-ID: Hi all, Please review this small change that improves the performance of GitLab's currentUser call. Best regards, Robin ------------- Commit messages: - Cache the result of GitLab's current user Changes: https://git.openjdk.java.net/skara/pull/768/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=768&range=00 Stats: 7 lines in 1 file changed: 6 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/768.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/768/head:pull/768 PR: https://git.openjdk.java.net/skara/pull/768 From ehelin at openjdk.java.net Fri Sep 4 07:40:30 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 07:40:30 GMT Subject: Integrated: Cache the result of GitLab's current user In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 07:36:29 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that improves the performance of GitLab's currentUser call. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/768 From rwestberg at openjdk.java.net Fri Sep 4 07:40:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 07:40:31 GMT Subject: Integrated: Cache the result of GitLab's current user In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 07:36:29 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that improves the performance of GitLab's currentUser call. > > Best regards, > Robin This pull request has now been integrated. Changeset: 07930a41 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/07930a41 Stats: 7 lines in 1 file changed: 0 ins; 6 del; 1 mod Cache the result of GitLab's current user Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/768 From ehelin at openjdk.java.net Fri Sep 4 08:29:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:29:02 GMT Subject: RFR: defpath: catch errors when creating a Forge Message-ID: Hi all, please review this patch that catches more errors in `git-defpath` when trying to create a `Forge` instance. Thanks, Erik ------------- Commit messages: - defpath: catch errors when creating a Forge Changes: https://git.openjdk.java.net/skara/pull/770/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=770&range=00 Stats: 20 lines in 1 file changed: 10 ins; 0 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/770.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/770/head:pull/770 PR: https://git.openjdk.java.net/skara/pull/770 From ehelin at openjdk.java.net Fri Sep 4 08:30:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:30:01 GMT Subject: Integrated: cli: remote git-expand command Message-ID: Hi all, please remove this patch that removes the very rarely used `git-expand` CLI command. `git-expand` does not carry its weight ever since we introduced automatic expanding of pull requests titles (done server-side via the bots). Testing: - [x] `make test` on Linux x64 - [x] `make` on Linux x64 - [x] Verified that `git-expand` is no longer present Thanks, Erik ------------- Commit messages: - cli: remote git-expand command Changes: https://git.openjdk.java.net/skara/pull/769/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=769&range=00 Stats: 160 lines in 2 files changed: 0 ins; 160 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/769.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/769/head:pull/769 PR: https://git.openjdk.java.net/skara/pull/769 From rwestberg at openjdk.java.net Fri Sep 4 08:30:01 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:30:01 GMT Subject: Integrated: cli: remote git-expand command In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:24:12 GMT, Erik Helin wrote: > Hi all, > > please remove this patch that removes the very rarely used `git-expand` CLI command. `git-expand` does not carry its > weight ever since we introduced automatic expanding of pull requests titles (done server-side via the bots). > Testing: > - [x] `make test` on Linux x64 > - [x] `make` on Linux x64 > - [x] Verified that `git-expand` is no longer present > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/769 From ehelin at openjdk.java.net Fri Sep 4 08:30:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:30:01 GMT Subject: Integrated: cli: remote git-expand command In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:24:12 GMT, Erik Helin wrote: > Hi all, > > please remove this patch that removes the very rarely used `git-expand` CLI command. `git-expand` does not carry its > weight ever since we introduced automatic expanding of pull requests titles (done server-side via the bots). > Testing: > - [x] `make test` on Linux x64 > - [x] `make` on Linux x64 > - [x] Verified that `git-expand` is no longer present > > Thanks, > Erik This pull request has now been integrated. Changeset: ba720a38 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ba720a38 Stats: 160 lines in 2 files changed: 160 ins; 0 del; 0 mod cli: remote git-expand command Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/769 From ehelin at openjdk.java.net Fri Sep 4 08:30:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:30:52 GMT Subject: RFR: fork: align --setup-pre-push-hook with jcheck Message-ID: Hi all, please review this patch that aligns the `--setup-pre-push-hook` for `git-fork` with the same option in `git-jcheck`. Thanks, Erik ------------- Commit messages: - fork: align --setup-pre-push-hook with jcheck Changes: https://git.openjdk.java.net/skara/pull/771/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=771&range=00 Stats: 6 lines in 1 file changed: 0 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/771.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/771/head:pull/771 PR: https://git.openjdk.java.net/skara/pull/771 From rwestberg at openjdk.java.net Fri Sep 4 08:34:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:34:20 GMT Subject: Integrated: Cache repeated calls for GitLab labels Message-ID: <_NuhWaQagi3JpIEZ9CubH3lWNvs8M5bny_UlTrCpSUk=.fb6ce204-82ad-4473-a88a-734ec4aa3e14@github.com> Hi all, Please review this small change that caches repeated calls to GitLab PR labels, similar to how GitHub does. Best regards, Robin ------------- Commit messages: - Cache repeated calls for GitLab labels Changes: https://git.openjdk.java.net/skara/pull/772/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=772&range=00 Stats: 16 lines in 1 file changed: 11 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/772.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/772/head:pull/772 PR: https://git.openjdk.java.net/skara/pull/772 From ehelin at openjdk.java.net Fri Sep 4 08:34:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:34:21 GMT Subject: Integrated: Cache repeated calls for GitLab labels In-Reply-To: <_NuhWaQagi3JpIEZ9CubH3lWNvs8M5bny_UlTrCpSUk=.fb6ce204-82ad-4473-a88a-734ec4aa3e14@github.com> References: <_NuhWaQagi3JpIEZ9CubH3lWNvs8M5bny_UlTrCpSUk=.fb6ce204-82ad-4473-a88a-734ec4aa3e14@github.com> Message-ID: On Fri, 4 Sep 2020 08:29:46 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that caches repeated calls to GitLab PR labels, similar to how GitHub does. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/772 From rwestberg at openjdk.java.net Fri Sep 4 08:34:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:34:21 GMT Subject: Integrated: Cache repeated calls for GitLab labels In-Reply-To: <_NuhWaQagi3JpIEZ9CubH3lWNvs8M5bny_UlTrCpSUk=.fb6ce204-82ad-4473-a88a-734ec4aa3e14@github.com> References: <_NuhWaQagi3JpIEZ9CubH3lWNvs8M5bny_UlTrCpSUk=.fb6ce204-82ad-4473-a88a-734ec4aa3e14@github.com> Message-ID: <5Cc2zSUTD1QbWSBTMkKV8QiSxk7EGaC06NILggGf5f4=.588ba2a1-bdfd-422e-813e-e99a1c02465f@github.com> On Fri, 4 Sep 2020 08:29:46 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that caches repeated calls to GitLab PR labels, similar to how GitHub does. > > Best regards, > Robin This pull request has now been integrated. Changeset: 496dc082 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/496dc082 Stats: 16 lines in 1 file changed: 0 ins; 11 del; 5 mod Cache repeated calls for GitLab labels Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/772 From rwestberg at openjdk.java.net Fri Sep 4 08:34:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:34:34 GMT Subject: RFR: defpath: catch errors when creating a Forge In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:26:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that catches more errors in `git-defpath` when trying to create a `Forge` instance. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/770 From ehelin at openjdk.java.net Fri Sep 4 08:34:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:34:35 GMT Subject: Integrated: defpath: catch errors when creating a Forge In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:26:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that catches more errors in `git-defpath` when trying to create a `Forge` instance. > > Thanks, > Erik This pull request has now been integrated. Changeset: fc938d93 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fc938d93 Stats: 20 lines in 1 file changed: 0 ins; 10 del; 10 mod defpath: catch errors when creating a Forge Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/770 From ehelin at openjdk.java.net Fri Sep 4 08:35:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:35:21 GMT Subject: Integrated: info: remove --mercurial and add --title Message-ID: <3ek7Lbnj2hgIs4VyX1VOqIdxCaYq3YjeVPQDzNeB9Pw=.e3c1af34-0db7-45f9-a4fd-63cdda2dae64@github.com> Hi all, please review this patch removes the unused `--mecurial` flag from `git-info` and also adds the missing `--title` flag (oops!). Thanks, Erik ------------- Commit messages: - info: remove --mercurial and add --title Changes: https://git.openjdk.java.net/skara/pull/773/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=773&range=00 Stats: 10 lines in 1 file changed: 4 ins; 5 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/773.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/773/head:pull/773 PR: https://git.openjdk.java.net/skara/pull/773 From rwestberg at openjdk.java.net Fri Sep 4 08:35:24 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:35:24 GMT Subject: RFR: fork: align --setup-pre-push-hook with jcheck In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:28:17 GMT, Erik Helin wrote: > Hi all, > > please review this patch that aligns the `--setup-pre-push-hook` for `git-fork` with the same option in `git-jcheck`. > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/771 From rwestberg at openjdk.java.net Fri Sep 4 08:35:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:35:21 GMT Subject: Integrated: info: remove --mercurial and add --title In-Reply-To: <3ek7Lbnj2hgIs4VyX1VOqIdxCaYq3YjeVPQDzNeB9Pw=.e3c1af34-0db7-45f9-a4fd-63cdda2dae64@github.com> References: <3ek7Lbnj2hgIs4VyX1VOqIdxCaYq3YjeVPQDzNeB9Pw=.e3c1af34-0db7-45f9-a4fd-63cdda2dae64@github.com> Message-ID: <6rg19DmKxLkkNLqzxgA7pdCzbnsHD598tmgHovgME6k=.f43bbc1a-61ff-4ab3-8796-6090d6087267@github.com> On Fri, 4 Sep 2020 08:31:37 GMT, Erik Helin wrote: > Hi all, > > please review this patch removes the unused `--mecurial` flag from `git-info` and also adds the missing `--title` flag > (oops!). > Thanks, > Erik Looks nice! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/773 From ehelin at openjdk.java.net Fri Sep 4 08:35:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:35:21 GMT Subject: Integrated: info: remove --mercurial and add --title In-Reply-To: <3ek7Lbnj2hgIs4VyX1VOqIdxCaYq3YjeVPQDzNeB9Pw=.e3c1af34-0db7-45f9-a4fd-63cdda2dae64@github.com> References: <3ek7Lbnj2hgIs4VyX1VOqIdxCaYq3YjeVPQDzNeB9Pw=.e3c1af34-0db7-45f9-a4fd-63cdda2dae64@github.com> Message-ID: <4bRB6BQE6nyI6bF99SNsL3KLyWzyR-J6UrpPQRS5Wws=.7a38654d-de9f-4255-9202-8138e7bb3d80@github.com> On Fri, 4 Sep 2020 08:31:37 GMT, Erik Helin wrote: > Hi all, > > please review this patch removes the unused `--mecurial` flag from `git-info` and also adds the missing `--title` flag > (oops!). > Thanks, > Erik This pull request has now been integrated. Changeset: 1b0bee8c Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/1b0bee8c Stats: 10 lines in 1 file changed: 5 ins; 4 del; 1 mod info: remove --mercurial and add --title Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/773 From ehelin at openjdk.java.net Fri Sep 4 08:35:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:35:24 GMT Subject: Integrated: fork: align --setup-pre-push-hook with jcheck In-Reply-To: References: Message-ID: <6QL8MWyIQ03dUECS0ygTGPj8gcIyKsj2FHf7Tfaqbeo=.8bfa725a-f3fa-49a9-9687-9e303933ee37@github.com> On Fri, 4 Sep 2020 08:28:17 GMT, Erik Helin wrote: > Hi all, > > please review this patch that aligns the `--setup-pre-push-hook` for `git-fork` with the same option in `git-jcheck`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 3c9a2da3 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/3c9a2da3 Stats: 6 lines in 1 file changed: 1 ins; 0 del; 5 mod fork: align --setup-pre-push-hook with jcheck Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/771 From ehelin at openjdk.java.net Fri Sep 4 08:43:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:43:39 GMT Subject: RFR: fork: fix helptext for --reference Message-ID: Hi all, please review this patch updates the helptext for the flag `--reference` of `git-fork` to say that `git-fork` will always use `--reference-if-able` together with `--dissociate` when cloning (for safety reasons). Thanks, Erik ------------- Commit messages: - fork: fix helptext for --reference Changes: https://git.openjdk.java.net/skara/pull/774/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=774&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/774.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/774/head:pull/774 PR: https://git.openjdk.java.net/skara/pull/774 From ehelin at openjdk.java.net Fri Sep 4 08:48:21 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:48:21 GMT Subject: RFR: publish: rename --follow to --browse Message-ID: Hi all, please rename this patch that renames the flag `--follow` to `--browse` for `git-publish` to make its meaning more clear. Thanks, Erik ------------- Commit messages: - publish: rename --follow to --browse Changes: https://git.openjdk.java.net/skara/pull/775/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=775&range=00 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/775.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/775/head:pull/775 PR: https://git.openjdk.java.net/skara/pull/775 From rwestberg at openjdk.java.net Fri Sep 4 08:50:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:50:06 GMT Subject: RFR: fork: fix helptext for --reference In-Reply-To: References: Message-ID: <6tpqb9_O8ZgMhuG-1jVDicPiR736LFg9wI0S4AJIBGk=.fdfffeff-d911-4b75-a81c-2c99a7896fd9@github.com> On Fri, 4 Sep 2020 08:41:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch updates the helptext for the flag `--reference` of `git-fork` to say that `git-fork` will > always use `--reference-if-able` together with `--dissociate` when cloning (for safety reasons). > Thanks, > Erik Looks fine! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/774 From ehelin at openjdk.java.net Fri Sep 4 08:51:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:51:45 GMT Subject: RFR: publish: rename --follow to --browse [v2] In-Reply-To: References: Message-ID: > Hi all, > > please rename this patch that renames the flag `--follow` to `--browse` for `git-publish` to make its meaning more > clear. > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Fix spelling Co-authored-by: Robin Westberg ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/775/files - new: https://git.openjdk.java.net/skara/pull/775/files/1142a800..91fd35f0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=775&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=775&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/775.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/775/head:pull/775 PR: https://git.openjdk.java.net/skara/pull/775 From rwestberg at openjdk.java.net Fri Sep 4 08:51:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:51:46 GMT Subject: RFR: publish: rename --follow to --browse [v2] In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:49:23 GMT, Erik Helin wrote: >> Hi all, >> >> please rename this patch that renames the flag `--follow` to `--browse` for `git-publish` to make its meaning more >> clear. >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Fix spelling > > Co-authored-by: Robin Westberg Looks good, just one spelling fix! cli/src/main/java/org/openjdk/skara/cli/GitPublish.java line 147: > 145: Switch.shortcut("") > 146: .fullname("browse") > 147: .helptext("Open link returend by remote in web browser") Suggestion: .helptext("Open link returned by remote in web browser") ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/775 From ehelin at openjdk.java.net Fri Sep 4 08:52:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 08:52:10 GMT Subject: RFR: skara: add -v, --version and -h, --help Message-ID: Hi all, please review this patch that adds the `-v`, `--version`, `-h` and `--help` flags to `git skara`. I also made sure that we don't print out the `debug` command, as it is only intended to be used by Skara developers. Thanks, Erik ------------- Commit messages: - skara: add -v, --version and -h, --help Changes: https://git.openjdk.java.net/skara/pull/776/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=776&range=00 Stats: 21 lines in 1 file changed: 17 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/776.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/776/head:pull/776 PR: https://git.openjdk.java.net/skara/pull/776 From rwestberg at openjdk.java.net Fri Sep 4 08:52:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 08:52:10 GMT Subject: RFR: skara: add -v, --version and -h, --help In-Reply-To: References: Message-ID: <4SDmM4h__Ogvcor5UVSoLgihWrFMqcxy1-27YiFrYg0=.2411f0e9-ca30-4172-8dcd-9716af918140@github.com> On Fri, 4 Sep 2020 08:48:47 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `-v`, `--version`, `-h` and `--help` flags to `git skara`. I also made sure that > we don't print out the `debug` command, as it is only intended to be used by Skara developers. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/776 From ehelin at openjdk.java.net Fri Sep 4 09:38:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 09:38:34 GMT Subject: Integrated: fork: fix helptext for --reference In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:41:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch updates the helptext for the flag `--reference` of `git-fork` to say that `git-fork` will > always use `--reference-if-able` together with `--dissociate` when cloning (for safety reasons). > Thanks, > Erik This pull request has now been integrated. Changeset: 6fb4c6ee Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/6fb4c6ee Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod fork: fix helptext for --reference Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/774 From rwestberg at openjdk.java.net Fri Sep 4 09:44:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 09:44:40 GMT Subject: RFR: Fix build error Message-ID: Hi all, Please review this small change that fixes a build error. Best regards, Robin ------------- Commit messages: - Fix build error Changes: https://git.openjdk.java.net/skara/pull/777/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=777&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/777.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/777/head:pull/777 PR: https://git.openjdk.java.net/skara/pull/777 From ehelin at openjdk.java.net Fri Sep 4 09:44:41 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 09:44:41 GMT Subject: RFR: Fix build error In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 09:41:45 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes a build error. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/777 From ihse at openjdk.java.net Fri Sep 4 09:47:31 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 4 Sep 2020 09:47:31 GMT Subject: RFR: Improve "git pr help" Message-ID: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> The help texts were never shown for the "git pr" sub-commands. ------------- Commit messages: - Improve "git pr help" Changes: https://git.openjdk.java.net/skara/pull/778/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=778&range=00 Stats: 81 lines in 3 files changed: 14 ins; 0 del; 67 mod Patch: https://git.openjdk.java.net/skara/pull/778.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/778/head:pull/778 PR: https://git.openjdk.java.net/skara/pull/778 From rwestberg at openjdk.java.net Fri Sep 4 09:47:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 09:47:47 GMT Subject: Integrated: Fix build error In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 09:41:45 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes a build error. > > Best regards, > Robin This pull request has now been integrated. Changeset: 0b3457fd Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/0b3457fd Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Fix build error Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/777 From ehelin at openjdk.java.net Fri Sep 4 09:54:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 09:54:57 GMT Subject: RFR: Improve "git pr help" In-Reply-To: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> References: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> Message-ID: <9EFp5jW2FRh7pmFtLHOyMSkzoMpSX3LbEHLAhi5vT-I=.28b50ee0-a19e-40a3-b3e7-4da75355bf0b@github.com> On Fri, 4 Sep 2020 09:44:52 GMT, Magnus Ihse Bursie wrote: > The help texts were never shown for the "git pr" sub-commands. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/778 From ehelin at openjdk.java.net Fri Sep 4 09:57:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 09:57:15 GMT Subject: Integrated: publish: rename --follow to --browse In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:45:45 GMT, Erik Helin wrote: > Hi all, > > please rename this patch that renames the flag `--follow` to `--browse` for `git-publish` to make its meaning more > clear. > Thanks, > Erik This pull request has now been integrated. Changeset: dc3276db Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/dc3276db Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod publish: rename --follow to --browse Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/775 From ehelin at openjdk.java.net Fri Sep 4 09:57:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 09:57:35 GMT Subject: Integrated: skara: add -v, --version and -h, --help In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 08:48:47 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `-v`, `--version`, `-h` and `--help` flags to `git skara`. I also made sure that > we don't print out the `debug` command, as it is only intended to be used by Skara developers. > Thanks, > Erik This pull request has now been integrated. Changeset: fd58cb63 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fd58cb63 Stats: 21 lines in 1 file changed: 0 ins; 17 del; 4 mod skara: add -v, --version and -h, --help Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/776 From ihse at openjdk.java.net Fri Sep 4 09:58:05 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 4 Sep 2020 09:58:05 GMT Subject: RFR: Improve "git pr help" [v2] In-Reply-To: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> References: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> Message-ID: <6fh42MmoTkFrIQqTKLEam9nEd4mGAqhfcf84z_5EqEk=.09483aa3-3049-4992-82aa-dde9a527bd6e@github.com> > The help texts were never shown for the "git pr" sub-commands. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Fix build error Reviewed-by: ehelin ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/778/files - new: https://git.openjdk.java.net/skara/pull/778/files/8603021f..2da6890f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=778&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=778&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/778.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/778/head:pull/778 PR: https://git.openjdk.java.net/skara/pull/778 From ehelin at openjdk.java.net Fri Sep 4 10:01:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:01:01 GMT Subject: RFR: sync: catch exceptions when creating Forge Message-ID: <9wau0tTLHFumnPq1hEmDF5eRTjmJLEzlaZzON_AiuaA=.54be6c3a-be7c-4dd6-b4bd-10f4843cf709@github.com> Hi all, please review this patch that makes `git-sync` prints a more informative error message when the `Forge` can't be instantiated when trying to auto-magically figure out the "upstream" repository. Thanks, Erik ------------- Commit messages: - sync: catch exceptions when creating Forge Changes: https://git.openjdk.java.net/skara/pull/779/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=779&range=00 Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/779.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/779/head:pull/779 PR: https://git.openjdk.java.net/skara/pull/779 From ihse at openjdk.java.net Fri Sep 4 10:08:46 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 4 Sep 2020 10:08:46 GMT Subject: RFR: Improve "git pr help" [v3] In-Reply-To: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> References: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> Message-ID: > The help texts were never shown for the "git pr" sub-commands. Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision: Fix merge error ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/778/files - new: https://git.openjdk.java.net/skara/pull/778/files/2da6890f..c0787c92 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=778&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=778&range=01-02 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/778.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/778/head:pull/778 PR: https://git.openjdk.java.net/skara/pull/778 From rwestberg at openjdk.java.net Fri Sep 4 10:10:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 10:10:55 GMT Subject: RFR: sync: catch exceptions when creating Forge In-Reply-To: <9wau0tTLHFumnPq1hEmDF5eRTjmJLEzlaZzON_AiuaA=.54be6c3a-be7c-4dd6-b4bd-10f4843cf709@github.com> References: <9wau0tTLHFumnPq1hEmDF5eRTjmJLEzlaZzON_AiuaA=.54be6c3a-be7c-4dd6-b4bd-10f4843cf709@github.com> Message-ID: On Fri, 4 Sep 2020 09:58:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` prints a more informative error message when the `Forge` can't be > instantiated when trying to auto-magically figure out the "upstream" repository. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/779 From ehelin at openjdk.java.net Fri Sep 4 10:12:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:12:10 GMT Subject: RFR: token: handle arguments without scheme and add help message Message-ID: Hi all, please review this patch that makes `git-token` print a more informative message when the user is about to enter the token. Also made sure that `git token store .com` works by adding `https://` (there are currently no forges that serves over plain HTTP). Thanks, Erik ------------- Commit messages: - token: handle arguments without scheme and add help message Changes: https://git.openjdk.java.net/skara/pull/780/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=780&range=00 Stats: 5 lines in 1 file changed: 5 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/780.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/780/head:pull/780 PR: https://git.openjdk.java.net/skara/pull/780 From rwestberg at openjdk.java.net Fri Sep 4 10:12:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 10:12:10 GMT Subject: RFR: token: handle arguments without scheme and add help message In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:07:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-token` print a more informative message when the user is about to enter the > token. Also made sure that `git token store .com` works by adding `https://` (there are currently no forges that > serves over plain HTTP). Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/780 From ehelin at openjdk.java.net Fri Sep 4 10:12:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:12:32 GMT Subject: RFR: translate: better helptext for --map Message-ID: Hi all, please review this small patch that updates the helptext for `git translate --map`. Thanks, Erik ------------- Commit messages: - translate: better helptext for --map Changes: https://git.openjdk.java.net/skara/pull/781/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=781&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/781.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/781/head:pull/781 PR: https://git.openjdk.java.net/skara/pull/781 From rwestberg at openjdk.java.net Fri Sep 4 10:12:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 10:12:33 GMT Subject: RFR: translate: better helptext for --map In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:09:16 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that updates the helptext for `git translate --map`. > > Thanks, > Erik Looks fine! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/781 From ehelin at openjdk.java.net Fri Sep 4 10:26:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:26:04 GMT Subject: Integrated: sync: catch exceptions when creating Forge In-Reply-To: <9wau0tTLHFumnPq1hEmDF5eRTjmJLEzlaZzON_AiuaA=.54be6c3a-be7c-4dd6-b4bd-10f4843cf709@github.com> References: <9wau0tTLHFumnPq1hEmDF5eRTjmJLEzlaZzON_AiuaA=.54be6c3a-be7c-4dd6-b4bd-10f4843cf709@github.com> Message-ID: On Fri, 4 Sep 2020 09:58:26 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` prints a more informative error message when the `Forge` can't be > instantiated when trying to auto-magically figure out the "upstream" repository. > Thanks, > Erik This pull request has now been integrated. Changeset: db91d71f Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/db91d71f Stats: 4 lines in 1 file changed: 0 ins; 2 del; 2 mod sync: catch exceptions when creating Forge Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/779 From ehelin at openjdk.java.net Fri Sep 4 10:26:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:26:53 GMT Subject: Integrated: token: handle arguments without scheme and add help message In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:07:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-token` print a more informative message when the user is about to enter the > token. Also made sure that `git token store .com` works by adding `https://` (there are currently no forges that > serves over plain HTTP). Thanks, > Erik This pull request has now been integrated. Changeset: b0922e06 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b0922e06 Stats: 5 lines in 1 file changed: 0 ins; 5 del; 0 mod token: handle arguments without scheme and add help message Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/780 From ehelin at openjdk.java.net Fri Sep 4 10:27:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:27:05 GMT Subject: Integrated: translate: better helptext for --map In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:09:16 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that updates the helptext for `git translate --map`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 889b360f Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/889b360f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod translate: better helptext for --map Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/781 From ehelin at openjdk.java.net Fri Sep 4 10:36:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 10:36:10 GMT Subject: RFR: webrev: better helptext for flags Message-ID: Hi all, please review this patch that updates the helptext for the webrev flags. Thanks, Erik ------------- Commit messages: - webrev: better helptext for flags Changes: https://git.openjdk.java.net/skara/pull/782/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=782&range=00 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/782.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/782/head:pull/782 PR: https://git.openjdk.java.net/skara/pull/782 From rwestberg at openjdk.java.net Fri Sep 4 10:36:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 10:36:11 GMT Subject: RFR: webrev: better helptext for flags In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:31:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that updates the helptext for the webrev flags. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/782 From ehelin at openjdk.java.net Fri Sep 4 12:28:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 12:28:34 GMT Subject: Integrated: webrev: better helptext for flags In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 10:31:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that updates the helptext for the webrev flags. > > Thanks, > Erik This pull request has now been integrated. Changeset: af124a15 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/af124a15 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod webrev: better helptext for flags Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/782 From rwestberg at openjdk.java.net Fri Sep 4 12:46:21 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 12:46:21 GMT Subject: RFR: 553: Add informational message when automatic labeling comes up empty Message-ID: Hi all, Please review this change that makes the automatic labeler emit a helpful message when it either succeeds or fails with its task. Best regards, Robin ------------- Commit messages: - Add auto-labeller help message when appropriate Changes: https://git.openjdk.java.net/skara/pull/783/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=783&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-553 Stats: 68 lines in 3 files changed: 66 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/783.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/783/head:pull/783 PR: https://git.openjdk.java.net/skara/pull/783 From ehelin at openjdk.java.net Fri Sep 4 12:48:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 12:48:24 GMT Subject: RFR: 553: Add informational message when automatic labeling comes up empty In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 12:43:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that makes the automatic labeler emit a helpful message when it either succeeds or fails with > its task. > Best regards, > Robin Looks really nice, great work @rwestberg! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/783 From rwestberg at openjdk.java.net Fri Sep 4 12:52:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 12:52:25 GMT Subject: Integrated: 553: Add informational message when automatic labeling comes up empty In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 12:43:32 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that makes the automatic labeler emit a helpful message when it either succeeds or fails with > its task. > Best regards, > Robin This pull request has now been integrated. Changeset: f705138a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f705138a Stats: 68 lines in 3 files changed: 0 ins; 66 del; 2 mod 553: Add informational message when automatic labeling comes up empty Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/783 From ihse at openjdk.java.net Fri Sep 4 13:22:30 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 4 Sep 2020 13:22:30 GMT Subject: Integrated: Improve "git pr help" In-Reply-To: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> References: <_Z3vLgzzbBQenGfUd6BO8d7Wdk3NHuvvRE994yIYz5A=.d926caaf-c9b7-4294-acd4-578638db72c4@github.com> Message-ID: On Fri, 4 Sep 2020 09:44:52 GMT, Magnus Ihse Bursie wrote: > The help texts were never shown for the "git pr" sub-commands. This pull request has now been integrated. Changeset: 65d45ce2 Author: Magnus Ihse Bursie Committer: Erik Helin URL: https://git.openjdk.java.net/skara/commit/65d45ce2 Stats: 144 lines in 3 files changed: 63 ins; 77 del; 4 mod Improve "git pr help" Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/778 From rwestberg at openjdk.java.net Fri Sep 4 13:25:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 13:25:26 GMT Subject: RFR: Avoid posting Jira link comments multiple times Message-ID: <1VZUuagppCDh2q7WQFyqI0IsYV6rdsoyoZTmbAk7bto=.f794019b-eda9-44ad-b177-780cab43070e@github.com> Hi all, Please review this change that avoids potentially posting the same Jira link comment multiple times. Best regards, Robin ------------- Commit messages: - Avoid doubleposting Changes: https://git.openjdk.java.net/skara/pull/784/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=784&range=00 Stats: 9 lines in 1 file changed: 9 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/784.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/784/head:pull/784 PR: https://git.openjdk.java.net/skara/pull/784 From ehelin at openjdk.java.net Fri Sep 4 13:26:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 13:26:17 GMT Subject: RFR: jcheck: allow configurable census URL Message-ID: Hi all, please review this patch that makes it possible to configure a URL to the census.xml in a .jcheck/configuration file. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - jcheck: allow configurable census URL Changes: https://git.openjdk.java.net/skara/pull/785/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=785&range=00 Stats: 21 lines in 2 files changed: 18 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/785.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/785/head:pull/785 PR: https://git.openjdk.java.net/skara/pull/785 From rwestberg at openjdk.java.net Fri Sep 4 13:29:07 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 13:29:07 GMT Subject: RFR: jcheck: allow configurable census URL In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 13:23:38 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible to configure a URL to the census.xml in a .jcheck/configuration file. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/785 From ehelin at openjdk.java.net Fri Sep 4 13:32:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 13:32:50 GMT Subject: Integrated: jcheck: allow configurable census URL In-Reply-To: References: Message-ID: <5MBy6DrKLk47pw1BLsnpXSCfhjWSaqL1PT9P9KTC0JA=.ae0fd66a-8fb7-425f-91dc-ea60c9a35882@github.com> On Fri, 4 Sep 2020 13:23:38 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible to configure a URL to the census.xml in a .jcheck/configuration file. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: ca0fdff1 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ca0fdff1 Stats: 21 lines in 2 files changed: 0 ins; 18 del; 3 mod jcheck: allow configurable census URL Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/785 From ehelin at openjdk.java.net Fri Sep 4 13:33:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 13:33:40 GMT Subject: RFR: Avoid posting Jira link comments multiple times In-Reply-To: <1VZUuagppCDh2q7WQFyqI0IsYV6rdsoyoZTmbAk7bto=.f794019b-eda9-44ad-b177-780cab43070e@github.com> References: <1VZUuagppCDh2q7WQFyqI0IsYV6rdsoyoZTmbAk7bto=.f794019b-eda9-44ad-b177-780cab43070e@github.com> Message-ID: On Fri, 4 Sep 2020 13:22:52 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that avoids potentially posting the same Jira link comment multiple times. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/784 From rwestberg at openjdk.java.net Fri Sep 4 13:33:40 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 13:33:40 GMT Subject: Integrated: Avoid posting Jira link comments multiple times In-Reply-To: <1VZUuagppCDh2q7WQFyqI0IsYV6rdsoyoZTmbAk7bto=.f794019b-eda9-44ad-b177-780cab43070e@github.com> References: <1VZUuagppCDh2q7WQFyqI0IsYV6rdsoyoZTmbAk7bto=.f794019b-eda9-44ad-b177-780cab43070e@github.com> Message-ID: On Fri, 4 Sep 2020 13:22:52 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that avoids potentially posting the same Jira link comment multiple times. > > Best regards, > Robin This pull request has now been integrated. Changeset: a55a6917 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/a55a6917 Stats: 9 lines in 1 file changed: 0 ins; 9 del; 0 mod Avoid posting Jira link comments multiple times Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/784 From ihse at openjdk.java.net Fri Sep 4 13:58:56 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Fri, 4 Sep 2020 13:58:56 GMT Subject: RFR: Include 'treconfigure' in help for git trees Message-ID: <9DaeqlOSCgLNe-uTvt0w4WQ-xmSGehAVhOcw0ITWWrk=.b73316e4-e486-413a-a1f6-965995063e33@github.com> This fix makes "git trees --help" a bit more helpful. It also add missing newline separating sub-repos in output. ------------- Commit messages: - Include 'treconfigure' in help for git trees Changes: https://git.openjdk.java.net/skara/pull/786/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=786&range=00 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/786.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/786/head:pull/786 PR: https://git.openjdk.java.net/skara/pull/786 From ehelin at openjdk.java.net Fri Sep 4 13:58:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 4 Sep 2020 13:58:57 GMT Subject: RFR: Include 'treconfigure' in help for git trees In-Reply-To: <9DaeqlOSCgLNe-uTvt0w4WQ-xmSGehAVhOcw0ITWWrk=.b73316e4-e486-413a-a1f6-965995063e33@github.com> References: <9DaeqlOSCgLNe-uTvt0w4WQ-xmSGehAVhOcw0ITWWrk=.b73316e4-e486-413a-a1f6-965995063e33@github.com> Message-ID: On Fri, 4 Sep 2020 13:55:09 GMT, Magnus Ihse Bursie wrote: > This fix makes "git trees --help" a bit more helpful. It also add missing newline separating sub-repos in output. Looks good ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/786 From rwestberg at openjdk.java.net Fri Sep 4 15:08:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 15:08:17 GMT Subject: RFR: Avoid running the labeler if there are none configured Message-ID: Hi all, Please review this small change that fixes a few test failures. Best regards, Robin ------------- Commit messages: - Avoid running the labeler if there are none configured Changes: https://git.openjdk.java.net/skara/pull/787/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=787&range=00 Stats: 3 lines in 1 file changed: 3 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/787.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/787/head:pull/787 PR: https://git.openjdk.java.net/skara/pull/787 From rwestberg at openjdk.java.net Fri Sep 4 15:42:31 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 15:42:31 GMT Subject: RFR: Avoid running the labeler if there are none configured [v2] In-Reply-To: References: Message-ID: <4X5vL8NCUwHYNaqP8zEvm0a7jdVVCsu1rK7edo8gR5M=.a7361c8b-abe5-459b-af5c-c93ba9a9da89@github.com> > Hi all, > > Please review this small change that fixes a few test failures. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Some more test fixes ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/787/files - new: https://git.openjdk.java.net/skara/pull/787/files/566ad08e..d2ea02ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=787&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=787&range=00-01 Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/787.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/787/head:pull/787 PR: https://git.openjdk.java.net/skara/pull/787 From rwestberg at openjdk.java.net Fri Sep 4 17:28:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 4 Sep 2020 17:28:57 GMT Subject: Integrated: Avoid running the labeler if there are none configured In-Reply-To: References: Message-ID: On Fri, 4 Sep 2020 15:05:44 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that fixes a few test failures. > > Best regards, > Robin This pull request has now been integrated. Changeset: 8e4c19c5 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/8e4c19c5 Stats: 5 lines in 2 files changed: 0 ins; 5 del; 0 mod Avoid running the labeler if there are none configured Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/787 From raffaello.giulietti at gmail.com Fri Sep 4 21:02:40 2020 From: raffaello.giulietti at gmail.com (Raffaello Giulietti) Date: Fri, 4 Sep 2020 23:02:40 +0200 Subject: Skara CLI tools want to download JDK Message-ID: Hi, seems that Skara CLI tools need to download a JDK for some reason: > git info 65d45ce242 Compiling ... Downloading JDK... % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 0 189M 0 818k 0 0 486k 0 0:06:38 0:00:01 0:06:37 485k^C What am I doing incorrectly? Of course, I have a valid JAVA_HOME env var pointing to OpenJDK 14. Greetings Raffaello From erik.helin at oracle.com Sat Sep 5 06:09:21 2020 From: erik.helin at oracle.com (Erik Helin) Date: Sat, 5 Sep 2020 08:09:21 +0200 Subject: Skara CLI tools want to download JDK In-Reply-To: References: Message-ID: On 9/4/20 11:02 PM, Raffaello Giulietti wrote: > Hi, > > seems that Skara CLI tools need to download a JDK for some reason: > > > git info 65d45ce242 > Compiling ... > Downloading JDK... > ? % Total??? % Received % Xferd? Average Speed?? Time??? Time???? Time > Current > ???????????????????????????????? Dload? Upload?? Total?? Spent??? Left > Speed > ? 0? 189M??? 0? 818k??? 0???? 0?? 486k????? 0? 0:06:38? 0:00:01 > 0:06:37? 485k^C > > What am I doing incorrectly? Of course, I have a valid JAVA_HOME env var > pointing to OpenJDK 14. Nothing, the Skara CLI tools downloads a JDK by default to bootstrap themselves :) Skara can also be built in "offline" mode where you to have to supply your own JDK an Gradle, see the Skara README.md [0] for more details. Thanks, Erik [0]: https://github.com/openjdk/skara/blob/master/README.md#offline-builds > Greetings > Raffaello From ehelin at openjdk.java.net Sat Sep 5 07:15:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:15:11 GMT Subject: RFR: git-pr: remove --no-commit from git apply Message-ID: <_UtKrZo1KKB5BGdkR3leCF8PAN8FSg-y_h4-XcUUqYU=.6c68b64c-04d9-4ba3-9f54-bf079d2b1319@github.com> Hi all, please review this patch that removes `--no-commit` from `git apply` in `pr/Utils.java` (a left-over from some Mercurial experimentation). Thanks, Erik ------------- Commit messages: - git-pr: remove --no-commit from git apply Changes: https://git.openjdk.java.net/skara/pull/788/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=788&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/788.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/788/head:pull/788 PR: https://git.openjdk.java.net/skara/pull/788 From rwestberg at openjdk.java.net Sat Sep 5 07:15:11 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:15:11 GMT Subject: RFR: git-pr: remove --no-commit from git apply In-Reply-To: <_UtKrZo1KKB5BGdkR3leCF8PAN8FSg-y_h4-XcUUqYU=.6c68b64c-04d9-4ba3-9f54-bf079d2b1319@github.com> References: <_UtKrZo1KKB5BGdkR3leCF8PAN8FSg-y_h4-XcUUqYU=.6c68b64c-04d9-4ba3-9f54-bf079d2b1319@github.com> Message-ID: On Sat, 5 Sep 2020 07:10:38 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes `--no-commit` from `git apply` in `pr/Utils.java` (a left-over from some > Mercurial experimentation). > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/788 From ehelin at openjdk.java.net Sat Sep 5 07:16:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:16:22 GMT Subject: RFR: git-pr-test: add flags --job and --approve Message-ID: Hi all, please review this patch that adds the `--job` and `--approve` flags to `git pr test`. Thanks, Erik ------------- Commit messages: - git-pr-test: add flags --job and --approve Changes: https://git.openjdk.java.net/skara/pull/790/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=790&range=00 Stats: 18 lines in 1 file changed: 16 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/790.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/790/head:pull/790 PR: https://git.openjdk.java.net/skara/pull/790 From ehelin at openjdk.java.net Sat Sep 5 07:16:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:16:44 GMT Subject: RFR: git-pr-approve: allow configurable message Message-ID: Hi all, please review this patch that allows a configurable message for `git-pr approve` via the `-m, --message` flag. Thanks, Erik ------------- Commit messages: - git-pr-approve: allow configurable message Changes: https://git.openjdk.java.net/skara/pull/789/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=789&range=00 Stats: 13 lines in 2 files changed: 11 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/789.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/789/head:pull/789 PR: https://git.openjdk.java.net/skara/pull/789 From rwestberg at openjdk.java.net Sat Sep 5 07:16:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:16:44 GMT Subject: RFR: git-pr-approve: allow configurable message In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:12:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows a configurable message for `git-pr approve` via the `-m, --message` flag. > > Thanks, > Erik Looks good, as they say! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/789 From ehelin at openjdk.java.net Sat Sep 5 07:17:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:17:51 GMT Subject: RFR: git-pr: git pr sponsor should sponsor Message-ID: Hi all, please review this patch that makes `git pr sponsor` actually run `GitPrSponsor::main`, _not_ `GitPrSet::main`. Thanks, Erik ------------- Commit messages: - git-pr: git pr sponsor should sponsor Changes: https://git.openjdk.java.net/skara/pull/791/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=791&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/791.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/791/head:pull/791 PR: https://git.openjdk.java.net/skara/pull/791 From rwestberg at openjdk.java.net Sat Sep 5 07:18:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:18:36 GMT Subject: RFR: git-pr-test: add flags --job and --approve In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:13:40 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--job` and `--approve` flags to `git pr test`. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/790 From rwestberg at openjdk.java.net Sat Sep 5 07:21:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:21:19 GMT Subject: RFR: git-pr: git pr sponsor should sponsor In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:15:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git pr sponsor` actually run `GitPrSponsor::main`, _not_ `GitPrSet::main`. > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/791 From ehelin at openjdk.java.net Sat Sep 5 07:21:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:21:47 GMT Subject: RFR: git-pr-checkout: better helptext Message-ID: <1wunXVVc8SFMbcyfXMhR2zrRPDfyRQmUo3Nc5spVsVI=.6337b397-5e89-4991-8ef6-7c807adf16c4@github.com> Hi all, please review this patch that slightly updates the helptext for the `-b, --branch` flag for `git pr checkout` to make it align more with Git's helptext for the `-b, --branch` option to `git checkout`. Thanks, Erik ------------- Commit messages: - git-pr-checkout: better helptext Changes: https://git.openjdk.java.net/skara/pull/792/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=792&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/792.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/792/head:pull/792 PR: https://git.openjdk.java.net/skara/pull/792 From rwestberg at openjdk.java.net Sat Sep 5 07:21:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:21:47 GMT Subject: RFR: git-pr-checkout: better helptext In-Reply-To: <1wunXVVc8SFMbcyfXMhR2zrRPDfyRQmUo3Nc5spVsVI=.6337b397-5e89-4991-8ef6-7c807adf16c4@github.com> References: <1wunXVVc8SFMbcyfXMhR2zrRPDfyRQmUo3Nc5spVsVI=.6337b397-5e89-4991-8ef6-7c807adf16c4@github.com> Message-ID: On Sat, 5 Sep 2020 07:18:29 GMT, Erik Helin wrote: > Hi all, > > please review this patch that slightly updates the helptext for the `-b, --branch` flag for `git pr checkout` to make > it align more with Git's helptext for the `-b, --branch` option to `git checkout`. > Thanks, > Erik Looks nice! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/792 From ihse at openjdk.java.net Sat Sep 5 07:22:46 2020 From: ihse at openjdk.java.net (Magnus Ihse Bursie) Date: Sat, 5 Sep 2020 07:22:46 GMT Subject: Integrated: Include 'treconfigure' in help for git trees In-Reply-To: <9DaeqlOSCgLNe-uTvt0w4WQ-xmSGehAVhOcw0ITWWrk=.b73316e4-e486-413a-a1f6-965995063e33@github.com> References: <9DaeqlOSCgLNe-uTvt0w4WQ-xmSGehAVhOcw0ITWWrk=.b73316e4-e486-413a-a1f6-965995063e33@github.com> Message-ID: On Fri, 4 Sep 2020 13:55:09 GMT, Magnus Ihse Bursie wrote: > This fix makes "git trees --help" a bit more helpful. It also add missing newline separating sub-repos in output. This pull request has now been integrated. Changeset: ecbeb097 Author: Magnus Ihse Bursie Committer: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ecbeb097 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Include 'treconfigure' in help for git trees Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/786 From ehelin at openjdk.java.net Sat Sep 5 07:23:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:23:16 GMT Subject: Integrated: git-pr: remove --no-commit from git apply In-Reply-To: <_UtKrZo1KKB5BGdkR3leCF8PAN8FSg-y_h4-XcUUqYU=.6c68b64c-04d9-4ba3-9f54-bf079d2b1319@github.com> References: <_UtKrZo1KKB5BGdkR3leCF8PAN8FSg-y_h4-XcUUqYU=.6c68b64c-04d9-4ba3-9f54-bf079d2b1319@github.com> Message-ID: <6ibloEPLmsbhEqicPLoQMzkYJUtYjowJMlGyhVbGnqQ=.ca7ad15f-c784-48b8-9362-0fde74f2df56@github.com> On Sat, 5 Sep 2020 07:10:38 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes `--no-commit` from `git apply` in `pr/Utils.java` (a left-over from some > Mercurial experimentation). > Thanks, > Erik This pull request has now been integrated. Changeset: fbac52c4 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fbac52c4 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod git-pr: remove --no-commit from git apply Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/788 From ehelin at openjdk.java.net Sat Sep 5 07:23:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:23:31 GMT Subject: RFR: git-pr-fetch: remove --branch option Message-ID: Hi all, please review this patch that removes the `--branch` option from `git pr fetch` to make `git pr fetch` align better with `git fetch`. Thanks, Erik ------------- Commit messages: - git-pr-fetch: remove --branch option Changes: https://git.openjdk.java.net/skara/pull/793/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=793&range=00 Stats: 11 lines in 1 file changed: 0 ins; 10 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/793.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/793/head:pull/793 PR: https://git.openjdk.java.net/skara/pull/793 From rwestberg at openjdk.java.net Sat Sep 5 07:23:32 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:23:32 GMT Subject: RFR: git-pr-fetch: remove --branch option In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:20:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the `--branch` option from `git pr fetch` to make `git pr fetch` align better > with `git fetch`. > Thanks, > Erik Looks fine! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/793 From ehelin at openjdk.java.net Sat Sep 5 07:23:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:23:47 GMT Subject: Integrated: git-pr-test: add flags --job and --approve In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:13:40 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `--job` and `--approve` flags to `git pr test`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 9b249685 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/9b249685 Stats: 18 lines in 1 file changed: 0 ins; 16 del; 2 mod git-pr-test: add flags --job and --approve Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/790 From ehelin at openjdk.java.net Sat Sep 5 07:26:54 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:26:54 GMT Subject: Integrated: git-pr-checkout: better helptext In-Reply-To: <1wunXVVc8SFMbcyfXMhR2zrRPDfyRQmUo3Nc5spVsVI=.6337b397-5e89-4991-8ef6-7c807adf16c4@github.com> References: <1wunXVVc8SFMbcyfXMhR2zrRPDfyRQmUo3Nc5spVsVI=.6337b397-5e89-4991-8ef6-7c807adf16c4@github.com> Message-ID: <70lgme0r0Up3I5RvQfEgzhH6pEyM5Ysios7HL8ABdV0=.36667241-21bc-4f7b-ad08-2b7feb372506@github.com> On Sat, 5 Sep 2020 07:18:29 GMT, Erik Helin wrote: > Hi all, > > please review this patch that slightly updates the helptext for the `-b, --branch` flag for `git pr checkout` to make > it align more with Git's helptext for the `-b, --branch` option to `git checkout`. > Thanks, > Erik This pull request has now been integrated. Changeset: 13771031 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/13771031 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod git-pr-checkout: better helptext Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/792 From ehelin at openjdk.java.net Sat Sep 5 07:27:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:27:04 GMT Subject: Integrated: git-pr-fetch: remove --branch option In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:20:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes the `--branch` option from `git pr fetch` to make `git pr fetch` align better > with `git fetch`. > Thanks, > Erik This pull request has now been integrated. Changeset: 2e89e20b Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2e89e20b Stats: 11 lines in 1 file changed: 10 ins; 0 del; 1 mod git-pr-fetch: remove --branch option Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/793 From ehelin at openjdk.java.net Sat Sep 5 07:27:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:27:23 GMT Subject: Integrated: git-pr-approve: allow configurable message In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:12:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows a configurable message for `git-pr approve` via the `-m, --message` flag. > > Thanks, > Erik This pull request has now been integrated. Changeset: ea08e685 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ea08e685 Stats: 13 lines in 2 files changed: 0 ins; 11 del; 2 mod git-pr-approve: allow configurable message Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/789 From ehelin at openjdk.java.net Sat Sep 5 07:28:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:28:24 GMT Subject: Integrated: git-pr: git pr sponsor should sponsor In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:15:05 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git pr sponsor` actually run `GitPrSponsor::main`, _not_ `GitPrSet::main`. > > Thanks, > Erik This pull request has now been integrated. Changeset: 6a3e3468 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/6a3e3468 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod git-pr: git pr sponsor should sponsor Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/791 From rwestberg at openjdk.java.net Sat Sep 5 07:33:50 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:33:50 GMT Subject: RFR: 550: "branch has unmerged commits" message could be clarified by the bot Message-ID: Hi all, Please review this change that improves the final integrated message. Best regards, Robin ------------- Commit messages: - Add a notice about the closed message. - Only show up to 10 commits in the final integration message Changes: https://git.openjdk.java.net/skara/pull/794/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=794&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-550 Stats: 33 lines in 3 files changed: 26 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/794.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/794/head:pull/794 PR: https://git.openjdk.java.net/skara/pull/794 From ehelin at openjdk.java.net Sat Sep 5 07:38:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 07:38:05 GMT Subject: RFR: 550: "branch has unmerged commits" message could be clarified by the bot In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:29:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the final integrated message. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/794 From rwestberg at openjdk.java.net Sat Sep 5 07:44:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 07:44:43 GMT Subject: Integrated: 550: "branch has unmerged commits" message could be clarified by the bot In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:29:55 GMT, Robin Westberg wrote: > Hi all, > > Please review this change that improves the final integrated message. > > Best regards, > Robin This pull request has now been integrated. Changeset: 2830d500 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/2830d500 Stats: 33 lines in 3 files changed: 0 ins; 26 del; 7 mod 550: "branch has unmerged commits" message could be clarified by the bot 564: PR bot should inform the PR is integrated Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/794 From rwestberg at openjdk.java.net Sat Sep 5 08:02:20 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 08:02:20 GMT Subject: RFR: Proper name for hgupdate-sync-label Message-ID: Hi all, Please review this minor change that updates the name of the sync label to the one actually in use. Best regards, Robin ------------- Commit messages: - Proper name for hgupdate-sync-label Changes: https://git.openjdk.java.net/skara/pull/795/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=795&range=00 Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/795.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/795/head:pull/795 PR: https://git.openjdk.java.net/skara/pull/795 From ehelin at openjdk.java.net Sat Sep 5 08:02:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 08:02:22 GMT Subject: RFR: Proper name for hgupdate-sync-label In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:59:19 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that updates the name of the sync label to the one actually in use. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/795 From rwestberg at openjdk.java.net Sat Sep 5 08:06:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 08:06:54 GMT Subject: Integrated: Proper name for hgupdate-sync-label In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 07:59:19 GMT, Robin Westberg wrote: > Hi all, > > Please review this minor change that updates the name of the sync label to the one actually in use. > > Best regards, > Robin This pull request has now been integrated. Changeset: ef99a66a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ef99a66a Stats: 5 lines in 3 files changed: 0 ins; 0 del; 5 mod Proper name for hgupdate-sync-label Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/795 From ehelin at openjdk.java.net Sat Sep 5 11:38:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 11:38:22 GMT Subject: RFR: bots: add census bot Message-ID: HI all, please review this patch that adds a census syncing bot. Thanks, Erik ------------- Commit messages: - bots: add census bot Changes: https://git.openjdk.java.net/skara/pull/796/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=796&range=00 Stats: 287 lines in 7 files changed: 287 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/796.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/796/head:pull/796 PR: https://git.openjdk.java.net/skara/pull/796 From ehelin at openjdk.java.net Sat Sep 5 11:47:48 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 11:47:48 GMT Subject: RFR: bots: add census bot [v2] In-Reply-To: References: Message-ID: > HI all, > > please review this patch that adds a census syncing bot. > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Nicer conf ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/796/files - new: https://git.openjdk.java.net/skara/pull/796/files/133caf10..9600d4db Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=796&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=796&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/796.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/796/head:pull/796 PR: https://git.openjdk.java.net/skara/pull/796 From rwestberg at openjdk.java.net Sat Sep 5 12:26:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 12:26:17 GMT Subject: RFR: bots: add census bot [v2] In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 11:47:48 GMT, Erik Helin wrote: >> HI all, >> >> please review this patch that adds a census syncing bot. >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Nicer conf Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/796 From ehelin at openjdk.java.net Sat Sep 5 12:30:26 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 12:30:26 GMT Subject: Integrated: bots: add census bot In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 11:35:33 GMT, Erik Helin wrote: > HI all, > > please review this patch that adds a census syncing bot. > > Thanks, > Erik This pull request has now been integrated. Changeset: 3ff5943a Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/3ff5943a Stats: 287 lines in 7 files changed: 0 ins; 287 del; 0 mod bots: add census bot Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/796 From ehelin at openjdk.java.net Sat Sep 5 12:43:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 12:43:31 GMT Subject: RFR: censussync: add bot to images Message-ID: Hi all, please review this small patch that adds the censussync bot to the bots image. Thanks, Erik ------------- Commit messages: - censussync: add bot to images Changes: https://git.openjdk.java.net/skara/pull/797/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=797&range=00 Stats: 3 lines in 2 files changed: 1 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/797.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/797/head:pull/797 PR: https://git.openjdk.java.net/skara/pull/797 From rwestberg at openjdk.java.net Sat Sep 5 12:46:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 12:46:55 GMT Subject: RFR: censussync: add bot to images In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 12:40:50 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds the censussync bot to the bots image. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/797 From ehelin at openjdk.java.net Sat Sep 5 12:46:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 12:46:56 GMT Subject: Integrated: censussync: add bot to images In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 12:40:50 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that adds the censussync bot to the bots image. > > Thanks, > Erik This pull request has now been integrated. Changeset: b7ab5393 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b7ab5393 Stats: 3 lines in 2 files changed: 0 ins; 1 del; 2 mod censussync: add bot to images Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/797 From ehelin at openjdk.java.net Sat Sep 5 13:58:38 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 13:58:38 GMT Subject: Integrated: censussync: minor bugfixes Message-ID: Hi all, please review this patch that fixes a few minor bugs in the census-sync bot. Thanks, Erik ------------- Commit messages: - censussync: minor bugfixes Changes: https://git.openjdk.java.net/skara/pull/798/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=798&range=00 Stats: 8 lines in 2 files changed: 4 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/798.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/798/head:pull/798 PR: https://git.openjdk.java.net/skara/pull/798 From rwestberg at openjdk.java.net Sat Sep 5 13:58:39 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 13:58:39 GMT Subject: Integrated: censussync: minor bugfixes In-Reply-To: References: Message-ID: <4k-wdq6Q66l2HJaY1FiVST6MBlF9g3rCNAJZfeaAqA4=.2b6865df-1b77-4958-bdd4-16df64f442c3@github.com> On Sat, 5 Sep 2020 13:53:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes a few minor bugs in the census-sync bot. > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/798 From ehelin at openjdk.java.net Sat Sep 5 13:58:40 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sat, 5 Sep 2020 13:58:40 GMT Subject: Integrated: censussync: minor bugfixes In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 13:53:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that fixes a few minor bugs in the census-sync bot. > > Thanks, > Erik This pull request has now been integrated. Changeset: 011f8e46 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/011f8e46 Stats: 8 lines in 2 files changed: 0 ins; 4 del; 4 mod censussync: minor bugfixes Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/798 From rwestberg at openjdk.java.net Sat Sep 5 14:25:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 14:25:09 GMT Subject: RFR: Improve bot message formatting Message-ID: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Hi all, Please review this small change that improves the formatting of a few bot messages. Best regards, Robin ------------- Commit messages: - Improve bot message formatting Changes: https://git.openjdk.java.net/skara/pull/799/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=00 Stats: 15 lines in 3 files changed: 8 ins; 0 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/799.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/799/head:pull/799 PR: https://git.openjdk.java.net/skara/pull/799 From rwestberg at openjdk.java.net Sat Sep 5 14:38:44 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 14:38:44 GMT Subject: RFR: Improve bot message formatting [v2] In-Reply-To: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> References: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Message-ID: > Hi all, > > Please review this small change that improves the formatting of a few bot messages. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Remove redundant backticks ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/799/files - new: https://git.openjdk.java.net/skara/pull/799/files/7ce2c61f..05515ca9 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=00-01 Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/799.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/799/head:pull/799 PR: https://git.openjdk.java.net/skara/pull/799 From rwestberg at openjdk.java.net Sat Sep 5 14:56:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 14:56:30 GMT Subject: RFR: Decrease the severity of the no labels (yet) log message Message-ID: Hi all, Please review this small change of a log message severity. Best regards, Robin ------------- Commit messages: - Decrease the severity of the no labels (yet) log message Changes: https://git.openjdk.java.net/skara/pull/800/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=800&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/800.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/800/head:pull/800 PR: https://git.openjdk.java.net/skara/pull/800 From rwestberg at openjdk.java.net Sat Sep 5 15:38:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sat, 5 Sep 2020 15:38:54 GMT Subject: RFR: Improve bot message formatting [v3] In-Reply-To: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> References: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Message-ID: <3hMZY9whH7Poyiqk-wpM2WO3p-dAW9vKOqM9GOFGNfo=.396445b1-8f60-448e-8a41-d1dc9e09e2c2@github.com> > Hi all, > > Please review this small change that improves the formatting of a few bot messages. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Adjust tests accordingly ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/799/files - new: https://git.openjdk.java.net/skara/pull/799/files/05515ca9..82917f51 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=01-02 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/799.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/799/head:pull/799 PR: https://git.openjdk.java.net/skara/pull/799 From jai.forums2013 at gmail.com Sun Sep 6 05:59:09 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Sun, 6 Sep 2020 11:29:09 +0530 Subject: git webrev doesn't include commit message and author info? Message-ID: I'm just getting used to the new scheme of things for contributing to the jdk repo. I use (and would like to continue using) the webrev tool to generate a webrev and then use the mailing lists to initiate a RFR. I have been using the following command to generate the webrev: ?git webrev -o /tmp/webrev/8252767/2 -u jpai -c 8252767 The webrev gets generated successfully. I've uploaded it here https://cr.openjdk.java.net/~jpai/webrev/8252767/2/ for reference. However, that generated patch file[1] doesn't include any of the commit message or the author, which effectively means that, when I request a review and a sponsor for this change, the sponsors won't be able to "import" this patch and commit it on my behalf (unlike the mercurial equivalent of webrev tool). The old webrev tool (for mercurial) used to include that information in the generated patch/changeset. Here's one such example from the old webrev tool against mercurial https://cr.openjdk.java.net/~jpai/webrev/8232879/2/webrev/jdk.changeset. FWIW, the actual commit in my git repo (on which this git webrev was executed) can be found here https://github.com/openjdk/jdk/pull/26/commits/aad69c9c3ca22e7cb4473ba9738b55796ae070aa [1] https://cr.openjdk.java.net/~jpai/webrev/8252767/2/JDK-8252767.patch -Jaikiran From rwestberg at openjdk.java.net Sun Sep 6 08:20:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sun, 6 Sep 2020 08:20:37 GMT Subject: RFR: Improve bot message formatting [v4] In-Reply-To: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> References: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Message-ID: > Hi all, > > Please review this small change that improves the formatting of a few bot messages. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Also improve the notifier push comment detection and test ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/799/files - new: https://git.openjdk.java.net/skara/pull/799/files/82917f51..518ce676 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=03 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=799&range=02-03 Stats: 22 lines in 2 files changed: 1 ins; 1 del; 20 mod Patch: https://git.openjdk.java.net/skara/pull/799.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/799/head:pull/799 PR: https://git.openjdk.java.net/skara/pull/799 From ehelin at openjdk.java.net Sun Sep 6 08:30:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sun, 6 Sep 2020 08:30:57 GMT Subject: RFR: Decrease the severity of the no labels (yet) log message In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 14:53:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change of a log message severity. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/800 From ehelin at openjdk.java.net Sun Sep 6 08:31:10 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Sun, 6 Sep 2020 08:31:10 GMT Subject: RFR: Improve bot message formatting [v4] In-Reply-To: References: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Message-ID: On Sun, 6 Sep 2020 08:20:37 GMT, Robin Westberg wrote: >> Hi all, >> >> Please review this small change that improves the formatting of a few bot messages. >> >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Also improve the notifier push comment detection and test Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/799 From rwestberg at openjdk.java.net Sun Sep 6 08:34:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sun, 6 Sep 2020 08:34:05 GMT Subject: Integrated: Decrease the severity of the no labels (yet) log message In-Reply-To: References: Message-ID: On Sat, 5 Sep 2020 14:53:49 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change of a log message severity. > > Best regards, > Robin This pull request has now been integrated. Changeset: feaebb2a Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/feaebb2a Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Decrease the severity of the no labels (yet) log message Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/800 From jai.forums2013 at gmail.com Sun Sep 6 08:42:06 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Sun, 6 Sep 2020 14:12:06 +0530 Subject: How do I retrigger "checks" on a PR to generate a RFR mail? Message-ID: <83dee26c-ba83-1402-aae2-8f4733f9556a@gmail.com> In context of this PR[1], when I created it, my github account wasn't linked to my OpenJDK account. It has now been done and I have also joined the OpenJDK org through the invitation I received. In order to have the bot now redo the checks and send an automated RFR to the mailing list it's identified (the "net" mailing list in this case), what is the command that I need to comment in that PR? Or should I force push to my branch that corresponds to the PR, to retrigger the checks? I had a look at https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands but couldn't find anything relevant. [1] https://github.com/openjdk/jdk/pull/26 -Jaikiran From robin.westberg at oracle.com Sun Sep 6 08:47:12 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Sun, 6 Sep 2020 10:47:12 +0200 Subject: How do I retrigger "checks" on a PR to generate a RFR mail? In-Reply-To: <83dee26c-ba83-1402-aae2-8f4733f9556a@gmail.com> References: <83dee26c-ba83-1402-aae2-8f4733f9556a@gmail.com> Message-ID: <6F2D689F-8370-4C66-87FD-7D56797B2A09@oracle.com> Hi Jaikiran, > On 6 Sep 2020, at 10:42, Jaikiran Pai wrote: > > In context of this PR[1], when I created it, my github account wasn't > linked to my OpenJDK account. It has now been done and I have also > joined the OpenJDK org through the invitation I received. > > In order to have the bot now redo the checks and send an automated RFR > to the mailing list it's identified (the "net" mailing list in this > case), what is the command that I need to comment in that PR? Or should > I force push to my branch that corresponds to the PR, to retrigger the > checks? > > I had a look at > https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands but > couldn't find anything relevant. The check will be rerun if anything that would affect the outcome changes. In this case, the check can?t determine the issue ID which you can see here: https://github.com/openjdk/jdk/pull/26/checks?check_run_id=1077437559 So either edit the PR title manually to remove the leading ?RFR ? text or issue a command like ?/solves 8252767? and the title will be updated with a description taken from Jira. You can also just set the title to 8252767 when creating the PR and it will be automatically expanded. Best regards, Robin > > > [1] https://github.com/openjdk/jdk/pull/26 > > -Jaikiran > From rwestberg at openjdk.java.net Sun Sep 6 08:52:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Sun, 6 Sep 2020 08:52:33 GMT Subject: Integrated: Improve bot message formatting In-Reply-To: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> References: <39senZBwy-l8pB8GcFKh5YmA07Zl7fyC1yZpp-NnI3o=.e835a866-0bbd-4f99-90b1-032f79b13af7@github.com> Message-ID: On Sat, 5 Sep 2020 14:22:27 GMT, Robin Westberg wrote: > Hi all, > > Please review this small change that improves the formatting of a few bot messages. > > Best regards, > Robin This pull request has now been integrated. Changeset: 5da1a5a6 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/5da1a5a6 Stats: 40 lines in 7 files changed: 2 ins; 9 del; 29 mod Improve bot message formatting Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/799 From jai.forums2013 at gmail.com Sun Sep 6 09:09:23 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Sun, 6 Sep 2020 14:39:23 +0530 Subject: openjdk.org in quoted text of email reply vs openjdk.java.net in From field Message-ID: <7421f326-f9ec-5ce9-0172-d4c2f8e443ed@gmail.com> Noticed a minor thing in the automated RFR messages from a pull request. When an initial RFR mail is sent from a PR, like this one[1], it uses a @openjdk.java.net for the From email address field. When the author of the PR then replies to the mail, a quoted text is included in the mail body, like here[2]. That quoted text (not the From field) uses @openjdk.org. Is this an intentional difference between openjdk.java.net and openjdk.org usage? [1] https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014336.html [2] https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014335.html -Jaikiran From robin.westberg at oracle.com Sun Sep 6 09:14:31 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Sun, 6 Sep 2020 11:14:31 +0200 Subject: openjdk.org in quoted text of email reply vs openjdk.java.net in From field In-Reply-To: <7421f326-f9ec-5ce9-0172-d4c2f8e443ed@gmail.com> References: <7421f326-f9ec-5ce9-0172-d4c2f8e443ed@gmail.com> Message-ID: Hi Jaikiran, > On 6 Sep 2020, at 11:09, Jaikiran Pai wrote: > > Noticed a minor thing in the automated RFR messages from a pull request. > When an initial RFR mail is sent from a PR, like this one[1], it uses a > @openjdk.java.net for the From email address field. When the > author of the PR then replies to the mail, a quoted text is included in > the mail body, like here[2]. That quoted text (not the From field) uses > @openjdk.org. Is this an intentional difference between > openjdk.java.net and openjdk.org usage? Yeah, it?s intentional, the idea is that the RFR messages will be sent from the @openjdk.org email address. However, this domain is still waiting for proper MX record configuration, which causes many receiving mail servers to reject such mails. So as a temporary measure, the sender domain is rewritten as @openjdk.java.net just before the email is sent. Best regards, Robin > > > [1] > https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014336.html > > [2] > https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014335.html > > -Jaikiran > From jai.forums2013 at gmail.com Sun Sep 6 09:48:02 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Sun, 6 Sep 2020 15:18:02 +0530 Subject: openjdk.org in quoted text of email reply vs openjdk.java.net in From field In-Reply-To: References: <7421f326-f9ec-5ce9-0172-d4c2f8e443ed@gmail.com> Message-ID: <2cc36ce2-8491-340e-840a-5a88dfb915c8@gmail.com> Thank you for that detail, Robin. -Jaikiran On 06/09/20 2:44 pm, Robin Westberg wrote: > Hi Jaikiran, > >> On 6 Sep 2020, at 11:09, Jaikiran Pai wrote: >> >> Noticed a minor thing in the automated RFR messages from a pull request. >> When an initial RFR mail is sent from a PR, like this one[1], it uses a >> @openjdk.java.net for the From email address field. When the >> author of the PR then replies to the mail, a quoted text is included in >> the mail body, like here[2]. That quoted text (not the From field) uses >> @openjdk.org. Is this an intentional difference between >> openjdk.java.net and openjdk.org usage? > Yeah, it?s intentional, the idea is that the RFR messages will be sent from the @openjdk.org email address. However, this domain is still waiting for proper MX record configuration, which causes many receiving mail servers to reject such mails. So as a temporary measure, the sender domain is rewritten as @openjdk.java.net just before the email is sent. > > Best regards, > Robin >> >> [1] >> https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014336.html >> >> [2] >> https://mail.openjdk.java.net/pipermail/net-dev/2020-September/014335.html >> >> -Jaikiran >> From jvernee at openjdk.java.net Mon Sep 7 10:26:40 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 7 Sep 2020 10:26:40 GMT Subject: RFR: Remove mention of /integrate from the start of the pre-integration message. Message-ID: Hi, In response to some of the discussion on: https://github.com/openjdk/jdk/pull/26 I suggest changing the pre-integration comment to remove the mention of `/integrate` at the start, where it reads: type `/integrate` in a new comment to proceed Since `/integrate` is also mentioned at the end of the same message (with a clearer description of what it does [1](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java#L603-L610)), this is an attempt to encourage users to read till the end of the message before typing `/integrate`. Thanks, Jorn ------------- Commit messages: - Remove mention of /integrate from the start of the integration message. Changes: https://git.openjdk.java.net/skara/pull/801/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=801&range=00 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/801.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/801/head:pull/801 PR: https://git.openjdk.java.net/skara/pull/801 From rwestberg at openjdk.java.net Mon Sep 7 12:43:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 7 Sep 2020 12:43:16 GMT Subject: RFR: Remove mention of /integrate from the start of the pre-integration message. In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 10:15:51 GMT, Jorn Vernee wrote: > Hi, > > In response to some of the discussion on: https://github.com/openjdk/jdk/pull/26 I suggest changing the pre-integration > comment to remove the mention of `/integrate` at the start, where it reads: > type `/integrate` in a new comment to proceed > > Since `/integrate` is also mentioned at the end of the same message (with a clearer description of what it does > [1](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java#L603-L610)), > this is an attempt to encourage users to read till the end of the message before typing `/integrate`. Thanks, > Jorn Looks good, thanks for fixing! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/801 From rwestberg at openjdk.java.net Mon Sep 7 12:43:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 7 Sep 2020 12:43:42 GMT Subject: RFR: 610: Add support for other issue tracker email addresses than @openjdk.org Message-ID: It should be possible to find Jira users based on committer email addresses that are written as `@openjdk.org` in case they exist. Best regards, Robin ------------- Commit messages: - Allow finding jira users by email Changes: https://git.openjdk.java.net/skara/pull/802/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=802&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-610 Stats: 95 lines in 6 files changed: 93 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/802.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/802/head:pull/802 PR: https://git.openjdk.java.net/skara/pull/802 From ehelin at openjdk.java.net Mon Sep 7 13:02:06 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 7 Sep 2020 13:02:06 GMT Subject: RFR: 610: Add support for other issue tracker email addresses than @openjdk.org In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 12:40:39 GMT, Robin Westberg wrote: > It should be possible to find Jira users based on committer email addresses that are written as `@openjdk.org` in case > they exist. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/802 From ehelin at openjdk.java.net Mon Sep 7 13:02:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 7 Sep 2020 13:02:45 GMT Subject: RFR: Remove mention of /integrate from the start of the pre-integration message. In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 10:15:51 GMT, Jorn Vernee wrote: > Hi, > > In response to some of the discussion on: https://github.com/openjdk/jdk/pull/26 I suggest changing the pre-integration > comment to remove the mention of `/integrate` at the start, where it reads: > type `/integrate` in a new comment to proceed > > Since `/integrate` is also mentioned at the end of the same message (with a clearer description of what it does > [1](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java#L603-L610)), > this is an attempt to encourage users to read till the end of the message before typing `/integrate`. Thanks, > Jorn Looks good, thanks Jorn! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/801 From jvernee at openjdk.java.net Mon Sep 7 13:06:06 2020 From: jvernee at openjdk.java.net (Jorn Vernee) Date: Mon, 7 Sep 2020 13:06:06 GMT Subject: Integrated: Remove mention of /integrate from the start of the pre-integration message. In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 10:15:51 GMT, Jorn Vernee wrote: > Hi, > > In response to some of the discussion on: https://github.com/openjdk/jdk/pull/26 I suggest changing the pre-integration > comment to remove the mention of `/integrate` at the start, where it reads: > type `/integrate` in a new comment to proceed > > Since `/integrate` is also mentioned at the end of the same message (with a clearer description of what it does > [1](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java#L603-L610)), > this is an attempt to encourage users to read till the end of the message before typing `/integrate`. Thanks, > Jorn This pull request has now been integrated. Changeset: 55c4ce77 Author: Jorn Vernee URL: https://git.openjdk.java.net/skara/commit/55c4ce77 Stats: 3 lines in 1 file changed: 0 ins; 0 del; 3 mod Remove mention of /integrate from the start of the pre-integration message. Reviewed-by: rwestberg, ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/801 From ehelin at openjdk.java.net Mon Sep 7 13:41:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 7 Sep 2020 13:41:42 GMT Subject: Integrated: checkout: check status before converting Message-ID: Hi all, please review this patch that makes the checkout bot checks if the `HEAD` commit on the branch in the `from` repository already has been converted. If it has, then there is no need to run the converter. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - checkout: check status before converting Changes: https://git.openjdk.java.net/skara/pull/803/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=803&range=00 Stats: 14 lines in 1 file changed: 10 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/803.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/803/head:pull/803 PR: https://git.openjdk.java.net/skara/pull/803 From rwestberg at openjdk.java.net Mon Sep 7 13:41:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 7 Sep 2020 13:41:42 GMT Subject: Integrated: checkout: check status before converting In-Reply-To: References: Message-ID: <0mK6RRPcRQt-Hw1jmO9Ustt58mMqGfh7e4mNQgZD-0I=.36212cda-0eb5-46cb-a4c4-9065707ca95c@github.com> On Mon, 7 Sep 2020 13:37:39 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the checkout bot checks if the `HEAD` commit on the branch in the `from` repository > already has been converted. If it has, then there is no need to run the converter. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/803 From ehelin at openjdk.java.net Mon Sep 7 13:41:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 7 Sep 2020 13:41:43 GMT Subject: Integrated: checkout: check status before converting In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 13:37:39 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the checkout bot checks if the `HEAD` commit on the branch in the `from` repository > already has been converted. If it has, then there is no need to run the converter. > Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 05b70648 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/05b70648 Stats: 14 lines in 1 file changed: 0 ins; 10 del; 4 mod checkout: check status before converting Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/803 From rwestberg at openjdk.java.net Mon Sep 7 13:45:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 7 Sep 2020 13:45:05 GMT Subject: Integrated: 610: Add support for other issue tracker email addresses than @openjdk.org In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 12:40:39 GMT, Robin Westberg wrote: > It should be possible to find Jira users based on committer email addresses that are written as `@openjdk.org` in case > they exist. > Best regards, > Robin This pull request has now been integrated. Changeset: 4a6a45bd Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/4a6a45bd Stats: 95 lines in 6 files changed: 1 ins; 93 del; 1 mod 610: Add support for other issue tracker email addresses than @openjdk.org Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/802 From philip.race at oracle.com Mon Sep 7 17:32:31 2020 From: philip.race at oracle.com (Philip Race) Date: Mon, 07 Sep 2020 10:32:31 -0700 Subject: Request for assistance: Verify and update mailing list filter rules for jdk/jdk in preparation for Skara transition In-Reply-To: References: <568BB329-6F50-43B4-BE1D-3A9D7EA60F79@oracle.com> <35347485-216D-42BC-A05A-8D974E3FA581@oracle.com> <56e127e9-3802-a8d5-9a79-042166f02409@oracle.com> <5F4A83A9.1000207@oracle.com> Message-ID: <5F566EAF.2010509@oracle.com> [Removing jdk-dev as we are drilling into a skara discussion deeper than needs to be distributed to jdk-dev]. On 8/31/20, 7:16 AM, Erik Helin wrote: > On 8/29/20 6:34 PM, Philip Race wrote: >> I have some questions which at least tangentially relate to the list >> mappings which raise >> what to me are tricky problems but maybe they've already been thought >> through and solved. >> >> First, what is the minimum number of reviewers required a fix for the >> JDK project ? > > It is 1 Reviewer as configured by .jcheck/conf. > >> Second, how can we have that by default adjusted depending on mailing >> list, with the >> ability to either raise or lower that number according to the >> judgement of the fixer. >> In the client area 2 reviewers is the big rule, only one has to be a >> Capital R reviewer, >> but for trivial and urgent fixes we allow just one reviewer. > > Ok, so we have to separate between culture and rules. The .jcheck/conf > file configures the rules, and the rule is 1 Reviewer. I think this is something that needs to be configured at a finer grain than that in the JDK project, for the same reason that there is more than one mailing list. JDK is special. And I think there is an additonal subtlety which you raise below. > > For several directories in the jdk repository various norms have > formed with regards to the requirements that needs to be met before > one can push. For example for the src/hotspot directory you need 1 > Reviewer and 1 Author (or above) to review and you should wait 24 > hours before pushing. For the client directories you state that 2 > Reviewers are needed (I wasn't aware, I have never contributed to the > client code). For the make directory you really ought to get a review > from either Erik J or Magnus. These norms are not mechanically > enforced (not today by jcheck, nor tomorrow by Skara), instead they > are enforced through Reviewers educating contributors about the > cultural norms. I should clarify that we really do mean more like hotspot "1 Reviewer and 1 Author". We rarely require two capital R reviewers, because active ones are in very short supply. So is the hotspot one enforced by this directory scheme in the skara tooling, or are you just referring to "culture" ? If I do "/reviewers 2" I am now supposing that it really means two capital R reviewers and won't accept an author as one of them ? I think we would really want a way to do what hotspot does - at least for the reviewers. We don't have the 24 hour rule. Also am I correct in understanding that a person proposing a fix cannot change (ie either increase or decrease) the number of reviewers unless they themselves are a reviewer ? I would have thought that for some fixes a committer would know up front what is appropriate and should be able to change it. Author maybe not, but a committer I think should have this capability. > >> Third, if a fix is cross-posted to (say) build-dev and 2d-dev, how do >> you ensure it >> gets both a build reviewer and a 2D reviewer's approval before >> pushing ? That >> is after all the point of the cross-posting. > > The norm that a change to the Makefiles must be reviewed by a senior > build engineer (in most cases Erik J or Magnus) is not mechanically > enforced, as I explained above. The point of cross-posting to > build-dev is to allow an experienced build engineer to get the chance > to look at the patch, otherwise the build engineers would have follow > all mailing lists. > > I agree with Kevin that trying to capture all these cultural norms > automatically is going to be very tricky (if not impossible). Perhaps > the developers guide could be a good place to store this information? > > Remember that today with Mercurial we don't really enforce anything, > as you can put any Reviewers OpenJDK username on the "Reviewed-by" > line and then push. A Committer doing this would probably find > themselves losing their Committer status very quickly though... I know, but also as I wrote, nothing in the mercurial workflow tells you it is ready to integrate contrary to those social norms, where as in the case of skara it does. The developer's guide is alas way too far removed from the immediacy of the message you get from skara to be an effective deterrent. So I think we are going to get a lot of cases where people don't wait who should have waited. They will believe the tooling indicates process has changed. At the very least the message about being ready to integrate could carry a warning that some areas require a 2nd review beyond the base configuration of the project and eg if this is a client fix, please wait .. -phil. > > Thanks, > Erik > >> -phil. >> >> On 8/27/20, 10:37 AM, Joe Darcy wrote: >>> Hello, >>> >>> The mapping of >>> changed-file-to-OpenJDK-mailing-list(s)-to-review-the-file can be >>> non-obvious, both to new contributors and to experienced >>> contributors working in an unfamiliar area. If an automated mapping >>> gets this 95+% correct, with the ability for manual tweaking, that >>> strikes me as an overall improvement over the current situation. >>> >>> The current mapping has various entries that should be changed, but >>> that is why it is being sent out for review before the Skara >>> transition :-) >>> >>> As a general comment, I would expect both the mapping and other >>> aspects of the Skara tooling to get updated in response to feedback >>> after jdk/jdk moves over. >>> >>> -Joe >>> >>> On 8/27/2020 9:53 AM, Igor Ignatyev wrote: >>>> Hi Robin, >>>> >>>> although I really like the idea of having mapping b/w files and >>>> groups/components/subcomponents, I agree w/ David that in its >>>> *current* form it's unworkable. having the mapping in Skara repo is >>>> impractical, as it introduces additional overhead for maintenance, >>>> not to speak of possible desynchronization. Thus I suggest moving >>>> the mapping to jdk/jdk repo and updating Skara tooling accordingly. >>>> >>>> I also have a question regarding the format, why did you decide to >>>> invent your own format instead of using CODEOWNER-like format which >>>> fits the needs rather nicely and is used for similar purposes by >>>> github and gitlab? >>>> >>>> Thanks, >>>> -- Igor >>>> >>>>> On Aug 27, 2020, at 6:26 AM, David Holmes >>>>> wrote: >>>>> >>>>> In all seriousness I just don't think this is a reasonable or >>>>> necessary thing to do. When you create a PR you should specify the >>>>> mailing lists to be used, as you do today with a RFR. Trying to >>>>> maintain a file by file mapping is just a huge initial setup cost >>>>> and a maintenance nightmare. It is not necessary to try and >>>>> automate this IMO. >>>>> >>>>> I wish this intent had been flagged/discussed some time ago. :( >>>>> >>>>> David >>>>> ----- >>>>> >>>>> On 27/08/2020 8:34 pm, Robin Westberg wrote: >>>>>> Hi all, >>>>>> As part of transitioning the jdk/jdk repository to Git with >>>>>> project Skara, we have created a set of rules that determine >>>>>> which mailing list(s) should be the default recipient of a review >>>>>> request, depending on which files are changed. The initial >>>>>> version of these rules was created by looking at historical >>>>>> commits and matching them with existing mailing list review >>>>>> threads. This has produced a reasonable basis, but it can most >>>>>> certainly be made better with some additional manual curating. >>>>>> Therefore, it would be very helpful if people with good knowledge >>>>>> of the various subsystems and source files that make up the JDK >>>>>> would be willing to take a look at these rules, and also suggest >>>>>> improvements where needed. In addition, lists like [1] would also >>>>>> be very useful insofar they exist. >>>>>> The current version of these rules is located in a JSON file in >>>>>> the Skara repository at [2]. In order to check the validity of >>>>>> the rules, there is also a CLI tool that can be used to apply it >>>>>> to either a subset of files or existing commits and produce a >>>>>> suggestion [3] [4]. If you are interested in helping out with >>>>>> curating these rules, these are the steps to get started: >>>>>> 1. Install the Skara CLI tools: >>>>>> https://wiki.openjdk.java.net/display/SKARA/CLI+Tools >>>>>> 2. Locate a suitable clone of the jdk/jdk repository (either >>>>>> Mercurial or Git is fine) >>>>>> 3. Change (cd) to the root of your jdk/jdk repository >>>>>> 3. Run the ?debug mlrules? command on your favorite subset of >>>>>> files, for example like this (use the actual location of jdk.json >>>>>> on your system): >>>>>> $ git skara debug mlrules -v >>>>>> ~/git/skara/config/mailinglist/rules/jdk.json src/hotspot/share/jfr/ >>>>>> Reading rules file... >>>>>> src/hotspot/share/jfr/dcmd: [hotspot-jfr-dev] >>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.cpp: >>>>>> [hotspot-jfr-dev] >>>>>> src/hotspot/share/jfr/instrumentation/jfrEventClassTransformer.hpp: >>>>>> [hotspot-jfr-dev] >>>>>> src/hotspot/share/jfr/instrumentation/jfrJvmtiAgent.cpp: >>>>>> [hotspot-jfr-dev, serviceability-dev] >>>>>> ? >>>>>> Final list suggestion is: [hotspot-jfr-dev, serviceability-dev] >>>>>> The command accepts multiple folder and/or file names to make it >>>>>> possible to simulate a potential change to a given set of files: >>>>>> $ git skara debug mlrules -v >>>>>> ../skara/config/mailinglist/rules/jdk.json doc/ide.md >>>>>> src/hotspot/cpu/x86/x86.ad src/hotspot/os/linux/gc/z/zNUMA_linux.cpp >>>>>> Reading rules file... >>>>>> doc: [build-dev] >>>>>> src/hotspot/cpu: [hotspot-compiler-dev] >>>>>> src/hotspot/os: [hotspot-runtime-dev, hotspot-gc-dev] >>>>>> Combined list suggestion: [build-dev, hotspot-compiler-dev, >>>>>> hotspot-gc-dev, hotspot-runtime-dev] >>>>>> Final list suggestion is: [build-dev, hotspot-dev] >>>>>> If the suggestions look fine, all is well. If not, you are >>>>>> welcome to propose a change to the rules, preferably by editing >>>>>> the jdk.json file [6] and creating a pull request towards the >>>>>> Skara project as described in [5]. Coincidentally, this is the >>>>>> same way that future changes to the jdk/jdk repository will be >>>>>> integrated, so this exercise could also serve as a way of getting >>>>>> started with Git / Skara! >>>>>> Best regards, >>>>>> Robin >>>>>> [1] https://openjdk.java.net/groups/2d/2dawtfiles.html >>>>>> [2] >>>>>> https://git.openjdk.java.net/skara/blob/master/config/mailinglist/rules/jdk.json >>>>>> >>>>>> [3] >>>>>> $ git skara debug mlrules -v >>>>>> ~/git/skara/config/mailinglist/rules/jdk.json >>>>>> src/java.desktop/unix/native >>>>>> Reading rules file... >>>>>> src/java.desktop/unix/native/common: [2d-dev] >>>>>> src/java.desktop/unix/native/include: [] >>>>>> src/java.desktop/unix/native/libawt: [2d-dev] >>>>>> src/java.desktop/unix/native/libawt_headless: [awt-dev] >>>>>> src/java.desktop/unix/native/libawt_xawt: [awt-dev] >>>>>> src/java.desktop/unix/native/libfontmanager: [2d-dev] >>>>>> src/java.desktop/unix/native/libjawt: [awt-dev] >>>>>> src/java.desktop/unix/native/libsplashscreen: [awt-dev] >>>>>> Combined list suggestion: [2d-dev, awt-dev] >>>>>> Final list suggestion is: [2d-dev, awt-dev] >>>>>> [4] >>>>>> $ git skara debug mlrules -d 30 -v >>>>>> ~/git/skara/config/mailinglist/rules/jdk.json . >>>>>> ... >>>>>> ? [2d-dev, awt-dev, serviceability-dev] c32923e0: 8240487: >>>>>> Cleanup whitespace in .cc, .hh, .m, and .mm files >>>>>> ? [awt-dev] 7f74c7dd: 8212226: SurfaceManager throws "Invalid >>>>>> Image variant" for MultiResolutionImage (Windows) >>>>>> Suggested lists: [2d-dev, awt-dev] >>>>>> Rules matching unmentioned lists [2d-dev]: >>>>>> >>>>>> src/java.desktop/share/classes/sun/java2d/SunGraphics2D.java - >>>>>> [2d-dev: ^src/java.desktop/share/classes/sun/java2d/] >>>>>> ? >>>>>> [5] https://wiki.openjdk.java.net/display/SKARA/Skara#Skara-Workflow >>>>>> [6] >>>>>> The rules are made up of sets of regular expressions for the >>>>>> various mailing lists that are used for reviewing changes going >>>>>> into the JDK. If any rule matches, that mailing list will get a >>>>>> copy of the review request email. For directories containing >>>>>> files that belong to different subsystems, it?s usually a good >>>>>> idea to write the rules in a complementary fashion if possible, >>>>>> so that anything not explicitly mentioned gets a reasonable >>>>>> default. As an example, see these rules for a subset of awt / 2d >>>>>> / i18n files: >>>>>> ?awt-dev?: >>>>>> "src/java.desktop/share/classes/sun/awt/(?!font|sunhints|color/|font/|geom/|im/|image/|print/)? >>>>>> >>>>>> ?2d-dev?: >>>>>> "src/java.desktop/share/classes/sun/awt/(font|sunhints|color/|font/|geom/|image/|print/)" >>>>>> >>>>>> ?I18n-dev?: "src/java.desktop/share/classes/sun/awt/im/? >>>>>> In this example, anything not explicitly indicated as belonging >>>>>> to either 2d-dev or i18-dev will be matched by awt-dev. From avoitylov at openjdk.java.net Mon Sep 7 20:03:51 2020 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Mon, 7 Sep 2020 20:03:51 GMT Subject: RFR: SKARA-611: PR generated an email on jdk-dev Message-ID: This came up as https://github.com/openjdk/jdk/pull/49 generated a mailing list notification on jdk-dev. Removing jdk-dev mailing list aggregation as this mailing list should not be used for PRs. ./gradlew test BUILD SUCCESSFUL in 23m 19s 138 actionable tasks: 138 executed on mac. ------------- Commit messages: - SKARA-611 Changes: https://git.openjdk.java.net/skara/pull/804/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=804&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-611 Stats: 6 lines in 1 file changed: 0 ins; 6 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/804.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/804/head:pull/804 PR: https://git.openjdk.java.net/skara/pull/804 From avoitylov at openjdk.java.net Tue Sep 8 06:40:25 2020 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Tue, 8 Sep 2020 06:40:25 GMT Subject: RFR: SKARA-611: PR generated an email on jdk-dev In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 20:01:13 GMT, Aleksei Voitylov wrote: > This came up as https://github.com/openjdk/jdk/pull/49 generated a mailing list notification on jdk-dev. Removing > jdk-dev mailing list aggregation as this mailing list should not be used for PRs. > ./gradlew test > BUILD SUCCESSFUL in 23m 19s > 138 actionable tasks: 138 executed > > on mac. Hmm. Testing on a local linux box passed. ------------- PR: https://git.openjdk.java.net/skara/pull/804 From rwestberg at openjdk.java.net Tue Sep 8 08:07:55 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 8 Sep 2020 08:07:55 GMT Subject: RFR: SKARA-611: PR generated an email on jdk-dev In-Reply-To: References: Message-ID: <-gNs5c1Rk62o9gl4GUBVVXie9omVqr_ZgN9WfTBTVNk=.0de8c022-8320-488b-ad5f-41f1649e3299@github.com> On Mon, 7 Sep 2020 20:01:13 GMT, Aleksei Voitylov wrote: > This came up as https://github.com/openjdk/jdk/pull/49 generated a mailing list notification on jdk-dev. Removing > jdk-dev mailing list aggregation as this mailing list should not be used for PRs. > ./gradlew test > BUILD SUCCESSFUL in 23m 19s > 138 actionable tasks: 138 executed > > on mac. Thanks for fixing, looks good! The linux errors are a bit intermittent since we switched to run on ubuntu-20.04, seems like they are running on hosts that are quite a bit slower than ubuntu-default. But if it passes on mac and win there's certainly nothing to worry about. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/804 From avoitylov at openjdk.java.net Tue Sep 8 08:59:17 2020 From: avoitylov at openjdk.java.net (Aleksei Voitylov) Date: Tue, 8 Sep 2020 08:59:17 GMT Subject: Integrated: SKARA-611: PR generated an email on jdk-dev In-Reply-To: References: Message-ID: On Mon, 7 Sep 2020 20:01:13 GMT, Aleksei Voitylov wrote: > This came up as https://github.com/openjdk/jdk/pull/49 generated a mailing list notification on jdk-dev. Removing > jdk-dev mailing list aggregation as this mailing list should not be used for PRs. > ./gradlew test > BUILD SUCCESSFUL in 23m 19s > 138 actionable tasks: 138 executed > > on mac. This pull request has now been integrated. Changeset: b047aefc Author: Aleksei Voitylov Committer: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/b047aefc Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod 611: PR generated an email on jdk-dev Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/804 From shade at redhat.com Tue Sep 8 10:46:18 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Tue, 8 Sep 2020 12:46:18 +0200 Subject: JDK Sandbox and Skara Message-ID: Hi, I wanted to have some guidance with JDK Sandbox and Skara. Since JDK Sandbox uses branches already, do we treat that repository as if it is a personal (yet shared) fork of openjdk/jdk? That is, are we expected to push the changes directly to openjdk/jdk-sandbox branches, without involving any of Skara tooling? Probably something for Sandbox/Skara FAQ? -- Thanks, -Aleksey From ehelin at openjdk.java.net Tue Sep 8 12:08:54 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 12:08:54 GMT Subject: RFR: jcheck: remove unused code Message-ID: Hi all, please review this patch that removes some very old code in `JCheck` that has never been used and just clutters the `JCheck` API. We have other ways of ensuring whether a certain commit should or should not be allowed to be pushed, the code that this patch removes is not used. This is a fully backwards compatible change with both older and newer .jcheck/conf files. Testing: - [x] `make test` passes on Linux x64 - [x] `make images` passes on Linux x64 Thanks, Erik ------------- Commit messages: - jcheck: remove unused blacklist and whitelist code Changes: https://git.openjdk.java.net/skara/pull/805/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=805&range=00 Stats: 269 lines in 11 files changed: 0 ins; 260 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/805.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/805/head:pull/805 PR: https://git.openjdk.java.net/skara/pull/805 From rwestberg at openjdk.java.net Tue Sep 8 12:12:17 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 8 Sep 2020 12:12:17 GMT Subject: RFR: jcheck: remove unused code In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 12:06:02 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes some very old code in `JCheck` that has never been used and just clutters the > `JCheck` API. We have other ways of ensuring whether a certain commit should or should not be allowed to be pushed, the > code that this patch removes is not used. This is a fully backwards compatible change with both older and newer > .jcheck/conf files. > Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/805 From ehelin at openjdk.java.net Tue Sep 8 12:21:47 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 12:21:47 GMT Subject: Integrated: jcheck: remove unused code In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 12:06:02 GMT, Erik Helin wrote: > Hi all, > > please review this patch that removes some very old code in `JCheck` that has never been used and just clutters the > `JCheck` API. We have other ways of ensuring whether a certain commit should or should not be allowed to be pushed, the > code that this patch removes is not used. This is a fully backwards compatible change with both older and newer > .jcheck/conf files. > Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 2578f645 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/2578f645 Stats: 237 lines in 11 files changed: 226 ins; 0 del; 11 mod jcheck: remove unused code Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/805 From erik.helin at oracle.com Tue Sep 8 13:02:42 2020 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 8 Sep 2020 15:02:42 +0200 Subject: JDK Sandbox and Skara In-Reply-To: References: Message-ID: On 9/8/20 12:46 PM, Aleksey Shipilev wrote: > Hi, > > I wanted to have some guidance with JDK Sandbox and Skara. > > Since JDK Sandbox uses branches already, do we treat that repository as > if it is a personal (yet shared) fork of openjdk/jdk? That is, are we > expected to push the changes directly to openjdk/jdk-sandbox branches, > without involving any of Skara tooling? Yes, since you are a Committer (actually Reviewer, but the point here is that you have Committer status) you have been given direct write access to the openjdk/jdk-sandbox repository [0]. Feel free to use the openjdk/jdk-sandbox repository in the same way as you used the Mercurial jdk/sandbox repository [1]. > Probably something for Sandbox/Skara FAQ? Yes, good suggestion, I added an entry [2]. Thanks, Erik [0]: https://git.openjdk.java.net/jdk-sandbox [1]: https://hg.openjdk.java.net/jdk/sandbox [2]: https://wiki.openjdk.java.net/display/SKARA/FAQ#FAQ-Repositories From ehelin at openjdk.java.net Tue Sep 8 13:18:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 13:18:55 GMT Subject: RFR: vcs: do not hard-code VCS default branch names Message-ID: Hi all, please review this patch that ensures that we don't hard-code the name of the default branches for various version control system throughout the Skara source code. Skara has from the beginning been very strict about abstracting away VCS implementation details, but the name of the default branches has managed to find its way into multiple corners of the source code. Testing: - [x] `make test` passes on Linux x64 - [x] `make images` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: do not hardcode VCS default branch names Changes: https://git.openjdk.java.net/skara/pull/806/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=806&range=00 Stats: 56 lines in 19 files changed: 22 ins; 1 del; 33 mod Patch: https://git.openjdk.java.net/skara/pull/806.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/806/head:pull/806 PR: https://git.openjdk.java.net/skara/pull/806 From rwestberg at openjdk.java.net Tue Sep 8 13:20:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 8 Sep 2020 13:20:43 GMT Subject: RFR: 599: Unverified reviews should not count towards jcheck Message-ID: The usage of the `/reviewer add` command has apparently been a bit confusing. This change renames the `add` sub command to `create` instead to clarify the intent better. Such manually credited reviewers will also not count towards the "formal" review requirements as specified by the jcheck configuration. ------------- Commit messages: - Rename the reviewer add subcommand to credit Changes: https://git.openjdk.java.net/skara/pull/807/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=807&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-599 Stats: 74 lines in 6 files changed: 20 ins; 4 del; 50 mod Patch: https://git.openjdk.java.net/skara/pull/807.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/807/head:pull/807 PR: https://git.openjdk.java.net/skara/pull/807 From rwestberg at openjdk.java.net Tue Sep 8 13:21:58 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 8 Sep 2020 13:21:58 GMT Subject: RFR: vcs: do not hard-code VCS default branch names In-Reply-To: References: Message-ID: <5JecmNh-MOOZpuEpFmu9cLXP3ZJRQPaojR2Efo8JNzw=.128f451a-1c22-431e-a0a0-1d5d62896c36@github.com> On Tue, 8 Sep 2020 13:16:08 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that we don't hard-code the name of the default branches for various version > control system throughout the Skara source code. Skara has from the beginning been very strict about abstracting away > VCS implementation details, but the name of the default branches has managed to find its way into multiple corners of > the source code. Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik Looks good, thanks for fixing! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/806 From ehelin at openjdk.java.net Tue Sep 8 13:27:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 13:27:37 GMT Subject: RFR: 599: Unverified reviews should not count towards jcheck In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 13:18:00 GMT, Robin Westberg wrote: > The usage of the `/reviewer add` command has apparently been a bit confusing. This change renames the `add` sub command > to `credit` instead to clarify the intent better. Such manually credited reviewers will also not count towards the > "formal" review requirements as specified by the jcheck configuration. Thanks Robin, this looks nice! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/807 From ehelin at openjdk.java.net Tue Sep 8 13:27:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 13:27:37 GMT Subject: RFR: 599: Unverified reviews should not count towards jcheck In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 13:24:39 GMT, Erik Helin wrote: >> The usage of the `/reviewer add` command has apparently been a bit confusing. This change renames the `add` sub command >> to `credit` instead to clarify the intent better. Such manually credited reviewers will also not count towards the >> "formal" review requirements as specified by the jcheck configuration. > > Thanks Robin, this looks nice! I will update the documentation for the [/reviewer](https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/reviewer) pull request command once we have deployed this ?? ------------- PR: https://git.openjdk.java.net/skara/pull/807 From ehelin at openjdk.java.net Tue Sep 8 13:35:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 13:35:20 GMT Subject: RFR: vcs: do not hard-code VCS default branch names [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that ensures that we don't hard-code the name of the default branches for various version > control system throughout the Skara source code. Skara has from the beginning been very strict about abstracting away > VCS implementation details, but the name of the default branches has managed to find its way into multiple corners of > the source code. Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Use abstraction for HgRepository as well ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/806/files - new: https://git.openjdk.java.net/skara/pull/806/files/6b2063aa..85f2b95f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=806&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=806&range=00-01 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/806.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/806/head:pull/806 PR: https://git.openjdk.java.net/skara/pull/806 From ehelin at openjdk.java.net Tue Sep 8 13:39:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 8 Sep 2020 13:39:09 GMT Subject: Integrated: vcs: do not hard-code VCS default branch names In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 13:16:08 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that we don't hard-code the name of the default branches for various version > control system throughout the Skara source code. Skara has from the beginning been very strict about abstracting away > VCS implementation details, but the name of the default branches has managed to find its way into multiple corners of > the source code. Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: fa0aa00b Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fa0aa00b Stats: 57 lines in 20 files changed: 1 ins; 22 del; 34 mod vcs: do not hard-code VCS default branch names Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/806 From rwestberg at openjdk.java.net Tue Sep 8 15:15:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 8 Sep 2020 15:15:15 GMT Subject: RFR: Properly check for user not found in Jira Message-ID: When checking if a user can be found by email address, the result will be an array on success, and something else otherwise. Best regards, Robin ------------- Commit messages: - Properly check for user not found Changes: https://git.openjdk.java.net/skara/pull/808/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=808&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/808.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/808/head:pull/808 PR: https://git.openjdk.java.net/skara/pull/808 From ehelin at openjdk.java.net Wed Sep 9 05:56:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 05:56:37 GMT Subject: RFR: Properly check for user not found in Jira In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 15:12:40 GMT, Robin Westberg wrote: > When checking if a user can be found by email address, the result will be an array on success, and something else > otherwise. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/808 From rwestberg at openjdk.java.net Wed Sep 9 06:42:57 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 06:42:57 GMT Subject: Integrated: Properly check for user not found in Jira In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 15:12:40 GMT, Robin Westberg wrote: > When checking if a user can be found by email address, the result will be an array on success, and something else > otherwise. > Best regards, > Robin This pull request has now been integrated. Changeset: ea4920d8 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ea4920d8 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Properly check for user not found in Jira Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/808 From rwestberg at openjdk.java.net Wed Sep 9 07:05:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 07:05:05 GMT Subject: Integrated: 599: Unverified reviews should not count towards jcheck In-Reply-To: References: Message-ID: On Tue, 8 Sep 2020 13:18:00 GMT, Robin Westberg wrote: > The usage of the `/reviewer add` command has apparently been a bit confusing. This change renames the `add` sub command > to `credit` instead to clarify the intent better. Such manually credited reviewers will also not count towards the > "formal" review requirements as specified by the jcheck configuration. This pull request has now been integrated. Changeset: d23a796d Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/d23a796d Stats: 74 lines in 6 files changed: 4 ins; 20 del; 50 mod 599: Unverified reviews should not count towards jcheck Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/807 From shade at redhat.com Wed Sep 9 07:06:17 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 9 Sep 2020 09:06:17 +0200 Subject: JDK Sandbox and Skara In-Reply-To: References: Message-ID: On 9/8/20 3:02 PM, Erik Helin wrote: > Yes, good suggestion, I added an entry [2]. Thanks, that's useful. -- -Aleksey From shade at redhat.com Wed Sep 9 07:49:08 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 9 Sep 2020 09:49:08 +0200 Subject: Using PR /test instead of jdk-submit: "You need to get approval" Message-ID: Hi, Now I have questions for jdk-submit-like functionality :) Look at this PR: https://github.com/openjdk/jdk/pull/92 When both "/test tier1" and "/test builds" is requested, the bot replies: "@shipilev you need to get approval to run the tests in tier1 for commits up to ..." I am confused about what that means. Does it mean I have to have some additional privileges to use /test? Does it mean the PR should be Reviewed first? Either way, I think the message should be a bit more clear. -- Thanks, -Aleksey From erik.helin at oracle.com Wed Sep 9 08:50:51 2020 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 9 Sep 2020 10:50:51 +0200 Subject: Using PR /test instead of jdk-submit: "You need to get approval" In-Reply-To: References: Message-ID: <2148ccfa-9658-2085-1479-98ebc94467a0@oracle.com> On 9/9/20 9:49 AM, Aleksey Shipilev wrote: > Hi, > > Now I have questions for jdk-submit-like functionality :) > > Look at this PR: > ? https://github.com/openjdk/jdk/pull/92 > > When both "/test tier1" and "/test builds" is requested, the bot replies: > ?"@shipilev you need to get approval to run the tests in tier1 for > commits up to ..." > > I am confused about what that means. Does it mean I have to have some > additional privileges to use /test? Does it mean the PR should be > Reviewed first? Either way, I think the message should be a bit more clear. The bot powering the /test command is feeling so-so at the moment, see my reply to Yasumasa on jdk-dev [0]. I'm hoping to find some cycles to fix this today, but there are few other bugs with high prio to handle at the moment too :/ I should have this fixed by end of this week, sorry for any inconveniences this may have caused. Thanks, Erik [0]: https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004702.html From shade at redhat.com Wed Sep 9 10:06:29 2020 From: shade at redhat.com (Aleksey Shipilev) Date: Wed, 9 Sep 2020 12:06:29 +0200 Subject: JDK Sandbox and Skara In-Reply-To: References: Message-ID: <418c3df4-f520-9330-29da-84b1736749e8@redhat.com> Hi again, On 9/8/20 3:02 PM, Erik Helin wrote: > Yes, since you are a Committer (actually Reviewer, but the point here is > that you have Committer status) you have been given direct write access > to the openjdk/jdk-sandbox repository [0]. Feel free to use the > openjdk/jdk-sandbox repository in the same way as you used the Mercurial > jdk/sandbox repository [1]. Okay, then another clarification. When we need to update our jdk-sandbox branches to current state of master, we are just plainly "git merge" master to our branches, right? In other words, we do the same thing as we do with Mercurial here. We don't do any of "git rebase" magic, even for jdk-sandbox, because the jdk-sandbox branches are already public and it would make a mess for other contributors to the same branch? It probably makes some sense to say that rebase should not be used except within the personal forks? -- Thanks, -Aleksey From rwestberg at openjdk.java.net Wed Sep 9 10:09:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 10:09:29 GMT Subject: RFR: 625: Proxy build plugin should work on URLs without scheme In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 10:01:20 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the build work with http proxy environment variables that do not have a scheme > (i.e. does not have a `http://` prefix). > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Marked as reviewed by rwestberg (Reviewer). Looks good! ------------- PR: https://git.openjdk.java.net/skara/pull/809 From ehelin at openjdk.java.net Wed Sep 9 10:09:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 10:09:28 GMT Subject: RFR: 625: Proxy build plugin should work on URLs without scheme Message-ID: Hi all, please review this patch that makes the build work with http proxy environment variables that do not have a scheme (i.e. does not have a `http://` prefix). Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - 625 Changes: https://git.openjdk.java.net/skara/pull/809/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=809&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-625 Stats: 28 lines in 1 file changed: 17 ins; 1 del; 10 mod Patch: https://git.openjdk.java.net/skara/pull/809.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/809/head:pull/809 PR: https://git.openjdk.java.net/skara/pull/809 From ehelin at openjdk.java.net Wed Sep 9 10:12:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 10:12:20 GMT Subject: Integrated: 625: Proxy build plugin should work on URLs without scheme In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 10:01:20 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the build work with http proxy environment variables that do not have a scheme > (i.e. does not have a `http://` prefix). > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: ab9de3dc Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ab9de3dc Stats: 30 lines in 1 file changed: 3 ins; 19 del; 8 mod 625: Proxy build plugin should work on URLs without scheme Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/809 From erik.helin at oracle.com Wed Sep 9 10:18:09 2020 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 9 Sep 2020 03:18:09 -0700 (PDT) Subject: JDK Sandbox and Skara In-Reply-To: <418c3df4-f520-9330-29da-84b1736749e8@redhat.com> References: <418c3df4-f520-9330-29da-84b1736749e8@redhat.com> Message-ID: On 9/9/20 12:06 PM, Aleksey Shipilev wrote: > Hi again, > > On 9/8/20 3:02 PM, Erik Helin wrote: >> Yes, since you are a Committer (actually Reviewer, but the point here is >> that you have Committer status) you have been given direct write access >> to the openjdk/jdk-sandbox repository [0]. Feel free to use the >> openjdk/jdk-sandbox repository in the same way as you used the Mercurial >> jdk/sandbox repository [1]. > > Okay, then another clarification. > > When we need to update our jdk-sandbox branches to current state of > master, we are just plainly "git merge" master to our branches, right? > In other words, we do the same thing as we do with Mercurial here. Yep. > We don't do any of "git rebase" magic, even for jdk-sandbox, because the > jdk-sandbox branches are already public and it would make a mess for > other contributors to the same branch? It probably makes some sense to > say that rebase should not be used except within the personal forks? If you are the sole person working on your personal branch in jdk-sandbox, then feel free to rebase. If there are multiple people collaborating (what I guess will be the most common use-case for branches in jdk-sandbox) then you are correct, then you should use merge in order to not mutate public history. I should probably just "port" the old Mercurial sandbox documentation [0] over to a new "Sandbox" page on the Skara wiki and in the process add a note about this. I will get to that shortly, thanks for pointing this out! Thanks, Erik [0]: https://cr.openjdk.java.net/~chegar/docs/sandbox.html From ehelin at openjdk.java.net Wed Sep 9 10:24:18 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 10:24:18 GMT Subject: RFR: jira: make links() more reliable Message-ID: Hi all, please review this patch that makes `JiraIssue.links()` a bit more reliable in the face of unexpected HTTP codes. I also took the liberty to use an `ArrayList` instead of concatenating `Stream`s. Thanks, Erik ------------- Commit messages: - jira: make links() more reliable Changes: https://git.openjdk.java.net/skara/pull/810/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=810&range=00 Stats: 19 lines in 1 file changed: 7 ins; 0 del; 12 mod Patch: https://git.openjdk.java.net/skara/pull/810.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/810/head:pull/810 PR: https://git.openjdk.java.net/skara/pull/810 From rwestberg at openjdk.java.net Wed Sep 9 10:24:19 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 10:24:19 GMT Subject: RFR: jira: make links() more reliable In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 10:19:32 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `JiraIssue.links()` a bit more reliable in the face of unexpected HTTP codes. I > also took the liberty to use an `ArrayList` instead of concatenating `Stream`s. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/810 From rwestberg at openjdk.java.net Wed Sep 9 11:12:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 11:12:37 GMT Subject: RFR: 616: Sponsorship information is incorrect. Message-ID: In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, just say that Committer status is required. Best regards, Robin ------------- Commit messages: - Skip discerning between authors and non-authors for the sponsor message Changes: https://git.openjdk.java.net/skara/pull/811/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=811&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-616 Stats: 7 lines in 1 file changed: 0 ins; 5 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/811.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/811/head:pull/811 PR: https://git.openjdk.java.net/skara/pull/811 From ehelin at openjdk.java.net Wed Sep 9 11:31:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 11:31:31 GMT Subject: RFR: 616: Sponsorship information is incorrect. In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 11:09:38 GMT, Robin Westberg wrote: > In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, > just say that Committer status is required. > Best regards, > Robin bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 586: > 584: message.append("\n"); > 585: var contributor = censusInstance.namespace().get(pr.author().id()); > 586: message.append("As you do not have [Committer](https://openjdk.java.net/bylaws#committer) status in > this project, "); Can we make `project` a link to the project in https://openjdk.java.net/census ? ------------- PR: https://git.openjdk.java.net/skara/pull/811 From ehelin at openjdk.java.net Wed Sep 9 11:32:01 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 11:32:01 GMT Subject: Integrated: jira: make links() more reliable In-Reply-To: References: Message-ID: <1KE_CnDPeqyD9DZuovirVhqRy61XG9l34Dcab1hXYEE=.7718ff45-cc0e-428f-8169-29765ecfba0d@github.com> On Wed, 9 Sep 2020 10:19:32 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `JiraIssue.links()` a bit more reliable in the face of unexpected HTTP codes. I > also took the liberty to use an `ArrayList` instead of concatenating `Stream`s. > Thanks, > Erik This pull request has now been integrated. Changeset: 985532db Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/985532db Stats: 19 lines in 1 file changed: 0 ins; 7 del; 12 mod jira: make links() more reliable Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/810 From rwestberg at openjdk.java.net Wed Sep 9 11:49:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 11:49:33 GMT Subject: RFR: 616: Sponsorship information is incorrect. [v2] In-Reply-To: References: Message-ID: <9EE4uBQLdXDCdX5R31NgiJ3GhIVjECc0ym2ys16YmwY=.89cd5b21-e537-4be5-803f-be2fca10c33c@github.com> > In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, > just say that Committer status is required. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Add a link to the project member list in the census ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/811/files - new: https://git.openjdk.java.net/skara/pull/811/files/fc35c49e..e00e9588 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=811&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=811&range=00-01 Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/811.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/811/head:pull/811 PR: https://git.openjdk.java.net/skara/pull/811 From ehelin at openjdk.java.net Wed Sep 9 12:00:38 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 12:00:38 GMT Subject: RFR: 616: Sponsorship information is incorrect. [v2] In-Reply-To: <9EE4uBQLdXDCdX5R31NgiJ3GhIVjECc0ym2ys16YmwY=.89cd5b21-e537-4be5-803f-be2fca10c33c@github.com> References: <9EE4uBQLdXDCdX5R31NgiJ3GhIVjECc0ym2ys16YmwY=.89cd5b21-e537-4be5-803f-be2fca10c33c@github.com> Message-ID: On Wed, 9 Sep 2020 11:49:33 GMT, Robin Westberg wrote: >> In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, >> just say that Committer status is required. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Add a link to the project member list in the census Looks great! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/811 From ehelin at openjdk.java.net Wed Sep 9 12:17:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 12:17:27 GMT Subject: RFR: 598: Add test-request label when test request needs approval Message-ID: Hi all, please review this patch that adds a label for test requests. Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit tests Thanks, Erik ------------- Commit messages: - 598 Changes: https://git.openjdk.java.net/skara/pull/812/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=812&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-598 Stats: 92 lines in 3 files changed: 91 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/812.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/812/head:pull/812 PR: https://git.openjdk.java.net/skara/pull/812 From rwestberg at openjdk.java.net Wed Sep 9 12:17:27 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 9 Sep 2020 12:17:27 GMT Subject: RFR: 598: Add test-request label when test request needs approval In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 12:13:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a label for test requests. > > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/812 From ehelin at openjdk.java.net Wed Sep 9 12:20:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 9 Sep 2020 12:20:19 GMT Subject: Integrated: 598: Add test-request label when test request needs approval In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 12:13:00 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a label for test requests. > > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: fe45ab05 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fe45ab05 Stats: 92 lines in 3 files changed: 0 ins; 91 del; 1 mod 598: Add test-request label when test request needs approval Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/812 From robberphex at gmail.com Thu Sep 10 05:44:10 2020 From: robberphex at gmail.com (Robert Lu) Date: Thu, 10 Sep 2020 13:44:10 +0800 Subject: jdk/jdk repository transition to Git, GitHub and Skara is done In-Reply-To: References: Message-ID: Hi, Thanks for supporting git. I tried to open a PR(https://github.com/openjdk/jdk/pull/104), but I have two questions: 1. I signed OCA as `Robert Lu`, which is different with my GitHub name. so The bot marked my as oca-verify. How could I associate my GitHub name with the name in OCA list? 2. the bot will add `Progress` section for PR, but the format is(all in one line): --------- ### Progress - [x] Change must not contain extraneous whitespace - [ ] Commit message must refer to an issue - [ ] Change must be properly reviewed It looks like the bot post markdown in the wrong format, please fix this. On Sat, Sep 5, 2020 at 8:22 PM Erik Helin wrote: > Hi all, > > the transition to Git, GitHub and Skara for the Mercurial jdk/jdk [0] > and jdk/sandbox [1] is now done. The Git repositories jdk [2] and > jdk-sandbox [3] are now open for contributions. Note that the jdk/client > repository has been retired [4] and that the jdk/submit repository has > been replaced by /test pull request command [5]. Due to planned > maintenance the /test pull request command might now work reliably until > Sep 7 [14]. > > To get started with Git, GitHub and Skara, see the "Getting Started" > section on the Skara wiki [6]. In particular, make sure that you > associate your OpenJDK username with your GitHub username [7]. On the > Skara wiki you will also find: > > - an extensive FAQ [8] > - reference documentation for all pull request commands [9] > - reference documentation for all CLI tools [10] > > If you are new to Git then we strongly recommend the excellent "Pro Git" > book to get started. The book is freely available for reading online at > https://git-scm.com/book and can also be downloaded for offline reading. > > For those of you working with the JDK Updates project (whose > repositories still use Mercurial) the Skara CLI tooling is backwards > compatible with Mercurial. For more information about using the Skara > CLI tools and Mercurial, including how to import a Git patch to > Mercurial, see the Skara wiki [11]. > > With a transition this large and complex, we are bound to have missed > something. If you run into bugs, errors or if something is missing, > start by taking a deep breath :) We also get annoyed when the tools we > use for our daily work aren't working as expected, so we feel your > frustration. If you run into issues, please reach out to us on skara-dev > [11], ping us on IRC [12] or file a bug on Skara in JBS [13]. > > Last, but definitely not least, we would like to thank the following > people for making this transition possible: > > - Mark Reinhold > - Joe Darcy > - Erik Joelsson > - Stanislav Smirnov > - Christian T?rnqvist > - Tim Bell > - Tony Squier > - All Skara contributors! > > A huge thank you also to all OpenJDK projects that have transitioned > before the JDK project. You have all provided invaluable feedback that > has helped shaped the Git, GitHub and Skara experience. Please help your > friends and colleagues in OpenJDK that are now embarking on the same > transition that you all have already accomplished. > > Thanks! > Erik and Robin > > [0]: https://hg.openjdk.java.net/jdk/jdk > [1]: https://hg.openjdk.java.net/jdk/sandbox > [2]: https://git.openjdk.java.net/jdk > [3]: https://git.openjdk.java.net/jdk-sandbox > [4]: > https://mail.openjdk.java.net/pipermail/2d-dev/2020-August/011004.html > [5]: > > https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands#PullRequestCommands-/test > [6]: https://wiki.openjdk.java.net/display/SKARA/#Skara-GettingStarted > [7]: > > https://wiki.openjdk.java.net/display/SKARA/#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername > [8]: https://wiki.openjdk.java.net/display/skara/FAQ > [9]: https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands > [10]: https://wiki.openjdk.java.net/display/SKARA/CLI+Tools > [11]: skara-dev at openjdk.java.net > [12]: #openjdk on irc.oftc.net > [13]: https://bugs.openjdk.java.net/projects/SKARA/issues > [14]: > https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004689.html > -- Robert Lu About me: https://www.robberphex.com/about-me From ehelin at openjdk.java.net Thu Sep 10 13:24:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 10 Sep 2020 13:24:05 GMT Subject: Integrated: 634: Refresh PR data between commands in CommandWorkItem Message-ID: Hi all, please review this patch that ensures that the pull request data is re-fetched between commands are being run (since commands can affect the PR state). Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - 634 Changes: https://git.openjdk.java.net/skara/pull/813/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=813&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-634 Stats: 63 lines in 3 files changed: 59 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/813.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/813/head:pull/813 PR: https://git.openjdk.java.net/skara/pull/813 From ehelin at openjdk.java.net Thu Sep 10 13:24:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 10 Sep 2020 13:24:05 GMT Subject: Integrated: 634: Refresh PR data between commands in CommandWorkItem In-Reply-To: References: Message-ID: On Thu, 10 Sep 2020 13:19:37 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that the pull request data is re-fetched between commands are being run (since > commands can affect the PR state). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: de0ffaa7 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/de0ffaa7 Stats: 63 lines in 3 files changed: 0 ins; 59 del; 4 mod 634: Refresh PR data between commands in CommandWorkItem Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/813 From rwestberg at openjdk.java.net Thu Sep 10 13:24:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 10 Sep 2020 13:24:05 GMT Subject: Integrated: 634: Refresh PR data between commands in CommandWorkItem In-Reply-To: References: Message-ID: <1GthfpuZR97sqD5JzafiCs3RTDhdKJSVKoTMkNGjJPM=.d1d57b5d-e84e-4965-a294-8409248d55e8@github.com> On Thu, 10 Sep 2020 13:19:37 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that the pull request data is re-fetched between commands are being run (since > commands can affect the PR state). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/813 From rwestberg at openjdk.java.net Thu Sep 10 13:29:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 10 Sep 2020 13:29:38 GMT Subject: Integrated: 616: Sponsorship information is incorrect. In-Reply-To: References: Message-ID: On Wed, 9 Sep 2020 11:09:38 GMT, Robin Westberg wrote: > In the "this PR requires a sponsor" message, there's no need to display different messages depending on author status, > just say that Committer status is required. > Best regards, > Robin This pull request has now been integrated. Changeset: 8806fe56 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/8806fe56 Stats: 7 lines in 1 file changed: 2 ins; 0 del; 5 mod 616: Sponsorship information is incorrect. Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/811 From rwestberg at openjdk.java.net Fri Sep 11 07:10:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 07:10:26 GMT Subject: RFR: Treat bad whitespace in commit message gracefully Message-ID: The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line summaries to help avoid this problem in the first place. Best regards, Robin ------------- Commit messages: - Treat bad whitespace in commit message gracefully Changes: https://git.openjdk.java.net/skara/pull/814/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=814&range=00 Stats: 6 lines in 2 files changed: 3 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/814.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/814/head:pull/814 PR: https://git.openjdk.java.net/skara/pull/814 From ehelin at openjdk.java.net Fri Sep 11 07:13:20 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 07:13:20 GMT Subject: RFR: Treat bad whitespace in commit message gracefully In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 07:07:39 GMT, Robin Westberg wrote: > The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line > summaries to help avoid this problem in the first place. > Best regards, > Robin bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 204: > 202: @Override > 203: public void visit(MessageWhitespaceIssue issue) { > 204: addFailureMessage(issue.check(), "The commit message contains bad whitespace"); Suggestion: String desc = null; if (issue.kind() == MessageWhitespaceIssue.Whitespace.TRAILING) { desc = "trailing whitespace"; } else if (issue.kind() == MessageWhitespaceIssue.Whitespace.CR) { desc = "a carriage return"; } else { desc = "a tab"; } addFailureMessage(issue.check(), "The commit message contains " + desc + " on line " + issue.line()); ------------- PR: https://git.openjdk.java.net/skara/pull/814 From rwestberg at openjdk.java.net Fri Sep 11 07:17:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 07:17:30 GMT Subject: RFR: Treat bad whitespace in commit message gracefully [v2] In-Reply-To: References: Message-ID: > The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line > summaries to help avoid this problem in the first place. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Updated after review ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/814/files - new: https://git.openjdk.java.net/skara/pull/814/files/13c77292..6ed61f60 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=814&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=814&range=00-01 Stats: 9 lines in 1 file changed: 8 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/814.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/814/head:pull/814 PR: https://git.openjdk.java.net/skara/pull/814 From ehelin at openjdk.java.net Fri Sep 11 07:20:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 07:20:49 GMT Subject: RFR: Treat bad whitespace in commit message gracefully [v2] In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 07:17:30 GMT, Robin Westberg wrote: >> The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line >> summaries to help avoid this problem in the first place. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Updated after review bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 211: > 209: } else { > 210: desc = "a tab"; > 211: } Suggestion: } else if (issue.kind() == MessageWhitespaceIssue.Whitespace.TAB) { desc = "a tab"; } else { throw new IllegalStateException("Unknown whitespace: " + issue.kind()); } ------------- PR: https://git.openjdk.java.net/skara/pull/814 From rwestberg at openjdk.java.net Fri Sep 11 07:24:22 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 07:24:22 GMT Subject: RFR: Treat bad whitespace in commit message gracefully [v3] In-Reply-To: References: Message-ID: > The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line > summaries to help avoid this problem in the first place. > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: One more update ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/814/files - new: https://git.openjdk.java.net/skara/pull/814/files/6ed61f60..ae22b04d Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=814&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=814&range=01-02 Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/814.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/814/head:pull/814 PR: https://git.openjdk.java.net/skara/pull/814 From ehelin at openjdk.java.net Fri Sep 11 07:45:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 07:45:59 GMT Subject: RFR: Treat bad whitespace in commit message gracefully [v3] In-Reply-To: References: Message-ID: <-nglk2yGdmfKWa2jp9sBiQBFiI7WC6hiv-hhbkIX9eE=.3714457d-5101-4065-ae28-057bd2edbf2b@github.com> On Fri, 11 Sep 2020 07:24:22 GMT, Robin Westberg wrote: >> The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line >> summaries to help avoid this problem in the first place. >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > One more update Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/814 From dalibor.topic at oracle.com Fri Sep 11 08:12:47 2020 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 11 Sep 2020 10:12:47 +0200 Subject: jdk/jdk repository transition to Git, GitHub and Skara is done In-Reply-To: References: Message-ID: On 10.09.2020 07:44, Robert Lu wrote: > Hi, > Thanks for supporting git. > > I tried to open a PR(https://github.com/openjdk/jdk/pull/104), but I have > two questions: > 1. I signed OCA as `Robert Lu`, which is different with my GitHub name. so > The bot marked my as oca-verify. How could I associate my GitHub name with > the name in OCA list? In that case there's a manual step that needs to be done on our end. I'll take care of initiating it. cheers, dalibor topic -- Dalibor Topic Consulting Product Manager Phone: +494089091214 , Mobile: +491737185961 , Video: dalibor.topic at oracle.com Oracle Global Services Germany GmbH Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRB 246209 Gesch?ftsf?hrer: Ralf Herrmann From rwestberg at openjdk.java.net Fri Sep 11 08:41:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 08:41:18 GMT Subject: Integrated: Treat bad whitespace in commit message gracefully In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 07:07:39 GMT, Robin Westberg wrote: > The check "message" should handle the error gracefully instead of throwing. Also trim individual lines in multi-line > summaries to help avoid this problem in the first place. > Best regards, > Robin This pull request has now been integrated. Changeset: b59316d0 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/b59316d0 Stats: 16 lines in 2 files changed: 0 ins; 13 del; 3 mod Treat bad whitespace in commit message gracefully Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/814 From ehelin at openjdk.java.net Fri Sep 11 09:03:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 09:03:16 GMT Subject: Integrated: vcs: better regex for real names Message-ID: Hi all, please review this patch that makes the real name regular expression in the commit message parser accept essentially all characters except the one used in e-mail addresses. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: better regex for real names Changes: https://git.openjdk.java.net/skara/pull/815/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=815&range=00 Stats: 22 lines in 3 files changed: 19 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/815.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/815/head:pull/815 PR: https://git.openjdk.java.net/skara/pull/815 From rwestberg at openjdk.java.net Fri Sep 11 09:03:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 09:03:16 GMT Subject: Integrated: vcs: better regex for real names In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 08:59:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the real name regular expression in the commit message parser accept essentially > all characters except the one used in e-mail addresses. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/815 From ehelin at openjdk.java.net Fri Sep 11 09:03:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 09:03:17 GMT Subject: Integrated: vcs: better regex for real names In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 08:59:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the real name regular expression in the commit message parser accept essentially > all characters except the one used in e-mail addresses. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 5c7b36ec Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/5c7b36ec Stats: 22 lines in 3 files changed: 0 ins; 19 del; 3 mod vcs: better regex for real names Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/815 From dalibor.topic at oracle.com Fri Sep 11 10:42:20 2020 From: dalibor.topic at oracle.com (Dalibor Topic) Date: Fri, 11 Sep 2020 12:42:20 +0200 Subject: jdk/jdk repository transition to Git, GitHub and Skara is done In-Reply-To: References: Message-ID: <8a3dc46c-7807-15d7-d92f-4f256053b835@oracle.com> On 11.09.2020 10:12, Dalibor Topic wrote: > > > On 10.09.2020 07:44, Robert Lu wrote: >> Hi, >> Thanks for supporting git. >> >> I tried to open a PR(https://github.com/openjdk/jdk/pull/104), but I have >> two questions: >> 1. I signed OCA as `Robert Lu`, which is different with my GitHub >> name. so >> The bot marked my as oca-verify. How could I associate my GitHub name >> with >> the name in OCA list? > > In that case there's a manual step that needs to be done on our end. > I'll take care of initiating it. Done. cheers, dalibor topic -- Dalibor Topic Consulting Product Manager Phone: +494089091214 , Mobile: +491737185961 , Video: dalibor.topic at oracle.com Oracle Global Services Germany GmbH Hauptverwaltung: Riesstr. 25, D-80992 M?nchen Registergericht: Amtsgericht M?nchen, HRB 246209 Gesch?ftsf?hrer: Ralf Herrmann From rwestberg at openjdk.java.net Fri Sep 11 11:54:35 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 11 Sep 2020 11:54:35 GMT Subject: RFR: Set the resolved in build custom field in Jira when resolving an issue (if configured) Message-ID: When the issue notifier resolves an issue upon commit, it should also set the "Resolved In Build" field, if so configured. Best regards, Robin ------------- Commit messages: - Set the resolved in build custom field in Jira when resolving an issue (if configured) Changes: https://git.openjdk.java.net/skara/pull/816/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=816&range=00 Stats: 21 lines in 4 files changed: 17 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/816.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/816/head:pull/816 PR: https://git.openjdk.java.net/skara/pull/816 From ehelin at openjdk.java.net Fri Sep 11 13:05:27 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 11 Sep 2020 13:05:27 GMT Subject: RFR: Set the resolved in build custom field in Jira when resolving an issue (if configured) In-Reply-To: References: Message-ID: <-53GbG0DAWq5nW5CbmxuOfZL81U1EFS3soPYgDggqtw=.b2226eda-24b7-4eeb-b500-3d83bfeaa32e@github.com> On Fri, 11 Sep 2020 11:51:31 GMT, Robin Westberg wrote: > When the issue notifier resolves an issue upon commit, it should also set the "Resolved In Build" field, if so > configured. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/816 From erik.helin at oracle.com Fri Sep 11 13:19:58 2020 From: erik.helin at oracle.com (Erik Helin) Date: Fri, 11 Sep 2020 15:19:58 +0200 Subject: jdk/jdk repository transition to Git, GitHub and Skara is done In-Reply-To: References: Message-ID: <3a6df370-ff88-892e-c037-d42f48693499@oracle.com> On 9/10/20 7:44 AM, Robert Lu wrote: > 2. the bot will add `Progress` section for PR, but the format is(all in > one line): > --------- ### Progress - [x] Change must not contain extraneous > whitespace - [ ] Commit message must refer to an issue - [ ] Change must > be properly reviewed > It looks like the bot post markdown in the wrong format, please fix this. We were missing a blank line prior to our HTML comment, I filed SKARA-660 [0]. Thanks, Erik [0]: https://bugs.openjdk.java.net/browse/SKARA-660 From rwestberg at openjdk.java.net Mon Sep 14 07:21:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 14 Sep 2020 07:21:38 GMT Subject: Integrated: Set the resolved in build custom field in Jira when resolving an issue (if configured) In-Reply-To: References: Message-ID: On Fri, 11 Sep 2020 11:51:31 GMT, Robin Westberg wrote: > When the issue notifier resolves an issue upon commit, it should also set the "Resolved In Build" field, if so > configured. > Best regards, > Robin This pull request has now been integrated. Changeset: 6c04c128 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/6c04c128 Stats: 21 lines in 4 files changed: 0 ins; 17 del; 4 mod Set the resolved in build custom field in Jira when resolving an issue (if configured) Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/816 From rwestberg at openjdk.java.net Mon Sep 14 12:13:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 14 Sep 2020 12:13:04 GMT Subject: RFR: Set or update the resolved in build field when new tags arrive Message-ID: When the issue notifier is configured to set a build name when resolving issues, it should also update that name when an OpenJDK-formatted tag is seen in the repository. ------------- Commit messages: - Set or update the resolved in build field when new tags arrive Changes: https://git.openjdk.java.net/skara/pull/817/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=817&range=00 Stats: 369 lines in 4 files changed: 363 ins; 3 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/817.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/817/head:pull/817 PR: https://git.openjdk.java.net/skara/pull/817 From ehelin at openjdk.java.net Mon Sep 14 12:33:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 12:33:55 GMT Subject: RFR: jcheck: use census from .jcheck/conf by default Message-ID: Hi all, please review this patch that makes jcheck by default use the census file pointed to by .jcheck/conf (an overriding census can also be supplied). A whole bunch of trivial updates to tests were needed due to `CommitCheck.check` now taking a `Census` parameter. Testing: - [x] `make test` passes on Linux x64 - [x] `make images` passes on Linux x64 - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - jcheck: use census from .jcheck/conf by default Changes: https://git.openjdk.java.net/skara/pull/818/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=818&range=00 Stats: 246 lines in 34 files changed: 32 ins; 30 del; 184 mod Patch: https://git.openjdk.java.net/skara/pull/818.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/818/head:pull/818 PR: https://git.openjdk.java.net/skara/pull/818 From rwestberg at openjdk.java.net Mon Sep 14 12:36:56 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 14 Sep 2020 12:36:56 GMT Subject: RFR: jcheck: use census from .jcheck/conf by default In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 12:30:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes jcheck by default use the census file pointed to by .jcheck/conf (an overriding > census can also be supplied). A whole bunch of trivial updates to tests were needed due to `CommitCheck.check` now > taking a `Census` parameter. Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/818 From ehelin at openjdk.java.net Mon Sep 14 12:47:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 12:47:37 GMT Subject: RFR: Set or update the resolved in build field when new tags arrive In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 12:10:14 GMT, Robin Westberg wrote: > When the issue notifier is configured to set a build name when resolving issues, it should also update that name when > an OpenJDK-formatted tag is seen in the repository. Looks good, just spell out "rib" in two places ?? bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/BuildCompare.java line 40: > 38: } > 39: > 40: // Notable values for rib are 'team', 'master', and numbered builds Suggestion: // Notable values for "Resolved in Build" are 'team', 'master', and numbered builds bots/notify/src/main/java/org/openjdk/skara/bots/notify/issue/IssueNotifier.java line 296: > 294: var optionalIssue = issueProject.issue(commitIssue.shortId()); > 295: if (optionalIssue.isEmpty()) { > 296: log.severe("Cannot update RIB for issue " + commitIssue.id() Suggestion: log.severe("Cannot update "Resolved in Build" for issue " + commitIssue.id() ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/817 From ehelin at openjdk.java.net Mon Sep 14 12:48:07 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 12:48:07 GMT Subject: Integrated: jcheck: use census from .jcheck/conf by default In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 12:30:54 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes jcheck by default use the census file pointed to by .jcheck/conf (an overriding > census can also be supplied). A whole bunch of trivial updates to tests were needed due to `CommitCheck.check` now > taking a `Census` parameter. Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 4d2fa4aa Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/4d2fa4aa Stats: 246 lines in 34 files changed: 30 ins; 32 del; 184 mod jcheck: use census from .jcheck/conf by default Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/818 From ehelin at openjdk.java.net Mon Sep 14 14:14:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 14:14:28 GMT Subject: RFR: checkout-bot: support pulling tags Message-ID: Hi all, please review this patch that allows the checkout bot to support pulling tags. To achieve this I updated `Repository.pull` to take an explicit `includeTags` argument. Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - vcs: support pulling tags Changes: https://git.openjdk.java.net/skara/pull/819/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=819&range=00 Stats: 69 lines in 5 files changed: 55 ins; 0 del; 14 mod Patch: https://git.openjdk.java.net/skara/pull/819.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/819/head:pull/819 PR: https://git.openjdk.java.net/skara/pull/819 From rwestberg at openjdk.java.net Mon Sep 14 15:00:47 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 14 Sep 2020 15:00:47 GMT Subject: RFR: checkout-bot: support pulling tags In-Reply-To: References: Message-ID: <0ggldwmFBzQUgoe9roKIZj9WOjk9lEPimONHuPKF-uw=.3c5e5f27-02ae-4d60-a19d-4f5266ab7f6c@github.com> On Mon, 14 Sep 2020 14:11:29 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the checkout bot to support pulling tags. To achieve this I updated > `Repository.pull` to take an explicit `includeTags` argument. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik Looks good! Perhaps you could add an issue for this so that we see that the resolved in build functionality works. :) ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/819 From ehelin at openjdk.java.net Mon Sep 14 15:31:26 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 15:31:26 GMT Subject: Integrated: 672: Support pulling tags in checkout bot In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 14:11:29 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the checkout bot to support pulling tags. To achieve this I updated > `Repository.pull` to take an explicit `includeTags` argument. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: b86ed562 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b86ed562 Stats: 69 lines in 5 files changed: 0 ins; 55 del; 14 mod 672: Support pulling tags in checkout bot Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/819 From ehelin at openjdk.java.net Mon Sep 14 16:05:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 14 Sep 2020 16:05:52 GMT Subject: RFR: 673: PR author should be able to use /reviewers command Message-ID: Hi all, please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author knows ahead of time that it is a complicated to PR to review). Testing: - [x] `make test` passes on Linux x64 - [x] Added one additional unit test Thanks, Erik ------------- Commit messages: - 673 Changes: https://git.openjdk.java.net/skara/pull/820/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=820&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-673 Stats: 37 lines in 2 files changed: 35 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/820.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/820/head:pull/820 PR: https://git.openjdk.java.net/skara/pull/820 From kcr at openjdk.java.net Mon Sep 14 16:09:56 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 14 Sep 2020 16:09:56 GMT Subject: RFR: 673: PR author should be able to use /reviewers command In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 16:03:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author > knows ahead of time that it is a complicated to PR to review). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added one additional unit test > > Thanks, > Erik I presume that the author cannot reduce the number of reviewers once it has been increased, unless they are also a "R"eviewer? ------------- PR: https://git.openjdk.java.net/skara/pull/820 From kcr at openjdk.java.net Mon Sep 14 16:28:17 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 14 Sep 2020 16:28:17 GMT Subject: RFR: 673: PR author should be able to use /reviewers command In-Reply-To: References: Message-ID: <8lM_5k1P9VjJVQeZNaG2V2c9OWLQhxsxHOKoyCAvk8M=.72ba3781-8806-413b-98f6-b30e141dd348@github.com> On Mon, 14 Sep 2020 16:03:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author > knows ahead of time that it is a complicated to PR to review). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added one additional unit test > > Thanks, > Erik bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 52: > 50: @Override > 51: public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath, > CommandInvocation command, List allComments, PrintWriter reply) { 52: if > (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { This would suggest that my assumption is wrong, and that an author can reduce the number of reviewers required even if they are not a Reviewer. I think this might not be what we want. ------------- PR: https://git.openjdk.java.net/skara/pull/820 From prr at openjdk.java.net Mon Sep 14 20:20:16 2020 From: prr at openjdk.java.net (Phil Race) Date: Mon, 14 Sep 2020 20:20:16 GMT Subject: RFR: 673: PR author should be able to use /reviewers command In-Reply-To: <8lM_5k1P9VjJVQeZNaG2V2c9OWLQhxsxHOKoyCAvk8M=.72ba3781-8806-413b-98f6-b30e141dd348@github.com> References: <8lM_5k1P9VjJVQeZNaG2V2c9OWLQhxsxHOKoyCAvk8M=.72ba3781-8806-413b-98f6-b30e141dd348@github.com> Message-ID: On Mon, 14 Sep 2020 16:26:07 GMT, Kevin Rushforth wrote: >> Hi all, >> >> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author >> knows ahead of time that it is a complicated to PR to review). >> Testing: >> - [x] `make test` passes on Linux x64 >> - [x] Added one additional unit test >> >> Thanks, >> Erik > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 52: > >> 50: @Override >> 51: public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath, >> CommandInvocation command, List allComments, PrintWriter reply) { 52: if >> (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { > > This would suggest that my assumption is wrong, and that an author can reduce the number of reviewers required even if > they are not a Reviewer. I think this might not be what we want. I think it is fine to let them increase it. ------------- PR: https://git.openjdk.java.net/skara/pull/820 From kcr at openjdk.java.net Mon Sep 14 21:16:56 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 14 Sep 2020 21:16:56 GMT Subject: RFR: 673: PR author should be able to use /reviewers command In-Reply-To: References: <8lM_5k1P9VjJVQeZNaG2V2c9OWLQhxsxHOKoyCAvk8M=.72ba3781-8806-413b-98f6-b30e141dd348@github.com> Message-ID: On Mon, 14 Sep 2020 20:18:10 GMT, Phil Race wrote: >> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 52: >> >>> 50: @Override >>> 51: public void handle(PullRequestBot bot, PullRequest pr, CensusInstance censusInstance, Path scratchPath, >>> CommandInvocation command, List allComments, PrintWriter reply) { 52: if >>> (!pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { >> >> This would suggest that my assumption is wrong, and that an author can reduce the number of reviewers required even if >> they are not a Reviewer. I think this might not be what we want. > > I think it is fine to let them increase it. Agreed. It's the case of an author reducing it after a Reviewer has increased it that I think should be disallowed. ------------- PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 08:49:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 08:49:29 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author > knows ahead of time that it is a complicated to PR to review). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added one additional unit test > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: PR authors should not be allowed to decrease ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/820/files - new: https://git.openjdk.java.net/skara/pull/820/files/eef24783..347594f0 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=820&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=820&range=00-01 Stats: 120 lines in 5 files changed: 111 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/820.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/820/head:pull/820 PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 08:49:29 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 08:49:29 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v2] In-Reply-To: References: <8lM_5k1P9VjJVQeZNaG2V2c9OWLQhxsxHOKoyCAvk8M=.72ba3781-8806-413b-98f6-b30e141dd348@github.com> Message-ID: On Mon, 14 Sep 2020 21:14:45 GMT, Kevin Rushforth wrote: >> I think it is fine to let them increase it. > > Agreed. It's the case of an author reducing it after a Reviewer has increased it that I think should be disallowed. @kevinrushforth and @prrace - I agree, see changes in commit 347594f ------------- PR: https://git.openjdk.java.net/skara/pull/820 From rwestberg at openjdk.java.net Tue Sep 15 09:04:07 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 15 Sep 2020 09:04:07 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v2] In-Reply-To: References: Message-ID: On Tue, 15 Sep 2020 08:49:29 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author >> knows ahead of time that it is a complicated to PR to review). >> Testing: >> - [x] `make test` passes on Linux x64 >> - [x] Added one additional unit test >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > PR authors should not be allowed to decrease Looks good, but you can probably simplify it a bit since the "exclude" parameter isn't really used. :) bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersTracker.java line 105: > 103: } > 104: > 105: static Optional additionalRequiredReviewers(HostUser botUser, List > comments, Comment exclude) { The exclude comment parameter probably isn't the one you are looking for, as the reply marker isn't in the command comment but the reply. bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandInvocation.java line 16: > 14: private final Comment comment; > 15: > 16: CommandInvocation(String id, HostUser user, CommandHandler handler, String name, String args, Comment comment) { Think you can drop this parameter if you drop the exclude param! ------------- PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 09:47:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 09:47:03 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v3] In-Reply-To: References: Message-ID: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> > Hi all, > > please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author > knows ahead of time that it is a complicated to PR to review). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added one additional unit test > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Simplify code based on reviewer feedback ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/820/files - new: https://git.openjdk.java.net/skara/pull/820/files/347594f0..7b177683 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=820&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=820&range=01-02 Stats: 39 lines in 4 files changed: 0 ins; 23 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/820.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/820/head:pull/820 PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 09:48:57 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 09:48:57 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v2] In-Reply-To: References: Message-ID: On Tue, 15 Sep 2020 09:01:01 GMT, Robin Westberg wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> PR authors should not be allowed to decrease > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersTracker.java line 105: > >> 103: } >> 104: >> 105: static Optional additionalRequiredReviewers(HostUser botUser, List >> comments, Comment exclude) { > > The exclude comment parameter probably isn't the one you are looking for, as the reply marker isn't in the command > comment but the reply. Thanks, fixed in 7b17768 > bots/pr/src/main/java/org/openjdk/skara/bots/pr/CommandInvocation.java line 16: > >> 14: private final Comment comment; >> 15: >> 16: CommandInvocation(String id, HostUser user, CommandHandler handler, String name, String args, Comment comment) { > > Think you can drop this parameter if you drop the exclude param! Yep, fixed in 7b17768 ------------- PR: https://git.openjdk.java.net/skara/pull/820 From rwestberg at openjdk.java.net Tue Sep 15 11:59:02 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 15 Sep 2020 11:59:02 GMT Subject: RFR: Set or update the resolved in build field when new tags arrive [v2] In-Reply-To: References: Message-ID: > When the issue notifier is configured to set a build name when resolving issues, it should also update that name when > an OpenJDK-formatted tag is seen in the repository. Robin Westberg has updated the pull request incrementally with two additional commits since the last revision: - Apply suggestions from code review Co-authored-by: Erik Duveblad - Fix setting the resolved in build field in JBS ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/817/files - new: https://git.openjdk.java.net/skara/pull/817/files/c31aaab4..18cbafea Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=817&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=817&range=00-01 Stats: 70 lines in 6 files changed: 42 ins; 4 del; 24 mod Patch: https://git.openjdk.java.net/skara/pull/817.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/817/head:pull/817 PR: https://git.openjdk.java.net/skara/pull/817 From rwestberg at openjdk.java.net Tue Sep 15 12:33:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 15 Sep 2020 12:33:16 GMT Subject: Integrated: Set or update the resolved in build field when new tags arrive In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 12:10:14 GMT, Robin Westberg wrote: > When the issue notifier is configured to set a build name when resolving issues, it should also update that name when > an OpenJDK-formatted tag is seen in the repository. This pull request has now been integrated. Changeset: 9dd71506 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/9dd71506 Stats: 435 lines in 7 files changed: 7 ins; 405 del; 23 mod Set or update the resolved in build field when new tags arrive Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/817 From kcr at openjdk.java.net Tue Sep 15 12:57:01 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 15 Sep 2020 12:57:01 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v3] In-Reply-To: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> References: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> Message-ID: On Tue, 15 Sep 2020 09:47:03 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author >> knows ahead of time that it is a complicated to PR to review). >> Testing: >> - [x] `make test` passes on Linux x64 >> - [x] Added one additional unit test >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Simplify code based on reviewer feedback Looks good with one minor suggestion (feel free to ignore it). bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 111: > 109: } > 110: > 111: if (pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { Maybe simplify this to just `! isReviewer`? Including the test for `is author` doesn't really add value (removing it seems to better reflect the intent and might be safer / more future proof). ------------- Marked as reviewed by kcr (no project role). PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 13:21:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 13:21:36 GMT Subject: RFR: 637: PR author should be able to use /csr PR command Message-ID: Hi all, please review this patch that allows pull request authors that are *not* Reviewers to use the `/csr` command. A person who is not a Reviewer should still be allowed to state that a CSR is required (but not that state that a CSR is *not* required). Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - 637 Changes: https://git.openjdk.java.net/skara/pull/821/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=821&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-637 Stats: 29 lines in 2 files changed: 19 ins; 3 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/821.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/821/head:pull/821 PR: https://git.openjdk.java.net/skara/pull/821 From ehelin at openjdk.java.net Tue Sep 15 13:34:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 13:34:31 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v3] In-Reply-To: References: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> Message-ID: On Tue, 15 Sep 2020 12:52:47 GMT, Kevin Rushforth wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> Simplify code based on reviewer feedback > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 111: > >> 109: } >> 110: >> 111: if (pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { > > Maybe simplify this to just `! isReviewer`? Including the test for `is author` doesn't really add value (removing it > seems to better reflect the intent and might be safer / more future proof). No, we don't want people who are _not_ the PR author and who are _not_ Reviewers to be able to increase the required number of reviewers. Allowing that makes it possible to harass pull request by e.g. registering a spam account and just drop a bunch `/reviewers 9` in a number of PRs. ------------- PR: https://git.openjdk.java.net/skara/pull/820 From rwestberg at openjdk.java.net Tue Sep 15 13:35:29 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 15 Sep 2020 13:35:29 GMT Subject: RFR: 637: PR author should be able to use /csr PR command In-Reply-To: References: Message-ID: On Tue, 15 Sep 2020 13:18:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows pull request authors that are *not* Reviewers to use the `/csr` command. A person > who is not a Reviewer should still be allowed to state that a CSR is required (but not that state that a CSR is *not* > required). Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/821 From rwestberg at openjdk.java.net Tue Sep 15 13:36:41 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 15 Sep 2020 13:36:41 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v3] In-Reply-To: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> References: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> Message-ID: On Tue, 15 Sep 2020 09:47:03 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author >> knows ahead of time that it is a complicated to PR to review). >> Testing: >> - [x] `make test` passes on Linux x64 >> - [x] Added one additional unit test >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Simplify code based on reviewer feedback Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 14:29:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 14:29:39 GMT Subject: Integrated: 673: PR author should be able to use /reviewers command In-Reply-To: References: Message-ID: On Mon, 14 Sep 2020 16:03:01 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows pull request author's to issue the `/reviewers` command (sometimes the PR author > knows ahead of time that it is a complicated to PR to review). > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added one additional unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 82aa583d Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/82aa583d Stats: 126 lines in 3 files changed: 0 ins; 123 del; 3 mod 673: PR author should be able to use /reviewers command Reviewed-by: rwestberg, kcr ------------- PR: https://git.openjdk.java.net/skara/pull/820 From ehelin at openjdk.java.net Tue Sep 15 14:29:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 15 Sep 2020 14:29:50 GMT Subject: Integrated: 637: PR author should be able to use /csr PR command In-Reply-To: References: Message-ID: On Tue, 15 Sep 2020 13:18:48 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows pull request authors that are *not* Reviewers to use the `/csr` command. A person > who is not a Reviewer should still be allowed to state that a CSR is required (but not that state that a CSR is *not* > required). Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: d2f5dd9c Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d2f5dd9c Stats: 29 lines in 2 files changed: 3 ins; 19 del; 7 mod 637: PR author should be able to use /csr PR command Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/821 From kcr at openjdk.java.net Tue Sep 15 15:09:20 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Tue, 15 Sep 2020 15:09:20 GMT Subject: RFR: 673: PR author should be able to use /reviewers command [v3] In-Reply-To: References: <0z6KC8XoFflJ-z-d2Y0XbvGYwjGTWV8F0uqpiRPuUHM=.674e11d6-8530-4e3d-a489-ab45a2c2438e@github.com> Message-ID: On Tue, 15 Sep 2020 13:32:01 GMT, Erik Helin wrote: >> bots/pr/src/main/java/org/openjdk/skara/bots/pr/ReviewersCommand.java line 111: >> >>> 109: } >>> 110: >>> 111: if (pr.author().equals(command.user()) && !censusInstance.isReviewer(command.user())) { >> >> Maybe simplify this to just `! isReviewer`? Including the test for `is author` doesn't really add value (removing it >> seems to better reflect the intent and might be safer / more future proof). > > No, we don't want people who are _not_ the PR author and who are _not_ Reviewers to be able to increase the required > number of reviewers. Allowing that makes it possible to harass pull request by e.g. registering a spam account and just > drop a bunch `/reviewers 9` in a number of PRs. I agree, but that isn't related to this block (your concern is a good one and is handled by the previous block). By adding the `author &&` to `!reviewer` it makes this less restrictive not more. In any case, it doesn't matter...at least not given the prior test. ------------- PR: https://git.openjdk.java.net/skara/pull/820 From fw at deneb.enyo.de Tue Sep 15 17:44:48 2020 From: fw at deneb.enyo.de (Florian Weimer) Date: Tue, 15 Sep 2020 19:44:48 +0200 Subject: Missing metadata removal in jdk commit Message-ID: <87tuvz3pf3.fsf@mid.deneb.enyo.de> I see this in the commit history: commit 7eb4d4aa018e37052cbf37cd854380006c309645 Author: Kim Barrett Date: Tue Sep 15 10:52:50 2020 +0000 8247909: Improve PrimitiveConversions::cast using C++14 Reimpliment PrimitiveConversions::cast, with some cases now constexpr. --------- ### Progress - [x] Change must not contain extraneous whitespace - [x] Commit message must refer to an issue - [ ] Change must be properly reviewed ### Issue * [JDK-8247909](https://bugs.openjdk.java.net/browse/JDK-8247909): Improve PrimitiveConversions::cast using C++14 ### Download `$ git fetch https://git.openjdk.java.net/jdk pull/143/head:pull/143` `$ git checkout pull/143` Reviewed-by: dholmes, stefank I don't think it makes sense to preserve this information in the Git history, and the SGML comment suggests that it's expected to be stripped. From kevin.rushforth at oracle.com Tue Sep 15 18:04:06 2020 From: kevin.rushforth at oracle.com (Kevin Rushforth) Date: Tue, 15 Sep 2020 11:04:06 -0700 Subject: Missing metadata removal in jdk commit In-Reply-To: <87tuvz3pf3.fsf@mid.deneb.enyo.de> References: <87tuvz3pf3.fsf@mid.deneb.enyo.de> Message-ID: <87d4dbdb-0703-959c-718a-2fa1a40cec8c@oracle.com> This looks like a bug in Skara when parsing the "/summary" commands from the Description. Perhaps "/summary" should be limited to a single line when part of the Description, or else disallowed entirely in the Description and only be parsed in comments? -- Kevin On 9/15/2020 10:44 AM, Florian Weimer wrote: > I see this in the commit history: > > commit 7eb4d4aa018e37052cbf37cd854380006c309645 > Author: Kim Barrett > Date: Tue Sep 15 10:52:50 2020 +0000 > > 8247909: Improve PrimitiveConversions::cast using C++14 > > Reimpliment PrimitiveConversions::cast, with some cases now constexpr. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Issue > * [JDK-8247909](https://bugs.openjdk.java.net/browse/JDK-8247909): Improve PrimitiveConversions::cast using C++14 > > > ### Download > `$ git fetch https://git.openjdk.java.net/jdk pull/143/head:pull/143` > `$ git checkout pull/143` > > Reviewed-by: dholmes, stefank > > I don't think it makes sense to preserve this information in the Git > history, and the SGML comment suggests that it's expected to be > stripped. From ehelin at openjdk.java.net Wed Sep 16 07:46:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 07:46:28 GMT Subject: RFR: 680: Allow /csr command in PR body Message-ID: Hi all, please review this patch that allows the `/csr` pull request command to be used in the PR body. Testing: - [x] `make test` passes - [x] Added one addition Thanks, Erik ------------- Commit messages: - 680 Changes: https://git.openjdk.java.net/skara/pull/822/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=822&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-680 Stats: 39 lines in 2 files changed: 39 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/822.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/822/head:pull/822 PR: https://git.openjdk.java.net/skara/pull/822 From rwestberg at openjdk.java.net Wed Sep 16 07:49:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 16 Sep 2020 07:49:36 GMT Subject: RFR: 680: Allow /csr command in PR body In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 07:14:23 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the `/csr` pull request command to be used in the PR body. > > Testing: > - [x] `make test` passes > - [x] Added one addition > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/822 From ehelin at openjdk.java.net Wed Sep 16 07:49:36 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 07:49:36 GMT Subject: Integrated: 680: Allow /csr command in PR body In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 07:14:23 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the `/csr` pull request command to be used in the PR body. > > Testing: > - [x] `make test` passes > - [x] Added one addition > > Thanks, > Erik This pull request has now been integrated. Changeset: c4441df8 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/c4441df8 Stats: 39 lines in 2 files changed: 0 ins; 39 del; 0 mod 680: Allow /csr command in PR body Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/822 From ehelin at openjdk.java.net Wed Sep 16 07:50:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 07:50:13 GMT Subject: Integrated: 674: Allow reviewers command in PR body Message-ID: Hi all, please review this pull request that allows the `/reviewers` pull request command to be used in the PR body. Testing: - `make test` passes on Linux x64 - Added one additional unit test Thanks, Erik ------------- Commit messages: - 674 Changes: https://git.openjdk.java.net/skara/pull/823/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=823&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-674 Stats: 35 lines in 2 files changed: 35 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/823.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/823/head:pull/823 PR: https://git.openjdk.java.net/skara/pull/823 From rwestberg at openjdk.java.net Wed Sep 16 07:50:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 16 Sep 2020 07:50:13 GMT Subject: Integrated: 674: Allow reviewers command in PR body In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 07:34:42 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that allows the `/reviewers` pull request command to be used in the PR body. > > Testing: > - `make test` passes on Linux x64 > - Added one additional unit test > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/823 From ehelin at openjdk.java.net Wed Sep 16 07:50:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 07:50:13 GMT Subject: Integrated: 674: Allow reviewers command in PR body In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 07:34:42 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that allows the `/reviewers` pull request command to be used in the PR body. > > Testing: > - `make test` passes on Linux x64 > - Added one additional unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: b6d3b9dc Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b6d3b9dc Stats: 35 lines in 2 files changed: 0 ins; 35 del; 0 mod 674: Allow reviewers command in PR body Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/823 From ehelin at openjdk.java.net Wed Sep 16 08:16:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 08:16:12 GMT Subject: RFR: 660: Add blank line prior to PR body HTML comment Message-ID: Hi all, please review this patch that adds a newline (a blank line) prior to the bots `` message. This is needed to avoid bad interactions with GitHub's Markdown parser for some of the more esoteric Markdown features of GitHub Flavored Markdown. Testing: - [x] `make test` passes on Linux x64 - [x] `make images` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 660 Changes: https://git.openjdk.java.net/skara/pull/824/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=824&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-660 Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/824.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/824/head:pull/824 PR: https://git.openjdk.java.net/skara/pull/824 From rwestberg at openjdk.java.net Wed Sep 16 08:16:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 16 Sep 2020 08:16:12 GMT Subject: RFR: 660: Add blank line prior to PR body HTML comment In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 08:12:57 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a newline (a blank line) prior to the bots `` message. This is needed to avoid bad > interactions with GitHub's Markdown parser for some of the more esoteric Markdown features of GitHub Flavored Markdown. > Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/824 From ehelin at openjdk.java.net Wed Sep 16 08:28:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 08:28:44 GMT Subject: Integrated: 660: Add blank line prior to PR body HTML comment In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 08:12:57 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds a newline (a blank line) prior to the bots `` message. This is needed to avoid bad > interactions with GitHub's Markdown parser for some of the more esoteric Markdown features of GitHub Flavored Markdown. > Testing: > - [x] `make test` passes on Linux x64 > - [x] `make images` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 660eb7fb Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/660eb7fb Stats: 2 lines in 2 files changed: 0 ins; 0 del; 2 mod 660: Add blank line prior to PR body HTML comment Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/824 From ehelin at openjdk.java.net Wed Sep 16 10:12:31 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 10:12:31 GMT Subject: RFR: 684: Pull request command parser parses too much Message-ID: Hi all, please review this patch that ensures that `extractCommands` in `CommandWorkItem` only parses the parts of the PR body that the user has written (i.e. scrub the automatic message from the bots). Testing: - [x] `make test` passes on Linux x64 - Added a new unit test Thanks, Erik ------------- Commit messages: - 684 Changes: https://git.openjdk.java.net/skara/pull/825/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=825&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-684 Stats: 50 lines in 3 files changed: 47 ins; 2 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/825.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/825/head:pull/825 PR: https://git.openjdk.java.net/skara/pull/825 From ehelin at openjdk.java.net Wed Sep 16 10:12:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 10:12:32 GMT Subject: RFR: 684: Pull request command parser parses too much In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 10:09:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that `extractCommands` in `CommandWorkItem` only parses the parts of the PR body > that the user has written (i.e. scrub the automatic message from the bots). > Testing: > - [x] `make test` passes on Linux x64 > - Added a new unit test > > Thanks, > Erik I also removed an unused line from `PullRequestBody` ------------- PR: https://git.openjdk.java.net/skara/pull/825 From rwestberg at openjdk.java.net Wed Sep 16 10:14:54 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 16 Sep 2020 10:14:54 GMT Subject: RFR: 684: Pull request command parser parses too much In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 10:09:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that `extractCommands` in `CommandWorkItem` only parses the parts of the PR body > that the user has written (i.e. scrub the automatic message from the bots). > Testing: > - [x] `make test` passes on Linux x64 > - Added a new unit test > > Thanks, > Erik Nice cleanup, looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/825 From erik.helin at oracle.com Wed Sep 16 10:24:30 2020 From: erik.helin at oracle.com (Erik Helin) Date: Wed, 16 Sep 2020 12:24:30 +0200 Subject: Missing metadata removal in jdk commit In-Reply-To: <87tuvz3pf3.fsf@mid.deneb.enyo.de> References: <87tuvz3pf3.fsf@mid.deneb.enyo.de> Message-ID: On 9/15/20 7:44 PM, Florian Weimer wrote: > I see this in the commit history: > > commit 7eb4d4aa018e37052cbf37cd854380006c309645 > Author: Kim Barrett > Date: Tue Sep 15 10:52:50 2020 +0000 > > 8247909: Improve PrimitiveConversions::cast using C++14 > > Reimpliment PrimitiveConversions::cast, with some cases now constexpr. > > --------- > ### Progress > - [x] Change must not contain extraneous whitespace > - [x] Commit message must refer to an issue > - [ ] Change must be properly reviewed > > ### Issue > * [JDK-8247909](https://bugs.openjdk.java.net/browse/JDK-8247909): Improve PrimitiveConversions::cast using C++14 > > > ### Download > `$ git fetch https://git.openjdk.java.net/jdk pull/143/head:pull/143` > `$ git checkout pull/143` > > Reviewed-by: dholmes, stefank > > I don't think it makes sense to preserve this information in the Git > history, and the SGML comment suggests that it's expected to be > stripped. Yeah, I noticed this yesterday too, it is a bug. Fixed in [0]. Thanks, Erik [0]: https://git.openjdk.java.net/skara/pull/825 From ehelin at openjdk.java.net Wed Sep 16 10:25:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 16 Sep 2020 10:25:34 GMT Subject: Integrated: 684: Pull request command parser parses too much In-Reply-To: References: Message-ID: On Wed, 16 Sep 2020 10:09:30 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that `extractCommands` in `CommandWorkItem` only parses the parts of the PR body > that the user has written (i.e. scrub the automatic message from the bots). > Testing: > - [x] `make test` passes on Linux x64 > - Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: aa02b310 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/aa02b310 Stats: 50 lines in 3 files changed: 2 ins; 47 del; 1 mod 684: Pull request command parser parses too much Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/825 From ehelin at openjdk.java.net Thu Sep 17 07:29:00 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 07:29:00 GMT Subject: RFR: 689: Do not automatically adjust labels after users intervenes Message-ID: Hi all, please review this patch that disables the automatic labeling once the pull request author has issued any `/label` commands. Testing: - [x] `make test` passes on Linux x64 - [x] Updated unit tests Thanks, Erik ------------- Commit messages: - 689 Changes: https://git.openjdk.java.net/skara/pull/826/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=826&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-689 Stats: 33 lines in 2 files changed: 11 ins; 16 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/826.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/826/head:pull/826 PR: https://git.openjdk.java.net/skara/pull/826 From rwestberg at openjdk.java.net Thu Sep 17 07:40:05 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 07:40:05 GMT Subject: RFR: 689: Do not automatically adjust labels after users intervenes In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 07:26:14 GMT, Erik Helin wrote: > Hi all, > > please review this patch that disables the automatic labeling once the pull request author has issued any `/label` > commands. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/826 From ehelin at openjdk.java.net Thu Sep 17 07:54:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 07:54:22 GMT Subject: RFR: 648: `git sync` requires ssh to be specified when setting 'to' repo on set-up Message-ID: Hi all, please review this patch that makes `git-sync` work better with git-style SSH paths. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - 648 Changes: https://git.openjdk.java.net/skara/pull/827/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=827&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-648 Stats: 7 lines in 2 files changed: 4 ins; 0 del; 3 mod Patch: https://git.openjdk.java.net/skara/pull/827.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/827/head:pull/827 PR: https://git.openjdk.java.net/skara/pull/827 From rwestberg at openjdk.java.net Thu Sep 17 07:54:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 07:54:23 GMT Subject: RFR: 648: `git sync` requires ssh to be specified when setting 'to' repo on set-up In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 07:49:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` work better with git-style SSH paths. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/827 From ehelin at openjdk.java.net Thu Sep 17 07:58:04 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 07:58:04 GMT Subject: Integrated: 689: Do not automatically adjust labels after users intervenes In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 07:26:14 GMT, Erik Helin wrote: > Hi all, > > please review this patch that disables the automatic labeling once the pull request author has issued any `/label` > commands. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: d7cdb985 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d7cdb985 Stats: 33 lines in 2 files changed: 16 ins; 11 del; 6 mod 689: Do not automatically adjust labels after users intervenes Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/826 From ehelin at openjdk.java.net Thu Sep 17 07:58:24 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 07:58:24 GMT Subject: Integrated: 648: `git sync` requires ssh to be specified when setting 'to' repo on set-up In-Reply-To: References: Message-ID: <2P76o8G_dBo9rSK1uX-LlPFeORpKJloblbwwQ0Z3KnU=.da64ebc3-3951-44ad-b33c-d39ebd1c3a56@github.com> On Thu, 17 Sep 2020 07:49:19 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes `git-sync` work better with git-style SSH paths. > > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 44ceeb74 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/44ceeb74 Stats: 7 lines in 2 files changed: 0 ins; 4 del; 3 mod 648: `git sync` requires ssh to be specified when setting 'to' repo on set-up Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/827 From rwestberg at openjdk.java.net Thu Sep 17 13:17:42 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 13:17:42 GMT Subject: RFR: 692: Improve integration message Message-ID: Update the integration ready message slightly in response to feedback. Best regards, Robin ------------- Commit messages: - Update matching tests - Initial update Changes: https://git.openjdk.java.net/skara/pull/828/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=828&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-692 Stats: 45 lines in 2 files changed: 13 ins; 10 del; 22 mod Patch: https://git.openjdk.java.net/skara/pull/828.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/828/head:pull/828 PR: https://git.openjdk.java.net/skara/pull/828 From ehelin at openjdk.java.net Thu Sep 17 13:27:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 13:27:22 GMT Subject: RFR: 683: Stats entry in automatic integration email swaps insertions and deletions Message-ID: <7sfdSIDJg8fhd-ZEBBllXDVbqlUygI2DvZd70BWNxng=.97f7c3b1-6114-4584-b268-2e560e68ce0a@github.com> Hi all, please review this small patch that fixes the "Stats:" line for integration notifications ?? Thanks, Erik ------------- Commit messages: - 683 Changes: https://git.openjdk.java.net/skara/pull/829/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=829&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-683 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/829.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/829/head:pull/829 PR: https://git.openjdk.java.net/skara/pull/829 From rwestberg at openjdk.java.net Thu Sep 17 13:27:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 13:27:23 GMT Subject: RFR: 683: Stats entry in automatic integration email swaps insertions and deletions In-Reply-To: <7sfdSIDJg8fhd-ZEBBllXDVbqlUygI2DvZd70BWNxng=.97f7c3b1-6114-4584-b268-2e560e68ce0a@github.com> References: <7sfdSIDJg8fhd-ZEBBllXDVbqlUygI2DvZd70BWNxng=.97f7c3b1-6114-4584-b268-2e560e68ce0a@github.com> Message-ID: On Thu, 17 Sep 2020 13:24:14 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes the "Stats:" line for integration notifications ?? > > Thanks, > Erik Looks great! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/829 From ehelin at openjdk.java.net Thu Sep 17 13:32:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 13:32:05 GMT Subject: Integrated: 683: Stats entry in automatic integration email swaps insertions and deletions In-Reply-To: <7sfdSIDJg8fhd-ZEBBllXDVbqlUygI2DvZd70BWNxng=.97f7c3b1-6114-4584-b268-2e560e68ce0a@github.com> References: <7sfdSIDJg8fhd-ZEBBllXDVbqlUygI2DvZd70BWNxng=.97f7c3b1-6114-4584-b268-2e560e68ce0a@github.com> Message-ID: On Thu, 17 Sep 2020 13:24:14 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that fixes the "Stats:" line for integration notifications ?? > > Thanks, > Erik This pull request has now been integrated. Changeset: ca3795d2 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/ca3795d2 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 683: Stats entry in automatic integration email swaps insertions and deletions Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/829 From rwestberg at openjdk.java.net Thu Sep 17 13:50:37 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 13:50:37 GMT Subject: RFR: 692: Improve integration message [v2] In-Reply-To: References: Message-ID: > Update the integration ready message slightly in response to feedback. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Additional test updates ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/828/files - new: https://git.openjdk.java.net/skara/pull/828/files/7f51b8c8..915b817f Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=828&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=828&range=00-01 Stats: 5 lines in 1 file changed: 0 ins; 1 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/828.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/828/head:pull/828 PR: https://git.openjdk.java.net/skara/pull/828 From ehelin at openjdk.java.net Thu Sep 17 14:01:51 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 14:01:51 GMT Subject: Integrated: 649: SKARA will not build/install without termcap Message-ID: Hi all, please review this small patch that makes us fall back to `TERM=dumb` if `TERM` is not specified when building on Linux. Testing: - [x] `make` works on Linux x64 with and without `TERM` defined Thanks, Erik ------------- Commit messages: - build: fall back to TERM=dumb on Linux Changes: https://git.openjdk.java.net/skara/pull/830/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=830&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-649 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/830.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/830/head:pull/830 PR: https://git.openjdk.java.net/skara/pull/830 From rwestberg at openjdk.java.net Thu Sep 17 14:01:52 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 17 Sep 2020 14:01:52 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 13:56:04 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes us fall back to `TERM=dumb` if `TERM` is not specified when building on Linux. > > Testing: > - [x] `make` works on Linux x64 with and without `TERM` defined > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/830 From ehelin at openjdk.java.net Thu Sep 17 14:01:53 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 14:01:53 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: References: Message-ID: <5L_oPFxDDcK7wxd05ogpwWqUnPsjpmH_n___fQuVi_Y=.7029e95a-ff61-40bd-b249-f470387295d6@github.com> On Thu, 17 Sep 2020 13:56:04 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes us fall back to `TERM=dumb` if `TERM` is not specified when building on Linux. > > Testing: > - [x] `make` works on Linux x64 with and without `TERM` defined > > Thanks, > Erik This pull request has now been integrated. Changeset: fa989500 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/fa989500 Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod 649: SKARA will not build/install without termcap Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/830 From ehelin at openjdk.java.net Thu Sep 17 14:04:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 17 Sep 2020 14:04:35 GMT Subject: RFR: 692: Improve integration message [v2] In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 13:50:37 GMT, Robin Westberg wrote: >> Update the integration ready message slightly in response to feedback. >> >> Best regards, >> Robin > > Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: > > Additional test updates Looks good, just one more test to fix! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/828 From phedlin at openjdk.java.net Thu Sep 17 21:30:45 2020 From: phedlin at openjdk.java.net (Patric Hedlin) Date: Thu, 17 Sep 2020 21:30:45 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 13:56:04 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes us fall back to `TERM=dumb` if `TERM` is not specified when building on Linux. > > Testing: > - [x] `make` works on Linux x64 with and without `TERM` defined > > Thanks, > Erik gradlew line 191: > 189: export LANG=en_US.UTF-8 > 190: export LANGUAGE=en_US.UTF-8 > 191: export TERM=${TERM:-dumb} TERM=dumb will work as a workaround (dropping the _fancy_ progress bar) but TERM not being set is not the proper condition for lack of **termcap** support (e.g. when **terminfo** is used and TERM set accordingly). ------------- PR: https://git.openjdk.java.net/skara/pull/830 From ehelin at openjdk.java.net Fri Sep 18 07:14:02 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 07:14:02 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: References: Message-ID: <5xI0CDyUhUKVSgDmX6jTopSsdu3jLBJOdwneFOSvTso=.14dbd291-0675-4b88-8f7f-a826be3e41bf@github.com> On Thu, 17 Sep 2020 21:28:37 GMT, Patric Hedlin wrote: >> Hi all, >> >> please review this small patch that makes us fall back to `TERM=dumb` if `TERM` is not specified when building on Linux. >> >> Testing: >> - [x] `make` works on Linux x64 with and without `TERM` defined >> >> Thanks, >> Erik > > gradlew line 191: > >> 189: export LANG=en_US.UTF-8 >> 190: export LANGUAGE=en_US.UTF-8 >> 191: export TERM=${TERM:-dumb} > > TERM=dumb will work as a workaround (dropping the _fancy_ progress bar) but TERM not being set is not the proper > condition for lack of **termcap** support (e.g. when **terminfo** is used and TERM set accordingly). @phedlin I'm not sure that there is a way to determine whether a process uses `termcap` or `terminfo`, do you know of a reliable way? I think the best we can do here is to add some documentation to `README.md`, instructing the user to run `sh gradlew --console=plain` as a workaround. Or do you have any other suggestions? ------------- PR: https://git.openjdk.java.net/skara/pull/830 From ehelin at openjdk.java.net Fri Sep 18 07:18:06 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 07:18:06 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: <5xI0CDyUhUKVSgDmX6jTopSsdu3jLBJOdwneFOSvTso=.14dbd291-0675-4b88-8f7f-a826be3e41bf@github.com> References: <5xI0CDyUhUKVSgDmX6jTopSsdu3jLBJOdwneFOSvTso=.14dbd291-0675-4b88-8f7f-a826be3e41bf@github.com> Message-ID: On Fri, 18 Sep 2020 07:11:42 GMT, Erik Helin wrote: >> gradlew line 191: >> >>> 189: export LANG=en_US.UTF-8 >>> 190: export LANGUAGE=en_US.UTF-8 >>> 191: export TERM=${TERM:-dumb} >> >> TERM=dumb will work as a workaround (dropping the _fancy_ progress bar) but TERM not being set is not the proper >> condition for lack of **termcap** support (e.g. when **terminfo** is used and TERM set accordingly). > > @phedlin I'm not sure that there is a way to determine whether a process uses `termcap` or `terminfo`, do you know of a > reliable way? I think the best we can do here is to add some documentation to `README.md`, instructing the user to run > `sh gradlew --console=plain` as a workaround. Or do you have any other suggestions? @phedlin I might have a way to default to `--console=plain` while still allowing Skara developers to opt-in to a more fancy console. Can you please try building with `sh gradlew --console=plain` and see if it works on your system? ------------- PR: https://git.openjdk.java.net/skara/pull/830 From rwestberg at openjdk.java.net Fri Sep 18 07:58:18 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 18 Sep 2020 07:58:18 GMT Subject: RFR: 692: Improve integration message [v3] In-Reply-To: References: Message-ID: > Update the integration ready message slightly in response to feedback. > > Best regards, > Robin Robin Westberg has updated the pull request incrementally with one additional commit since the last revision: Some additional test fixes ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/828/files - new: https://git.openjdk.java.net/skara/pull/828/files/915b817f..840966d8 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=828&range=02 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=828&range=01-02 Stats: 4 lines in 3 files changed: 0 ins; 0 del; 4 mod Patch: https://git.openjdk.java.net/skara/pull/828.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/828/head:pull/828 PR: https://git.openjdk.java.net/skara/pull/828 From rwestberg at openjdk.java.net Fri Sep 18 08:37:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 18 Sep 2020 08:37:34 GMT Subject: Integrated: 692: Improve integration message In-Reply-To: References: Message-ID: On Thu, 17 Sep 2020 13:14:56 GMT, Robin Westberg wrote: > Update the integration ready message slightly in response to feedback. > > Best regards, > Robin This pull request has now been integrated. Changeset: ae829d68 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ae829d68 Stats: 54 lines in 6 files changed: 11 ins; 13 del; 30 mod 692: Improve integration message Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/828 From ehelin at openjdk.java.net Fri Sep 18 08:52:50 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 08:52:50 GMT Subject: RFR: 690: Merge commit message is not Merge jdk, but: Merge jdk Message-ID: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> Hi all, please review this patch that makes it more clear what the expected and current commit messages are when showing the error for `MergeMessageCheck`. Thanks, Erik ------------- Commit messages: - 690 - Merge jdk - Updated .jcheck/conf Changes: https://git.openjdk.java.net/skara/pull/831/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=831&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-690 Stats: 14 lines in 2 files changed: 12 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/831.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/831/head:pull/831 PR: https://git.openjdk.java.net/skara/pull/831 From rwestberg at openjdk.java.net Fri Sep 18 08:52:53 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 18 Sep 2020 08:52:53 GMT Subject: RFR: 690: Merge commit message is not Merge jdk, but: Merge jdk In-Reply-To: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> References: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> Message-ID: <7ZGBLSqxXiR5CPR579WGWiF6DwxINTD8C2XPHE6uQHs=.9549c889-3010-4d20-b1be-bfbb76127995@github.com> On Fri, 18 Sep 2020 08:48:42 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it more clear what the expected and current commit messages are when showing the > error for `MergeMessageCheck`. > Thanks, > Erik Looks good, just one comment! .jcheck/conf line 44: > 42: > 43: [checks "merge"] > 44: message=Merge jdk Do we really want this check for Skara? :) ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/831 From phedlin at openjdk.java.net Fri Sep 18 09:00:16 2020 From: phedlin at openjdk.java.net (Patric Hedlin) Date: Fri, 18 Sep 2020 09:00:16 GMT Subject: Integrated: 649: SKARA will not build/install without termcap In-Reply-To: References: <5xI0CDyUhUKVSgDmX6jTopSsdu3jLBJOdwneFOSvTso=.14dbd291-0675-4b88-8f7f-a826be3e41bf@github.com> Message-ID: On Fri, 18 Sep 2020 07:15:57 GMT, Erik Helin wrote: >> @phedlin I'm not sure that there is a way to determine whether a process uses `termcap` or `terminfo`, do you know of a >> reliable way? I think the best we can do here is to add some documentation to `README.md`, instructing the user to run >> `sh gradlew --console=plain` as a workaround. Or do you have any other suggestions? > > @phedlin I might have a way to default to `--console=plain` while still allowing Skara developers to opt-in to a more > fancy console. Can you please try building with `sh gradlew --console=plain` and see if it works on your system? JAVA_HOME=~/local/jdk14-import/build/linux-aarch64/images/jdk sh ./gradlew --console=plain FAILURE: Build failed with an exception. * What went wrong: Could not open terminal for stdout: could not get termcap entry * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org ------------- PR: https://git.openjdk.java.net/skara/pull/830 From ehelin at openjdk.java.net Fri Sep 18 09:03:14 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 09:03:14 GMT Subject: RFR: 690: Merge commit message is not Merge jdk, but: Merge jdk [v2] In-Reply-To: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> References: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> Message-ID: > Hi all, > > please review this patch that makes it more clear what the expected and current commit messages are when showing the > error for `MergeMessageCheck`. > Thanks, > Erik Erik Helin has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 690 ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/831/files - new: https://git.openjdk.java.net/skara/pull/831/files/fc746103..8a9fb6ae Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=831&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=831&range=00-01 Stats: 4 lines in 1 file changed: 0 ins; 3 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/831.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/831/head:pull/831 PR: https://git.openjdk.java.net/skara/pull/831 From ehelin at openjdk.java.net Fri Sep 18 09:03:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 09:03:15 GMT Subject: RFR: 690: Merge commit message is not Merge jdk, but: Merge jdk [v2] In-Reply-To: <7ZGBLSqxXiR5CPR579WGWiF6DwxINTD8C2XPHE6uQHs=.9549c889-3010-4d20-b1be-bfbb76127995@github.com> References: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> <7ZGBLSqxXiR5CPR579WGWiF6DwxINTD8C2XPHE6uQHs=.9549c889-3010-4d20-b1be-bfbb76127995@github.com> Message-ID: On Fri, 18 Sep 2020 08:50:05 GMT, Robin Westberg wrote: >> Erik Helin has refreshed the contents of this pull request, and previous commits have been removed. The incremental >> views will show differences compared to the previous content of the PR. The pull request contains one new commit since >> the last revision: >> 690 > > .jcheck/conf line 44: > >> 42: >> 43: [checks "merge"] >> 44: message=Merge jdk > > Do we really want this check for Skara? :) Haha, some debugging leftovers, I will clean up ?? ------------- PR: https://git.openjdk.java.net/skara/pull/831 From ehelin at openjdk.java.net Fri Sep 18 09:05:54 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 18 Sep 2020 09:05:54 GMT Subject: Integrated: 690: Merge commit message is not Merge jdk, but: Merge jdk In-Reply-To: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> References: <7avUyEJgQP4C8-rcyZJ_3XdsPCJYmUjUkia1aVCPVxE=.4ec0fcbe-711c-4c4a-9b92-55d0bfbceb36@github.com> Message-ID: On Fri, 18 Sep 2020 08:48:42 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it more clear what the expected and current commit messages are when showing the > error for `MergeMessageCheck`. > Thanks, > Erik This pull request has now been integrated. Changeset: 87ac6537 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/87ac6537 Stats: 10 lines in 1 file changed: 0 ins; 9 del; 1 mod 690: Merge commit message is not Merge jdk, but: Merge jdk Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/831 From stefank at openjdk.java.net Mon Sep 21 09:22:03 2020 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Mon, 21 Sep 2020 09:22:03 GMT Subject: RFR: 710: Map share/utilities to hotspot-dev Message-ID: <7mh-o3XuNl5HMSVCG1GUvwAb2WEEPp4xuMVlaP14V94=.d7cfe76e-2871-46b3-9049-f6adc21da7fb@github.com> PRs for changes to share/utilities go to hotspot-runtime. This is incorrect, since share/utilities is shared among the teams. ------------- Commit messages: - 710: Map share/utilities to hotspot-dev Changes: https://git.openjdk.java.net/skara/pull/832/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=832&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-710 Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/832.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/832/head:pull/832 PR: https://git.openjdk.java.net/skara/pull/832 From ehelin at openjdk.java.net Mon Sep 21 10:08:32 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 10:08:32 GMT Subject: RFR: defpath: normalize error format Message-ID: Hi all, please review this small patch that makes `git defpath` use the same error message as `git jcheck` and `git webrev` when not finding a local repository. Testing: - [x] Manual testing on Linux x64 Thanks, Erik ------------- Commit messages: - defpath: normalize error format Changes: https://git.openjdk.java.net/skara/pull/833/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=833&range=00 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/833.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/833/head:pull/833 PR: https://git.openjdk.java.net/skara/pull/833 From rwestberg at openjdk.java.net Mon Sep 21 12:24:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 12:24:25 GMT Subject: RFR: defpath: normalize error format In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 10:05:43 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git defpath` use the same error message as `git jcheck` and `git webrev` > when not finding a local repository. > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/833 From ehelin at openjdk.java.net Mon Sep 21 12:48:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 12:48:15 GMT Subject: Integrated: defpath: normalize error format In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 10:05:43 GMT, Erik Helin wrote: > Hi all, > > please review this small patch that makes `git defpath` use the same error message as `git jcheck` and `git webrev` > when not finding a local repository. > Testing: > - [x] Manual testing on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 12b9328f Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/12b9328f Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod defpath: normalize error format Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/833 From ehelin at openjdk.java.net Mon Sep 21 13:33:33 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 13:33:33 GMT Subject: RFR: 548: PR is marked as being ready for integration before the CSR is approved Message-ID: <156MhTA1Tdpq6fsVXOgggl_0g9fpSUcGBD1z8fkFm2M=.f407a23f-2f45-4860-b73a-a9ac98c38436@github.com> Hi all, please review this patch that makes the "csr" label be a blocker for a pull request becoming "ready". The "csr" label used to block integration, but it is more friendly for authors and reviewers if the integration message doesn't appear ?? Testing: - [x] `make test` passes on Linux x64 - [x] Added a new unit test Thanks, Erik ------------- Commit messages: - 548 Changes: https://git.openjdk.java.net/skara/pull/834/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=834&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-548 Stats: 65 lines in 3 files changed: 62 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/834.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/834/head:pull/834 PR: https://git.openjdk.java.net/skara/pull/834 From rwestberg at openjdk.java.net Mon Sep 21 13:33:33 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 13:33:33 GMT Subject: RFR: 548: PR is marked as being ready for integration before the CSR is approved In-Reply-To: <156MhTA1Tdpq6fsVXOgggl_0g9fpSUcGBD1z8fkFm2M=.f407a23f-2f45-4860-b73a-a9ac98c38436@github.com> References: <156MhTA1Tdpq6fsVXOgggl_0g9fpSUcGBD1z8fkFm2M=.f407a23f-2f45-4860-b73a-a9ac98c38436@github.com> Message-ID: On Mon, 21 Sep 2020 13:29:51 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the "csr" label be a blocker for a pull request becoming "ready". The "csr" label > used to block integration, but it is more friendly for authors and reviewers if the integration message doesn't appear > ?? Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/834 From rwestberg at openjdk.java.net Mon Sep 21 13:39:45 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 13:39:45 GMT Subject: RFR: 710: Map share/utilities to hotspot-dev In-Reply-To: <7mh-o3XuNl5HMSVCG1GUvwAb2WEEPp4xuMVlaP14V94=.d7cfe76e-2871-46b3-9049-f6adc21da7fb@github.com> References: <7mh-o3XuNl5HMSVCG1GUvwAb2WEEPp4xuMVlaP14V94=.d7cfe76e-2871-46b3-9049-f6adc21da7fb@github.com> Message-ID: On Mon, 21 Sep 2020 09:19:24 GMT, Stefan Karlsson wrote: > PRs for changes to share/utilities go to hotspot-runtime. This is incorrect, since share/utilities is shared among the > teams. Looks good, thanks for updating! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/832 From ehelin at openjdk.java.net Mon Sep 21 13:43:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 13:43:55 GMT Subject: Integrated: 548: PR is marked as being ready for integration before the CSR is approved In-Reply-To: <156MhTA1Tdpq6fsVXOgggl_0g9fpSUcGBD1z8fkFm2M=.f407a23f-2f45-4860-b73a-a9ac98c38436@github.com> References: <156MhTA1Tdpq6fsVXOgggl_0g9fpSUcGBD1z8fkFm2M=.f407a23f-2f45-4860-b73a-a9ac98c38436@github.com> Message-ID: On Mon, 21 Sep 2020 13:29:51 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes the "csr" label be a blocker for a pull request becoming "ready". The "csr" label > used to block integration, but it is more friendly for authors and reviewers if the integration message doesn't appear > ?? Testing: > - [x] `make test` passes on Linux x64 > - [x] Added a new unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 36edd9ea Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/36edd9ea Stats: 65 lines in 3 files changed: 1 ins; 62 del; 2 mod 548: PR is marked as being ready for integration before the CSR is approved Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/834 From ehelin at openjdk.java.net Mon Sep 21 14:29:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 14:29:43 GMT Subject: RFR: 657: Integrate command uses "merge request" in failure message Message-ID: <3_k6tekdCBhscXHtGJ70Lv9Xzl6ZLTLEc7cyyl_p9TY=.4095184d-d763-41b4-8fe4-09a01f37eba6@github.com> Hi all, please review this patch that uses the wording "integration request" instead of "merge request" in failure messages for the `/integrate` pull request command. Testing: - [x] `make test` passes on Linux x64 - [x] Updated unit tests Thanks, Erik ------------- Commit messages: - 657 Changes: https://git.openjdk.java.net/skara/pull/835/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=835&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-657 Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/835.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/835/head:pull/835 PR: https://git.openjdk.java.net/skara/pull/835 From ehelin at openjdk.java.net Mon Sep 21 14:38:52 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 14:38:52 GMT Subject: RFR: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict Message-ID: Hi all, please review this patch that correctly links to the project in the merge bot's message. I also updated the `git` instructions to suffix repository URLs with `.git` for older git clients who might not be used to eventual re-directs from forges when the URL isn't ending in `.git`. Testing: - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 663 Changes: https://git.openjdk.java.net/skara/pull/836/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=836&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-663 Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/836.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/836/head:pull/836 PR: https://git.openjdk.java.net/skara/pull/836 From ehelin at openjdk.java.net Mon Sep 21 16:17:13 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 21 Sep 2020 16:17:13 GMT Subject: RFR: 694: Checking invalid email gives an exception Message-ID: Hi all, please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and e-mail for a pull request's `HEAD` commit. Testing: - Added a new unit test - `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 694 Changes: https://git.openjdk.java.net/skara/pull/837/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=837&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-694 Stats: 48 lines in 3 files changed: 45 ins; 1 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/837.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/837/head:pull/837 PR: https://git.openjdk.java.net/skara/pull/837 From tbell at openjdk.java.net Mon Sep 21 16:34:25 2020 From: tbell at openjdk.java.net (Tim Bell) Date: Mon, 21 Sep 2020 16:34:25 GMT Subject: RFR: 694: Checking invalid email gives an exception In-Reply-To: References: Message-ID: <5V9eFNGNqyDPOwGYOVtZ8wBLcAuKp0OwSgtxfsZwb1k=.6a72d024-5eb6-4807-9eb6-ef880018fb38@github.com> On Mon, 21 Sep 2020 16:14:22 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and > e-mail for a pull request's `HEAD` commit. > Testing: > - Added a new unit test > - `make test` passes on Linux x64 > > Thanks, > Erik Marked as reviewed by tbell (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/837 From rwestberg at openjdk.java.net Mon Sep 21 16:56:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 16:56:46 GMT Subject: RFR: 657: Integrate command uses "merge request" in failure message In-Reply-To: <3_k6tekdCBhscXHtGJ70Lv9Xzl6ZLTLEc7cyyl_p9TY=.4095184d-d763-41b4-8fe4-09a01f37eba6@github.com> References: <3_k6tekdCBhscXHtGJ70Lv9Xzl6ZLTLEc7cyyl_p9TY=.4095184d-d763-41b4-8fe4-09a01f37eba6@github.com> Message-ID: On Mon, 21 Sep 2020 14:26:55 GMT, Erik Helin wrote: > Hi all, > > please review this patch that uses the wording "integration request" instead of "merge request" in failure messages for > the `/integrate` pull request command. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated unit tests > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/835 From rwestberg at openjdk.java.net Mon Sep 21 16:58:15 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 16:58:15 GMT Subject: RFR: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 14:35:50 GMT, Erik Helin wrote: > Hi all, > > please review this patch that correctly links to the project in the merge bot's message. I also updated the `git` > instructions to suffix repository URLs with `.git` for older git clients who might not be used to eventual re-directs > from forges when the URL isn't ending in `.git`. Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/836 From rwestberg at openjdk.java.net Mon Sep 21 17:04:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 21 Sep 2020 17:04:36 GMT Subject: RFR: 694: Checking invalid email gives an exception In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 16:14:22 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and > e-mail for a pull request's `HEAD` commit. > Testing: > - Added a new unit test > - `make test` passes on Linux x64 > > Thanks, > Erik bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 166: > 164: public void visit(AuthorNameIssue issue) { > 165: // We only get here for contributors without an OpenJDK username > 166: addFailureMessage(issue.check(), "Pull request's HEAD commit must contain a full name"); This is not strictly true, CheckRun.java around line 194 will check that all commits in a PR contain the same name and email address. Could of course start using just the one in HEAD without that check.. ------------- PR: https://git.openjdk.java.net/skara/pull/837 From thomas.stuefe at gmail.com Tue Sep 22 04:55:31 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 22 Sep 2020 06:55:31 +0200 Subject: Test errors in clean repo Message-ID: Hi all, I try to test a small fix I did in skara cli, following the steps laid out in README.md, using "gradlew test". I run into a number of test errors, but found those are also reproducible on a clean repo: org.openjdk.skara.vcs.RepositoryTests > [2] HG FAILED java.io.IOException: Unexpected exit code 'hg merge --abort' exited with status: 255 [stdout] > hg merge [-P] [[-r] REV] > > merge another revision into working directory > > options: > > -r --rev REV revision to merge > -P --preview review revisions to merge (no merge is performed) > -t --tool VALUE specify merge tool > > (use "hg merge -h" to show more help) [stderr] > hg merge: option --abort not recognized at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.await(HgRepository.java:103) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.abortMerge(HgRepository.java:1037) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.RepositoryTests.testAbortMerge(RepositoryTests.java:1960) and: org.openjdk.skara.vcs.RepositoryTests > [2] HG FAILED java.io.IOException: Unexpected exit code 'hg tag --message Added tag 1.0 --user duke --rev fda4f0071b9f038f67b1cc953f0b69440d64912f --date 2007-12-03T10:15:30+01:00 1.0' exited with status: 255 [stdout] [stderr] > abort: invalid date: '2007-12-03T10:15:30+01:00' at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.await(HgRepository.java:103) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.tag(HgRepository.java:697) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.RepositoryTests.testTimestampOnTags(RepositoryTests.java:2612) and: org.openjdk.skara.vcs.RepositoryTests > [2] HG FAILED java.io.IOException: Unexpected exit code: 255 at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.await(HgRepository.java:113) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.readMetadata(HgRepository.java:344) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.commitMetadata(HgRepository.java:285) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.hg.HgRepository.commitMetadata(HgRepository.java:325) at org.openjdk.skara.vcs/org.openjdk.skara.vcs.RepositoryTests.testPull(RepositoryTests.java:2722) I run on an older Ubuntu release (16.4, I like to ride out my LTSes). Seems to me an issue with mercurial? Is it too old? If yes, does that affect only tests or also my daily work post-skara? I did not have any problems before. If a newer mercurial is needed, should we warn people, similar to the git version warnings? Thanks, Thomas From stuefe at openjdk.java.net Tue Sep 22 05:05:22 2020 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 22 Sep 2020 05:05:22 GMT Subject: RFR: 716: Git version check pattern matching is too strict Message-ID: Hi, may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems, but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version number correctly. https://bugs.openjdk.java.net/browse/SKARA-716 Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo (see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything to do with my fix. ------------- Commit messages: - 716: Git version check pattern matching is too strict Changes: https://git.openjdk.java.net/skara/pull/838/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=838&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-716 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/838.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/838/head:pull/838 PR: https://git.openjdk.java.net/skara/pull/838 From ehelin at openjdk.java.net Tue Sep 22 09:24:55 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:24:55 GMT Subject: Integrated: 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict In-Reply-To: References: Message-ID: <0I-78o4C499Im64uQyoi-BS-jS-JypMRO74aGY30yBc=.e7754a16-440f-46b6-83f5-3dd86d695d60@github.com> On Mon, 21 Sep 2020 14:35:50 GMT, Erik Helin wrote: > Hi all, > > please review this patch that correctly links to the project in the merge bot's message. I also updated the `git` > instructions to suffix repository URLs with `.git` for older git clients who might not be used to eventual re-directs > from forges when the URL isn't ending in `.git`. Testing: > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 72317c6e Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/72317c6e Stats: 5 lines in 1 file changed: 0 ins; 0 del; 5 mod 663: Bad URL in PR created by openjdk-bot in responnse to merge conflict Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/836 From ehelin at openjdk.java.net Tue Sep 22 09:25:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:25:09 GMT Subject: Integrated: 657: Integrate command uses "merge request" in failure message In-Reply-To: <3_k6tekdCBhscXHtGJ70Lv9Xzl6ZLTLEc7cyyl_p9TY=.4095184d-d763-41b4-8fe4-09a01f37eba6@github.com> References: <3_k6tekdCBhscXHtGJ70Lv9Xzl6ZLTLEc7cyyl_p9TY=.4095184d-d763-41b4-8fe4-09a01f37eba6@github.com> Message-ID: On Mon, 21 Sep 2020 14:26:55 GMT, Erik Helin wrote: > Hi all, > > please review this patch that uses the wording "integration request" instead of "merge request" in failure messages for > the `/integrate` pull request command. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Updated unit tests > > Thanks, > Erik This pull request has now been integrated. Changeset: b69b6d26 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/b69b6d26 Stats: 8 lines in 4 files changed: 0 ins; 0 del; 8 mod 657: Integrate command uses "merge request" in failure message Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/835 From stefank at openjdk.java.net Tue Sep 22 09:29:06 2020 From: stefank at openjdk.java.net (Stefan Karlsson) Date: Tue, 22 Sep 2020 09:29:06 GMT Subject: Integrated: 710: Map share/utilities to hotspot-dev In-Reply-To: <7mh-o3XuNl5HMSVCG1GUvwAb2WEEPp4xuMVlaP14V94=.d7cfe76e-2871-46b3-9049-f6adc21da7fb@github.com> References: <7mh-o3XuNl5HMSVCG1GUvwAb2WEEPp4xuMVlaP14V94=.d7cfe76e-2871-46b3-9049-f6adc21da7fb@github.com> Message-ID: On Mon, 21 Sep 2020 09:19:24 GMT, Stefan Karlsson wrote: > PRs for changes to share/utilities go to hotspot-runtime. This is incorrect, since share/utilities is shared among the > teams. This pull request has now been integrated. Changeset: 4f170e4e Author: Stefan Karlsson Committer: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/4f170e4e Stats: 4 lines in 1 file changed: 2 ins; 2 del; 0 mod 710: Map share/utilities to hotspot-dev Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/832 From ehelin at openjdk.java.net Tue Sep 22 09:41:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:41:45 GMT Subject: RFR: 716: Git version check pattern matching is too strict In-Reply-To: References: Message-ID: <8cKiZE2bqYyXFVM3QbpierMxMCKhhBZHV9Engoj18wo=.9d37222e-0e6b-488d-ae82-38b9efb7c2c5@github.com> On Tue, 22 Sep 2020 05:02:47 GMT, Thomas Stuefe wrote: > Hi, > > may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems, > but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version > number correctly. https://bugs.openjdk.java.net/browse/SKARA-716 > > Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo > (see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything > to do with my fix. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/838 From ehelin at openjdk.java.net Tue Sep 22 09:41:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:41:45 GMT Subject: RFR: 716: Git version check pattern matching is too strict In-Reply-To: <8cKiZE2bqYyXFVM3QbpierMxMCKhhBZHV9Engoj18wo=.9d37222e-0e6b-488d-ae82-38b9efb7c2c5@github.com> References: <8cKiZE2bqYyXFVM3QbpierMxMCKhhBZHV9Engoj18wo=.9d37222e-0e6b-488d-ae82-38b9efb7c2c5@github.com> Message-ID: On Tue, 22 Sep 2020 09:39:04 GMT, Erik Helin wrote: >> Hi, >> >> may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems, >> but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version >> number correctly. https://bugs.openjdk.java.net/browse/SKARA-716 >> >> Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo >> (see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything >> to do with my fix. > > Looks good! @tstuefe the tests are failing because you have a too old Mercurial version. ------------- PR: https://git.openjdk.java.net/skara/pull/838 From ehelin at openjdk.java.net Tue Sep 22 09:45:37 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:45:37 GMT Subject: RFR: 694: Checking invalid email gives an exception [v2] In-Reply-To: References: Message-ID: > Hi all, > > please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and > e-mail for a pull request's `HEAD` commit. > Testing: > - Added a new unit test > - `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request incrementally with one additional commit since the last revision: Only require HEAD to have valid author ------------- Changes: - all: https://git.openjdk.java.net/skara/pull/837/files - new: https://git.openjdk.java.net/skara/pull/837/files/c392626c..b49bd902 Webrevs: - full: https://webrevs.openjdk.java.net/?repo=skara&pr=837&range=01 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=837&range=00-01 Stats: 76 lines in 2 files changed: 0 ins; 76 del; 0 mod Patch: https://git.openjdk.java.net/skara/pull/837.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/837/head:pull/837 PR: https://git.openjdk.java.net/skara/pull/837 From ehelin at openjdk.java.net Tue Sep 22 09:59:16 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 09:59:16 GMT Subject: RFR: 694: Checking invalid email gives an exception [v2] In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 17:02:15 GMT, Robin Westberg wrote: >> Erik Helin has updated the pull request incrementally with one additional commit since the last revision: >> >> Only require HEAD to have valid author > > bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java line 166: > >> 164: public void visit(AuthorNameIssue issue) { >> 165: // We only get here for contributors without an OpenJDK username >> 166: addFailureMessage(issue.check(), "Pull request's HEAD commit must contain a full name"); > > This is not strictly true, CheckRun.java around line 194 will check that all commits in a PR contain the same name and > email address. Could of course start using just the one in HEAD without that check.. Thanks, updated in b49bd90 ------------- PR: https://git.openjdk.java.net/skara/pull/837 From rwestberg at openjdk.java.net Tue Sep 22 10:37:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 22 Sep 2020 10:37:25 GMT Subject: RFR: 694: Checking invalid email gives an exception [v2] In-Reply-To: References: Message-ID: On Tue, 22 Sep 2020 09:45:37 GMT, Erik Helin wrote: >> Hi all, >> >> please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and >> e-mail for a pull request's `HEAD` commit. >> Testing: >> - Added a new unit test >> - `make test` passes on Linux x64 >> >> Thanks, >> Erik > > Erik Helin has updated the pull request incrementally with one additional commit since the last revision: > > Only require HEAD to have valid author Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/837 From volker.simonis at gmail.com Tue Sep 22 10:55:06 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 22 Sep 2020 12:55:06 +0200 Subject: Errors when running jcheck locally Message-ID: Hi, sorry if this has been documented or answered already somewhere but I couldn't find any information in the WIki or the mailing list. I think I have a valid setup and configured everything properly, but when I run "git jcheck" locally on my clone of a https://github.com/openjdk/jdk fork, I get the following errors: $ git status On branch JDK-8253435-cpusets-fix $ git log commit 568c48964a156f5ca71319f0585f2d5c84899c62 (HEAD -> JDK-8253435-cpusets-fix) Author: Volker Simonis Date: Mon Sep 21 18:58:58 2020 +0200 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist ... $ git jcheck [branches] error: illegal branch name: JDK-8253435-cpusets-fix [branches] error: illegal branch name: zip_entry_fix [committer] error: 568c4896: missing committer email from domain openjdk.org [committer] error: 568c4896: Volker Simonis is not committer in project jdk [reviewers] error: 568c4896: 1 reviewer required, found 0 The last error is valid because I have not entered any reviewers yet, but what about the other errors? Isn't jcheck intended to be run locally? Thank you and best regards, Volker From thomas.stuefe at gmail.com Tue Sep 22 11:27:23 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 22 Sep 2020 13:27:23 +0200 Subject: Running tests without a PR? Message-ID: Hi, Sorry if that question has been answered already, but I cannot find anything about it on the wiki. If I understand correctly, the old functionality of jdk-submit is now covered by the PR command /test? But to run that I need to have an actual PR? Is there a way to run the tests without opening a PR? There are several scenarios where this may be useful. For instance, running the tests before creating a PR prevents polluting the PR with follow up fixes. Thanks, Thomas From robin.westberg at oracle.com Tue Sep 22 12:12:22 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Tue, 22 Sep 2020 14:12:22 +0200 Subject: Running tests without a PR? In-Reply-To: References: Message-ID: Hi Thomas, We?re hoping that most of what the submit-repo provided can instead be serviced by GitHub Actions in the near future (see https://github.com/openjdk/jdk/pull/284 ) - these tests can run directly on a branch before creating a PR. Otherwise, as you have seen, any commands such as /test do indeed require a PR. In these cases you can usually use a ?draft? PR though, which won?t cause any RFR emails to be sent until it leaves the draft state. So in such a PR it doesn?t really matter if you make multiple commits, you can just squash them together before making the PR non-draft. Best regards, Robin > On 22 Sep 2020, at 13:27, Thomas St?fe wrote: > > Hi, > > Sorry if that question has been answered already, but I cannot find > anything about it on the wiki. > > If I understand correctly, the old functionality of jdk-submit is now > covered by the PR command /test? But to run that I need to have an actual > PR? > > Is there a way to run the tests without opening a PR? > > There are several scenarios where this may be useful. For instance, running > the tests before creating a PR prevents polluting the PR with follow up > fixes. > > Thanks, Thomas From rwestberg at openjdk.java.net Tue Sep 22 12:18:13 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 22 Sep 2020 12:18:13 GMT Subject: RFR: 623: Label rules filter should take direct group matches into account Message-ID: When a mailing list rule filter matches a group, any group members should be removed from the list of matches. Best regards, Robin ------------- Commit messages: - Remove group matches separately Changes: https://git.openjdk.java.net/skara/pull/839/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=839&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-623 Stats: 27 lines in 2 files changed: 25 ins; 1 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/839.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/839/head:pull/839 PR: https://git.openjdk.java.net/skara/pull/839 From thomas.stuefe at gmail.com Tue Sep 22 12:33:44 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 22 Sep 2020 14:33:44 +0200 Subject: Running tests without a PR? In-Reply-To: References: Message-ID: Hi Robin, On Tue, Sep 22, 2020 at 2:14 PM Robin Westberg wrote: > Hi Thomas, > > We?re hoping that most of what the submit-repo provided can instead be > serviced by GitHub Actions in the near future (see > https://github.com/openjdk/jdk/pull/284) - these tests can run directly > on a branch before creating a PR. > > This seems like a very useful feature. Especially if you manage to be less opaque about build/test errors than jdk-submit had been :) > Otherwise, as you have seen, any commands such as /test do indeed require > a PR. In these cases you can usually use a ?draft? PR though, which won?t > cause any RFR emails to be sent until it leaves the draft state. So in such > a PR it doesn?t really matter if you make multiple commits, you can just > squash them together before making the PR non-draft. > So, in a PR in draft state I still can change history (Rebase, squash, whatnot)? Just asking since AFAIK a PR in review should not be rebased anymore. Thanks, Thomas > > Best regards, > Robin > > On 22 Sep 2020, at 13:27, Thomas St?fe wrote: > > Hi, > > Sorry if that question has been answered already, but I cannot find > anything about it on the wiki. > > If I understand correctly, the old functionality of jdk-submit is now > covered by the PR command /test? But to run that I need to have an actual > PR? > > Is there a way to run the tests without opening a PR? > > There are several scenarios where this may be useful. For instance, running > the tests before creating a PR prevents polluting the PR with follow up > fixes. > > Thanks, Thomas > > > From stuefe at openjdk.java.net Tue Sep 22 14:33:26 2020 From: stuefe at openjdk.java.net (Thomas Stuefe) Date: Tue, 22 Sep 2020 14:33:26 GMT Subject: Integrated: 716: Git version check pattern matching is too strict In-Reply-To: References: Message-ID: On Tue, 22 Sep 2020 05:02:47 GMT, Thomas Stuefe wrote: > Hi, > > may I have reviews please for this small fix. On my Ubuntu 16.4 box I run with git 2.7.0 (so far without any problems, > but that is another story). Skara wants a newer version and does a version check. That check fails to parse the version > number correctly. https://bugs.openjdk.java.net/browse/SKARA-716 > > Tests: tried to run gradlw test on my Linux box but I get test errors - but those errors also appear on a clean repo > (see https://mail.openjdk.java.net/pipermail/skara-dev/2020-September/003410.html), I am quite sure they have anything > to do with my fix. This pull request has now been integrated. Changeset: 179f9232 Author: Thomas Stuefe Committer: Erik Helin URL: https://git.openjdk.java.net/skara/commit/179f9232 Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod 716: Git version check pattern matching is too strict Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/838 From ehelin at openjdk.java.net Tue Sep 22 14:33:44 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 14:33:44 GMT Subject: git: openjdk/skara: 694: Checking invalid email gives an exception Message-ID: Changeset: dc524c14 Author: Erik Helin Date: 2020-09-22 14:33:17 +0000 URL: https://git.openjdk.java.net/skara/commit/dc524c14 694: Checking invalid email gives an exception Reviewed-by: tbell, rwestberg ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java ! bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestCheckIssueVisitor.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/CheckTests.java ! bots/pr/src/test/java/org/openjdk/skara/bots/pr/IntegrateTests.java From ehelin at openjdk.java.net Tue Sep 22 14:34:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 14:34:43 GMT Subject: RFR: 623: Label rules filter should take direct group matches into account In-Reply-To: References: Message-ID: On Tue, 22 Sep 2020 12:15:07 GMT, Robin Westberg wrote: > When a mailing list rule filter matches a group, any group members should be removed from the list of matches. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/839 From ehelin at openjdk.java.net Tue Sep 22 14:35:34 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 14:35:34 GMT Subject: Integrated: 694: Checking invalid email gives an exception In-Reply-To: References: Message-ID: On Mon, 21 Sep 2020 16:14:22 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that contributors who do not have an OpenJDK username specify a valid name and > e-mail for a pull request's `HEAD` commit. > Testing: > - Added a new unit test > - `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: dc524c14 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/dc524c14 Stats: 124 lines in 5 files changed: 45 ins; 77 del; 2 mod 694: Checking invalid email gives an exception Reviewed-by: tbell, rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/837 From erik.helin at oracle.com Tue Sep 22 15:51:59 2020 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 22 Sep 2020 17:51:59 +0200 Subject: Errors when running jcheck locally In-Reply-To: References: Message-ID: <0a3f7599-c488-d60f-0eb5-4ce0f759c4f8@oracle.com> On 9/22/20 12:55 PM, Volker Simonis wrote: > Hi, > > sorry if this has been documented or answered already somewhere but I > couldn't find any information in the WIki or the mailing list. > > I think I have a valid setup and configured everything properly, but > when I run "git jcheck" locally on my clone of a > https://github.com/openjdk/jdk fork, I get the following errors: > > $ git status > On branch JDK-8253435-cpusets-fix > $ git log > commit 568c48964a156f5ca71319f0585f2d5c84899c62 (HEAD -> > JDK-8253435-cpusets-fix) > Author: Volker Simonis > Date: Mon Sep 21 18:58:58 2020 +0200 > > 8253435: Cgroup: 'stomping of _mount_path' crash if manually > mounted cpusets exist > ... > $ git jcheck > [branches] error: illegal branch name: JDK-8253435-cpusets-fix > [branches] error: illegal branch name: zip_entry_fix > [committer] error: 568c4896: missing committer email from domain openjdk.org > [committer] error: 568c4896: Volker Simonis is not committer in project jdk > [reviewers] error: 568c4896: 1 reviewer required, found 0 > > The last error is valid because I have not entered any reviewers yet, > but what about the other errors? The branches error is because you have branches locally :) The upstream jdk repository does not allow any additional branches and jcheck can't know that it is being run in a contributor's local repository. The committer error is because the values for `user.name` and `user.email` in your local git configuration isn't following the JEP 357 conventions. > Isn't jcheck intended to be run locally? It certainly is! git-jcheck has the flag --ignore which lets you ignore errors from a particular check. Any error printed by git-jcheck is always prefixed with the check that found the error (in your case the branches, committer and reviewers checks). I would argue that you can safely ignore all errors from the branches, committer and reviewers checks because: - you cannot create a new branch in the upstream jdk repository since you don't direct write access. - the committer field in the final commit will be set by the Skara bots and they will use the right values. Whatever you have configured locally does not matter. - since the commit is _not_ out for review yet you can't have any reviewers. To always ignore errors from the branches, committer and reviewers checks, just run: $ git config --global jcheck.ignore branches,committer,reviewers Thanks, Erik > Thank you and best regards, > Volker > From ehelin at openjdk.java.net Tue Sep 22 16:15:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 22 Sep 2020 16:15:12 GMT Subject: RFR: 685: Show a warning if PR author's full name does not match commit author's full name Message-ID: <8ebjp2Tet0KurHoq8ssscz0PKusGf3uVs5eJ8jYORkU=.bbf0bc5e-4219-4aa5-8796-b5ff0490037b@github.com> Hi all, please review this patch that adds an error if the author of the pull request does not have an OpenJDK username, has a full name set for their GitHub account and the `HEAD` commit for the pull request uses another full name. Testing: - [x] `make test` passes on Linux x64 - [x] Added an additional unit test Thanks, Erik ------------- Commit messages: - 685 Changes: https://git.openjdk.java.net/skara/pull/840/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=840&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-685 Stats: 64 lines in 5 files changed: 52 ins; 3 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/840.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/840/head:pull/840 PR: https://git.openjdk.java.net/skara/pull/840 From volker.simonis at gmail.com Tue Sep 22 21:32:48 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Tue, 22 Sep 2020 23:32:48 +0200 Subject: Errors when running jcheck locally In-Reply-To: <0a3f7599-c488-d60f-0eb5-4ce0f759c4f8@oracle.com> References: <0a3f7599-c488-d60f-0eb5-4ce0f759c4f8@oracle.com> Message-ID: Thanks a lot Erik for the detailed explanation! Erik Helin schrieb am Di., 22. Sept. 2020, 17:52: > On 9/22/20 12:55 PM, Volker Simonis wrote: > > Hi, > > > > sorry if this has been documented or answered already somewhere but I > > couldn't find any information in the WIki or the mailing list. > > > > I think I have a valid setup and configured everything properly, but > > when I run "git jcheck" locally on my clone of a > > https://github.com/openjdk/jdk fork, I get the following errors: > > > > $ git status > > On branch JDK-8253435-cpusets-fix > > $ git log > > commit 568c48964a156f5ca71319f0585f2d5c84899c62 (HEAD -> > > JDK-8253435-cpusets-fix) > > Author: Volker Simonis > > Date: Mon Sep 21 18:58:58 2020 +0200 > > > > 8253435: Cgroup: 'stomping of _mount_path' crash if manually > > mounted cpusets exist > > ... > > $ git jcheck > > [branches] error: illegal branch name: JDK-8253435-cpusets-fix > > [branches] error: illegal branch name: zip_entry_fix > > [committer] error: 568c4896: missing committer email from domain > openjdk.org > > [committer] error: 568c4896: Volker Simonis is not committer in project > jdk > > [reviewers] error: 568c4896: 1 reviewer required, found 0 > > > > The last error is valid because I have not entered any reviewers yet, > > but what about the other errors? > > The branches error is because you have branches locally :) The upstream > jdk repository does not allow any additional branches and jcheck can't > know that it is being run in a contributor's local repository. > > The committer error is because the values for `user.name` and > `user.email` in your local git configuration isn't following the JEP 357 > conventions. > > > Isn't jcheck intended to be run locally? > > It certainly is! git-jcheck has the flag --ignore which lets you ignore > errors from a particular check. Any error printed by git-jcheck is > always prefixed with the check that found the error (in your case the > branches, committer and reviewers checks). > > I would argue that you can safely ignore all errors from the branches, > committer and reviewers checks because: > > - you cannot create a new branch in the upstream jdk repository since > you don't direct write access. > - the committer field in the final commit will be set by the Skara bots > and they will use the right values. Whatever you have configured > locally does not matter. > - since the commit is _not_ out for review yet you can't have any > reviewers. > > To always ignore errors from the branches, committer and reviewers > checks, just run: > > $ git config --global jcheck.ignore branches,committer,reviewers > > Thanks, > Erik > > > Thank you and best regards, > > Volker > > > From rwestberg at openjdk.java.net Wed Sep 23 07:59:14 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 23 Sep 2020 07:59:14 GMT Subject: RFR: 685: Show a warning if PR author's full name does not match commit author's full name In-Reply-To: <8ebjp2Tet0KurHoq8ssscz0PKusGf3uVs5eJ8jYORkU=.bbf0bc5e-4219-4aa5-8796-b5ff0490037b@github.com> References: <8ebjp2Tet0KurHoq8ssscz0PKusGf3uVs5eJ8jYORkU=.bbf0bc5e-4219-4aa5-8796-b5ff0490037b@github.com> Message-ID: On Tue, 22 Sep 2020 16:12:07 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds an error if the author of the pull request does not have an OpenJDK username, has a > full name set for their GitHub account and the `HEAD` commit for the pull request uses another full name. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added an additional unit test > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/840 From rwestberg at openjdk.java.net Wed Sep 23 09:02:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 23 Sep 2020 09:02:43 GMT Subject: Integrated: 623: Label rules filter should take direct group matches into account In-Reply-To: References: Message-ID: <6c2f2BPbu_o6st_vIUWQ1NNmQlUwz4VUpaMffZ8y7Pg=.64af4404-9dd5-454e-befb-7f667de704c8@github.com> On Tue, 22 Sep 2020 12:15:07 GMT, Robin Westberg wrote: > When a mailing list rule filter matches a group, any group members should be removed from the list of matches. > > Best regards, > Robin This pull request has now been integrated. Changeset: e80a5d45 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/e80a5d45 Stats: 27 lines in 2 files changed: 25 ins; 1 del; 1 mod 623: Label rules filter should take direct group matches into account Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/839 From ehelin at openjdk.java.net Wed Sep 23 09:40:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 23 Sep 2020 09:40:22 GMT Subject: Integrated: 685: Show a warning if PR author's full name does not match commit author's full name In-Reply-To: <8ebjp2Tet0KurHoq8ssscz0PKusGf3uVs5eJ8jYORkU=.bbf0bc5e-4219-4aa5-8796-b5ff0490037b@github.com> References: <8ebjp2Tet0KurHoq8ssscz0PKusGf3uVs5eJ8jYORkU=.bbf0bc5e-4219-4aa5-8796-b5ff0490037b@github.com> Message-ID: On Tue, 22 Sep 2020 16:12:07 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds an error if the author of the pull request does not have an OpenJDK username, has a > full name set for their GitHub account and the `HEAD` commit for the pull request uses another full name. > Testing: > - [x] `make test` passes on Linux x64 > - [x] Added an additional unit test > > Thanks, > Erik This pull request has now been integrated. Changeset: 72b87eb0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/72b87eb0 Stats: 64 lines in 5 files changed: 52 ins; 3 del; 9 mod 685: Show a warning if PR author's full name does not match commit author's full name Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/840 From ehelin at openjdk.java.net Wed Sep 23 13:20:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 23 Sep 2020 13:20:23 GMT Subject: RFR: pr: always re-fetch PR for returned work items Message-ID: Hi all, please review this patch that ensures that we always re-fetch a pull request before returning new work items. This is to ensure that the returned work items never work on stale data. Thanks, Erik ------------- Commit messages: - pr: always re-fetch PR for returned work items Changes: https://git.openjdk.java.net/skara/pull/841/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=841&range=00 Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/841.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/841/head:pull/841 PR: https://git.openjdk.java.net/skara/pull/841 From rwestberg at openjdk.java.net Wed Sep 23 13:40:24 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 23 Sep 2020 13:40:24 GMT Subject: RFR: pr: always re-fetch PR for returned work items In-Reply-To: References: Message-ID: On Wed, 23 Sep 2020 13:17:24 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that we always re-fetch a pull request before returning new work items. This is > to ensure that the returned work items never work on stale data. > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/841 From ehelin at openjdk.java.net Wed Sep 23 13:50:42 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 23 Sep 2020 13:50:42 GMT Subject: Integrated: pr: always re-fetch PR for returned work items In-Reply-To: References: Message-ID: On Wed, 23 Sep 2020 13:17:24 GMT, Erik Helin wrote: > Hi all, > > please review this patch that ensures that we always re-fetch a pull request before returning new work items. This is > to ensure that the returned work items never work on stale data. > Thanks, > Erik This pull request has now been integrated. Changeset: 51351209 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/51351209 Stats: 8 lines in 2 files changed: 6 ins; 0 del; 2 mod pr: always re-fetch PR for returned work items Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/841 From thomas.stuefe at gmail.com Thu Sep 24 07:36:49 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 09:36:49 +0200 Subject: Some questions about PR commands Message-ID: Hi all, I have some questions about PR commands (I read https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands which I believe is the correct documentation). - Can I invite specific reviewers? Since often a PR is the result of preliminary discussions, where before I would have cc'ed someone specific for the initial RFR mail. - /test - is the test argument optional (square brackets seem to indicate that). If yes, what tests are executed by default? - /label and /issue - are "add" and "remove" optional (square brackets seem to indicate that but examples don't). Is add the default? - Can I stack multiple commands? If yes, can they appear anywhere in a PR comment? Also in the PR body? What happens if I specify the same command multiple times, does the last win or do they accumulate? - Draft PR: which commands, if any, work in for draft PR? In particular, does /test work? - Finally, I see long running PRs use the "[Vx]" suffix in their PR names. Are these manually created or is there some tool support I missed for long running PRs? Thank you! Thomas From thomas.stuefe at gmail.com Thu Sep 24 09:45:13 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 11:45:13 +0200 Subject: Errors when running jcheck locally In-Reply-To: <0a3f7599-c488-d60f-0eb5-4ce0f759c4f8@oracle.com> References: <0a3f7599-c488-d60f-0eb5-4ce0f759c4f8@oracle.com> Message-ID: Hi Erik, On Tue, Sep 22, 2020 at 5:54 PM Erik Helin wrote: > On 9/22/20 12:55 PM, Volker Simonis wrote: > > Hi, > > > > sorry if this has been documented or answered already somewhere but I > > couldn't find any information in the WIki or the mailing list. > > > > I think I have a valid setup and configured everything properly, but > > when I run "git jcheck" locally on my clone of a > > https://github.com/openjdk/jdk fork, I get the following errors: > > > > $ git status > > On branch JDK-8253435-cpusets-fix > > $ git log > > commit 568c48964a156f5ca71319f0585f2d5c84899c62 (HEAD -> > > JDK-8253435-cpusets-fix) > > Author: Volker Simonis > > Date: Mon Sep 21 18:58:58 2020 +0200 > > > > 8253435: Cgroup: 'stomping of _mount_path' crash if manually > > mounted cpusets exist > > ... > > $ git jcheck > > [branches] error: illegal branch name: JDK-8253435-cpusets-fix > > [branches] error: illegal branch name: zip_entry_fix > > [committer] error: 568c4896: missing committer email from domain > openjdk.org > > [committer] error: 568c4896: Volker Simonis is not committer in project > jdk > > [reviewers] error: 568c4896: 1 reviewer required, found 0 > > > > The last error is valid because I have not entered any reviewers yet, > > but what about the other errors? > > The branches error is because you have branches locally :) The upstream > jdk repository does not allow any additional branches and jcheck can't > know that it is being run in a contributor's local repository. > > The committer error is because the values for `user.name` and > `user.email` in your local git configuration isn't following the JEP 357 > conventions. > > I have some more questions, if I may: So I have a census name ("stuefe"), a github name ("tstuefe"), and a full name ("Thomas Stuefe"). You have two :) Following the steps in https://wiki.openjdk.java.net/display/SKARA#Skara-AssociatingyourGitHubaccountandyourOpenJDKusername associates the github name with my census name at Oracle, right? The skara wiki at https://wiki.openjdk.java.net/display/SKARA#Skara-InitialConfiguration further states I should use the full name as a global user.name setting in git: $ git config --global user.name 'Your Full Name' Does "Full Name" have to match the census full name? (e.g. in your case, "Helin", in my case "Stuefe", not "St?fe")? Why can I not use the github name as user.name? Since some commits at https://github.com/openjdk/jdk/commits/master appear to use the github name, some the full name, the former being linked to the profile, the latter not. Since I usually do not use the full name in my commits, requiring this for OpenJDK would mean I have to overwrite it on a per-repository base. Thank you, and sorry for all the questions! ... Thomas From rwestberg at openjdk.java.net Thu Sep 24 10:33:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 24 Sep 2020 10:33:46 GMT Subject: RFR: 720: Incorrect usage instructions for label command In-Reply-To: References: Message-ID: On Thu, 24 Sep 2020 10:28:45 GMT, Erik Helin wrote: > Hi all, > > please review this patch that improves the messages from the bots wrt to applied labels. For automatically applied > labels we now list the labels more prominently. This is done to bring more attention to lists that will be CC:d. When > no labels are automatically found then the message has been made a bit shorter by using a dropdown for revealing > applicable labels. Both messages now link to the `/label` pull request command documentation instead of describing it > in the messages. Testing: > - [x] Updated a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Marked as reviewed by rwestberg (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/842 From rwestberg at openjdk.java.net Thu Sep 24 10:33:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 24 Sep 2020 10:33:46 GMT Subject: RFR: 720: Incorrect usage instructions for label command In-Reply-To: References: Message-ID: <5qShnuSej4CUJlgOoBbLuA6D4O-H1RySNXm6h1sq9mg=.eddac5bf-bb54-41b6-a357-ab57942a5e13@github.com> On Thu, 24 Sep 2020 10:31:12 GMT, Robin Westberg wrote: >> Hi all, >> >> please review this patch that improves the messages from the bots wrt to applied labels. For automatically applied >> labels we now list the labels more prominently. This is done to bring more attention to lists that will be CC:d. When >> no labels are automatically found then the message has been made a bit shorter by using a dropdown for revealing >> applicable labels. Both messages now link to the `/label` pull request command documentation instead of describing it >> in the messages. Testing: >> - [x] Updated a unit test >> - [x] `make test` passes on Linux x64 >> >> Thanks, >> Erik > > Marked as reviewed by rwestberg (Reviewer). Looks good! ------------- PR: https://git.openjdk.java.net/skara/pull/842 From ehelin at openjdk.java.net Thu Sep 24 10:33:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 10:33:45 GMT Subject: RFR: 720: Incorrect usage instructions for label command Message-ID: Hi all, please review this patch that improves the messages from the bots wrt to applied labels. For automatically applied labels we now list the labels more prominently. This is done to bring more attention to lists that will be CC:d. When no labels are automatically found then the message has been made a bit shorter by using a dropdown for revealing applicable labels. Both messages now link to the `/label` pull request command documentation instead of describing it in the messages. Testing: - [x] Updated a unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - 720 Changes: https://git.openjdk.java.net/skara/pull/842/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=842&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-720 Stats: 30 lines in 2 files changed: 11 ins; 1 del; 18 mod Patch: https://git.openjdk.java.net/skara/pull/842.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/842/head:pull/842 PR: https://git.openjdk.java.net/skara/pull/842 From thomas.stuefe at gmail.com Thu Sep 24 10:41:46 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 12:41:46 +0200 Subject: Commit message whitespace issue Message-ID: Hi, sorry to be a bother, but I try to understand the jcheck bot error on the following PR: https://github.com/openjdk/jdk/pull/332 "The commit message contains a tab on line 2" The PR contains a single commit which I created using git commit -m 'JDK-8253572' Since the commit message only consists of one word, where does the tab come into play? What should I do to fix or avoid this problem? Thanks again! ..Thomas From robin.westberg at oracle.com Thu Sep 24 11:12:38 2020 From: robin.westberg at oracle.com (Robin Westberg) Date: Thu, 24 Sep 2020 13:12:38 +0200 Subject: Commit message whitespace issue In-Reply-To: References: Message-ID: Hi Thomas, > On 24 Sep 2020, at 12:41, Thomas St?fe wrote: > > Hi, > > sorry to be a bother, but I try to understand the jcheck bot error on the > following PR: No worries! > https://github.com/openjdk/jdk/pull/332 > > "The commit message contains a tab on line 2" > > The PR contains a single commit which I created using > > git commit -m 'JDK-8253572' > > Since the commit message only consists of one word, where does the tab come > into play? What should I do to fix or avoid this problem? This error certainly looks a bit confusing. The root of the error is that https://bugs.openjdk.java.net/browse/JDK-8249943 contains a tab at the end of the tile, which has then been propagated to the commit message that will be used for the final commit. Normally you?d see what this commit message looks like, but it won?t be shown until the check passes.. We should ensure that the the check filters tab characters from issue titles I think, I?ll file a bug for this. Meanwhile, I edited the propagated title in your PR to unblock it, hope you don?t mind. Best regards, Robin > > Thanks again! > > ..Thomas From thomas.stuefe at gmail.com Thu Sep 24 11:32:53 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 13:32:53 +0200 Subject: Commit message whitespace issue In-Reply-To: References: Message-ID: On Thu, Sep 24, 2020 at 1:12 PM Robin Westberg wrote: > Hi Thomas, > > On 24 Sep 2020, at 12:41, Thomas St?fe wrote: > > Hi, > > sorry to be a bother, but I try to understand the jcheck bot error on the > following PR: > > > No worries! > > https://github.com/openjdk/jdk/pull/332 > > "The commit message contains a tab on line 2" > > The PR contains a single commit which I created using > > git commit -m 'JDK-8253572' > > Since the commit message only consists of one word, where does the tab come > into play? What should I do to fix or avoid this problem? > > > This error certainly looks a bit confusing. The root of the error is that > https://bugs.openjdk.java.net/browse/JDK-8249943 contains a tab at the > end of the tile, which has then been propagated to the commit message that > will be used for the final commit. Normally you?d see what this commit > message looks like, but it won?t be shown until the check passes.. > > We should ensure that the the check filters tab characters from issue > titles I think, I?ll file a bug for this. > > Meanwhile, I edited the propagated title in your PR to unblock it, hope > you don?t mind. > > Thanks a lot Robin! JBS should really strip the issue titles. Cheers, Thomas > Best regards, > Robin > > > Thanks again! > > ..Thomas > > > From ehelin at openjdk.java.net Thu Sep 24 11:34:09 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 11:34:09 GMT Subject: Integrated: 720: Incorrect usage instructions for label command In-Reply-To: References: Message-ID: On Thu, 24 Sep 2020 10:28:45 GMT, Erik Helin wrote: > Hi all, > > please review this patch that improves the messages from the bots wrt to applied labels. For automatically applied > labels we now list the labels more prominently. This is done to bring more attention to lists that will be CC:d. When > no labels are automatically found then the message has been made a bit shorter by using a dropdown for revealing > applicable labels. Both messages now link to the `/label` pull request command documentation instead of describing it > in the messages. Testing: > - [x] Updated a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 978cf2d8 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/978cf2d8 Stats: 30 lines in 2 files changed: 11 ins; 1 del; 18 mod 720: Incorrect usage instructions for label command Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/842 From rwestberg at openjdk.java.net Thu Sep 24 12:46:26 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 24 Sep 2020 12:46:26 GMT Subject: RFR: 665: Mismatch between issue and PR title should not allow integration Message-ID: If there's a mismatch between the PR title and the issue title, we'll not set the `ready` label until either one of them is changed. Also added a section in the PR body to list these integration blockers (waiting for a CSR approval is another such one). Best regards, Robin ------------- Commit messages: - Update tests - Add JBS title mismatch as an integration blocker Changes: https://git.openjdk.java.net/skara/pull/843/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=843&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-665 Stats: 136 lines in 9 files changed: 68 ins; 47 del; 21 mod Patch: https://git.openjdk.java.net/skara/pull/843.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/843/head:pull/843 PR: https://git.openjdk.java.net/skara/pull/843 From ehelin at openjdk.java.net Thu Sep 24 13:11:19 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 13:11:19 GMT Subject: RFR: 665: Mismatch between issue and PR title should not allow integration In-Reply-To: References: Message-ID: On Thu, 24 Sep 2020 12:43:14 GMT, Robin Westberg wrote: > If there's a mismatch between the PR title and the issue title, we'll not set the `ready` label until either one of > them is changed. Also added a section in the PR body to list these integration blockers (waiting for a CSR approval is > another such one). Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/843 From ehelin at openjdk.java.net Thu Sep 24 13:21:45 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 13:21:45 GMT Subject: RFR: pr: hint about two reviewers for some labels Message-ID: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> Hi all, please review this patch that makes it possible to configure per repository whether certain labels should cause a hint in the integration message about two reviewers to be displayed. Testing: - [x] Added a new unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - pr: hint about two reviewers for some labels Changes: https://git.openjdk.java.net/skara/pull/844/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=844&range=00 Stats: 86 lines in 5 files changed: 81 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/844.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/844/head:pull/844 PR: https://git.openjdk.java.net/skara/pull/844 From rwestberg at openjdk.java.net Thu Sep 24 13:21:46 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 24 Sep 2020 13:21:46 GMT Subject: RFR: pr: hint about two reviewers for some labels In-Reply-To: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> References: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> Message-ID: On Thu, 24 Sep 2020 13:17:35 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible to configure per repository whether certain labels should cause a hint > in the integration message about two reviewers to be displayed. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/844 From rwestberg at openjdk.java.net Thu Sep 24 13:22:12 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Thu, 24 Sep 2020 13:22:12 GMT Subject: Integrated: 665: Mismatch between issue and PR title should not allow integration In-Reply-To: References: Message-ID: On Thu, 24 Sep 2020 12:43:14 GMT, Robin Westberg wrote: > If there's a mismatch between the PR title and the issue title, we'll not set the `ready` label until either one of > them is changed. Also added a section in the PR body to list these integration blockers (waiting for a CSR approval is > another such one). Best regards, > Robin This pull request has now been integrated. Changeset: c9630751 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/c9630751 Stats: 133 lines in 9 files changed: 68 ins; 44 del; 21 mod 665: Mismatch between issue and PR title should not allow integration Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/843 From thomas.stuefe at gmail.com Thu Sep 24 13:33:39 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 15:33:39 +0200 Subject: Large webrevs do not show up Message-ID: Hi all, I just posted a PR for jep387: https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/042203.html and the webrev is not displayed. I tried several browsers on several machines. The patch is rather large. Did I hit a limit with github? Thanks, Thomas From ehelin at openjdk.java.net Thu Sep 24 13:42:05 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 13:42:05 GMT Subject: RFR: pr: hint about two reviewers for some labels [v2] In-Reply-To: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> References: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> Message-ID: > Hi all, > > please review this patch that makes it possible to configure per repository whether certain labels should cause a hint > in the integration message about two reviewers to be displayed. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Erik Helin has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains two commits: - Merge master - pr: hint about two reviewers for some labels ------------- Changes: https://git.openjdk.java.net/skara/pull/844/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=844&range=01 Stats: 86 lines in 5 files changed: 81 ins; 0 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/844.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/844/head:pull/844 PR: https://git.openjdk.java.net/skara/pull/844 From thomas.stuefe at gmail.com Thu Sep 24 13:42:51 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 15:42:51 +0200 Subject: Invalid @openjdk.java.net mail addresses Message-ID: Hi all, I am quite sure this is already a known issue but looking through skara-dev I did not find anything. It seems currently, when processing PRs, skara tools send mails to the mailing lists using a fictious xx at openjdk.java.net mail address (eg stuefe at openjdk.java.net) instead of the real user address. I would have expected the primary github user address to be used. This leads to bounces when discussing things on the ML. Also, I would prefer to see my mails under my own mail address. Am I missing something obvious? If so, sorry... Thanks! Thomas From volker.simonis at gmail.com Thu Sep 24 13:52:09 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 24 Sep 2020 15:52:09 +0200 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: Message-ID: On Thu, Sep 24, 2020 at 3:45 PM Thomas St?fe wrote: > > Hi all, > > I am quite sure this is already a known issue but looking through skara-dev > I did not find anything. > > It seems currently, when processing PRs, skara tools send mails to the > mailing lists using a fictious xx at openjdk.java.net mail address (eg > stuefe at openjdk.java.net) instead of the real user address. I would have > expected the primary github user address to be used. > How did you find out that skara tools send out mails to an address which doesn't exist? I only see that the mails sent out by the skara tooling are sent from xxx at openjdk.java.net. E.g.: From: Volker Simonis But I think that's harmless. > This leads to bounces when discussing things on the ML. Also, I would > prefer to see my mails under my own mail address. > > Am I missing something obvious? If so, sorry... > > Thanks! > > Thomas From thomas.stuefe at gmail.com Thu Sep 24 13:53:34 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 15:53:34 +0200 Subject: Large webrevs do not show up In-Reply-To: References: Message-ID: Okay, I opened https://bugs.openjdk.java.net/browse/SKARA-732 to track this issue. Cheers, Thomas On Thu, Sep 24, 2020 at 3:33 PM Thomas St?fe wrote: > Hi all, > > I just posted a PR for jep387: > > > https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/042203.html > > and the webrev is not displayed. I tried several browsers on several > machines. The patch is rather large. Did I hit a limit with github? > > Thanks, Thomas > From volker.simonis at gmail.com Thu Sep 24 13:56:46 2020 From: volker.simonis at gmail.com (Volker Simonis) Date: Thu, 24 Sep 2020 15:56:46 +0200 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: Message-ID: Ah, now I see what you mean: Subject: Re: RFR: 8253435: Cgroup: 'stomping of _mount_path' crash if manually mounted cpusets exist From: Bob Vandette In-Reply-To: Date: Tue, 22 Sep 2020 10:59:16 -0400 Cc: hotspot-runtime-dev at openjdk.java.net Content-Transfer-Encoding: quoted-printable Message-Id: <6043D8E3-F75D-4011-AE9A-C4D2EA1A739B at oracle.com> References: To: Volker Simonis The "Volker Simonis " seems indeed strange. Maybe they have a magic mail server which translates all "@openjdk.java.net" addresses into real addresses? On Thu, Sep 24, 2020 at 3:52 PM Volker Simonis wrote: > > On Thu, Sep 24, 2020 at 3:45 PM Thomas St?fe wrote: > > > > Hi all, > > > > I am quite sure this is already a known issue but looking through skara-dev > > I did not find anything. > > > > It seems currently, when processing PRs, skara tools send mails to the > > mailing lists using a fictious xx at openjdk.java.net mail address (eg > > stuefe at openjdk.java.net) instead of the real user address. I would have > > expected the primary github user address to be used. > > > > How did you find out that skara tools send out mails to an address > which doesn't exist? > > I only see that the mails sent out by the skara tooling are sent from > xxx at openjdk.java.net. E.g.: > > From: Volker Simonis > > But I think that's harmless. > > > This leads to bounces when discussing things on the ML. Also, I would > > prefer to see my mails under my own mail address. > > > > Am I missing something obvious? If so, sorry... > > > > Thanks! > > > > Thomas From thomas.stuefe at gmail.com Thu Sep 24 14:01:22 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 16:01:22 +0200 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: Message-ID: On Thu, Sep 24, 2020 at 3:57 PM Volker Simonis wrote: > Ah, now I see what you mean: > > Subject: Re: RFR: 8253435: Cgroup: 'stomping of _mount_path' crash if > manually mounted cpusets exist > From: Bob Vandette > In-Reply-To: 431a6072-62a9-46cb-be58-b4e03d303428 at github.com> > Date: Tue, 22 Sep 2020 10:59:16 -0400 > Cc: hotspot-runtime-dev at openjdk.java.net > Content-Transfer-Encoding: quoted-printable > Message-Id: <6043D8E3-F75D-4011-AE9A-C4D2EA1A739B at oracle.com> > References: 431a6072-62a9-46cb-be58-b4e03d303428 at github.com> > To: Volker Simonis > > Yes that is what I meant. The same also happens for reviewers which review on Github and then are part of the ML discussion via openjdk.java.net. > The "Volker Simonis " seems indeed strange. > Maybe they have a magic mail server which translates all > "@openjdk.java.net" addresses into real addresses? > > Not AFAICS. I see bounces when addressing those mail addresses. Cheers, Thomas > On Thu, Sep 24, 2020 at 3:52 PM Volker Simonis > wrote: > > > > On Thu, Sep 24, 2020 at 3:45 PM Thomas St?fe > wrote: > > > > > > Hi all, > > > > > > I am quite sure this is already a known issue but looking through > skara-dev > > > I did not find anything. > > > > > > It seems currently, when processing PRs, skara tools send mails to the > > > mailing lists using a fictious xx at openjdk.java.net mail address (eg > > > stuefe at openjdk.java.net) instead of the real user address. I would > have > > > expected the primary github user address to be used. > > > > > > > How did you find out that skara tools send out mails to an address > > which doesn't exist? > > > > I only see that the mails sent out by the skara tooling are sent from > > xxx at openjdk.java.net. E.g.: > > > > From: Volker Simonis > > > > But I think that's harmless. > > > > > This leads to bounces when discussing things on the ML. Also, I would > > > prefer to see my mails under my own mail address. > > > > > > Am I missing something obvious? If so, sorry... > > > > > > Thanks! > > > > > > Thomas > From james.laskey at oracle.com Thu Sep 24 14:07:39 2020 From: james.laskey at oracle.com (Jim Laskey) Date: Thu, 24 Sep 2020 11:07:39 -0300 Subject: Large webrevs do not show up In-Reply-To: References: Message-ID: <18D4A300-7ABC-478E-B4EE-09EDEEC08124@oracle.com> Is it a timeout issue loading the data? webrev.js:1491 const setup = init(); window.onload = async function(e) { await setup; << Unhandled Promise Rejection: SyntaxError: The string did not match the expected pattern. log("onload: fragment: " + window.location.hash); renderFromFragment(window.location.hash); } > On Sep 24, 2020, at 10:53 AM, Thomas St?fe wrote: > > Okay, I opened https://bugs.openjdk.java.net/browse/SKARA-732 to track this > issue. > > Cheers, Thomas > > On Thu, Sep 24, 2020 at 3:33 PM Thomas St?fe > wrote: > >> Hi all, >> >> I just posted a PR for jep387: >> >> >> https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/042203.html >> >> and the webrev is not displayed. I tried several browsers on several >> machines. The patch is rather large. Did I hit a limit with github? >> >> Thanks, Thomas >> From ehelin at openjdk.java.net Thu Sep 24 14:18:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Thu, 24 Sep 2020 14:18:28 GMT Subject: Integrated: pr: hint about two reviewers for some labels In-Reply-To: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> References: <1O9gqHRsFQfXLoeV6lW-Cwz14zpPbdi7tt2-eg-GLbg=.45b1033b-a48e-49a1-a204-77cc312804d3@github.com> Message-ID: On Thu, 24 Sep 2020 13:17:35 GMT, Erik Helin wrote: > Hi all, > > please review this patch that makes it possible to configure per repository whether certain labels should cause a hint > in the integration message about two reviewers to be displayed. > Testing: > - [x] Added a new unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 29a27d58 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/29a27d58 Stats: 86 lines in 5 files changed: 81 ins; 0 del; 5 mod pr: hint about two reviewers for some labels Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/844 From tim.bell at oracle.com Thu Sep 24 14:49:18 2020 From: tim.bell at oracle.com (Tim Bell) Date: Thu, 24 Sep 2020 07:49:18 -0700 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: Message-ID: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> On 2020-09-24 06:56, Volker Simonis wrote: > The "Volker Simonis" seems indeed strange. > Maybe they have a magic mail server which translates all > "@openjdk.java.net" addresses into real addresses? That is exactly what I am working on. My initial testing was encouraging, so stay tuned. I need another day or two to work on the mapping of OpenJDK id strings to Github membership information. In many cases it is not 1:1. Tim Bell From thomas.stuefe at gmail.com Thu Sep 24 14:53:06 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 16:53:06 +0200 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> References: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> Message-ID: Thank you Tim! On Thu, Sep 24, 2020, 16:49 Tim Bell wrote: > On 2020-09-24 06:56, Volker Simonis wrote: > > The "Volker Simonis" seems indeed strange. > > Maybe they have a magic mail server which translates all > > "@openjdk.java.net" addresses into real addresses? > > That is exactly what I am working on. My initial testing was > encouraging, so stay tuned. I need another day or two to work on the > mapping of OpenJDK id strings to Github membership information. In many > cases it is not 1:1. > > Tim Bell > From thomas.stuefe at gmail.com Thu Sep 24 15:29:30 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Thu, 24 Sep 2020 17:29:30 +0200 Subject: Large webrevs do not show up In-Reply-To: <18D4A300-7ABC-478E-B4EE-09EDEEC08124@oracle.com> References: <18D4A300-7ABC-478E-B4EE-09EDEEC08124@oracle.com> Message-ID: Hi Jim! I assume you mean a timeout during webrev generation? Possibly. Generating the webrev by hand certainly takes a long time. Cheers, Thomas On Thu, Sep 24, 2020 at 4:07 PM Jim Laskey wrote: > Is it a timeout issue loading the data? > > > webrev.js:1491 > > const setup = init(); > window.onload = async function(e) { > await setup; > << Unhandled Promise Rejection: SyntaxError: The string did not match > the expected pattern. > log("onload: fragment: " + window.location.hash); > renderFromFragment(window.location.hash); > } > > > > On Sep 24, 2020, at 10:53 AM, Thomas St?fe > wrote: > > > > Okay, I opened https://bugs.openjdk.java.net/browse/SKARA-732 to track > this > > issue. > > > > Cheers, Thomas > > > > On Thu, Sep 24, 2020 at 3:33 PM Thomas St?fe > > wrote: > > > >> Hi all, > >> > >> I just posted a PR for jep387: > >> > >> > >> > https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-September/042203.html > >> > >> and the webrev is not displayed. I tried several browsers on several > >> machines. The patch is rather large. Did I hit a limit with github? > >> > >> Thanks, Thomas > >> > > From rwestberg at openjdk.java.net Fri Sep 25 10:20:36 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 25 Sep 2020 10:20:36 GMT Subject: RFR: Initial implementation of RestRequest cache expiration Message-ID: Check the age of cached pages before reusing them to avoid incorrectly receiving stale date from misbehaving caches. Best regards, Robin ------------- Commit messages: - Initial implementation of restrequest cache expiration Changes: https://git.openjdk.java.net/skara/pull/845/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=845&range=00 Stats: 24 lines in 1 file changed: 22 ins; 0 del; 2 mod Patch: https://git.openjdk.java.net/skara/pull/845.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/845/head:pull/845 PR: https://git.openjdk.java.net/skara/pull/845 From ehelin at openjdk.java.net Fri Sep 25 10:42:15 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 25 Sep 2020 10:42:15 GMT Subject: RFR: pr: add hint about 24h exposure for PRs with certain labels Message-ID: Hi all, please review this patch that allows the PR bot to show a hint in the integration message that the PR should perhaps bit out for review for at least 24 hours if the PR has certain label(s). Testing: - [x] Added a unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - pr: add hint about 24h exposure for PRs with certain labels Changes: https://git.openjdk.java.net/skara/pull/846/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=846&range=00 Stats: 128 lines in 11 files changed: 119 ins; 0 del; 9 mod Patch: https://git.openjdk.java.net/skara/pull/846.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/846/head:pull/846 PR: https://git.openjdk.java.net/skara/pull/846 From thomas.stuefe at gmail.com Fri Sep 25 10:46:20 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Fri, 25 Sep 2020 12:46:20 +0200 Subject: /test does not seem to do anything Message-ID: Hi all, I posted two PRs in the last days: https://github.com/openjdk/jdk/pull/332 https://github.com/openjdk/jdk/pull/336 In both cases I requested tests using the /test PR command. I tried: "/test" (no args) "/test tier1" and on the JEP387 one I tried, rather optimistically "/test tier1, tier2, tier3, tier4, tier5, tier6, tier7, tier8" Both PRs got the "test-request" tag but as far as I can observe no tests did run. Did I do something wrong? Or is this feature not yet active, or not active for outside contributors? Thanks, Thomas From rwestberg at openjdk.java.net Fri Sep 25 10:48:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 25 Sep 2020 10:48:38 GMT Subject: RFR: pr: add hint about 24h exposure for PRs with certain labels In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 10:39:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the PR bot to show a hint in the integration message that the PR should perhaps > bit out for review for at least 24 hours if the PR has certain label(s). > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/846 From ehelin at openjdk.java.net Fri Sep 25 12:05:59 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 25 Sep 2020 12:05:59 GMT Subject: RFR: Initial implementation of RestRequest cache expiration In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 10:18:00 GMT, Robin Westberg wrote: > Check the age of cached pages before reusing them to avoid incorrectly receiving stale date from misbehaving caches. > > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/845 From ehelin at openjdk.java.net Fri Sep 25 12:06:39 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 25 Sep 2020 12:06:39 GMT Subject: Integrated: pr: add hint about 24h exposure for PRs with certain labels In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 10:39:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows the PR bot to show a hint in the integration message that the PR should perhaps > bit out for review for at least 24 hours if the PR has certain label(s). > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: 88c0aa65 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/88c0aa65 Stats: 128 lines in 11 files changed: 119 ins; 0 del; 9 mod pr: add hint about 24h exposure for PRs with certain labels Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/846 From rwestberg at openjdk.java.net Fri Sep 25 12:30:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 25 Sep 2020 12:30:23 GMT Subject: RFR: Probe if Jira credentials are valid before making the actual API call Message-ID: The expiration time calculation is unreliable, replace it with a probe. Best regards, Robin ------------- Commit messages: - Probe if Jira credentials are valid before making the actual API call Changes: https://git.openjdk.java.net/skara/pull/847/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=847&range=00 Stats: 43 lines in 5 files changed: 23 ins; 4 del; 16 mod Patch: https://git.openjdk.java.net/skara/pull/847.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/847/head:pull/847 PR: https://git.openjdk.java.net/skara/pull/847 From rwestberg at openjdk.java.net Fri Sep 25 12:30:30 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 25 Sep 2020 12:30:30 GMT Subject: Integrated: Initial implementation of RestRequest cache expiration In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 10:18:00 GMT, Robin Westberg wrote: > Check the age of cached pages before reusing them to avoid incorrectly receiving stale date from misbehaving caches. > > Best regards, > Robin This pull request has now been integrated. Changeset: ed999e89 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/ed999e89 Stats: 24 lines in 1 file changed: 22 ins; 0 del; 2 mod Initial implementation of RestRequest cache expiration Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/845 From ehelin at openjdk.java.net Fri Sep 25 12:36:28 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 25 Sep 2020 12:36:28 GMT Subject: RFR: Probe if Jira credentials are valid before making the actual API call In-Reply-To: References: Message-ID: <-d6ahUpqONig-7uE0smCqXbMWJOaj_YR95N7HpwHu-Y=.2280ce84-2255-4c63-966c-f9adf7c14485@github.com> On Fri, 25 Sep 2020 12:27:19 GMT, Robin Westberg wrote: > The expiration time calculation is unreliable, replace it with a probe. > > Best regards, > Robin Looks great, thanks for fixing! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/847 From jai.forums2013 at gmail.com Fri Sep 25 13:21:01 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Fri, 25 Sep 2020 18:51:01 +0530 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> References: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> Message-ID: <7633b584-13d1-9b4f-8c4f-d971f865c87d@gmail.com> Hello Tim, On 24/09/20 8:19 pm, Tim Bell wrote: > On 2020-09-24 06:56, Volker Simonis wrote: >> The "Volker Simonis" seems indeed strange. >> Maybe they have a magic mail server which translates all >> "@openjdk.java.net" addresses into real addresses? > > That is exactly what I am working on.? My initial testing was > encouraging, so stay tuned.? I need another day or two to work on the > mapping of OpenJDK id strings to Github membership information.? In > many cases it is not 1:1. > Not sure what the implementation will look like, so adding some input on how I had configured my OpenJDK account pre-GitHub days. My OpenJDK account (jpai) is configured with a email address "A" which I use for subscribing to various OpenJDK mailing lists as well as in my JBS profile. My github profile, which is now linked to my OpenJDK account, uses a different email address "B". I control subscriptions on that "B" email address in a very controlled manner and don't use it much for my community work. In the implementation that you are working on, would it be possible for me to continue using my "A" email address which is linked to my OpenJDK account instead of the one on github? I would very much prefer that, if that's possible. -Jaikiran From robm at openjdk.java.net Fri Sep 25 14:29:05 2020 From: robm at openjdk.java.net (Rob McKenna) Date: Fri, 25 Sep 2020 14:29:05 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records Message-ID: This modification fixes the situation where a backport record may be a member of two distinct streams and has its hgupdate-sync label removed as a result. E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be applied to 15. The current logic gives precedence to the fact that it is the first release in the 15-updates stream and ignores the fact that it is not the first release in the feature stream. The label added by the feature stream is removed when evaluating the 15-updates stream. This should not be the case. ------------- Commit messages: - update-sync labels should be applied to all bar one record Changes: https://git.openjdk.java.net/skara/pull/848/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=848&range=00 Stats: 35 lines in 2 files changed: 27 ins; 1 del; 7 mod Patch: https://git.openjdk.java.net/skara/pull/848.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/848/head:pull/848 PR: https://git.openjdk.java.net/skara/pull/848 From ehelin at openjdk.java.net Fri Sep 25 14:31:56 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Fri, 25 Sep 2020 14:31:56 GMT Subject: RFR: pr: only warn about differing author names Message-ID: <598p0DNuIiL7h32ZSnoT_t-3GBg4tZCNdof_9N_YkZw=.125c43e0-560f-4ead-9b28-9056c31b88ce@github.com> Hi all, please review this patch that slightly updates the pull request full name checking to only write a warning instead of failing jcheck. This patch also provides clear instructions in the warning comment for how to create a new commit with the desired full name. Testing: - [x] Updated the existing unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - pr: only warn about differing author names Changes: https://git.openjdk.java.net/skara/pull/849/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=849&range=00 Stats: 89 lines in 8 files changed: 71 ins; 10 del; 8 mod Patch: https://git.openjdk.java.net/skara/pull/849.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/849/head:pull/849 PR: https://git.openjdk.java.net/skara/pull/849 From rwestberg at openjdk.java.net Fri Sep 25 15:00:00 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Fri, 25 Sep 2020 15:00:00 GMT Subject: RFR: pr: only warn about differing author names In-Reply-To: <598p0DNuIiL7h32ZSnoT_t-3GBg4tZCNdof_9N_YkZw=.125c43e0-560f-4ead-9b28-9056c31b88ce@github.com> References: <598p0DNuIiL7h32ZSnoT_t-3GBg4tZCNdof_9N_YkZw=.125c43e0-560f-4ead-9b28-9056c31b88ce@github.com> Message-ID: On Fri, 25 Sep 2020 14:29:07 GMT, Erik Helin wrote: > Hi all, > > please review this patch that slightly updates the pull request full name checking to only write a warning instead of > failing jcheck. This patch also provides clear instructions in the warning comment for how to create a new commit with > the desired full name. Testing: > - [x] Updated the existing unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/849 From robm at openjdk.java.net Fri Sep 25 15:38:09 2020 From: robm at openjdk.java.net (Rob McKenna) Date: Fri, 25 Sep 2020 15:38:09 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 14:26:18 GMT, Rob McKenna wrote: > This modification fixes the situation where a backport record may be a member > of two distinct streams and has its hgupdate-sync label removed as a result. > > E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be > applied to 15. The current logic gives precedence to the fact that it is the > first release in the 15-updates stream and ignores the fact that it is not > the first release in the feature stream. The label added by the feature stream > is removed when evaluating the 15-updates stream. This should not be the case. @kevinrushforth - it'd be great if you could take a look at this when you're able. ------------- PR: https://git.openjdk.java.net/skara/pull/848 From tim.bell at oracle.com Mon Sep 28 05:37:44 2020 From: tim.bell at oracle.com (Tim Bell) Date: Sun, 27 Sep 2020 22:37:44 -0700 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: <7633b584-13d1-9b4f-8c4f-d971f865c87d@gmail.com> References: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> <7633b584-13d1-9b4f-8c4f-d971f865c87d@gmail.com> Message-ID: Hello On 2020-09-25 06:21, Jaikiran Pai wrote: >> mapping of OpenJDK id strings to Github membership information.? In >> many cases it is not 1:1. >> > Not sure what the implementation will look like, so adding some input on > how I had configured my OpenJDK account pre-GitHub days. My OpenJDK > account (jpai) is configured with a email address "A" which I use for > subscribing to various OpenJDK mailing lists as well as in my JBS > profile. My github profile, which is now linked to my OpenJDK account, > uses a different email address "B". I control subscriptions on that "B" > email address in a very controlled manner and don't use it much for my > community work. In the implementation that you are working on, would it > be possible for me to continue using my "A" email address which is > linked to my OpenJDK account instead of the one on github? I would very > much prefer that, if that's possible. What I have in place is that email sent to jpai at openjdk.java.net From rwestberg at openjdk.java.net Mon Sep 28 06:42:34 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 06:42:34 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 14:26:18 GMT, Rob McKenna wrote: > This modification fixes the situation where a backport record may be a member > of two distinct streams and has its hgupdate-sync label removed as a result. > > E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be > applied to 15. The current logic gives precedence to the fact that it is the > first release in the 15-updates stream and ignores the fact that it is not > the first release in the feature stream. The label added by the feature stream > is removed when evaluating the 15-updates stream. This should not be the case. Looks good to me, thanks for fixing! Perhaps @kevinrushforth would like to take a look as well though. ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/848 From rwestberg at openjdk.java.net Mon Sep 28 06:54:43 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 06:54:43 GMT Subject: Integrated: Probe if Jira credentials are valid before making the actual API call In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 12:27:19 GMT, Robin Westberg wrote: > The expiration time calculation is unreliable, replace it with a probe. > > Best regards, > Robin This pull request has now been integrated. Changeset: 54a35f61 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/54a35f61 Stats: 43 lines in 5 files changed: 23 ins; 4 del; 16 mod Probe if Jira credentials are valid before making the actual API call Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/847 From rwestberg at openjdk.java.net Mon Sep 28 07:46:49 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 07:46:49 GMT Subject: RFR: 731: Do not include target hash in cached PR metadata Message-ID: Avoid using the target branch hash in check metadata calculation, as the pull request update cache will hide such updates anyway. Best regards, Robin ------------- Commit messages: - Drop target hash from metadata calculation Changes: https://git.openjdk.java.net/skara/pull/850/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=850&range=00 Issue: https://bugs.openjdk.java.net/browse/SKARA-731 Stats: 13 lines in 3 files changed: 3 ins; 4 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/850.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/850/head:pull/850 PR: https://git.openjdk.java.net/skara/pull/850 From ehelin at openjdk.java.net Mon Sep 28 09:55:43 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 28 Sep 2020 09:55:43 GMT Subject: Integrated: pr: only warn about differing author names In-Reply-To: <598p0DNuIiL7h32ZSnoT_t-3GBg4tZCNdof_9N_YkZw=.125c43e0-560f-4ead-9b28-9056c31b88ce@github.com> References: <598p0DNuIiL7h32ZSnoT_t-3GBg4tZCNdof_9N_YkZw=.125c43e0-560f-4ead-9b28-9056c31b88ce@github.com> Message-ID: On Fri, 25 Sep 2020 14:29:07 GMT, Erik Helin wrote: > Hi all, > > please review this patch that slightly updates the pull request full name checking to only write a warning instead of > failing jcheck. This patch also provides clear instructions in the warning comment for how to create a new commit with > the desired full name. Testing: > - [x] Updated the existing unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: caf67380 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/caf67380 Stats: 89 lines in 8 files changed: 71 ins; 10 del; 8 mod pr: only warn about differing author names Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/849 From ehelin at openjdk.java.net Mon Sep 28 09:56:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 28 Sep 2020 09:56:23 GMT Subject: RFR: 731: Do not include target hash in cached PR metadata In-Reply-To: References: Message-ID: On Mon, 28 Sep 2020 07:43:51 GMT, Robin Westberg wrote: > Avoid using the target branch hash in check metadata calculation, as the pull request update cache will hide such > updates anyway. > Best regards, > Robin Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/850 From rwestberg at openjdk.java.net Mon Sep 28 09:56:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 09:56:23 GMT Subject: Integrated: 731: Do not include target hash in cached PR metadata In-Reply-To: References: Message-ID: On Mon, 28 Sep 2020 07:43:51 GMT, Robin Westberg wrote: > Avoid using the target branch hash in check metadata calculation, as the pull request update cache will hide such > updates anyway. > Best regards, > Robin This pull request has now been integrated. Changeset: b74e831b Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/b74e831b Stats: 13 lines in 3 files changed: 3 ins; 4 del; 6 mod 731: Do not include target hash in cached PR metadata Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/850 From rwestberg at openjdk.java.net Mon Sep 28 12:33:28 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 12:33:28 GMT Subject: RFR: Parallelize checking if a test update is needed Message-ID: The current TestBot getPeriodItems implementation can starve the scheduler a bit during startup, ensure that it always returns quickly. ------------- Commit messages: - Parallelize checking if a test update is needed Changes: https://git.openjdk.java.net/skara/pull/851/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=851&range=00 Stats: 165 lines in 2 files changed: 106 ins; 53 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/851.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/851/head:pull/851 PR: https://git.openjdk.java.net/skara/pull/851 From ehelin at openjdk.java.net Mon Sep 28 15:21:25 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 28 Sep 2020 15:21:25 GMT Subject: RFR: Parallelize checking if a test update is needed In-Reply-To: References: Message-ID: <84kM0XsmcQJtzl25gliVKMsyfX6DLGqqQqoA_0SJCOs=.611d6c4e-1c6a-4ca6-a322-cb7c651ea5b7@github.com> On Mon, 28 Sep 2020 12:30:23 GMT, Robin Westberg wrote: > The current TestBot getPeriodItems implementation can starve the scheduler a bit during startup, ensure that it always > returns quickly. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/851 From ehelin at openjdk.java.net Mon Sep 28 15:23:22 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 28 Sep 2020 15:23:22 GMT Subject: RFR: vcs: allow capital letters in e-mails Message-ID: Hi all, please review this patch that allows e-mail addresses for the "Co-authored-by" lines to have capital letters for the name part. Testing: - [x] Added a unit test - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: allow capital letters in e-mails Changes: https://git.openjdk.java.net/skara/pull/852/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=852&range=00 Stats: 19 lines in 2 files changed: 18 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/852.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/852/head:pull/852 PR: https://git.openjdk.java.net/skara/pull/852 From rwestberg at openjdk.java.net Mon Sep 28 16:29:04 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 16:29:04 GMT Subject: RFR: vcs: allow capital letters in e-mails In-Reply-To: References: Message-ID: <68f_83tQmEUL8bng0t-fpGcVV7oPvyGNuSz81UdGHJA=.57c72172-1561-4847-b7a4-00af9556eebf@github.com> On Mon, 28 Sep 2020 15:20:41 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows e-mail addresses for the "Co-authored-by" lines to have capital letters for the > name part. > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/852 From rwestberg at openjdk.java.net Mon Sep 28 16:38:38 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 16:38:38 GMT Subject: Integrated: 740: Parallelize checking if a test update is needed In-Reply-To: References: Message-ID: On Mon, 28 Sep 2020 12:30:23 GMT, Robin Westberg wrote: > The current TestBot getPeriodItems implementation can starve the scheduler a bit during startup, ensure that it always > returns quickly. This pull request has now been integrated. Changeset: 652091b6 Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/652091b6 Stats: 165 lines in 2 files changed: 106 ins; 53 del; 6 mod 740: Parallelize checking if a test update is needed Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/851 From ehelin at openjdk.java.net Mon Sep 28 17:42:03 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Mon, 28 Sep 2020 17:42:03 GMT Subject: Integrated: vcs: allow capital letters in e-mails In-Reply-To: References: Message-ID: On Mon, 28 Sep 2020 15:20:41 GMT, Erik Helin wrote: > Hi all, > > please review this patch that allows e-mail addresses for the "Co-authored-by" lines to have capital letters for the > name part. > Testing: > - [x] Added a unit test > - [x] `make test` passes on Linux x64 > > Thanks, > Erik This pull request has now been integrated. Changeset: d8d42e8d Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/d8d42e8d Stats: 19 lines in 2 files changed: 18 ins; 0 del; 1 mod vcs: allow capital letters in e-mails Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/852 From rwestberg at openjdk.java.net Mon Sep 28 17:54:10 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Mon, 28 Sep 2020 17:54:10 GMT Subject: RFR: Fix the TestBot concurrency improvement Message-ID: The fix to make the test bot more concurrent requires this additional fix in order to not interfere with other scheduled tasks. ------------- Commit messages: - No concurrency improvements without this Changes: https://git.openjdk.java.net/skara/pull/853/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=853&range=00 Stats: 14 lines in 1 file changed: 13 ins; 0 del; 1 mod Patch: https://git.openjdk.java.net/skara/pull/853.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/853/head:pull/853 PR: https://git.openjdk.java.net/skara/pull/853 From kcr at openjdk.java.net Mon Sep 28 23:26:43 2020 From: kcr at openjdk.java.net (Kevin Rushforth) Date: Mon, 28 Sep 2020 23:26:43 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 14:26:18 GMT, Rob McKenna wrote: > This modification fixes the situation where a backport record may be a member > of two distinct streams and has its hgupdate-sync label removed as a result. > > E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be > applied to 15. The current logic gives precedence to the fact that it is the > first release in the 15-updates stream and ignores the fact that it is not > the first release in the feature stream. The label added by the feature stream > is removed when evaluating the 15-updates stream. This should not be the case. The fix looks good to me. One question about the test: is the `assertNotLabeled` method really needed? It looks like `assertLabeled` will fail unless the set of issues with the labels is exactly as expected (i.e., it will fail if it finds an issue that should have the sync label but doesn't or if if find an issue that should not have the sync label but does), unless I'm missing something. ------------- Marked as reviewed by kcr (no project role). PR: https://git.openjdk.java.net/skara/pull/848 From jai.forums2013 at gmail.com Tue Sep 29 02:21:31 2020 From: jai.forums2013 at gmail.com (Jaikiran Pai) Date: Tue, 29 Sep 2020 07:51:31 +0530 Subject: Invalid @openjdk.java.net mail addresses In-Reply-To: References: <4b96b8eb-bd93-efc8-f2f3-efb2c3624b35@oracle.com> <7633b584-13d1-9b4f-8c4f-d971f865c87d@gmail.com> Message-ID: <6d518dc7-fc39-9040-ce34-2962b8b8dcb4@gmail.com> Hello Tim, On 28/09/20 11:07 am, Tim Bell wrote: > Hello > > On 2020-09-25 06:21, Jaikiran Pai wrote: > >>> mapping of OpenJDK id strings to Github membership information.? In >>> many cases it is not 1:1. >>> >> Not sure what the implementation will look like, so adding some input on >> how I had configured my OpenJDK account pre-GitHub days. My OpenJDK >> account (jpai) is configured with a email address "A" which I use for >> subscribing to various OpenJDK mailing lists as well as in my JBS >> profile. My github profile, which is now linked to my OpenJDK account, >> uses a different email address "B". I control subscriptions on that "B" >> email address in a very controlled manner and don't use it much for my >> community work. In the implementation that you are working on, would it >> be possible for me to continue using my "A" email address which is >> linked to my OpenJDK account instead of the one on github? I would very >> much prefer that, if that's possible. > > What I have in place is that email sent to jpai at openjdk.java.net Your comment on https://bugs.openjdk.java.net/browse/SKARA-645 which says: "email sent to at openjdk.java.net will be forwarded on to the email address registered for that user in the OpenJDK census." addresses my questions. Thank you for doing this. -Jaikiran From ehelin at openjdk.java.net Tue Sep 29 07:59:23 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 29 Sep 2020 07:59:23 GMT Subject: RFR: Fix the TestBot concurrency improvement In-Reply-To: References: Message-ID: On Mon, 28 Sep 2020 17:51:11 GMT, Robin Westberg wrote: > The fix to make the test bot more concurrent requires this additional fix in order to not interfere with other > scheduled tasks. Looks good! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/853 From rwestberg at openjdk.java.net Tue Sep 29 07:59:23 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 29 Sep 2020 07:59:23 GMT Subject: Integrated: Fix the TestBot concurrency improvement In-Reply-To: References: Message-ID: <9Db3GbFNtH0tI1jGR7i_IVFSoCzooxioN2UM8NkvIxk=.97a3e3b5-a9b2-4eac-bc9f-74eff3910819@github.com> On Mon, 28 Sep 2020 17:51:11 GMT, Robin Westberg wrote: > The fix to make the test bot more concurrent requires this additional fix in order to not interfere with other > scheduled tasks. This pull request has now been integrated. Changeset: 606b40cd Author: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/606b40cd Stats: 14 lines in 1 file changed: 13 ins; 0 del; 1 mod Fix the TestBot concurrency improvement Reviewed-by: ehelin ------------- PR: https://git.openjdk.java.net/skara/pull/853 From erik.helin at oracle.com Tue Sep 29 12:24:20 2020 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 29 Sep 2020 14:24:20 +0200 Subject: /test does not seem to do anything In-Reply-To: References: Message-ID: <4a41d20a-8789-423a-cfa0-542c27de8bdb@oracle.com> On 9/25/20 12:46 PM, Thomas St?fe wrote: > Hi all, > > I posted two PRs in the last days: > > https://github.com/openjdk/jdk/pull/332 > https://github.com/openjdk/jdk/pull/336 > > In both cases I requested tests using the /test PR command. I tried: > "/test" (no args) > "/test tier1" > > and on the JEP387 one I tried, rather optimistically > > "/test tier1, tier2, tier3, tier4, tier5, tier6, tier7, tier8" > > Both PRs got the "test-request" tag but as far as I can observe no tests > did run. > > Did I do something wrong? Or is this feature not yet active, or not > active for outside contributors? No, please see my post on jdk-dev [0]. We are working on bringing the /test pull request command back online. In the meantime feel free to try out the new GitHub Actions support! Thanks, Erik [0]: https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004702.html > Thanks, Thomas > From erik.helin at oracle.com Tue Sep 29 12:27:54 2020 From: erik.helin at oracle.com (Erik Helin) Date: Tue, 29 Sep 2020 14:27:54 +0200 Subject: Some questions about PR commands In-Reply-To: References: Message-ID: <57d7719c-95e1-6082-b4d2-116320df87d0@oracle.com> On 9/24/20 9:36 AM, Thomas St?fe wrote: > Hi all, > > I have some questions about PR commands (I read > https://wiki.openjdk.java.net/display/SKARA/Pull+Request+Commands which I > believe is the correct documentation). > > - Can I invite specific reviewers? Since often a PR is the result of > preliminary discussions, where before I would have cc'ed someone specific > for the initial RFR mail. No, we have an enhancement filed: https://bugs.openjdk.java.net/browse/SKARA-609 > - /test - is the test argument optional (square brackets seem to indicate > that). If yes, what tests are executed by default? Yes, by default tier1 is executed. > - /label and /issue - are "add" and "remove" optional (square brackets seem > to indicate that but examples don't). Is add the default? Yes. > - Can I stack multiple commands? If yes, can they appear anywhere in a PR > comment? Also in the PR body? What happens if I specify the same command > multiple times, does the last win or do they accumulate? Yes to all, the last command "wins". Only restriction is that you can't mix pull request commands and regular text in a comment and that the pull request commands must be last in the PR body. > - Draft PR: which commands, if any, work in for draft PR? In particular, > does /test work? All commands work for draft PRs. > - Finally, I see long running PRs use the "[Vx]" suffix in their PR names. > Are these manually created or is there some tool support I missed for long > running PRs? The [Vx] suffix is added to the RFR e-mails whenever a pull request has been updated. Think of it as sending out a new webrev "revision", e.g. "please see webrev.02". Thanks, Erik > Thank you! > > Thomas > From robm at openjdk.java.net Tue Sep 29 12:41:03 2020 From: robm at openjdk.java.net (Rob McKenna) Date: Tue, 29 Sep 2020 12:41:03 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records In-Reply-To: References: Message-ID: <1gNLWCIpWFOfsK1V3bihTx0ye0iWhYxS-UmauEN0GV4=.fc6e56df-f8c2-41c5-99d6-679297cc9df6@github.com> On Mon, 28 Sep 2020 23:24:32 GMT, Kevin Rushforth wrote: >> This modification fixes the situation where a backport record may be a member >> of two distinct streams and has its hgupdate-sync label removed as a result. >> >> E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be >> applied to 15. The current logic gives precedence to the fact that it is the >> first release in the 15-updates stream and ignores the fact that it is not >> the first release in the feature stream. The label added by the feature stream >> is removed when evaluating the 15-updates stream. This should not be the case. > > The fix looks good to me. One question about the test: is the `assertNotLabeled` method really needed? It looks like > `assertLabeled` will fail unless the set of issues with the labels is exactly as expected (i.e., it will fail if it > finds an issue that should have the sync label but doesn't or if if find an issue that should not have the sync label > but does), unless I'm missing something. I think I like the lack of ambiguity in the name. I vote to leave it in, but if Robin objects I can remove it. ------------- PR: https://git.openjdk.java.net/skara/pull/848 From ehelin at openjdk.java.net Tue Sep 29 12:41:11 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 29 Sep 2020 12:41:11 GMT Subject: RFR: forge: add search method Message-ID: Hi all, please review this patch that adds the `Forge.search` method to allow searching for a commit with a particular hash on a forge. Thanks, Erik ------------- Commit messages: - forge: add search method Changes: https://git.openjdk.java.net/skara/pull/854/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=854&range=00 Stats: 290 lines in 13 files changed: 248 ins; 25 del; 17 mod Patch: https://git.openjdk.java.net/skara/pull/854.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/854/head:pull/854 PR: https://git.openjdk.java.net/skara/pull/854 From rwestberg at openjdk.java.net Tue Sep 29 12:46:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 29 Sep 2020 12:46:06 GMT Subject: RFR: forge: add search method In-Reply-To: References: Message-ID: On Tue, 29 Sep 2020 12:32:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `Forge.search` method to allow searching for a commit with a particular hash on > a forge. > Thanks, > Erik Looks good, a bit worried that auto-pagination of thousands of commits will take a while though.. :) forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java line 246: > 244: .collect(Collectors.toList()); > 245: for (var project : projects) { > 246: var c = request.get("projects/" + project + "/repository/commits/" + hex) Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit ------------- PR: https://git.openjdk.java.net/skara/pull/854 From ehelin at openjdk.java.net Tue Sep 29 14:16:49 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Tue, 29 Sep 2020 14:16:49 GMT Subject: RFR: forge: add search method In-Reply-To: References: Message-ID: On Tue, 29 Sep 2020 12:44:02 GMT, Robin Westberg wrote: > Looks good, a bit worried that auto-pagination of thousands of commits will take a while though.. :) Since we are limiting the GitHub search to selected organizations, we should for the https://github.com/openjdk organization get at most `O(#repos)` results (a commit can exist at most once in a repo). > forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java line 246: > >> 244: .collect(Collectors.toList()); >> 245: for (var project : projects) { >> 246: var c = request.get("projects/" + project + "/repository/commits/" + hex) > > Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit That is the endpoint the code is using ?? Did you perhaps miss the `+ hex` part? ------------- PR: https://git.openjdk.java.net/skara/pull/854 From thomas.stuefe at gmail.com Tue Sep 29 15:03:18 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Tue, 29 Sep 2020 17:03:18 +0200 Subject: /test does not seem to do anything In-Reply-To: <4a41d20a-8789-423a-cfa0-542c27de8bdb@oracle.com> References: <4a41d20a-8789-423a-cfa0-542c27de8bdb@oracle.com> Message-ID: Thanks a lot Erik for this (and your other) mail. And for your great work on Skara. I feel we are slowly getting there :) Cheers, Thomas On Tue, Sep 29, 2020 at 2:31 PM Erik Helin wrote: > On 9/25/20 12:46 PM, Thomas St?fe wrote: > > Hi all, > > > > I posted two PRs in the last days: > > > > https://github.com/openjdk/jdk/pull/332 > > https://github.com/openjdk/jdk/pull/336 > > > > In both cases I requested tests using the /test PR command. I tried: > > "/test" (no args) > > "/test tier1" > > > > and on the JEP387 one I tried, rather optimistically > > > > "/test tier1, tier2, tier3, tier4, tier5, tier6, tier7, tier8" > > > > Both PRs got the "test-request" tag but as far as I can observe no tests > > did run. > > > > Did I do something wrong? Or is this feature not yet active, or not > > active for outside contributors? > > No, please see my post on jdk-dev [0]. We are working on bringing the > /test pull request command back online. In the meantime feel free to try > out the new GitHub Actions support! > > Thanks, > Erik > > [0]: > https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004702.html > > > Thanks, Thomas > > > From rwestberg at openjdk.java.net Tue Sep 29 15:38:08 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 29 Sep 2020 15:38:08 GMT Subject: RFR: forge: add search method In-Reply-To: References: Message-ID: On Tue, 29 Sep 2020 12:32:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `Forge.search` method to allow searching for a commit with a particular hash on > a forge. > Thanks, > Erik Marked as reviewed by rwestberg (Reviewer). ------------- PR: https://git.openjdk.java.net/skara/pull/854 From rwestberg at openjdk.java.net Tue Sep 29 15:38:09 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Tue, 29 Sep 2020 15:38:09 GMT Subject: RFR: forge: add search method In-Reply-To: References: Message-ID: On Tue, 29 Sep 2020 14:12:29 GMT, Erik Helin wrote: >> forge/src/main/java/org/openjdk/skara/forge/gitlab/GitLabHost.java line 246: >> >>> 244: .collect(Collectors.toList()); >>> 245: for (var project : projects) { >>> 246: var c = request.get("projects/" + project + "/repository/commits/" + hex) >> >> Could we use this endpoint instead? https://docs.gitlab.com/ce/api/commits.html#get-a-single-commit > > That is the endpoint the code is using ?? Did you perhaps miss the `+ hex` part? Well then, carry on! ------------- PR: https://git.openjdk.java.net/skara/pull/854 From thomas.stuefe at gmail.com Wed Sep 30 08:31:59 2020 From: thomas.stuefe at gmail.com (=?UTF-8?Q?Thomas_St=C3=BCfe?=) Date: Wed, 30 Sep 2020 10:31:59 +0200 Subject: /test does not seem to do anything In-Reply-To: References: <4a41d20a-8789-423a-cfa0-542c27de8bdb@oracle.com> Message-ID: oh.. I see this just works now, without me having to do anything. Nice. :) ..Thomas On Tue, Sep 29, 2020 at 5:03 PM Thomas St?fe wrote: > Thanks a lot Erik for this (and your other) mail. And for your great work > on Skara. I feel we are slowly getting there :) > > Cheers, Thomas > > On Tue, Sep 29, 2020 at 2:31 PM Erik Helin wrote: > >> On 9/25/20 12:46 PM, Thomas St?fe wrote: >> > Hi all, >> > >> > I posted two PRs in the last days: >> > >> > https://github.com/openjdk/jdk/pull/332 >> > https://github.com/openjdk/jdk/pull/336 >> > >> > In both cases I requested tests using the /test PR command. I tried: >> > "/test" (no args) >> > "/test tier1" >> > >> > and on the JEP387 one I tried, rather optimistically >> > >> > "/test tier1, tier2, tier3, tier4, tier5, tier6, tier7, tier8" >> > >> > Both PRs got the "test-request" tag but as far as I can observe no tests >> > did run. >> > >> > Did I do something wrong? Or is this feature not yet active, or not >> > active for outside contributors? >> >> No, please see my post on jdk-dev [0]. We are working on bringing the >> /test pull request command back online. In the meantime feel free to try >> out the new GitHub Actions support! >> >> Thanks, >> Erik >> >> [0]: >> https://mail.openjdk.java.net/pipermail/jdk-dev/2020-September/004702.html >> >> > Thanks, Thomas >> > >> > From rwestberg at openjdk.java.net Wed Sep 30 10:51:16 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 30 Sep 2020 10:51:16 GMT Subject: RFR: Show a summary of pre-submit testing results in the PR body (if any) Message-ID: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> Now that we are executing pre-submit tests for certain OpenJDK repositories, we can also display a summary of the results in the PR body, to help reviewers determine the test status of a change. ------------- Commit messages: - Initial implementation Changes: https://git.openjdk.java.net/skara/pull/855/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=855&range=00 Stats: 202 lines in 11 files changed: 196 ins; 1 del; 5 mod Patch: https://git.openjdk.java.net/skara/pull/855.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/855/head:pull/855 PR: https://git.openjdk.java.net/skara/pull/855 From rwestberg at openjdk.java.net Wed Sep 30 10:53:06 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 30 Sep 2020 10:53:06 GMT Subject: RFR: update-sync labels should be applied to all-bar-one records In-Reply-To: <1gNLWCIpWFOfsK1V3bihTx0ye0iWhYxS-UmauEN0GV4=.fc6e56df-f8c2-41c5-99d6-679297cc9df6@github.com> References: <1gNLWCIpWFOfsK1V3bihTx0ye0iWhYxS-UmauEN0GV4=.fc6e56df-f8c2-41c5-99d6-679297cc9df6@github.com> Message-ID: On Tue, 29 Sep 2020 12:39:00 GMT, Rob McKenna wrote: >> The fix looks good to me. One question about the test: is the `assertNotLabeled` method really needed? It looks like >> `assertLabeled` will fail unless the set of issues with the labels is exactly as expected (i.e., it will fail if it >> finds an issue that should have the sync label but doesn't or if if find an issue that should not have the sync label >> but does), unless I'm missing something. > > I think I like the lack of ambiguity in the name. I vote to leave it in, but if Robin objects I can remove it. I don't mind keeping it if you think it makes the test more readable! ------------- PR: https://git.openjdk.java.net/skara/pull/848 From robm at openjdk.java.net Wed Sep 30 10:53:06 2020 From: robm at openjdk.java.net (Rob McKenna) Date: Wed, 30 Sep 2020 10:53:06 GMT Subject: Integrated: update-sync labels should be applied to all-bar-one records In-Reply-To: References: Message-ID: On Fri, 25 Sep 2020 14:26:18 GMT, Rob McKenna wrote: > This modification fixes the situation where a backport record may be a member > of two distinct streams and has its hgupdate-sync label removed as a result. > > E.g. with backport records for 14, 15, 14.0.1, 15.0.1 no label would be > applied to 15. The current logic gives precedence to the fact that it is the > first release in the 15-updates stream and ignores the fact that it is not > the first release in the feature stream. The label added by the feature stream > is removed when evaluating the 15-updates stream. This should not be the case. This pull request has now been integrated. Changeset: f023a346 Author: Rob McKenna Committer: Robin Westberg URL: https://git.openjdk.java.net/skara/commit/f023a346 Stats: 35 lines in 2 files changed: 27 ins; 1 del; 7 mod update-sync labels should be applied to all-bar-one records Reviewed-by: rwestberg, kcr ------------- PR: https://git.openjdk.java.net/skara/pull/848 From ehelin at openjdk.java.net Wed Sep 30 12:07:17 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 30 Sep 2020 12:07:17 GMT Subject: RFR: Show a summary of pre-submit testing results in the PR body (if any) In-Reply-To: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> References: <9sJdqPsKZssNHzuulVOkCupUPBQmfJ64v3igeXWsV8E=.4f5e4122-93ec-430c-a4d3-c6182842019e@github.com> Message-ID: On Wed, 30 Sep 2020 10:48:21 GMT, Robin Westberg wrote: > Now that we are executing pre-submit tests for certain OpenJDK repositories, we can also display a summary of the > results in the PR body, to help reviewers determine the test status of a change. Wow, very nice! ------------- Marked as reviewed by ehelin (Reviewer). PR: https://git.openjdk.java.net/skara/pull/855 From ehelin at openjdk.java.net Wed Sep 30 12:09:35 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 30 Sep 2020 12:09:35 GMT Subject: Integrated: forge: add search method In-Reply-To: References: Message-ID: On Tue, 29 Sep 2020 12:32:27 GMT, Erik Helin wrote: > Hi all, > > please review this patch that adds the `Forge.search` method to allow searching for a commit with a particular hash on > a forge. > Thanks, > Erik This pull request has now been integrated. Changeset: 10f3a1f0 Author: Erik Helin URL: https://git.openjdk.java.net/skara/commit/10f3a1f0 Stats: 290 lines in 13 files changed: 248 ins; 25 del; 17 mod forge: add search method Reviewed-by: rwestberg ------------- PR: https://git.openjdk.java.net/skara/pull/854 From ehelin at openjdk.java.net Wed Sep 30 13:48:12 2020 From: ehelin at openjdk.java.net (Erik Helin) Date: Wed, 30 Sep 2020 13:48:12 GMT Subject: RFR: vcs: introduce "Backport-of" trailer Message-ID: <7UyqIrSeV2v0IvjdAnxgcpvaBCxFpmIC7vSz9Ruhq2s=.4f115732-0f7a-41e3-85b7-a8cb35687b54@github.com> Hi all, please review this pull request that adds support for the "Backport-of" trailer to commit messages. Testing: - [x] Added three new unit tests - [x] `make test` passes on Linux x64 Thanks, Erik ------------- Commit messages: - vcs: introduce "Backport-of" trailer Changes: https://git.openjdk.java.net/skara/pull/856/files Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=856&range=00 Stats: 91 lines in 8 files changed: 85 ins; 0 del; 6 mod Patch: https://git.openjdk.java.net/skara/pull/856.diff Fetch: git fetch https://git.openjdk.java.net/skara pull/856/head:pull/856 PR: https://git.openjdk.java.net/skara/pull/856 From rwestberg at openjdk.java.net Wed Sep 30 13:50:25 2020 From: rwestberg at openjdk.java.net (Robin Westberg) Date: Wed, 30 Sep 2020 13:50:25 GMT Subject: RFR: vcs: introduce "Backport-of" trailer In-Reply-To: <7UyqIrSeV2v0IvjdAnxgcpvaBCxFpmIC7vSz9Ruhq2s=.4f115732-0f7a-41e3-85b7-a8cb35687b54@github.com> References: <7UyqIrSeV2v0IvjdAnxgcpvaBCxFpmIC7vSz9Ruhq2s=.4f115732-0f7a-41e3-85b7-a8cb35687b54@github.com> Message-ID: <41g0tUBOsU2lwReloKOWpM8NBT5teqgSoWt4VLlNd7w=.94795578-63d8-41de-8771-03dff7326ddd@github.com> On Wed, 30 Sep 2020 13:45:34 GMT, Erik Helin wrote: > Hi all, > > please review this pull request that adds support for the "Backport-of" trailer to commit messages. > > Testing: > - [x] Added three new unit tests > - [x] `make test` passes on Linux x64 > > Thanks, > Erik Looks good! ------------- Marked as reviewed by rwestberg (Reviewer). PR: https://git.openjdk.java.net/skara/pull/856