Missing metadata removal in jdk commit

Kevin Rushforth kevin.rushforth at oracle.com
Tue Sep 15 18:04:06 UTC 2020


This looks like a bug in Skara when parsing the "/summary" commands from 
the Description. Perhaps "/summary" should be limited to a single line 
when part of the Description, or else disallowed entirely in the 
Description and only be parsed in comments?

-- Kevin


On 9/15/2020 10:44 AM, Florian Weimer wrote:
> I see this in the commit history:
>
> commit 7eb4d4aa018e37052cbf37cd854380006c309645
> Author: Kim Barrett <kbarrett at openjdk.org>
> Date:   Tue Sep 15 10:52:50 2020 +0000
>
>      8247909: Improve PrimitiveConversions::cast using C++14
>      
>      Reimpliment PrimitiveConversions::cast, with some cases now constexpr.
>      <!-- Anything below this marker will be automatically updated, please do not edit manually! -->
>      ---------
>      ### Progress
>      - [x] Change must not contain extraneous whitespace
>      - [x] Commit message must refer to an issue
>      - [ ] Change must be properly reviewed
>      
>      ### Issue
>      * [JDK-8247909](https://bugs.openjdk.java.net/browse/JDK-8247909): Improve PrimitiveConversions::cast using C++14
>      
>      
>      ### Download
>      `$ git fetch https://git.openjdk.java.net/jdk pull/143/head:pull/143`
>      `$ git checkout pull/143`
>      
>      Reviewed-by: dholmes, stefank
>
> I don't think it makes sense to preserve this information in the Git
> history, and the SGML comment suggests that it's expected to be
> stripped.



More information about the skara-dev mailing list