RFR: 963: Skara mlbridge bot sometimes resends old messages [v3]
Robin Westberg
rwestberg at openjdk.java.net
Wed Apr 14 13:46:52 UTC 2021
On Wed, 14 Apr 2021 12:55:54 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Robin Westberg has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into mlbridge_archive_parse
>> - Do not try to parse sent mails as a conversation as we just want the ID's
>> - Fix build error after merge
>> - Merge remote-tracking branch 'upstream/master' into mbox_crosspost
>> - Rename MailingList -> MailingListReader
>> - Fix configuration parsing
>> - Add support for treating a set of mboxes as a single source of conversations
>> - Improve mbox parsing
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/ArchiveWorkItem.java line 251:
>
>> 249: var archiveContents = Files.readString(mboxBasePath.resolve(pr.id() + ".mbox"), StandardCharsets.UTF_8);
>> 250: sentMails.addAll(Mbox.splitMbox(archiveContents, bot.emailAddress()));
>> 251: } catch (IOException ignored) {
>
> Shouldn't we at least log this?
This will happen every time a new PR is processed (since there won't be any archive) - I can't think of any actual error that could cause a problem here (problems with the folder contents should have been discovered when cloning it from git)
-------------
PR: https://git.openjdk.java.net/skara/pull/1117
More information about the skara-dev
mailing list