RFR: 934: Bots incorrectly assigned "build" label despite no obvious matching rule

[Robin Westberg]

On Wed, 14 Apr 2021 15:24:22 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

> When determining the set of file names to evaluate for determining label assignment, only include the source name for deletions and renames (and not for copies, for example).

Yes, that was indeed the case! Perhaps I should mention that it was actually @edvbld who figured it out.. :) So the diff we looked at was (dropped a few similar entries):


> git diff 15bcf6d9 0bce6a53 --find-renames=90% --find-copies=90% --find-copies-harder --name-status
M       src/jdk.jpackage/linux/classes/jdk/jpackage/internal/LinuxAppImageBuilder.java
R100    src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/java32.png       src/jdk.jpackage/linux/classes/jdk/jpackage/internal/resources/JavaApp.png
M       src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/MacAppBundler.javarces_ja.properties
M       src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/MacResources_zh_CN.properties
A       src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/product-def.plist
C091    make/data/macosxsigning/java.plist      src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/resources/sandbox.plist
M       src/jdk.jpackage/share/classes/jdk/jpackage/internal/Arguments.java
M       src/jdk.jpackage/windows/classes/jdk/jpackage/internal/WindowsAppImageBuilder.java
R100    src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/java48.ico     src/jdk.jpackage/windows/classes/jdk/jpackage/internal/resources/JavaApp.ico
M       test/jdk/tools/jpackage/helpers/jdk/jpackage/test/LauncherIconVerifier.java


So there was indeed a "copy" that seemed to come from the make folder..

-------------

PR: https://git.openjdk.java.net/skara/pull/1118