RFR: 983: Github commit links 404
rwestberg at openjdk.java.net
Fri Apr 23 07:19:36 UTC 2021
On Thu, 22 Apr 2021 22:38:29 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> Sometimes our abbreviated commit web links on Github are not working. My guess is that this is caused by collisions. I think the correct fix here is to stop abbreviating commit hashes in links. Github internal links seem to always be full hashes, while pretty printing the link text with an abbreviation. We should adopt the same basic principle.
Looks good! Perhaps you have run the tests locally, but couldn't hurt to enable the GitHub Actions to make sure there isn't some odd dependency on the short format left somewhere. :)
Marked as reviewed by rwestberg (Reviewer).
More information about the skara-dev