[cr] RFR: 988: Skara webrev is empty if patch has deleted files [v2]
erikj at openjdk.java.net
Fri Apr 23 20:17:30 UTC 2021
> If a file in the patch has been deleted this causes a dereference of an undefined value. To fix this I removed the quick return in fetchFileContent so that this function always returns a value.
> While verifying this, I also noted that the deleted file gets a Raw link which results in a 404. I think it should just not print the Raw link so I removed that too.
> If a file has only been renamed, with no other changes, the patch will be an empty string. This upsets the hunk loop, so I added a case for handling this.
> The resulting webrevs from the two reported patches look correct to me with these changes, but I would appreciate some more eyes on this.
Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
Adjusted for review comments
- all: https://git.openjdk.java.net/cr/pull/14/files
- new: https://git.openjdk.java.net/cr/pull/14/files/239d79c2..8eaa628d
- full: https://webrevs.openjdk.java.net/?repo=cr&pr=14&range=01
- incr: https://webrevs.openjdk.java.net/?repo=cr&pr=14&range=00-01
Stats: 4 lines in 1 file changed: 3 ins; 0 del; 1 mod
Fetch: git fetch https://git.openjdk.java.net/cr pull/14/head:pull/14
More information about the skara-dev