RFR: 983: Github commit links 404 [v2]

Erik Joelsson erikj at openjdk.java.net
Fri Apr 23 22:04:54 UTC 2021


> Sometimes our abbreviated commit web links on Github are not working. My guess is that this is caused by collisions. I think the correct fix here is to stop abbreviating commit hashes in links. Github internal links seem to always be full hashes, while pretty printing the link text with an abbreviation. We should adopt the same basic principle.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Add test

-------------

Changes:
  - all: https://git.openjdk.java.net/skara/pull/1136/files
  - new: https://git.openjdk.java.net/skara/pull/1136/files/43049974..52e7b972

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1136&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1136&range=00-01

  Stats: 72 lines in 1 file changed: 60 ins; 0 del; 12 mod
  Patch: https://git.openjdk.java.net/skara/pull/1136.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1136/head:pull/1136

PR: https://git.openjdk.java.net/skara/pull/1136


More information about the skara-dev mailing list