[skara] RFR: 574: git-info should use info from commit notifications [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Mon Feb 15 12:28:55 UTC 2021

> git-info should use info from commit notifications to get the link to the review, not JBS (since not all PR have issues)
> This required refactoring to move the hosted repo logic from cli/pr/Utils.java to where it can be accessed by all CLI tools. After some deliberating, I left a bunch of trivial wrappers in cli/pr/Utils.java -- otherwise this change would have touched *all* the files in cli/pr.
> Testing: ad hoc testing of "git info" on some arbitrary Skara commits.

Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:

  * Don't depend on bot name when looking for review comment
  * Fix crash in "git info" for projects where .jcheck/conf was missing the "jbs" key


  - all: https://git.openjdk.java.net/skara/pull/1011/files
  - new: https://git.openjdk.java.net/skara/pull/1011/files/0c0df134..d23292da

 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1011&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1011&range=00-01

  Stats: 25 lines in 1 file changed: 10 ins; 3 del; 12 mod
  Patch: https://git.openjdk.java.net/skara/pull/1011.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1011/head:pull/1011

PR: https://git.openjdk.java.net/skara/pull/1011

More information about the skara-dev mailing list