[skara] RFR: forge: improve GitLabRepository::commitWithComment

Robin Westberg rwestberg at openjdk.java.net
Tue Feb 16 13:25:07 UTC 2021

On Tue, 16 Feb 2021 13:18:57 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this patch that improves the method `GitLabRepository::commitWithComment`. The problem is that GitLab's search API isn't really up to par (cannot handle square brackets in search query) and the search API is also going in away from GitLab CE in 13.9. This patch implements a simple search, just iterating backwards over the most recent commits, searching for the given title. The results are cached in-memory to speed up future searches.
> Testing:
> - [x] Manual testing on Linux x64 using `git-skara debug commit-comments`
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1020

More information about the skara-dev mailing list