RFR: Initial version of census upgrade bot [v2]

Erik Helin ehelin at openjdk.java.net
Wed Feb 17 09:36:45 UTC 2021


On Tue, 16 Feb 2021 16:50:30 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:

>> Allows automated conversion of census.xml to the Skara format.
>
> Robin Westberg has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Avoid duplicating the XML class already present in the Census module

Looks good, but may I suggest renaming `CensusSyncDowngradeBot.java` to `CensusSyncUnifyBot.java` and `CensusSyncUpgradeBot.java` to `CensusSyncSplitBot.java`? Makes it a bit more clear what the bots are doing ��

xml/build.gradle line 30:

> 28: publishing {
> 29:     publications {
> 30:         webrev(MavenPublication) {

Suggestion:

        xml(MavenPublication) {

-------------

PR: https://git.openjdk.java.net/skara/pull/1019


More information about the skara-dev mailing list