Integrated: pr: fetch commit comments in work item

Erik Helin ehelin at openjdk.java.net
Tue Feb 23 14:15:00 UTC 2021


On Tue, 23 Feb 2021 13:59:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this patch that fetches recent commit comments in a separate `WorkItem` for the `PullRequestBot`. This is to ensure that:
> 
> - possible exceptions thrown when fetching recent commit comments do not impact other `WorkItem`s generated by `PullRequestBot.getPeriodicItems`
> - other `WorkItem`s can continue to make progress if the call to `recentCommitComments` takes a long time
> 
> Testing:
> - [x] `make test` passes on Linux x64
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 874a89ce
Author:    Erik Helin <ehelin at openjdk.org>
URL:       https://git.openjdk.java.net/skara/commit/874a89ce
Stats:     88 lines in 3 files changed: 67 ins; 17 del; 4 mod

pr: fetch commit comments in work item

Reviewed-by: rwestberg

-------------

PR: https://git.openjdk.java.net/skara/pull/1031


More information about the skara-dev mailing list