RFR: 867: Your git version is: 2.30.0.284...., which is not a known ...

Martin Buchholz martin at openjdk.java.net
Fri Jan 15 18:41:07 UTC 2021


On Fri, 15 Jan 2021 13:21:31 GMT, Jorn Vernee <jvernee at openjdk.org> wrote:

>> 867: Your git version is: 2.30.0.284...., which is not a known ...
>
> LGTM.
> 
> If you don't mind, please also add this version string as a test case to GitVersionTest: https://github.com/openjdk/skara/blob/master/vcs/src/test/java/org/openjdk/skara/vcs/git/GitVersionTest.java#L46

@JornVernee. I made an effort to add some tests.  Blind change below.

I tried and failed to run the test.  Installing junit5 made no difference.
README.md wants junit5 5.6.2 but my reasonably up-to-date system has an older version.
I tried `sh gradlew reproduce` but it wants docker installed, and I'm reluctant to do that.
`make test` produces no output to explain why it apparently didn't even try to compile GitVersionTest.

diff --git a/vcs/src/test/java/org/openjdk/skara/vcs/git/GitVersionTest.java b/vcs/src/test/java/org/openjdk/skara/vcs/git/GitVersionTest.java
index 8d9f7a58..92755fbd 100644
--- a/vcs/src/test/java/org/openjdk/skara/vcs/git/GitVersionTest.java
+++ b/vcs/src/test/java/org/openjdk/skara/vcs/git/GitVersionTest.java
@@ -43,7 +43,10 @@ public class GitVersionTest {
             arguments("git version 2.25.3", 2, 25, 3),
             arguments("git version 2.26.1", 2, 26, 1),
 
-            arguments("git version 2.27.0.windows.1", 2, 27, 0)
+            arguments("git version 2.27.0.windows.1", 2, 27, 0),
+
+            arguments("git version 2.30.0.284", 2, 30, 0),
+            arguments("git version 2.30.0.284.cafebabe-yoyodyne", 2, 30, 0)
         );
     }

-------------

PR: https://git.openjdk.java.net/skara/pull/984


More information about the skara-dev mailing list