Integrated: 80: Allow valid bug ID format to be configurable

[Robin Westberg]

On Wed, 25 Sep 2019 13:50:11 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> JBS issue: https://bugs.openjdk.java.net/browse/SKARA-80
> 
> This provides a configuration option to define the pattern for a valid issue ID as follows. This starts with the idea @edvbld mentioned in PR #99, although I felt it was cleaner to leave the default issue format as is, and use the more restrictive pattern for the "legacy" jdk conf file.
> 
> The syntax of the new pattern is:
> 
> [checks "issues"]
> pattern=<PATTERN_STRING>
> 
> The default pattern is:
> 
> [checks "issues"]
> pattern=^(([A-Z][A-Z0-9]+-)?[0-9]+): (\S.*)$
> 
> For legacy JDK `.jcheck/conf` files, the pattern is as follows to match the issue ID rules in `jcheck.py`:
> 
> [checks "issues"]
> pattern=^([124-8][0-9]{6}): (\S.*)$

Looks good, thanks for fixing this! Noticed a pre-existing typo, could perhaps fix that while we're at it..

jcheck/src/main/java/org/openjdk/skara/jcheck/IssuesCheck.java line 48:

> 46:         var metadata = CommitIssue.metadata(commit, message, conf, this);
> 47:         if (commit.message().isEmpty() || message.issues().isEmpty()) {
> 48:             log.finer("isuse: no reference to a JBS issue");

Suggestion:

            log.finer("issue: no reference to a JBS issue");

-------------

Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/163