RFR: 1026: Skara bot doesn't update Progress checklist for clean backports to show that it is properly reviewed [v2]
kcr at openjdk.java.net
Wed Jul 14 15:22:12 UTC 2021
On Wed, 14 Jul 2021 15:10:20 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> I understand the confusion. I chose the name to fit in with the current model and naming. When CheckRun evaluates if a cleanBackport PR is ready for integration, it calls PullRequestCheckIssueVisitor.isReadyForReview() (instead of .messages().isEmpty()). So the state we are checking for in the visitor is already named "readyForReview". The new method builds on that and returns the checks that were used to decide if it was readyForReview.
> I should add that the CheckRun knows about clean backports, while the visitor does not, it just evaluates Jcheck checks and reports on the outcome.
OK, thanks for the explanation.
More information about the skara-dev