The pre-integration checks of the project jtreg seem to be wrong

erik.joelsson at oracle.com erik.joelsson at oracle.com
Mon Jun 14 13:01:20 UTC 2021


On 2021-06-13 01:31, Guoxiong Li wrote:
> Thanks Phil and Jon for your kind reply.
>
> I found the jcheck `conf` files of other projects[1][2] have the checks
> about reviewers:
>
> ```
> [checks "reviewers"]
> reviewers=1
> ```
>
> But the jcheck `conf` file of the jtreg[3] doesn't have the similar item.
>
> Does it affect the bot?

Yes, that conf file is what the bots are looking at to know how to treat 
each repository. The configuration for each repository is managed by the 
project owning that repository. In this case it's Jon's call (as the 
code-tools lead) whether to require reviews or not.

/Erik

> [1] https://github.com/openjdk/skara/blob/master/.jcheck/conf
> [2] https://github.com/openjdk/jmh/blob/master/.jcheck/conf
> [3] https://github.com/openjdk/jtreg/blob/master/.jcheck/conf
>
> Best Regards,
> -- Guoxiong
>
>
> On Sun, Jun 13, 2021 at 2:55 AM Jonathan Gibbons <
> jonathan.gibbons at oracle.com> wrote:
>
>> It's probably a side-effect of the combination of Skara and the jtreg
>> configuration.
>>
>> I'll follow up with Skara folk.
>>
>> -- Jon
>>


More information about the skara-dev mailing list