RFR: 997: Email notifications are not sent to alias if binary change is commented in Gitlab [v2]

Erik Joelsson erikj at openjdk.java.net
Thu Jun 17 00:04:19 UTC 2021

> This fixes an NPE when parsing a review comment from Gitlab on a binary file. Such a comment does not have a line, and I picked the value 0 to signal that. I also updated the email formatting of such comments to skip showing line numbers and quotes from the file.

Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:

  Clarified comment


  - all: https://git.openjdk.java.net/skara/pull/1190/files
  - new: https://git.openjdk.java.net/skara/pull/1190/files/0a041293..6a22c75a

 - full: https://webrevs.openjdk.java.net/?repo=skara&pr=1190&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1190&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.java.net/skara/pull/1190.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1190/head:pull/1190

PR: https://git.openjdk.java.net/skara/pull/1190

More information about the skara-dev mailing list