RFR: pr: update all local branches for commit comments [v2]

Magnus Ihse Bursie ihse at openjdk.java.net
Wed Mar 10 10:24:35 UTC 2021

On Wed, 10 Mar 2021 10:22:08 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> please review this patch that makes `CommitCommentsWorkItem` properly update all local branches prior to calling `ReadOnlyRepository.commitMetdata`. `ReadOnlyRepository.commitMetadata` is essentially `rev-list —all` for Git and all local refs need to be updated for this to work. In order to make as few networks call as possible I manually merge each local branch with its remote counterpart (instead of doing `pull`).
>> Testing:
>> - [x] `make test` passes on Linux x64
>> Thanks,
>> Erik
> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>   No need to fetch remotes



Marked as reviewed by ihse (Committer).

PR: https://git.openjdk.java.net/skara/pull/1041

More information about the skara-dev mailing list