RFR: 912: PR title correction logic can get stuck [v3]
Magnus Ihse Bursie
ihse at openjdk.java.net
Fri Mar 12 10:41:44 UTC 2021
> The PR title correct logic introduced with SKARA-572 can end up trying to correct the title forever. An observed case is where the JBS title ends with a trailing space. When trying to update the PR title to include this trailing space, it will be stripped by GitLab and no update will actually be done. This will then get retried again and again.
> The fix is to strip the JBS title before doing any comparisons.
Magnus Ihse Bursie has updated the pull request incrementally with one additional commit since the last revision:
Move strip() into implementation of title(), as requested by reviewer.
- all: https://git.openjdk.java.net/skara/pull/1050/files
- new: https://git.openjdk.java.net/skara/pull/1050/files/6464ea93..2de1e70f
- full: https://webrevs.openjdk.java.net/?repo=skara&pr=1050&range=02
- incr: https://webrevs.openjdk.java.net/?repo=skara&pr=1050&range=01-02
Stats: 12 lines in 7 files changed: 0 ins; 0 del; 12 mod
Fetch: git fetch https://git.openjdk.java.net/skara pull/1050/head:pull/1050
More information about the skara-dev