Integrated: 912: PR title correction logic can get stuck
Magnus Ihse Bursie
ihse at openjdk.java.net
Fri Mar 12 13:15:09 UTC 2021
On Thu, 11 Mar 2021 11:50:30 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> The PR title correct logic introduced with SKARA-572 can end up trying to correct the title forever. An observed case is where the JBS title ends with a trailing space. When trying to update the PR title to include this trailing space, it will be stripped by GitLab and no update will actually be done. This will then get retried again and again.
>
> The fix is to strip the JBS title before doing any comparisons.
This pull request has now been integrated.
Changeset: e664a653
Author: Magnus Ihse Bursie <ihse at openjdk.org>
URL: https://git.openjdk.java.net/skara/commit/e664a653
Stats: 32 lines in 8 files changed: 17 ins; 0 del; 15 mod
912: PR title correction logic can get stuck
Reviewed-by: rwestberg
-------------
PR: https://git.openjdk.java.net/skara/pull/1050
More information about the skara-dev
mailing list