RFR: pr: add /tag commit command

Magnus Ihse Bursie magnus.ihse.bursie at oracle.com
Mon Mar 15 13:45:55 UTC 2021

On 2021-03-15 14:13, Kevin Rushforth wrote:
> On Mon, 15 Mar 2021 09:13:24 GMT, Robin Westberg <rwestberg at openjdk.org> wrote:
>>> Hi all,
>>> please review this patch that adds the `/tag` commit command. As the name implies, the command is used to create a tag with the given name referring to the commit the command is applied to. The command will check that the tag isn't already used and that it conforms to an eventual `.jcheck/conf` configuration.
>>> Thanks,
>>> Erik
>> Looks good!
> Will a project be able to configure the role / review requirements for adding a tag? For example, I can imagine that some projects might want to allow a Reviewer to add a tag without needing review approval from another Reviewer.
Tagging has never required review approval, now, has it? I thought 
integrator just applied tags for builds, basically on their own discretion.

So my question is basically the opposite: are there projects where 
tagging *should* require a review procedure?


> -------------
> PR: https://git.openjdk.java.net/skara/pull/1056

More information about the skara-dev mailing list