[skara] RFR: 744: The "Webrevs" link in the PR has confusing link to the changes for just one commit

Erik Helin ehelin at openjdk.java.net
Thu Mar 18 09:13:42 UTC 2021


Hi all,

please review this pull request that makes the link to the commit after the webrev be a bit more useful. Previously we relied on the forge to "do the right thing" we it noticed a full hash to a commit (link to the changes). This worked fine on GitLab but didn't work as well on GitHub. I have now introduced a proper abstraction and use that to provide the same link on GitLab but a better link on GitHub.

Thanks,
Erik

-------------

Commit messages:
 - skara-744

Changes: https://git.openjdk.java.net/skara/pull/1077/files
 Webrev: https://webrevs.openjdk.java.net/?repo=skara&pr=1077&range=00
  Issue: https://bugs.openjdk.java.net/browse/SKARA-744
  Stats: 25 lines in 6 files changed: 24 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/skara/pull/1077.diff
  Fetch: git fetch https://git.openjdk.java.net/skara pull/1077/head:pull/1077

PR: https://git.openjdk.java.net/skara/pull/1077


More information about the skara-dev mailing list