RFR: 744: The "Webrevs" link in the PR has confusing link to the changes for just one commit

Robin Westberg rwestberg at openjdk.java.net
Thu Mar 18 09:20:34 UTC 2021

On Thu, 18 Mar 2021 09:10:31 GMT, Erik Helin <ehelin at openjdk.org> wrote:

> Hi all,
> please review this pull request that makes the link to the commit after the webrev be a bit more useful. Previously we relied on the forge to "do the right thing" we it noticed a full hash to a commit (link to the changes). This worked fine on GitLab but didn't work as well on GitHub. I have now introduced a proper abstraction and use that to provide the same link on GitLab but a better link on GitHub.
> Thanks,
> Erik

Looks good!


Marked as reviewed by rwestberg (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1077

More information about the skara-dev mailing list