RFR: 1019: IssueNotifier fails if there are extra branches in a repo

Erik Helin ehelin at openjdk.java.net
Fri May 7 08:01:17 UTC 2021

On Thu, 6 May 2021 23:46:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This change makes the notifier bot more lenient when finding branches without fixVersions configured, or when those fixVersions do not have backports in the issue tracker, when processing new tags. Currently either of these cases will cause the rest of the commits affected by a tag to never get processed. See bug for more details.

Looks good!

This is definitely a reasonable approach. An alternative approach if you want to be a bit more safe would be to configure some branches with an ignore value. That way the notifier will know if a branch is supposed to e.g. have a `fixVersion` or not. That way we will still get the exceptions for cases when a branch does not have a configured `fixVersion` nor is configured to be ignored.


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1147

More information about the skara-dev mailing list