[cr] RFR: 1015: Webrev can't handle changes with binary files

[Erik Helin]

On Wed, 12 May 2021 21:35:37 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Please review this fix, which fixes handling of binary files in webrev diffs. We should not even attempt to show diffs for binary files.

index.html line 1506:

> 1504: function removeContext(patch) {
> 1505:     const hunks = new Array();
> 1506:     if (patch != null) {

Maybe do an early return instead? As in


if (patch === null) {
    return hunks;
}


That way you don't have to re-indent the entire method ��

-------------

PR: https://git.openjdk.java.net/cr/pull/16