RFR: 1061: The skara update command is broken for platforms without downloaded JDK

Erik Helin ehelin at openjdk.java.net
Thu May 27 08:00:00 UTC 2021

On Wed, 26 May 2021 23:43:09 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This patch changes the CLI launcher scripts to no longer export JAVA_HOME. This is to prevent this exported variable from interfering with the "git skara update" command. The update command needs to be able to run Gradle. Gradle cannot run with the JAVA_HOME exported from the Skara CLI scripts. Whatever JAVA_HOME the user has needs to survive through to the Gradle invocation.
> I'm not sure why JAVA_HOME was set here. It seems to have been around for a long time. I'm assuming it just happened to be written that way, but if anyone can think of a reason, that would be good. I'm running with this patch myself right now to try to catch any potential problems.

Looks good!


Marked as reviewed by ehelin (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1174

More information about the skara-dev mailing list