RFR: bot: add profile handler [v2]

Erik Joelsson erikj at openjdk.java.net
Fri May 28 12:41:25 UTC 2021


On Fri, 28 May 2021 11:25:55 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds a "profiling handler" typically listening on the `/profile` path. The profile handler will create a JFR recording that is sent as the reply to the HTTP request. The handler needs to configure a max duration (in seconds) for the recording and and a path to the `.jfc` configuration file. I made sure that only recording is allowed at a time to prevent too many requests to slow down the system too much.
>> 
>> Testing:
>> - [x] Tested locally on Linux x64 with various bots and configurations
>> 
>> Thanks,
>> Erik
>
> Erik Helin has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Fixup
>  - Require auth header

Marked as reviewed by erikj (Lead).

-------------

PR: https://git.openjdk.java.net/skara/pull/1164


More information about the skara-dev mailing list