RFR: 1125: OpenJDK 7 backports incorrectly tagged with hgupdate-sync

Erik Joelsson erikj at openjdk.java.net
Tue Sep 7 16:00:53 UTC 2021

On Fri, 3 Sep 2021 21:29:55 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> This patch makes "openjdk7u" a valid JdkVersion in the Skara version parser. This was preventing the SyncLabelBot from properly setting or removing the hgupdate-sync label on backports with this fixVersion.
> jbs/src/main/java/org/openjdk/skara/jbs/JdkVersion.java line 42:
>> 40: 
>> 41:     // Match a version string symbolizing some future, but yet undefined, update of a major version
>> 42:     private final static Pattern futureUpdatePattern = Pattern.compile("((openjdk)?[1-9][0-9]*u)(-([a-z0-9]+))?$");
> This seems like it has some overlap with `ojVersionPattern`. It might be OK, though.

Right, there is certainly overlap between some of these expressions. In the end I picked this one to extend as I thought the most defining feature was the 'u' without any number after it.


PR: https://git.openjdk.java.net/skara/pull/1215

More information about the skara-dev mailing list