RFR: 1198: Stop using fake non existing from email addresses

Kevin Rushforth kcr at openjdk.java.net
Thu Sep 30 22:56:06 UTC 2021


On Thu, 30 Sep 2021 22:47:28 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> With this patch, Skara mlbridge will no longer construct fake email addresses for users not in the census. Instead mails will be sent with the configured do-not-reply address (which is currently duke at openjdk.java.net). The full name of the user will still be added, just like before, so it's still possible for a human to see who made the comment that triggered the email.
> 
> Most of the changes are just adapting test cases that relied on this functionality. Those tests should still be valid as they are still verifying the full names correctly.

Good cleanup.

-------------

Marked as reviewed by kcr (Reviewer).

PR: https://git.openjdk.java.net/skara/pull/1228


More information about the skara-dev mailing list