From joe.darcy at oracle.com Sun Feb 9 13:01:36 2014 From: joe.darcy at oracle.com (Joe Darcy) Date: Sun, 09 Feb 2014 13:01:36 -0800 Subject: JDK 9 RFR of 8034046: Fix serial lint warnings in javax.sound Message-ID: <52F7ECB0.9090408@oracle.com> Hello, Please review this change to address serial lint warnings in javax.sound: 8034046: Fix serial lint warnings in javax.sound http://cr.openjdk.java.net/~darcy/8034046.0/ Mostly this change is adding six missing serialVersionUID fields; I verified the reported serialver values were consistent on JDK 6 and 8. However, in two classes I also removed some non-javadoc comments. Thanks, -Joe From Alan.Bateman at oracle.com Mon Feb 10 00:36:53 2014 From: Alan.Bateman at oracle.com (Alan Bateman) Date: Mon, 10 Feb 2014 08:36:53 +0000 Subject: JDK 9 RFR of 8034046: Fix serial lint warnings in javax.sound In-Reply-To: <52F7ECB0.9090408@oracle.com> References: <52F7ECB0.9090408@oracle.com> Message-ID: <52F88FA5.7080700@oracle.com> On 09/02/2014 21:01, Joe Darcy wrote: > Hello, > > Please review this change to address serial lint warnings in javax.sound: > > 8034046: Fix serial lint warnings in javax.sound > http://cr.openjdk.java.net/~darcy/8034046.0/ > > Mostly this change is adding six missing serialVersionUID fields; I > verified the reported serialver values were consistent on JDK 6 and 8. > > However, in two classes I also removed some non-javadoc comments. This looks good to me (and surprising that the non-javadoc comments were noticed and removed previously). -Alan From Sergey.Bylokhov at oracle.com Mon Feb 10 02:01:06 2014 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Mon, 10 Feb 2014 14:01:06 +0400 Subject: JDK 9 RFR of 8034046: Fix serial lint warnings in javax.sound In-Reply-To: <52F7ECB0.9090408@oracle.com> References: <52F7ECB0.9090408@oracle.com> Message-ID: <52F8A362.90203@oracle.com> Hi, Joe. The fix looks good. On 10.02.2014 1:01, Joe Darcy wrote: > Hello, > > Please review this change to address serial lint warnings in javax.sound: > > 8034046: Fix serial lint warnings in javax.sound > http://cr.openjdk.java.net/~darcy/8034046.0/ > > Mostly this change is adding six missing serialVersionUID fields; I > verified the reported serialver values were consistent on JDK 6 and 8. > > However, in two classes I also removed some non-javadoc comments. > > Thanks, > > -Joe -- Best regards, Sergey.