From Sergey.Bylokhov at oracle.com  Mon Oct  3 14:45:00 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 3 Oct 2016 17:45:00 +0300
Subject: <Sound Dev> [9] Review Request: 8167028 SunCodec.java can be removed
Message-ID: <bde5f8cf-05d2-765d-4a57-c97b6fb65550@oracle.com>

Hello, Audio Guru.

This is a request to small cleanup of the classes related to 
FormatConversionProvider.
  - SunCodec.java is removed. It was used as a parent class for other 
providers, but it contained only the methods to clone the array of 
supported formats. But we can have the same functionality if instead of 
cloning the array just create the new one each time it will be requested.
  - All our providers supports the same encodings as input and output. 
So getTargetEncodings() can be implemented via getSourceEncodings();
  - FormatConversionProvider contains a few methods to filter, search 
the data in arrays, and this functionality can be simplified by Stream API.

No regressions were found by jtreg/jck tests.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167028
Webrev can be found at: http://cr.openjdk.java.net/~serb/8167028/webrev.00

-- 
Best regards, Sergey.

From alexey.menkov at oracle.com  Mon Oct  3 16:29:59 2016
From: alexey.menkov at oracle.com (Alex Menkov)
Date: Mon, 3 Oct 2016 19:29:59 +0300
Subject: <Sound Dev> [9] Review Request: 8167028 SunCodec.java can be
 removed
In-Reply-To: <bde5f8cf-05d2-765d-4a57-c97b6fb65550@oracle.com>
References: <bde5f8cf-05d2-765d-4a57-c97b6fb65550@oracle.com>
Message-ID: <aebc9938-00f9-4912-295c-21ab832ddd70@oracle.com>

Looks okay to me.

--alex

On 03.10.2016 17:45, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> This is a request to small cleanup of the classes related to
> FormatConversionProvider.
>  - SunCodec.java is removed. It was used as a parent class for other
> providers, but it contained only the methods to clone the array of
> supported formats. But we can have the same functionality if instead of
> cloning the array just create the new one each time it will be requested.
>  - All our providers supports the same encodings as input and output. So
> getTargetEncodings() can be implemented via getSourceEncodings();
>  - FormatConversionProvider contains a few methods to filter, search the
> data in arrays, and this functionality can be simplified by Stream API.
>
> No regressions were found by jtreg/jck tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167028
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8167028/webrev.00
>

From philip.race at oracle.com  Mon Oct  3 22:26:32 2016
From: philip.race at oracle.com (Phil Race)
Date: Mon, 3 Oct 2016 15:26:32 -0700
Subject: <Sound Dev> [9] Review Request: 8167028 SunCodec.java can be
 removed
In-Reply-To: <aebc9938-00f9-4912-295c-21ab832ddd70@oracle.com>
References: <bde5f8cf-05d2-765d-4a57-c97b6fb65550@oracle.com>
	<aebc9938-00f9-4912-295c-21ab832ddd70@oracle.com>
Message-ID: <0ada1bc4-eb62-4d7f-80c1-1b95f862285c@oracle.com>

+1

-phil.

On 10/03/2016 09:29 AM, Alex Menkov wrote:
> Looks okay to me.
>
> --alex
>
> On 03.10.2016 17:45, Sergey Bylokhov wrote:
>> Hello, Audio Guru.
>>
>> This is a request to small cleanup of the classes related to
>> FormatConversionProvider.
>>  - SunCodec.java is removed. It was used as a parent class for other
>> providers, but it contained only the methods to clone the array of
>> supported formats. But we can have the same functionality if instead of
>> cloning the array just create the new one each time it will be 
>> requested.
>>  - All our providers supports the same encodings as input and output. So
>> getTargetEncodings() can be implemented via getSourceEncodings();
>>  - FormatConversionProvider contains a few methods to filter, search the
>> data in arrays, and this functionality can be simplified by Stream API.
>>
>> No regressions were found by jtreg/jck tests.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167028
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8167028/webrev.00
>>


From Sergey.Bylokhov at oracle.com  Mon Oct 10 17:35:04 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 10 Oct 2016 20:35:04 +0300
Subject: <Sound Dev> [9] Review Request: 8167435 IllegalArgumentException is
 not thrown by Clip.open(AudioFormat, byte[], int, int)
Message-ID: <71ad829a-663b-1f6a-9c4a-465872181a65@oracle.com>

Hello, Audio Guru.

Please review the fix for jdk9.

According the specification of Clip.open(AudioFormat,byte[], int, int):
      * @throws IllegalArgumentException if the buffer size does not 
represent an
      * integral number of sample frames
      */
     void open(AudioFormat format, byte[] data, int offset, int bufferSize)

We have two implementations of the Clip.
  - In SoftMixingClip  exception is thrown
  - In DirectAudioDevice  exception is not thrown

DirectAudioDevice was fixed, the check was moved to the utility method.

No regressions were found by jtreg/jck tests.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
Webrev can be found at: http://cr.openjdk.java.net/~serb/8167435/webrev.00

-- 
Best regards, Sergey.

From alexey.menkov at oracle.com  Tue Oct 11 11:36:28 2016
From: alexey.menkov at oracle.com (Alex Menkov)
Date: Tue, 11 Oct 2016 14:36:28 +0300
Subject: <Sound Dev> [9] Review Request: 8167435
 IllegalArgumentException is not thrown by Clip.open(AudioFormat, byte[], int,
 int)
In-Reply-To: <71ad829a-663b-1f6a-9c4a-465872181a65@oracle.com>
References: <71ad829a-663b-1f6a-9c4a-465872181a65@oracle.com>
Message-ID: <89d2ea3b-2c15-bb84-d9ae-3641a63b3cf5@oracle.com>

Looks good.

--alex

On 10.10.2016 20:35, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the fix for jdk9.
>
> According the specification of Clip.open(AudioFormat,byte[], int, int):
>      * @throws IllegalArgumentException if the buffer size does not
> represent an
>      * integral number of sample frames
>      */
>     void open(AudioFormat format, byte[] data, int offset, int bufferSize)
>
> We have two implementations of the Clip.
>  - In SoftMixingClip  exception is thrown
>  - In DirectAudioDevice  exception is not thrown
>
> DirectAudioDevice was fixed, the check was moved to the utility method.
>
> No regressions were found by jtreg/jck tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8167435/webrev.00
>

From javasound-dev at bome.com  Wed Oct 12 22:16:18 2016
From: javasound-dev at bome.com (Florian Bomers)
Date: Thu, 13 Oct 2016 00:16:18 +0200
Subject: <Sound Dev> [9] Review Request: 8167435
 IllegalArgumentException is not thrown by Clip.open(AudioFormat, byte[], int,
 int)
In-Reply-To: <89d2ea3b-2c15-bb84-d9ae-3641a63b3cf5@oracle.com>
References: <71ad829a-663b-1f6a-9c4a-465872181a65@oracle.com>
	<89d2ea3b-2c15-bb84-d9ae-3641a63b3cf5@oracle.com>
Message-ID: <41946ab0-3f20-e2af-7e42-0506a36cfcc4@bome.com>

+1
Best, Florian

On 11.10.2016 13:36, Alex Menkov wrote:
> Looks good.
>
> --alex
>
> On 10.10.2016 20:35, Sergey Bylokhov wrote:
>> Hello, Audio Guru.
>>
>> Please review the fix for jdk9.
>>
>> According the specification of Clip.open(AudioFormat,byte[], int, int):
>>      * @throws IllegalArgumentException if the buffer size does not
>> represent an
>>      * integral number of sample frames
>>      */
>>     void open(AudioFormat format, byte[] data, int offset, int
>> bufferSize)
>>
>> We have two implementations of the Clip.
>>  - In SoftMixingClip  exception is thrown
>>  - In DirectAudioDevice  exception is not thrown
>>
>> DirectAudioDevice was fixed, the check was moved to the utility method.
>>
>> No regressions were found by jtreg/jck tests.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
>> Webrev can be found at:
>> http://cr.openjdk.java.net/~serb/8167435/webrev.00
>>
>

-- 
Florian Bomers
Bome Software

everything sounds.
http://www.bome.com
__________________________________________________________________
Bome Software GmbH & Co KG        Gesellschafterin:
Dachauer Str.187                  Bome Komplement?r GmbH
80637 M?nchen, Germany            Gesch?ftsf?hrung: Florian B?mers
Amtsgericht M?nchen HRA95502      Amtsgericht M?nchen HRB185574


From Sergey.Bylokhov at oracle.com  Thu Oct 13 12:56:19 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 13 Oct 2016 15:56:19 +0300
Subject: <Sound Dev> [9] Review Request: 8167435
 IllegalArgumentException is not thrown by Clip.open(AudioFormat, byte[], int,
 int)
In-Reply-To: <41946ab0-3f20-e2af-7e42-0506a36cfcc4@bome.com>
References: <71ad829a-663b-1f6a-9c4a-465872181a65@oracle.com>
	<89d2ea3b-2c15-bb84-d9ae-3641a63b3cf5@oracle.com>
	<41946ab0-3f20-e2af-7e42-0506a36cfcc4@bome.com>
Message-ID: <928dc8c0-35b8-9518-2709-a9602145e051@oracle.com>

Thanks everyone!

On 13.10.16 1:16, Florian Bomers wrote:
> +1
> Best, Florian
>
> On 11.10.2016 13:36, Alex Menkov wrote:
>> Looks good.
>>
>> --alex
>>
>> On 10.10.2016 20:35, Sergey Bylokhov wrote:
>>> Hello, Audio Guru.
>>>
>>> Please review the fix for jdk9.
>>>
>>> According the specification of Clip.open(AudioFormat,byte[], int, int):
>>>      * @throws IllegalArgumentException if the buffer size does not
>>> represent an
>>>      * integral number of sample frames
>>>      */
>>>     void open(AudioFormat format, byte[] data, int offset, int
>>> bufferSize)
>>>
>>> We have two implementations of the Clip.
>>>  - In SoftMixingClip  exception is thrown
>>>  - In DirectAudioDevice  exception is not thrown
>>>
>>> DirectAudioDevice was fixed, the check was moved to the utility method.
>>>
>>> No regressions were found by jtreg/jck tests.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8167435
>>> Webrev can be found at:
>>> http://cr.openjdk.java.net/~serb/8167435/webrev.00
>>>
>>
>


-- 
Best regards, Sergey.

From Sergey.Bylokhov at oracle.com  Mon Oct 24 20:28:34 2016
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 24 Oct 2016 23:28:34 +0300
Subject: <Sound Dev> [9] Review Request: 8167615 Opensource unit/regression
 tests for JavaSound
Message-ID: <f886b88a-18cc-7a3a-b695-7427d46bbdaf@oracle.com>

Hello, Audio Guru.

Please review the fix for jdk9.

In the fix a number of tests are moved to the open ws. Note that most of 
the code moved as-is, and probably can be improved in the future, but I 
tried to limit the number of changes in this move.

Bug: https://bugs.openjdk.java.net/browse/JDK-8167615
Webrev can be found at: http://cr.openjdk.java.net/~serb/8167615/webrev.00

-- 
Best regards, Sergey.

From alexey.menkov at oracle.com  Tue Oct 25 15:49:36 2016
From: alexey.menkov at oracle.com (Alex Menkov)
Date: Tue, 25 Oct 2016 18:49:36 +0300
Subject: <Sound Dev> [9] Review Request: 8167615 Opensource
 unit/regression tests for JavaSound
In-Reply-To: <f886b88a-18cc-7a3a-b695-7427d46bbdaf@oracle.com>
References: <f886b88a-18cc-7a3a-b695-7427d46bbdaf@oracle.com>
Message-ID: <b4d7ef90-8b7c-1292-835f-cc6570f81360@oracle.com>

Looks good.

--alex

On 24.10.2016 23:28, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the fix for jdk9.
>
> In the fix a number of tests are moved to the open ws. Note that most of
> the code moved as-is, and probably can be improved in the future, but I
> tried to limit the number of changes in this move.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167615
> Webrev can be found at: http://cr.openjdk.java.net/~serb/8167615/webrev.00
>

From philip.race at oracle.com  Mon Oct 31 19:11:48 2016
From: philip.race at oracle.com (Philip Race)
Date: Mon, 31 Oct 2016 12:11:48 -0700
Subject: <Sound Dev> [9] Review Request: 8167615 Opensource
 unit/regression tests for JavaSound
In-Reply-To: <f886b88a-18cc-7a3a-b695-7427d46bbdaf@oracle.com>
References: <f886b88a-18cc-7a3a-b695-7427d46bbdaf@oracle.com>
Message-ID: <58179774.6080109@oracle.com>

+1

-phil

On 10/24/16, 1:28 PM, Sergey Bylokhov wrote:
> Hello, Audio Guru.
>
> Please review the fix for jdk9.
>
> In the fix a number of tests are moved to the open ws. Note that most 
> of the code moved as-is, and probably can be improved in the future, 
> but I tried to limit the number of changes in this move.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8167615
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8167615/webrev.00
>