From Sergey.Bylokhov at oracle.com Sat May 5 01:03:01 2018 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Fri, 4 May 2018 18:03:01 -0700 Subject: [11] Review Request: 8201279 javax.sound tests should not set java.home system property In-Reply-To: <3c3e2dcb-5645-4cd8-9f13-520810fa9547@oracle.com> References: <0409b359-1111-5a53-a7a2-48ac6b985ddb@Oracle.com> <3c3e2dcb-5645-4cd8-9f13-520810fa9547@oracle.com> Message-ID: <0aa5babb-902b-7d65-59ea-573da27e733e@oracle.com> CSR is created: https://bugs.openjdk.java.net/browse/JDK-8202680 On 21/04/2018 17:55, Sergey Bylokhov wrote: > Hi, Roger. > Thank you for the review. > > On 13/04/2018 07:19, Roger Riggs wrote: >> Should the new system property javax.sound.config.file be an >> implementation specific property >> and named "jdk.sound.config.file"? > > This new property describe a location of the "sound.properties" file, > which is mentioned in the public specification already. Based on this > and on the similar property for logging I selected this name > "javax.sound.config.file". > >> JSSecurityManager.java: >> Lines 99-102:? The code can be simplified by using Paths instead of >> File.? Paths.get() returns a Path; >> it can be used directly by java.nio.file.Files.newBufferedReader(Path) >> to get the BufferedInputStream. > > The code simplified as suggested: > http://cr.openjdk.java.net/~serb/8201279/webrev.02 > >> >> Otherwise, looks ok >> >> $.02, Roger >> >> --- >> Hello, Audio Guru. >> >> Please review the fix for jdk11. >> >> This change adds an optional "javax.sound.config.file" system >> property(the similar name is used for logging: >> "java.util.logging.config.file") which specified default location of the >> properties file. Note that all errors which maybe occurs during access >> to this file are ignored in the same way as for default config file >> "jdk/conf/sound.properties"(BTW I am not sure that this is a good idea, >> but follow the current approach). >> >> The CSR will be filed after the technical review. >> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8201279 >> Webrev can be found at: >> http://cr.openjdk.java.net/~serb/8201279/webrev.01 >> > > -- Best regards, Sergey. From philip.race at oracle.com Mon May 14 16:39:23 2018 From: philip.race at oracle.com (Phil Race) Date: Mon, 14 May 2018 09:39:23 -0700 Subject: [11] Review Request: 8201279 javax.sound tests should not set java.home system property In-Reply-To: <0aa5babb-902b-7d65-59ea-573da27e733e@oracle.com> References: <0409b359-1111-5a53-a7a2-48ac6b985ddb@Oracle.com> <3c3e2dcb-5645-4cd8-9f13-520810fa9547@oracle.com> <0aa5babb-902b-7d65-59ea-573da27e733e@oracle.com> Message-ID: <5a27bb18-1e70-41c3-711a-4f9e49684263@oracle.com> I had a similar though as Roger on the naming and documentation-level of the property but I suppose there is no problem and there is precedent. I've reviewed the CSR. +1 -phil. On 05/04/2018 06:03 PM, Sergey Bylokhov wrote: > CSR is created: > https://bugs.openjdk.java.net/browse/JDK-8202680 > > On 21/04/2018 17:55, Sergey Bylokhov wrote: >> Hi, Roger. >> Thank you for the review. >> >> On 13/04/2018 07:19, Roger Riggs wrote: >>> Should the new system property javax.sound.config.file be an >>> implementation specific property >>> and named "jdk.sound.config.file"? >> >> This new property describe a location of the "sound.properties" file, >> which is mentioned in the public specification already. Based on this >> and on the similar property for logging I selected this name >> "javax.sound.config.file". >> >>> JSSecurityManager.java: >>> Lines 99-102: The code can be simplified by using Paths instead of >>> File. Paths.get() returns a Path; >>> it can be used directly by >>> java.nio.file.Files.newBufferedReader(Path) to get the >>> BufferedInputStream. >> >> The code simplified as suggested: >> http://cr.openjdk.java.net/~serb/8201279/webrev.02 >> >>> >>> Otherwise, looks ok >>> >>> $.02, Roger >>> >>> --- >>> Hello, Audio Guru. >>> >>> Please review the fix for jdk11. >>> >>> This change adds an optional "javax.sound.config.file" system >>> property(the similar name is used for logging: >>> "java.util.logging.config.file") which specified default location of >>> the >>> properties file. Note that all errors which maybe occurs during access >>> to this file are ignored in the same way as for default config file >>> "jdk/conf/sound.properties"(BTW I am not sure that this is a good idea, >>> but follow the current approach). >>> >>> The CSR will be filed after the technical review. >>> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8201279 >>> Webrev can be found at: >>> http://cr.openjdk.java.net/~serb/8201279/webrev.01 >>> >> >> > >