From Sergey.Bylokhov at oracle.com Thu May 2 02:40:46 2019 From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov) Date: Wed, 1 May 2019 19:40:46 -0700 Subject: Support for sample widths greater than 16 bit and multichannel on Windows, In-Reply-To: References: Message-ID: <95814ddb-dd7d-9415-69bd-cf5c1b106e06@oracle.com> Hi, John. On 29/04/2019 03:45, John Mulcahy wrote: > Are there any plans to support sample widths greater than 16 bits and/or multichannel on Windows for JDK8? If not, are sample widths greater than 16 bits supported on Windows on a later JDK? And/or lines with more than 2 channels? It is unlikely will be implemented in JDK 8, but probably it would be possible to implement in some future version. I suggest creating an RFE on https://bugs.java.com/bugdatabase to track this, and of course, a patch is welcome. -- Best regards, Sergey. From john_mulcahy at hotmail.com Thu May 2 16:39:42 2019 From: john_mulcahy at hotmail.com (John Mulcahy) Date: Thu, 2 May 2019 16:39:42 +0000 Subject: Support for sample widths greater than 16 bit and multichannel on Windows, In-Reply-To: <95814ddb-dd7d-9415-69bd-cf5c1b106e06@oracle.com> References: , <95814ddb-dd7d-9415-69bd-cf5c1b106e06@oracle.com> Message-ID: Will do Sergey, thanks. Best regards, John ________________________________ From: Sergey Bylokhov Sent: 02 May 2019 02:40 To: John Mulcahy; sound-dev at openjdk.java.net Subject: Re: Support for sample widths greater than 16 bit and multichannel on Windows, Hi, John. On 29/04/2019 03:45, John Mulcahy wrote: > Are there any plans to support sample widths greater than 16 bits and/or multichannel on Windows for JDK8? If not, are sample widths greater than 16 bits supported on Windows on a later JDK? And/or lines with more than 2 channels? It is unlikely will be implemented in JDK 8, but probably it would be possible to implement in some future version. I suggest creating an RFE on https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.java.com%2Fbugdatabase&data=02%7C01%7C%7C2aa057a8c42a461871c608d6cea77b1b%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636923616043097311&sdata=8JCPnHPGe2u3NlbDfBvPUS40gcGXzSRDAVxApeZWMqE%3D&reserved=0 to track this, and of course, a patch is welcome. -- Best regards, Sergey. -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewluotechnologies at outlook.com Tue May 14 00:36:49 2019 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Tue, 14 May 2019 00:36:49 +0000 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) Message-ID: I've been trying to get the JDK to compile with the new /permissive- switch in VS2017 (https://devblogs.microsoft.com/cppblog/permissive-switch/) however there have been a few issues in various parts of the code. There are a few issues in the libjsound code where we attempt to assign string literals to LPSTR variables (instead of LPCSTR). I took some time to fix some of these and attached a patch. Let me know if you have any comments/feedback. I'm assuming that libjsound is owned by sound-dev, but if I'm mistaken, please do let me know the right team/mailing list to send this to. c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' Thanks, -Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: jdksound.txt URL: From javasound-dev at bome.com Tue May 14 09:48:01 2019 From: javasound-dev at bome.com (Florian Bomers) Date: Tue, 14 May 2019 11:48:01 +0200 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) In-Reply-To: References: Message-ID: Hi, the fix looks correct to me. Florian On 14.05.2019 02:36, Andrew Luo wrote: > I?ve been trying to get the JDK to compile with the new /permissive- > switch in VS2017 > (https://devblogs.microsoft.com/cppblog/permissive-switch/) however > there have been a few issues in various parts of the code.? There are > a few issues in the libjsound code where we attempt to assign string > literals to LPSTR variables (instead of LPCSTR).? I took some time to > fix some of these and attached a patch.? Let me know if you have any > comments/feedback.? I?m assuming that libjsound is owned by sound-dev, > but if I?m mistaken, please do let me know the right team/mailing list > to send this to. > > c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): > error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' > > Thanks, > > -Andrew > -- Florian Bomers Bome Software everything sounds. http://www.bome.com __________________________________________________________________ Bome Software GmbH & Co KG Gesellschafterin: Petra-Kelly-Str. 15 Bome Komplement?r GmbH 80797 M?nchen, Germany Gesch?ftsf?hrung: Florian B?mers Amtsgericht M?nchen HRA95502 Amtsgericht M?nchen HRB185574 From andrewluotechnologies at outlook.com Thu May 16 05:34:10 2019 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Thu, 16 May 2019 05:34:10 +0000 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) In-Reply-To: References: Message-ID: Hi Florian, Thanks for the review. By the way, I am not a JDK committer, is it possible that you or someone else on this mailing list would be willing to help sponsor this change? Thanks, -Andrew -----Original Message----- From: Florian Bomers Sent: Tuesday, May 14, 2019 2:48 AM To: Andrew Luo ; sound-dev at openjdk.java.net Subject: Re: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) Hi, the fix looks correct to me. Florian On 14.05.2019 02:36, Andrew Luo wrote: > I've been trying to get the JDK to compile with the new /permissive- > switch in VS2017 > (https://devblogs.microsoft.com/cppblog/permissive-switch/) however > there have been a few issues in various parts of the code.? There are > a few issues in the libjsound code where we attempt to assign string > literals to LPSTR variables (instead of LPCSTR).? I took some time to > fix some of these and attached a patch.? Let me know if you have any > comments/feedback.? I'm assuming that libjsound is owned by sound-dev, > but if I'm mistaken, please do let me know the right team/mailing list > to send this to. > > c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): > error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' > > Thanks, > > -Andrew > -- Florian Bomers Bome Software everything sounds. http://www.bome.com __________________________________________________________________ Bome Software GmbH & Co KG Gesellschafterin: Petra-Kelly-Str. 15 Bome Komplement?r GmbH 80797 M?nchen, Germany Gesch?ftsf?hrung: Florian B?mers Amtsgericht M?nchen HRA95502 Amtsgericht M?nchen HRB185574 From javasound-dev at bome.com Thu May 16 11:52:52 2019 From: javasound-dev at bome.com (Florian Bomers) Date: Thu, 16 May 2019 13:52:52 +0200 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) In-Reply-To: References: Message-ID: <381f1bb1-3ba6-89e6-f940-3bb1efea3a13@bome.com> I'm not a JDK committer either... On 16.05.2019 07:34, Andrew Luo wrote: > Hi Florian, > > Thanks for the review. > > By the way, I am not a JDK committer, is it possible that you or someone else on this mailing list would be willing to help sponsor this change? > > Thanks, > > -Andrew > > -----Original Message----- > From: Florian Bomers > Sent: Tuesday, May 14, 2019 2:48 AM > To: Andrew Luo ; sound-dev at openjdk.java.net > Subject: Re: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) > > Hi, the fix looks correct to me. > Florian > > On 14.05.2019 02:36, Andrew Luo wrote: >> I've been trying to get the JDK to compile with the new /permissive- >> switch in VS2017 >> (https://devblogs.microsoft.com/cppblog/permissive-switch/) however >> there have been a few issues in various parts of the code.? There are >> a few issues in the libjsound code where we attempt to assign string >> literals to LPSTR variables (instead of LPCSTR).? I took some time to >> fix some of these and attached a patch.? Let me know if you have any >> comments/feedback.? I'm assuming that libjsound is owned by sound-dev, >> but if I'm mistaken, please do let me know the right team/mailing list >> to send this to. >> >> c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): >> error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' >> >> Thanks, >> >> -Andrew >> > > -- > Florian Bomers > Bome Software > > everything sounds. > http://www.bome.com > __________________________________________________________________ > Bome Software GmbH & Co KG Gesellschafterin: > Petra-Kelly-Str. 15 Bome Komplement?r GmbH > 80797 M?nchen, Germany Gesch?ftsf?hrung: Florian B?mers > Amtsgericht M?nchen HRA95502 Amtsgericht M?nchen HRB185574 > > -- Florian Bomers Bome Software everything sounds. http://www.bome.com __________________________________________________________________ Bome Software GmbH & Co KG Gesellschafterin: Petra-Kelly-Str. 15 Bome Komplement?r GmbH 80797 M?nchen, Germany Gesch?ftsf?hrung: Florian B?mers Amtsgericht M?nchen HRA95502 Amtsgericht M?nchen HRB185574 From philip.race at oracle.com Thu May 16 17:12:27 2019 From: philip.race at oracle.com (Phil Race) Date: Thu, 16 May 2019 10:12:27 -0700 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) In-Reply-To: References: Message-ID: <4548e85a-30f7-7a17-53db-987d8845d34e@oracle.com> First thing you need is a bug : https://bugs.openjdk.java.net/browse/JDK-8224056 Second is a sponsor. I can help there. Can you resubmit with your patch in-line (not an attachment) and the subject line: RFR: 8224056: Fix some assignments of string literals to LPSTR (instead of LPCSTR) You said "a few issues" and "some of these" but you only have one that I see -LPSTR TranslateDSError(HRESULT hr) { +LPCSTR TranslateDSError(HRESULT hr) { What am I missing ? I don't want a patch per case, I'd like just one patch for all of java sound. We should also test this builds in the standard mode although I don't see why it should not. -phil. On 5/13/19 5:36 PM, Andrew Luo wrote: > > I?ve been trying to get the JDK to compile with the new /permissive- > switch in VS2017 > (https://devblogs.microsoft.com/cppblog/permissive-switch/) however > there have been a few issues in various parts of the code.? There are > a few issues in the libjsound code where we attempt to assign string > literals to LPSTR variables (instead of LPCSTR).? I took some time to > fix some of these and attached a patch.? Let me know if you have any > comments/feedback.? I?m assuming that libjsound is owned by sound-dev, > but if I?m mistaken, please do let me know the right team/mailing list > to send this to. > > c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): > error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' > > Thanks, > > -Andrew > -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewluotechnologies at outlook.com Fri May 17 18:03:03 2019 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Fri, 17 May 2019 18:03:03 +0000 Subject: RFR: 8224056: Fix some assignments of string literals to LPSTR (instead of LPCSTR) Message-ID: Hi, I'm sending out this RFR for this bug: https://bugs.openjdk.java.net/browse/JDK-8224056 Patch is inline below. Testing done: make, make images, make bundles with both /permissive- (passed --with-extra-cxxflags to configure) and without Thanks, -Andrew diff --git a/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp b/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp --- a/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp +++ b/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp @@ -357,7 +357,7 @@ } DS_Info; -LPSTR TranslateDSError(HRESULT hr) { +LPCSTR TranslateDSError(HRESULT hr) { switch(hr) { case DSERR_ALLOCATED: return "DSERR_ALLOCATED"; -------------- next part -------------- An HTML attachment was scrubbed... URL: From andrewluotechnologies at outlook.com Fri May 17 18:03:09 2019 From: andrewluotechnologies at outlook.com (Andrew Luo) Date: Fri, 17 May 2019 18:03:09 +0000 Subject: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) In-Reply-To: <4548e85a-30f7-7a17-53db-987d8845d34e@oracle.com> References: <4548e85a-30f7-7a17-53db-987d8845d34e@oracle.com> Message-ID: Thanks for the help. Sorry, I used the plural form, when I should have used the singular form. In libjsound there is only one case - there were other issues in the rest of the OpenJDK code... I will also Thanks, -Andrew From: Phil Race Sent: Thursday, May 16, 2019 10:12 AM To: Andrew Luo ; sound-dev at openjdk.java.net Subject: Re: [PATCH] Fix some assignments of string literals to LPSTR (instead of LPCSTR) First thing you need is a bug : https://bugs.openjdk.java.net/browse/JDK-8224056 Second is a sponsor. I can help there. Can you resubmit with your patch in-line (not an attachment) and the subject line: RFR: 8224056: Fix some assignments of string literals to LPSTR (instead of LPCSTR) You said "a few issues" and "some of these" but you only have one that I see -LPSTR TranslateDSError(HRESULT hr) { +LPCSTR TranslateDSError(HRESULT hr) { What am I missing ? I don't want a patch per case, I'd like just one patch for all of java sound. We should also test this builds in the standard mode although I don't see why it should not. -phil. On 5/13/19 5:36 PM, Andrew Luo wrote: I've been trying to get the JDK to compile with the new /permissive- switch in VS2017 (https://devblogs.microsoft.com/cppblog/permissive-switch/) however there have been a few issues in various parts of the code. There are a few issues in the libjsound code where we attempt to assign string literals to LPSTR variables (instead of LPCSTR). I took some time to fix some of these and attached a patch. Let me know if you have any comments/feedback. I'm assuming that libjsound is owned by sound-dev, but if I'm mistaken, please do let me know the right team/mailing list to send this to. c:/Users/Andrew/Documents/mercurial/openjdk/jdk/src/java.desktop/windows/native/libjsound/PLATFORM_API_WinOS_DirectSound.cpp(363): error C2440: 'return': cannot convert from 'const char [16]' to 'LPSTR' Thanks, -Andrew -------------- next part -------------- An HTML attachment was scrubbed... URL: