From philip.race at oracle.com  Tue Apr  7 22:13:43 2020
From: philip.race at oracle.com (Philip Race)
Date: Tue, 07 Apr 2020 15:13:43 -0700
Subject: <Sound Dev> RFR: 8238567 SoftMainMixer.processAudioBuffers():
 Wrong handling of stoppedMixers
In-Reply-To: <c24b5e9f-8b03-075c-b2c5-ef9831fa0fdc@oracle.com>
References: <c24b5e9f-8b03-075c-b2c5-ef9831fa0fdc@oracle.com>
Message-ID: <5E8CFB17.6050901@oracle.com>

+1

-phil

On 3/16/20, 5:34 AM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk/client.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8238567
> Fix: http://cr.openjdk.java.net/~serb/8238567/webrev.00
>
> The stoppedMixers Set contains the list of ModelChannelMixer, but we
> tried to call stoppedMixers.contains/remove and pass 
> SoftChannelMixerContainer
> as a parameter. I was not able to trigger a bug by the test..
>
>

From philip.race at oracle.com  Fri Apr 24 22:30:40 2020
From: philip.race at oracle.com (Philip Race)
Date: Fri, 24 Apr 2020 15:30:40 -0700
Subject: <Sound Dev> [15] Review Request: 8236980 Cleanup of toString
 methods in JavaSound
In-Reply-To: <30444307-477f-ee3b-e620-6e01f5205f95@oracle.com>
References: <318540c8-7d86-c185-41dd-e9520e411f51@oracle.com>
 <3fb64fe8-4416-b2b3-dc02-d83ec9832514@oracle.com>
 <2a20c4bc-fa88-deca-3b9f-3c8228a5aec9@oracle.com>
 <5E28EFD9.3060104@oracle.com>
 <30444307-477f-ee3b-e620-6e01f5205f95@oracle.com>
Message-ID: <5EA36890.9000205@oracle.com>

OK, approved.

-phil

On 1/24/20, 12:48 AM, Sergey Bylokhov wrote:
> On 1/22/20 4:59 pm, Philip Race wrote:
>>>
>>> The CSR will be necessary if I'll add or remove some assertions in 
>>> the spec.
>>
>> Meaning you don't think it is currently needed ?
>
> Yes, but I can create one if you think the changes are big enough.
>
>> Although really I don't understand how this fix is of any great 
>> importance.
>> Who was having a problem with the existing behaviour / spec ?
>
> The spec change wasn't an initial goal for this fix.
> I have started from updating the implementation of the methods where we
> inconsistently use fields and getters, then clean the methods which mix
> different types of string concatenations, and since I already updated 
> most
> of the methods I decided to cleanup the spec as well.
>
> BTW this change made java.desktop.jmod smaller by 1kb
>
>>
>> -phil.
>>>
>>>>
>>>> On 1/12/20 12:14 PM, Sergey Bylokhov wrote:
>>>>> Hello.
>>>>> Please review a "weekend cleanup" for JDK 15.
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8236980
>>>>> Fix: http://cr.openjdk.java.net/~serb/8236980/webrev.00
>>>>>
>>>>> I have made these changes:
>>>>>  - The words in the specs are unified across the different methods
>>>>>  - All toString() implementations now use getXXX() methods instead
>>>>>    of direct access to the fields(the getxxx() methods are skipped
>>>>>    only if the getxxx() method is final)
>>>>>  - A few tests were added to check some spec, and its implementations
>>>>>
>>>>
>>>
>>>
>
>