From github.com+87324768+lawrence-andrew at openjdk.java.net  Wed Sep  1 17:41:19 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Wed, 1 Sep 2021 17:41:19 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
Message-ID: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>

1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
2) After removing =yesno once again test case was failing with following exception
----------System.err:(15/782)----------
java.io.IOException: Illegal seek
at java.io.FileInputStream.skip(Native Method)
at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
at bug6186488.main(bug6186488.java:36)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:474)
at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
at java.lang.Thread.run(Thread.java:722)

3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
5) Add try-with-resource to close the synth.

@shurymury

-------------

Commit messages:
 - 7188098 : TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Changes: https://git.openjdk.java.net/jdk/pull/5338/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5338&range=00
  Issue: https://bugs.openjdk.java.net/browse/JDK-7188098
  Stats: 180 lines in 1 file changed: 151 ins; 22 del; 7 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5338.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5338/head:pull/5338

PR: https://git.openjdk.java.net/jdk/pull/5338

From github.com+741251+turbanoff at openjdk.java.net  Wed Sep  1 19:30:11 2021
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Wed, 1 Sep 2021 19:30:11 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v4]
In-Reply-To: <ZHTxa3hHOYqNUlSS9IoQJOqWbNpGr1KJ003JqowjDoc=.588a6b2c-2b9f-4aaf-8172-447c0ac16f43@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
 <NIvTAS4GZZGZaYvwtpV61lC2-9hPr5gWluKw-bVm-tc=.dfceb034-4588-40fb-893b-5a43c9d348a6@github.com>
 <dMwj1oSGORvppTPEHYHp880b9-j7CMYkPL4tQX50GTI=.1b766603-26b2-4322-979d-7c67358f7bba@github.com>
 <Mzw2vELvYDrk5ZcW0GCdifOqXb2qsXranCtQEcftif8=.67b18048-4557-4b7b-851b-443c13a8e07e@github.com>
 <ZHTxa3hHOYqNUlSS9IoQJOqWbNpGr1KJ003JqowjDoc=.588a6b2c-2b9f-4aaf-8172-447c0ac16f43@github.com>
Message-ID: <xlyPhpwj6Hvprzzoj8RMHhhZ0ex4jEwpmSldXE3ZCSo=.8d6f04b5-bdf5-4cab-bc8d-59d384ac4b38@github.com>

On Fri, 27 Aug 2021 18:28:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Can you please elaborate?
>> As I can see if size of array is exactly the same as size of vector/arraylist, implementations are similar - they just call System.arraycopy
>> ![???????????](https://user-images.githubusercontent.com/741251/131168809-480c05d6-2775-4812-91f5-c73833f9a396.png)
>
> To confirm this you need to do the same check on every usage of added toArray([]), the simpler version like "return toArray()" or return toArray(new MenuElement[elements.size()]) is simpler, no need to check something. I guess in some previouse fixes it was confirmed that the "return toArray(new MenuElement[0])" is even faster.

Ok. Simplified

-------------

PR: https://git.openjdk.java.net/jdk/pull/4680

From github.com+741251+turbanoff at openjdk.java.net  Wed Sep  1 19:30:10 2021
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Wed, 1 Sep 2021 19:30:10 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v5]
In-Reply-To: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
Message-ID: <2uvW-RV4K6LMrM5QpOJF2v_FjDJVZpkj1746Q_GAY9A=.b94c87be-ebd8-4ea8-aede-cf84126a6290@github.com>

> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where `Vector` was used as local variable.

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  8271603: Unnecessary Vector usage in java.desktop
  use toArray with zero sized array in places where Vector.copyInto was used

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4680/files
  - new: https://git.openjdk.java.net/jdk/pull/4680/files/5727f6f2..1f0ebd1c

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=04
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=03-04

  Stats: 22 lines in 9 files changed: 0 ins; 13 del; 9 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4680.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680

PR: https://git.openjdk.java.net/jdk/pull/4680

From github.com+741251+turbanoff at openjdk.java.net  Wed Sep  1 19:46:51 2021
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Wed, 1 Sep 2021 19:46:51 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v6]
In-Reply-To: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
Message-ID: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com>

> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where `Vector` was used as local variable.

Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:

 - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop
   
   # Conflicts:
   #	src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java
 - 8271603: Unnecessary Vector usage in java.desktop
   use toArray with zero sized array in places where Vector.copyInto was used
 - 8271603: Unnecessary Vector usage in java.desktop
   migrate even more usages
 - 8271603: Unnecessary Vector usage in java.desktop
   migrate more usages. Not sure how I missed them
 - 8271603: Unnecessary Vector usage in java.desktop
   revert back to use cycle to copy into array
 - 8271603: Unnecessary Vector usage in java.desktop
   revert back to Enumeration
   bring back default values
 - [PATCH] Unnecessary Vector usage in java.desktop
   use zero-length array
 - [PATCH] Unnecessary Vector usage in java.desktop

-------------

Changes: https://git.openjdk.java.net/jdk/pull/4680/files
 Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=05
  Stats: 270 lines in 34 files changed: 19 ins; 30 del; 221 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4680.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680

PR: https://git.openjdk.java.net/jdk/pull/4680

From serb at openjdk.java.net  Fri Sep  3 03:20:38 2021
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Fri, 3 Sep 2021 03:20:38 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v6]
In-Reply-To: <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
 <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com>
Message-ID: <m9bOeQ1dAUM6OePHF0QtwsmlcDPA33qhWHFUeFEZA1M=.810cae5f-fe23-4d94-971f-f2bad7645201@github.com>

On Wed, 1 Sep 2021 19:46:51 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
>> I checked only places where `Vector` was used as local variable.
>
> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
> 
>  - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop
>    
>    # Conflicts:
>    #	src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java
>  - 8271603: Unnecessary Vector usage in java.desktop
>    use toArray with zero sized array in places where Vector.copyInto was used
>  - 8271603: Unnecessary Vector usage in java.desktop
>    migrate even more usages
>  - 8271603: Unnecessary Vector usage in java.desktop
>    migrate more usages. Not sure how I missed them
>  - 8271603: Unnecessary Vector usage in java.desktop
>    revert back to use cycle to copy into array
>  - 8271603: Unnecessary Vector usage in java.desktop
>    revert back to Enumeration
>    bring back default values
>  - [PATCH] Unnecessary Vector usage in java.desktop
>    use zero-length array
>  - [PATCH] Unnecessary Vector usage in java.desktop

src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1578:

> 1576:         }
> 1577:         String[] retValue = new String[temp.size()];
> 1578:         temp.toArray(retValue);

Why not `return temp.toArray(new String[0]);` like in other places in the last commit?

-------------

PR: https://git.openjdk.java.net/jdk/pull/4680

From serb at openjdk.java.net  Fri Sep  3 03:56:29 2021
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Fri, 3 Sep 2021 03:56:29 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
In-Reply-To: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
Message-ID: <mZp0o6mY3pOtcowaOJJfnj1MDk-LkTMIIWK0mnkLG3c=.1cb1d58f-4cd7-44ce-9ff7-347088bcea8c@github.com>

On Wed, 1 Sep 2021 17:34:14 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:

> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
> 2) After removing =yesno once again test case was failing with following exception
> ----------System.err:(15/782)----------
> java.io.IOException: Illegal seek
> at java.io.FileInputStream.skip(Native Method)
> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
> at bug6186488.main(bug6186488.java:36)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:474)
> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
> at java.lang.Thread.run(Thread.java:722)
> 
> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
> 5) Add try-with-resource to close the synth.
> 
> @shurymury

test/jdk/javax/sound/midi/Synthesizer/Receiver/bug6186488.java line 104:

> 102:     private static void createAndShowTestDialog() {
> 103:         String testInstruction = "This test verify that software Java Syntesizer processed non-ShortMessage-derived messages. \n" +
> 104:                 "Click on 'Start Test' button. If you listen a sound then test pass else test fail.";

Probably it will be useful to ask the user to "Make sure that the speakers are connected and the volume is up."? Some other tests use this suggestion.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From github.com+741251+turbanoff at openjdk.java.net  Fri Sep  3 08:05:00 2021
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Fri, 3 Sep 2021 08:05:00 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v6]
In-Reply-To: <m9bOeQ1dAUM6OePHF0QtwsmlcDPA33qhWHFUeFEZA1M=.810cae5f-fe23-4d94-971f-f2bad7645201@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
 <7f4YqmkdSFHfBZVEG_zH7YlHgaXXTH946MURedTeMIs=.21591a2f-7139-49d3-a9cb-90acd423c49f@github.com>
 <m9bOeQ1dAUM6OePHF0QtwsmlcDPA33qhWHFUeFEZA1M=.810cae5f-fe23-4d94-971f-f2bad7645201@github.com>
Message-ID: <Du3Vniij78K5l2h8X604DRIaz8ner2Z4O98b-QsBpl0=.492ada58-1784-465b-bdcc-3b714f777425@github.com>

On Fri, 3 Sep 2021 03:17:02 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> Andrey Turbanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge remote-tracking branch 'origin/master' into avoid-unnecessary-vector-usage-in-java.desktop
>>    
>>    # Conflicts:
>>    #	src/java.desktop/share/classes/sun/awt/shell/ShellFolder.java
>>  - 8271603: Unnecessary Vector usage in java.desktop
>>    use toArray with zero sized array in places where Vector.copyInto was used
>>  - 8271603: Unnecessary Vector usage in java.desktop
>>    migrate even more usages
>>  - 8271603: Unnecessary Vector usage in java.desktop
>>    migrate more usages. Not sure how I missed them
>>  - 8271603: Unnecessary Vector usage in java.desktop
>>    revert back to use cycle to copy into array
>>  - 8271603: Unnecessary Vector usage in java.desktop
>>    revert back to Enumeration
>>    bring back default values
>>  - [PATCH] Unnecessary Vector usage in java.desktop
>>    use zero-length array
>>  - [PATCH] Unnecessary Vector usage in java.desktop
>
> src/java.desktop/share/classes/javax/swing/text/html/CSS.java line 1578:
> 
>> 1576:         }
>> 1577:         String[] retValue = new String[temp.size()];
>> 1578:         temp.toArray(retValue);
> 
> Why not `return temp.toArray(new String[0]);` like in other places in the last commit?

Good catch! Update here too.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4680

From github.com+741251+turbanoff at openjdk.java.net  Fri Sep  3 08:04:52 2021
From: github.com+741251+turbanoff at openjdk.java.net (Andrey Turbanov)
Date: Fri, 3 Sep 2021 08:04:52 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v7]
In-Reply-To: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
Message-ID: <U-5c4xVAwDMZ9YOUFCwa0lbct7qJwxSVIY9lvdTvfhA=.d848f208-fa13-42d8-b823-38010d59ea19@github.com>

> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
> I checked only places where `Vector` was used as local variable.

Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:

  8271603: Unnecessary Vector usage in java.desktop
  one more place to call toArray with zero-sized array

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/4680/files
  - new: https://git.openjdk.java.net/jdk/pull/4680/files/2fb05a2c..f0ab7f17

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=06
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=4680&range=05-06

  Stats: 2 lines in 1 file changed: 0 ins; 1 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/4680.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/4680/head:pull/4680

PR: https://git.openjdk.java.net/jdk/pull/4680

From github.com+87324768+lawrence-andrew at openjdk.java.net  Fri Sep  3 13:56:04 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Fri, 3 Sep 2021 13:56:04 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v2]
In-Reply-To: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
Message-ID: <Vq1IpfqwAvFFq3xjcwavTP9zo_3S7dpAayU13NrUieA=.8520f6f3-2535-4f28-aba1-8d25ef953afc@github.com>

> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
> 2) After removing =yesno once again test case was failing with following exception
> ----------System.err:(15/782)----------
> java.io.IOException: Illegal seek
> at java.io.FileInputStream.skip(Native Method)
> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
> at bug6186488.main(bug6186488.java:36)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:474)
> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
> at java.lang.Thread.run(Thread.java:722)
> 
> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
> 5) Add try-with-resource to close the synth.
> 
> @shurymury

lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

  Added extra instruction for the user

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5338/files
  - new: https://git.openjdk.java.net/jdk/pull/5338/files/c64e9480..863171b0

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5338&range=01
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5338&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5338.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5338/head:pull/5338

PR: https://git.openjdk.java.net/jdk/pull/5338

From github.com+87324768+lawrence-andrew at openjdk.java.net  Fri Sep  3 13:56:07 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Fri, 3 Sep 2021 13:56:07 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v2]
In-Reply-To: <mZp0o6mY3pOtcowaOJJfnj1MDk-LkTMIIWK0mnkLG3c=.1cb1d58f-4cd7-44ce-9ff7-347088bcea8c@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
 <mZp0o6mY3pOtcowaOJJfnj1MDk-LkTMIIWK0mnkLG3c=.1cb1d58f-4cd7-44ce-9ff7-347088bcea8c@github.com>
Message-ID: <_okg6UNDAevC038nufO1CjlH0CgHlpV8_hoBTyNp_BY=.f798b319-8bb5-4db6-bcbd-d8e9c7859c0f@github.com>

On Fri, 3 Sep 2021 03:53:55 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added extra instruction for the user
>
> test/jdk/javax/sound/midi/Synthesizer/Receiver/bug6186488.java line 104:
> 
>> 102:     private static void createAndShowTestDialog() {
>> 103:         String testInstruction = "This test verify that software Java Syntesizer processed non-ShortMessage-derived messages. \n" +
>> 104:                 "Click on 'Start Test' button. If you listen a sound then test pass else test fail.";
> 
> Probably it will be useful to ask the user to "Make sure that the speakers are connected and the volume is up."? Some other tests use this suggestion.

Updated instructions to close any sound program and speaker to be connected and increase the volume up.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From serb at openjdk.java.net  Fri Sep  3 18:07:29 2021
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Fri, 3 Sep 2021 18:07:29 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v2]
In-Reply-To: <Vq1IpfqwAvFFq3xjcwavTP9zo_3S7dpAayU13NrUieA=.8520f6f3-2535-4f28-aba1-8d25ef953afc@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
 <Vq1IpfqwAvFFq3xjcwavTP9zo_3S7dpAayU13NrUieA=.8520f6f3-2535-4f28-aba1-8d25ef953afc@github.com>
Message-ID: <DrVxKaF9_3vG1mHRxJyVFm9vSVioh23sOnqBSSTVgj4=.e9702e02-7a42-4887-a5e4-c63f43c7006b@github.com>

On Fri, 3 Sep 2021 13:56:04 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:

>> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
>> 2) After removing =yesno once again test case was failing with following exception
>> ----------System.err:(15/782)----------
>> java.io.IOException: Illegal seek
>> at java.io.FileInputStream.skip(Native Method)
>> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
>> at bug6186488.main(bug6186488.java:36)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:474)
>> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
>> at java.lang.Thread.run(Thread.java:722)
>> 
>> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
>> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
>> 5) Add try-with-resource to close the synth.
>> 
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added extra instruction for the user

test/jdk/javax/sound/midi/Synthesizer/Receiver/bug6186488.java line 2:

> 1: /*
> 2:  * Copyright (c) 2005, 2016, 2021, Oracle and/or its affiliates. All rights reserved.

You don't need a third year, but instead the second year should be updated.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From github.com+87324768+lawrence-andrew at openjdk.java.net  Fri Sep  3 18:10:53 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Fri, 3 Sep 2021 18:10:53 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v3]
In-Reply-To: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
Message-ID: <VUFYLSvziaDdx39_WFcHF2zSwfLHHLuS6LJ77swzmNI=.f4fba1f3-c54e-4405-841b-ec60c742df2a@github.com>

> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
> 2) After removing =yesno once again test case was failing with following exception
> ----------System.err:(15/782)----------
> java.io.IOException: Illegal seek
> at java.io.FileInputStream.skip(Native Method)
> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
> at bug6186488.main(bug6186488.java:36)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:474)
> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
> at java.lang.Thread.run(Thread.java:722)
> 
> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
> 5) Add try-with-resource to close the synth.
> 
> @shurymury

lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:

  Fixed year in copyright

-------------

Changes:
  - all: https://git.openjdk.java.net/jdk/pull/5338/files
  - new: https://git.openjdk.java.net/jdk/pull/5338/files/863171b0..cb6bcd31

Webrevs:
 - full: https://webrevs.openjdk.java.net/?repo=jdk&pr=5338&range=02
 - incr: https://webrevs.openjdk.java.net/?repo=jdk&pr=5338&range=01-02

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.java.net/jdk/pull/5338.diff
  Fetch: git fetch https://git.openjdk.java.net/jdk pull/5338/head:pull/5338

PR: https://git.openjdk.java.net/jdk/pull/5338

From github.com+87324768+lawrence-andrew at openjdk.java.net  Fri Sep  3 18:10:54 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Fri, 3 Sep 2021 18:10:54 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v2]
In-Reply-To: <DrVxKaF9_3vG1mHRxJyVFm9vSVioh23sOnqBSSTVgj4=.e9702e02-7a42-4887-a5e4-c63f43c7006b@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
 <Vq1IpfqwAvFFq3xjcwavTP9zo_3S7dpAayU13NrUieA=.8520f6f3-2535-4f28-aba1-8d25ef953afc@github.com>
 <DrVxKaF9_3vG1mHRxJyVFm9vSVioh23sOnqBSSTVgj4=.e9702e02-7a42-4887-a5e4-c63f43c7006b@github.com>
Message-ID: <nxoeajciah6f8SQuubHVhUq2zaVxEo4m6rup19HTC_c=.8e42e276-a4d5-4aa3-bc48-351654c8c781@github.com>

On Fri, 3 Sep 2021 18:03:58 GMT, Sergey Bylokhov <serb at openjdk.org> wrote:

>> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Added extra instruction for the user
>
> test/jdk/javax/sound/midi/Synthesizer/Receiver/bug6186488.java line 2:
> 
>> 1: /*
>> 2:  * Copyright (c) 2005, 2016, 2021, Oracle and/or its affiliates. All rights reserved.
> 
> You don't need a third year, but instead the second year should be updated.

Updated the year.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From serb at openjdk.java.net  Sat Sep  4 00:31:52 2021
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Sat, 4 Sep 2021 00:31:52 GMT
Subject: <Sound Dev> RFR: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails [v3]
In-Reply-To: <VUFYLSvziaDdx39_WFcHF2zSwfLHHLuS6LJ77swzmNI=.f4fba1f3-c54e-4405-841b-ec60c742df2a@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
 <VUFYLSvziaDdx39_WFcHF2zSwfLHHLuS6LJ77swzmNI=.f4fba1f3-c54e-4405-841b-ec60c742df2a@github.com>
Message-ID: <43RqMUStn_H7hOQH4YpRf9blyVwS_uCNB3dl5lR0-2o=.a447dcd1-3971-4775-bcab-aa59f26f3394@github.com>

On Fri, 3 Sep 2021 18:10:53 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:

>> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
>> 2) After removing =yesno once again test case was failing with following exception
>> ----------System.err:(15/782)----------
>> java.io.IOException: Illegal seek
>> at java.io.FileInputStream.skip(Native Method)
>> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
>> at bug6186488.main(bug6186488.java:36)
>> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
>> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>> at java.lang.reflect.Method.invoke(Method.java:474)
>> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
>> at java.lang.Thread.run(Thread.java:722)
>> 
>> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
>> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
>> 5) Add try-with-resource to close the synth.
>> 
>> @shurymury
>
> lawrence.andrews has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fixed year in copyright

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From serb at openjdk.java.net  Sat Sep  4 00:40:54 2021
From: serb at openjdk.java.net (Sergey Bylokhov)
Date: Sat, 4 Sep 2021 00:40:54 GMT
Subject: <Sound Dev> RFR: 8271603: Unnecessary Vector usage in
 java.desktop [v7]
In-Reply-To: <U-5c4xVAwDMZ9YOUFCwa0lbct7qJwxSVIY9lvdTvfhA=.d848f208-fa13-42d8-b823-38010d59ea19@github.com>
References: <hdHdAw2YkFb3bjjiY9aVTPYa92cFVn0reO2hlZR0vxw=.60aecb76-ae37-47d9-9650-486f5c513455@github.com>
 <U-5c4xVAwDMZ9YOUFCwa0lbct7qJwxSVIY9lvdTvfhA=.d848f208-fa13-42d8-b823-38010d59ea19@github.com>
Message-ID: <ZoOeT3iNtAwqgvhlnASSn0ubSr01rL31fH0vthVB-DM=.daf31df3-7ed2-4ba5-a2ac-1855c481a352@github.com>

On Fri, 3 Sep 2021 08:04:52 GMT, Andrey Turbanov <github.com+741251+turbanoff at openjdk.org> wrote:

>> Usage of thread-safe collection `Vector` is unnecessary. It's recommended to use `ArrayList` if a thread-safe implementation is not needed. In post-BiasedLocking times, this is gets worse, as every access is synchronized.
>> I checked only places where `Vector` was used as local variable.
>
> Andrey Turbanov has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8271603: Unnecessary Vector usage in java.desktop
>   one more place to call toArray with zero-sized array

Marked as reviewed by serb (Reviewer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4680

From github.com+87324768+lawrence-andrew at openjdk.java.net  Sun Sep  5 09:19:57 2021
From: github.com+87324768+lawrence-andrew at openjdk.java.net (lawrence.andrews)
Date: Sun, 5 Sep 2021 09:19:57 GMT
Subject: <Sound Dev> Integrated: 7188098 : TEST_BUG:
 closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails
In-Reply-To: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
References: <yBsyAhpjux7lOIXAiyo2edeluhwNPdI8Cp0q7t0fC6E=.940e3709-fd1e-49cf-acc6-8a02fab73d85@github.com>
Message-ID: <MgoJtZXyseJ3BCZQk1UoLBHVYStEyQkhpnQiYMXyJPU=.1dc7a2fa-9c67-487c-8cdf-f397c056df07@github.com>

On Wed, 1 Sep 2021 17:34:14 GMT, lawrence.andrews <github.com+87324768+lawrence-andrew at openjdk.org> wrote:

> 1) Testcase was failing with Parse Exception: Arguments to `manual' option not supported: yesno due to yesno
> 2) After removing =yesno once again test case was failing with following exception
> ----------System.err:(15/782)----------
> java.io.IOException: Illegal seek
> at java.io.FileInputStream.skip(Native Method)
> at java.io.BufferedInputStream.skip(BufferedInputStream.java:366)
> at bug6186488.main(bug6186488.java:36)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:474)
> at com.sun.javatest.regtest.MainWrapper$MainThread.run(MainWrapper.java:96)
> at java.lang.Thread.run(Thread.java:722)
> 
> 3) If test case is run independently user has to enter y or n to make the test case pass or fail that is when user heard the sound or no. The same action was able to perform via JTREG.  
> 4) Rewrote the testcase . Now user can listen to sound when he press "Start Test" and press "pass"  button if user hears the sound  and press "fail" button when user does not hear the sound. Test UI also shows a timer that get timeout if user does not perform any action.
> 5) Add try-with-resource to close the synth.
> 
> @shurymury

This pull request has now been integrated.

Changeset: c640fe42
Author:    lawrence.andrews <lawrence.andrews at oracle.com>
Committer: Sergey Bylokhov <serb at openjdk.org>
URL:       https://git.openjdk.java.net/jdk/commit/c640fe42c2b5e6668a2a875678be44443942c868
Stats:     182 lines in 1 file changed: 153 ins; 22 del; 7 mod

7188098: TEST_BUG: closed/javax/sound/midi/Synthesizer/Receiver/bug6186488.java fails

Reviewed-by: serb

-------------

PR: https://git.openjdk.java.net/jdk/pull/5338

From philip.race at oracle.com  Wed Sep 15 18:09:03 2021
From: philip.race at oracle.com (Philip Race)
Date: Wed, 15 Sep 2021 11:09:03 -0700
Subject: <Sound Dev> Retiring this sound-dev list on 30th September 2021
In-Reply-To: <a7877f2d-1498-575b-dc70-827996025650@oracle.com>
References: <a7877f2d-1498-575b-dc70-827996025650@oracle.com>
Message-ID: <50e3cd9f-3f58-d51c-a8ce-7fe51481a7d2@oracle.com>

As described below

-Phil.


-------- Forwarded Message --------
Subject: 	Retiring 2d, awt, beans, sound and swing mailing lists on 30th 
September 2021
Date: 	Wed, 15 Sep 2021 11:05:09 -0700
From: 	Philip Race <philip.race at oracle.com>
To: 	client-libs-dev at openjdk.java.net



Since :
1) The old client groups mailing lists were consolidated into 
client-libs-dev at openjdk dot java dot net [1],
including subscribing all subscribers to the old invividual lists to the 
new consolidated list, and
2) The skara github tooling has also migrated to that new list and
3) Folks are already using the new list for questions etc

Then :
I think it is time to plan the retirement of all the old lists :
2d-dev [2], awt-dev [3], beans-dev [4], sound-dev [5], and swing-dev [6]

Accordingly I propose that these five old lists become archived and 
read-only as of 12pm PDT 30th September 2021
and will ask the mail server adminstrators to plan to implement this at 
that time.

I will also forward this information to each of those individual lists.

-Phil Race
Client Libs Group Lead.

[1] https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev
[2] https://mail.openjdk.java.net/mailman/listinfo/2d-dev
[3] https://mail.openjdk.java.net/mailman/listinfo/awt-dev
[4] https://mail.openjdk.java.net/mailman/listinfo/beans-dev
[5] https://mail.openjdk.java.net/mailman/listinfo/sound-dev
[6] https://mail.openjdk.java.net/mailman/listinfo/swing-dev



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/sound-dev/attachments/20210915/e15ee1cc/attachment.htm>

From philip.race at oracle.com  Wed Sep 29 04:03:30 2021
From: philip.race at oracle.com (Philip Race)
Date: Tue, 28 Sep 2021 21:03:30 -0700
Subject: <Sound Dev> Retiring this sound-dev list on 30th September 2021
In-Reply-To: <50e3cd9f-3f58-d51c-a8ce-7fe51481a7d2@oracle.com>
References: <a7877f2d-1498-575b-dc70-827996025650@oracle.com>
 <50e3cd9f-3f58-d51c-a8ce-7fe51481a7d2@oracle.com>
Message-ID: <3955d2e3-a14d-72ed-6cc4-a03ade1131c8@oracle.com>

Reminder.

-phil.

On 9/15/21 11:09 AM, Philip Race wrote:
> As described below
>
> -Phil.
>
>
> -------- Forwarded Message --------
> Subject: 	Retiring 2d, awt, beans, sound and swing mailing lists on 
> 30th September 2021
> Date: 	Wed, 15 Sep 2021 11:05:09 -0700
> From: 	Philip Race <philip.race at oracle.com>
> To: 	client-libs-dev at openjdk.java.net
>
>
>
> Since :
> 1) The old client groups mailing lists were consolidated into 
> client-libs-dev at openjdk dot java dot net [1],
> including subscribing all subscribers to the old invividual lists to 
> the new consolidated list, and
> 2) The skara github tooling has also migrated to that new list and
> 3) Folks are already using the new list for questions etc
>
> Then :
> I think it is time to plan the retirement of all the old lists :
> 2d-dev [2], awt-dev [3], beans-dev [4], sound-dev [5], and swing-dev [6]
>
> Accordingly I propose that these five old lists become archived and 
> read-only as of 12pm PDT 30th September 2021
> and will ask the mail server adminstrators to plan to implement this 
> at that time.
>
> I will also forward this information to each of those individual lists.
>
> -Phil Race
> Client Libs Group Lead.
>
> [1] https://mail.openjdk.java.net/mailman/listinfo/client-libs-dev
> [2] https://mail.openjdk.java.net/mailman/listinfo/2d-dev
> [3] https://mail.openjdk.java.net/mailman/listinfo/awt-dev
> [4] https://mail.openjdk.java.net/mailman/listinfo/beans-dev
> [5] https://mail.openjdk.java.net/mailman/listinfo/sound-dev
> [6] https://mail.openjdk.java.net/mailman/listinfo/swing-dev
>
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/sound-dev/attachments/20210928/a8c68bdc/attachment.htm>