From anton.litvinov at oracle.com  Sun Jun  2 09:30:58 2013
From: anton.litvinov at oracle.com (Anton Litvinov)
Date: Sun, 02 Jun 2013 13:30:58 +0400
Subject: <Swing Dev> [8] Review request for 7151823: The test incorrectly
 recognizing OS
Message-ID: <51AB10D2.7030105@oracle.com>

Hello,

Please review the following fix for the bug.

Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00

The bug consists in the fact that a regression test for the bug 4624207 
cannot define that it is being run on OS X platform, when Aqua L&F is 
not used by Java. The fix substitutes detection of the platform by 
analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method.

Thank you,
Anton


From anton.litvinov at oracle.com  Sun Jun  2 09:56:16 2013
From: anton.litvinov at oracle.com (Anton Litvinov)
Date: Sun, 02 Jun 2013 13:56:16 +0400
Subject: <Swing Dev> [8] Review request for 6337518: Null Arrow Button
 Throws Exception in BasicComboBoxUI
In-Reply-To: <51A8DA63.6050608@oracle.com>
References: <51A8C9D9.5050709@oracle.com> <51A8DA63.6050608@oracle.com>
Message-ID: <51AB16C0.1010109@oracle.com>

Hello Alexander,

Thank you for the review of this fix. Could you please review a new 
version of the fix, which was changed according to your remarks. The 
file name of the regression test was changed to "bug6337518.java" and 
the test was moved to "test/javax/swing/JComboBox" directory.

Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.01

Thank you,
Anton

On 5/31/2013 9:14 PM, Alexander Potochkin wrote:
> Hello Anton
>
> The fix and the test look good,
> only a minor comment
>
> It is a common practice to name the new Swing tests like this:
> /ComponenetName/bugNumber/bugNumber.java
>
> I think it makes sense to follow the known pattern,
> so could you rename**NPEOnInstallComponentsTest folder to "6337518"
>
> by the way, you can safely put the new test under the JComboBox folder
> to avoid creating the new one (but this is up to you)
>
> Thanks
> alexp
>
> On 5/31/2013 8:03 PM, Anton Litvinov wrote:
>> Hello,
>>
>> Please review the following fix for a bug.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6337518
>> Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.00
>>
>> This bug consists in throwing of NullPointerException from the method 
>> "javax.swing.plaf.basic.BasicComboBoxUI.installComponents()", if 
>> "createArrowButton()" method returns null. The solution moves code 
>> generating this exception into a body of an already existing "if" 
>> block which checks the result of a call to "createArrowButton()" 
>> method for null.
>>
>> Thank you,
>> Anton
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20130602/d2edf0e2/attachment.html>

From Sergey.Bylokhov at oracle.com  Sun Jun  2 16:47:20 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Sun, 02 Jun 2013 20:47:20 +0400
Subject: <Swing Dev> [8] Review request for 7151823: The test
 incorrectly recognizing OS
In-Reply-To: <51AB10D2.7030105@oracle.com>
References: <51AB10D2.7030105@oracle.com>
Message-ID: <51AB7718.4000307@oracle.com>

Hi, Anton.
Fix looks good.

On 02.06.2013 13:30, Anton Litvinov wrote:
> Hello,
>
> Please review the following fix for the bug.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
> Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00
>
> The bug consists in the fact that a regression test for the bug 
> 4624207 cannot define that it is being run on OS X platform, when Aqua 
> L&F is not used by Java. The fix substitutes detection of the platform 
> by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method.
>
> Thank you,
> Anton


-- 
Best regards, Sergey.



From alexander.potochkin at oracle.com  Mon Jun  3 09:04:53 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Mon, 03 Jun 2013 13:04:53 +0400
Subject: <Swing Dev> [8] Review request for 7151823: The test
 incorrectly recognizing OS
In-Reply-To: <51AB10D2.7030105@oracle.com>
References: <51AB10D2.7030105@oracle.com>
Message-ID: <51AC5C35.2060004@oracle.com>


Looks good!

Thanks
alexp

On 6/2/2013 1:30 PM, Anton Litvinov wrote:
> Hello,
>
> Please review the following fix for the bug.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
> Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00
>
> The bug consists in the fact that a regression test for the bug 
> 4624207 cannot define that it is being run on OS X platform, when Aqua 
> L&F is not used by Java. The fix substitutes detection of the platform 
> by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method.
>
> Thank you,
> Anton



From alexander.potochkin at oracle.com  Mon Jun  3 09:05:55 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Mon, 03 Jun 2013 13:05:55 +0400
Subject: <Swing Dev> [8] Review request for 6337518: Null Arrow Button
 Throws Exception in BasicComboBoxUI
In-Reply-To: <51AB16C0.1010109@oracle.com>
References: <51A8C9D9.5050709@oracle.com> <51A8DA63.6050608@oracle.com>
	<51AB16C0.1010109@oracle.com>
Message-ID: <51AC5C73.3070308@oracle.com>

Hello Anton

On 6/2/2013 1:56 PM, Anton Litvinov wrote:
> Hello Alexander,
>
> Thank you for the review of this fix. Could you please review a new 
> version of the fix, which was changed according to your remarks. The 
> file name of the regression test was changed to "bug6337518.java" and 
> the test was moved to "test/javax/swing/JComboBox" directory.
>
> Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.01

Thanks much for changing the test!

Looks great now, approved
alexp

>
> Thank you,
> Anton
>
> On 5/31/2013 9:14 PM, Alexander Potochkin wrote:
>> Hello Anton
>>
>> The fix and the test look good,
>> only a minor comment
>>
>> It is a common practice to name the new Swing tests like this:
>> /ComponenetName/bugNumber/bugNumber.java
>>
>> I think it makes sense to follow the known pattern,
>> so could you rename**NPEOnInstallComponentsTest folder to "6337518"
>>
>> by the way, you can safely put the new test under the JComboBox folder
>> to avoid creating the new one (but this is up to you)
>>
>> Thanks
>> alexp
>>
>> On 5/31/2013 8:03 PM, Anton Litvinov wrote:
>>> Hello,
>>>
>>> Please review the following fix for a bug.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6337518
>>> Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.00
>>>
>>> This bug consists in throwing of NullPointerException from the 
>>> method "javax.swing.plaf.basic.BasicComboBoxUI.installComponents()", 
>>> if "createArrowButton()" method returns null. The solution moves 
>>> code generating this exception into a body of an already existing 
>>> "if" block which checks the result of a call to 
>>> "createArrowButton()" method for null.
>>>
>>> Thank you,
>>> Anton
>>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20130603/45c78cb6/attachment.html>

From dmitry.markov at oracle.com  Mon Jun  3 09:09:30 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Mon, 3 Jun 2013 02:09:30 -0700 (PDT)
Subject: <Swing Dev> [7u] Review request for 8014863 Line break
 calculations in Java 7 are incorrect
In-Reply-To: <51A864FF.1040604@oracle.com>
References: <51A864FF.1040604@oracle.com>
Message-ID: <51AC5D4A.3090008@oracle.com>

Hello,

Please review the back-port of the fix for 8014863 to jdk7u. I have 
changed the fix for jdk7u, corrected the calculation of the variable 
'index1' to prevent an IndexOutOfBoundsException.
New webrev is located at 
http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01

bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
technical review for jdk8: 
http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html

Thanks,
Dmitry

On 31/05/2013 12:53, dmitry markov wrote:
> Hello,
>
> Please review the back-port of the fix for 8014863 to jdk7u. The 
> changes are the same.
>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
> webrev for jdk7u-dev: 
> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
> technical review for jdk8: 
> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>
> Thanks,
> Dmitry



From alexandr.scherbatiy at oracle.com  Mon Jun  3 09:39:11 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 03 Jun 2013 13:39:11 +0400
Subject: <Swing Dev> [7u] Review request for 8014863 Line break
 calculations in Java 7 are incorrect
In-Reply-To: <51AC5D4A.3090008@oracle.com>
References: <51A864FF.1040604@oracle.com> <51AC5D4A.3090008@oracle.com>
Message-ID: <51AC643F.7080304@oracle.com>



   Could you test your fix with the Notepad and Stylepad demos and run 
the regression tests:
     jdk\test\javax\swing\text

    Thanks,
    Alexandr.

On 6/3/2013 1:09 PM, dmitry markov wrote:
> Hello,
>
> Please review the back-port of the fix for 8014863 to jdk7u. I have 
> changed the fix for jdk7u, corrected the calculation of the variable 
> 'index1' to prevent an IndexOutOfBoundsException.
> New webrev is located at 
> http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01
>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
> technical review for jdk8: 
> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>
> Thanks,
> Dmitry
>
> On 31/05/2013 12:53, dmitry markov wrote:
>> Hello,
>>
>> Please review the back-port of the fix for 8014863 to jdk7u. The 
>> changes are the same.
>>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>> webrev for jdk7u-dev: 
>> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>> technical review for jdk8: 
>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>
>> Thanks,
>> Dmitry
>



From alexandr.scherbatiy at oracle.com  Mon Jun  3 09:52:15 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 03 Jun 2013 13:52:15 +0400
Subject: <Swing Dev> [8] Review request for 7151823: The test
 incorrectly recognizing OS
In-Reply-To: <51AB10D2.7030105@oracle.com>
References: <51AB10D2.7030105@oracle.com>
Message-ID: <51AC674F.1000905@oracle.com>


The fix looks good for me.

  Next time you could use hitMnemonics() method form the swing 
regtesthelpers Util class that uses system mnemonics keys.

  Thanks,
  Alexandr.


On 6/2/2013 1:30 PM, Anton Litvinov wrote:
> Hello,
>
> Please review the following fix for the bug.
>
> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
> Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00
>
> The bug consists in the fact that a regression test for the bug 
> 4624207 cannot define that it is being run on OS X platform, when Aqua 
> L&F is not used by Java. The fix substitutes detection of the platform 
> by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method.
>
> Thank you,
> Anton



From anton.litvinov at oracle.com  Mon Jun  3 10:12:45 2013
From: anton.litvinov at oracle.com (Anton Litvinov)
Date: Mon, 03 Jun 2013 14:12:45 +0400
Subject: <Swing Dev> [8] Review request for 7151823: The test
 incorrectly recognizing OS
In-Reply-To: <51AC674F.1000905@oracle.com>
References: <51AB10D2.7030105@oracle.com> <51AC674F.1000905@oracle.com>
Message-ID: <51AC6C1D.2060108@oracle.com>

Hello Alexander,

Thank you for the review of this fix and information about 
"hitMnemonics()" method from the class "Util.java". Yes, surely, the 
next time when I need to press mnemonic keys using "java.awt.Robot" I 
will use this method. I supposed that in this particular bug, I had just 
to correct a used way of platform detection.

Thank you,
Anton

On 6/3/2013 1:52 PM, Alexander Scherbatiy wrote:
>
> The fix looks good for me.
>
>  Next time you could use hitMnemonics() method form the swing 
> regtesthelpers Util class that uses system mnemonics keys.
>
>  Thanks,
>  Alexandr.
>
>
> On 6/2/2013 1:30 PM, Anton Litvinov wrote:
>> Hello,
>>
>> Please review the following fix for the bug.
>>
>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7151823
>> Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00
>>
>> The bug consists in the fact that a regression test for the bug 
>> 4624207 cannot define that it is being run on OS X platform, when 
>> Aqua L&F is not used by Java. The fix substitutes detection of the 
>> platform by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" 
>> method.
>>
>> Thank you,
>> Anton
>



From Vladislav.Karnaukhov at oracle.com  Mon Jun  3 11:04:55 2013
From: Vladislav.Karnaukhov at oracle.com (Vladislav Karnaukhov)
Date: Mon, 03 Jun 2013 15:04:55 +0400
Subject: <Swing Dev> [7u] Review request for 6436314: Vector could be
 created with appropriate size in DefaultComboBoxModel
Message-ID: <51AC7857.9050505@oracle.com>

Hello,

please review a request for simple backport into jdk7.

webrev: http://cr.openjdk.java.net/~vkarnauk/6436314/jdk7/webrev.00/
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/791fd2ef87b3

The fix is identical to that in jdk8.

Regards,
- Vlad


From alexandr.scherbatiy at oracle.com  Mon Jun  3 11:31:18 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 03 Jun 2013 15:31:18 +0400
Subject: <Swing Dev> [8] Review request for 6337518: Null Arrow Button
 Throws Exception in BasicComboBoxUI
In-Reply-To: <51AB16C0.1010109@oracle.com>
References: <51A8C9D9.5050709@oracle.com> <51A8DA63.6050608@oracle.com>
	<51AB16C0.1010109@oracle.com>
Message-ID: <51AC7E86.1050505@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/2/2013 1:56 PM, Anton Litvinov wrote:
> Hello Alexander,
>
> Thank you for the review of this fix. Could you please review a new 
> version of the fix, which was changed according to your remarks. The 
> file name of the regression test was changed to "bug6337518.java" and 
> the test was moved to "test/javax/swing/JComboBox" directory.
>
> Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.01
>
> Thank you,
> Anton
>
> On 5/31/2013 9:14 PM, Alexander Potochkin wrote:
>> Hello Anton
>>
>> The fix and the test look good,
>> only a minor comment
>>
>> It is a common practice to name the new Swing tests like this:
>> /ComponenetName/bugNumber/bugNumber.java
>>
>> I think it makes sense to follow the known pattern,
>> so could you rename**NPEOnInstallComponentsTest folder to "6337518"
>>
>> by the way, you can safely put the new test under the JComboBox folder
>> to avoid creating the new one (but this is up to you)
>>
>> Thanks
>> alexp
>>
>> On 5/31/2013 8:03 PM, Anton Litvinov wrote:
>>> Hello,
>>>
>>> Please review the following fix for a bug.
>>>
>>> Bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6337518
>>> Webrev: http://cr.openjdk.java.net/~alitvinov/6337518/webrev.00
>>>
>>> This bug consists in throwing of NullPointerException from the 
>>> method "javax.swing.plaf.basic.BasicComboBoxUI.installComponents()", 
>>> if "createArrowButton()" method returns null. The solution moves 
>>> code generating this exception into a body of an already existing 
>>> "if" block which checks the result of a call to 
>>> "createArrowButton()" method for null.
>>>
>>> Thank you,
>>> Anton
>>
>



From alexandr.scherbatiy at oracle.com  Mon Jun  3 11:32:32 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 03 Jun 2013 15:32:32 +0400
Subject: <Swing Dev> [7u] Review request for 6436314: Vector could be
 created with appropriate size in DefaultComboBoxModel
In-Reply-To: <51AC7857.9050505@oracle.com>
References: <51AC7857.9050505@oracle.com>
Message-ID: <51AC7ED0.2080300@oracle.com>


   The fix looks good for me.

On 6/3/2013 3:04 PM, Vladislav Karnaukhov wrote:
> Hello,
>
> please review a request for simple backport into jdk7.
>
> webrev: http://cr.openjdk.java.net/~vkarnauk/6436314/jdk7/webrev.00/
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/791fd2ef87b3
>
> The fix is identical to that in jdk8.
>
> Regards,
> - Vlad



From dmitry.markov at oracle.com  Mon Jun  3 12:09:15 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Mon, 03 Jun 2013 16:09:15 +0400
Subject: <Swing Dev> [7u] Review request for 8014863 Line break
 calculations in Java 7 are incorrect
In-Reply-To: <51AC643F.7080304@oracle.com>
References: <51A864FF.1040604@oracle.com> <51AC5D4A.3090008@oracle.com>
	<51AC643F.7080304@oracle.com>
Message-ID: <51AC876B.1070002@oracle.com>

Hi Alexandr,

I have just tested the fix. The tests are passed.

Thanks,
Dmitry

On 03/06/2013 13:39, Alexander Scherbatiy wrote:
>
>
>   Could you test your fix with the Notepad and Stylepad demos and run 
> the regression tests:
>     jdk\test\javax\swing\text
>
>    Thanks,
>    Alexandr.
>
> On 6/3/2013 1:09 PM, dmitry markov wrote:
>> Hello,
>>
>> Please review the back-port of the fix for 8014863 to jdk7u. I have 
>> changed the fix for jdk7u, corrected the calculation of the variable 
>> 'index1' to prevent an IndexOutOfBoundsException.
>> New webrev is located at 
>> http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01
>>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>> technical review for jdk8: 
>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>
>> Thanks,
>> Dmitry
>>
>> On 31/05/2013 12:53, dmitry markov wrote:
>>> Hello,
>>>
>>> Please review the back-port of the fix for 8014863 to jdk7u. The 
>>> changes are the same.
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>> webrev for jdk7u-dev: 
>>> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
>>> jdk8 changeset: 
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>> technical review for jdk8: 
>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>
>>> Thanks,
>>> Dmitry
>>
>



From Vladislav.Karnaukhov at oracle.com  Mon Jun  3 13:53:19 2013
From: Vladislav.Karnaukhov at oracle.com (Vladislav Karnaukhov)
Date: Mon, 03 Jun 2013 17:53:19 +0400
Subject: <Swing Dev> [7u] Review request for 7068740: If you wrap a JTable
 in a JLayer you can't use the page up and page down cmds
Message-ID: <51AC9FCF.8010906@oracle.com>

Hello,

could you please review a request for a backport into jdk7? The fix is 
identical to that in jdk8.

webrev: http://cr.openjdk.java.net/~vkarnauk/7068740/jdk7/webrev.00/
jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4356b90f57d

Regards,
- Vlad


From alexandr.scherbatiy at oracle.com  Mon Jun  3 14:19:05 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 03 Jun 2013 18:19:05 +0400
Subject: <Swing Dev> [7u] Review request for 8014863 Line break
 calculations in Java 7 are incorrect
In-Reply-To: <51AC876B.1070002@oracle.com>
References: <51A864FF.1040604@oracle.com> <51AC5D4A.3090008@oracle.com>
	<51AC643F.7080304@oracle.com> <51AC876B.1070002@oracle.com>
Message-ID: <51ACA5D9.8020907@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/3/2013 4:09 PM, dmitry markov wrote:
> Hi Alexandr,
>
> I have just tested the fix. The tests are passed.
>
> Thanks,
> Dmitry
>
> On 03/06/2013 13:39, Alexander Scherbatiy wrote:
>>
>>
>>   Could you test your fix with the Notepad and Stylepad demos and run 
>> the regression tests:
>>     jdk\test\javax\swing\text
>>
>>    Thanks,
>>    Alexandr.
>>
>> On 6/3/2013 1:09 PM, dmitry markov wrote:
>>> Hello,
>>>
>>> Please review the back-port of the fix for 8014863 to jdk7u. I have 
>>> changed the fix for jdk7u, corrected the calculation of the variable 
>>> 'index1' to prevent an IndexOutOfBoundsException.
>>> New webrev is located at 
>>> http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>> jdk8 changeset: 
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>> technical review for jdk8: 
>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>
>>> Thanks,
>>> Dmitry
>>>
>>> On 31/05/2013 12:53, dmitry markov wrote:
>>>> Hello,
>>>>
>>>> Please review the back-port of the fix for 8014863 to jdk7u. The 
>>>> changes are the same.
>>>>
>>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>>> webrev for jdk7u-dev: 
>>>> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
>>>> jdk8 changeset: 
>>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>>> technical review for jdk8: 
>>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>>
>>>> Thanks,
>>>> Dmitry
>>>
>>
>



From alexandr.scherbatiy at oracle.com  Mon Jun  3 14:27:10 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 3 Jun 2013 07:27:10 -0700 (PDT)
Subject: <Swing Dev> [7u] Review request for 7068740: If you wrap a
 JTable in a JLayer you can't use the page up and page down cmds
In-Reply-To: <51AC9FCF.8010906@oracle.com>
References: <51AC9FCF.8010906@oracle.com>
Message-ID: <51ACA7BE.3080008@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/3/2013 5:53 PM, Vladislav Karnaukhov wrote:
> Hello,
>
> could you please review a request for a backport into jdk7? The fix is 
> identical to that in jdk8.
>
> webrev: http://cr.openjdk.java.net/~vkarnauk/7068740/jdk7/webrev.00/
> jdk8 changeset: http://hg.openjdk.java.net/jdk8/awt/jdk/rev/a4356b90f57d
>
> Regards,
> - Vlad



From sergey.malenkov at oracle.com  Mon Jun  3 16:10:14 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Mon, 03 Jun 2013 20:10:14 +0400
Subject: <Swing Dev> [8] Review request for 8013370: Null pointer exception
 when adding more than 9 accelators to a JMenuBar
Message-ID: <51ACBFE6.7050209@oracle.com>

Hello,

Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 
<http://cr.openjdk.java.net/%7Emalenkov/8013370.8.0/>
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013370

This is a regression after the 6680988fix.

Note, that it is regression in 7 and the fix should be ported to 7u.

Thanks,
SAM


From Sergey.Bylokhov at oracle.com  Mon Jun  3 18:26:34 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 03 Jun 2013 22:26:34 +0400
Subject: <Swing Dev> [8] Review request for 8013370: Null pointer
 exception when adding more than 9 accelators to a JMenuBar
In-Reply-To: <51ACBFE6.7050209@oracle.com>
References: <51ACBFE6.7050209@oracle.com>
Message-ID: <51ACDFDA.4040603@oracle.com>

Hi, Sergey.
Looks like copyright header is incorrect in the test.

On 03.06.2013 20:10, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 
> <http://cr.openjdk.java.net/%7Emalenkov/8013370.8.0/>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013370
>
> This is a regression after the 6680988fix.
>
> Note, that it is regression in 7 and the fix should be ported to 7u.
>
> Thanks,
> SAM


-- 
Best regards, Sergey.



From sergey.malenkov at oracle.com  Tue Jun  4 09:15:14 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Tue, 04 Jun 2013 13:15:14 +0400
Subject: <Swing Dev> [8] Review request for 8013370: Null pointer
 exception when adding more than 9 accelators to a JMenuBar
In-Reply-To: <51ACDFDA.4040603@oracle.com>
References: <51ACBFE6.7050209@oracle.com> <51ACDFDA.4040603@oracle.com>
Message-ID: <51ADB022.2070306@oracle.com>

Hi Sergey,

I've added a copyright header to the test:
http://cr.openjdk.java.net/~malenkov/8013370.8.1/ 
<http://cr.openjdk.java.net/%7Emalenkov/8013370.8.1/>

Thanks,
SAM

On 03.06.2013 22:26, Sergey Bylokhov wrote:
> Hi, Sergey.
> Looks like copyright header is incorrect in the test.
>
> On 03.06.2013 20:10, sergey malenkov wrote:
>> Hello,
>>
>> Could you please review the following fix:
>> fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 
>> <http://cr.openjdk.java.net/%7Emalenkov/8013370.8.0/>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013370
>>
>> This is a regression after the 6680988fix.
>>
>> Note, that it is regression in 7 and the fix should be ported to 7u.
>>
>> Thanks,
>> SAM
>
>



From alexander.potochkin at oracle.com  Tue Jun  4 11:30:33 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Tue, 04 Jun 2013 15:30:33 +0400
Subject: <Swing Dev> [7u] Review request for 8014863 Line break
 calculations in Java 7 are incorrect
In-Reply-To: <51AC876B.1070002@oracle.com>
References: <51A864FF.1040604@oracle.com> <51AC5D4A.3090008@oracle.com>
	<51AC643F.7080304@oracle.com> <51AC876B.1070002@oracle.com>
Message-ID: <51ADCFD9.8090401@oracle.com>

Hello Dmitry

looks good!

Thanks
alexp

On 6/3/2013 4:09 PM, dmitry markov wrote:
> Hi Alexandr,
>
> I have just tested the fix. The tests are passed.
>
> Thanks,
> Dmitry
>
> On 03/06/2013 13:39, Alexander Scherbatiy wrote:
>>
>>
>>   Could you test your fix with the Notepad and Stylepad demos and run 
>> the regression tests:
>>     jdk\test\javax\swing\text
>>
>>    Thanks,
>>    Alexandr.
>>
>> On 6/3/2013 1:09 PM, dmitry markov wrote:
>>> Hello,
>>>
>>> Please review the back-port of the fix for 8014863 to jdk7u. I have 
>>> changed the fix for jdk7u, corrected the calculation of the variable 
>>> 'index1' to prevent an IndexOutOfBoundsException.
>>> New webrev is located at 
>>> http://cr.openjdk.java.net/~alitvinov/8014863/webrev.01
>>>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>> jdk8 changeset: 
>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>> technical review for jdk8: 
>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>
>>> Thanks,
>>> Dmitry
>>>
>>> On 31/05/2013 12:53, dmitry markov wrote:
>>>> Hello,
>>>>
>>>> Please review the back-port of the fix for 8014863 to jdk7u. The 
>>>> changes are the same.
>>>>
>>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8014863
>>>> webrev for jdk7u-dev: 
>>>> http://cr.openjdk.java.net/~vkarnauk/8014863/jdk7/webrev.00/
>>>> jdk8 changeset: 
>>>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/c8a0abc1fd2d
>>>> technical review for jdk8: 
>>>> http://mail.openjdk.java.net/pipermail/swing-dev/2013-May/002709.html
>>>>
>>>> Thanks,
>>>> Dmitry
>>>
>>
>



From dmitry.markov at oracle.com  Tue Jun  4 13:52:21 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Tue, 04 Jun 2013 17:52:21 +0400
Subject: <Swing Dev> [8] Review request for 8015853:
 java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo
Message-ID: <51ADF115.2050308@oracle.com>

Hello,

Could you review the fix:
     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015853
     webrev: http://cr.openjdk.java.net/~vkarnauk/8015853/webrev.00/

The calculation of index1 variable in the View.forwardUpdate() method is 
not correct. The method getViewCount() should be used instead of 
getViewIndex() to calculate the correct index1 value.

Thanks,
Dmitry.


From Sergey.Bylokhov at oracle.com  Tue Jun  4 14:04:47 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 04 Jun 2013 18:04:47 +0400
Subject: <Swing Dev> [8] Review request for 8013370: Null pointer
 exception when adding more than 9 accelators to a JMenuBar
In-Reply-To: <51ACDFDA.4040603@oracle.com>
References: <51ACBFE6.7050209@oracle.com> <51ACDFDA.4040603@oracle.com>
Message-ID: <51ADF3FF.4010204@oracle.com>

Thanks.
Fix looks good.

On 03.06.2013 22:26, Sergey Bylokhov wrote:
> Hi, Sergey.
> Looks like copyright header is incorrect in the test.
>
> On 03.06.2013 20:10, sergey malenkov wrote:
>> Hello,
>>
>> Could you please review the following fix:
>> fix: http://cr.openjdk.java.net/~malenkov/8013370.8.0 
>> <http://cr.openjdk.java.net/%7Emalenkov/8013370.8.0/>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013370
>>
>> This is a regression after the 6680988fix.
>>
>> Note, that it is regression in 7 and the fix should be ported to 7u.
>>
>> Thanks,
>> SAM
>
>


-- 
Best regards, Sergey.



From konstantin.shefov at oracle.com  Wed Jun  5 14:05:55 2013
From: konstantin.shefov at oracle.com (Konstantin Shefov)
Date: Wed, 05 Jun 2013 18:05:55 +0400
Subject: <Swing Dev> [8] Review request for CR 7184908 TEST_BUG:
 [macosx] closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails
In-Reply-To: <51A4CEF5.8050301@oracle.com>
References: <51A4CEF5.8050301@oracle.com>
Message-ID: <51AF45C3.5050104@oracle.com>

Reminder. Please, review a test bug fix
On 28-May-13 19:36, Konstantin Shefov wrote:
> Hello,
>
> Please review a fix for the issue:
>
> 7184908 TEST_BUG: [macosx] 
> closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails
>
> Test bug fix. Move from closed to openjdk repo.
>
> http://bugs.sun.com/view_bug.do?bug_id=7184908
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.00
> Diff is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.closed.open
>
> Thanks,
> Konstantin



From Sergey.Bylokhov at oracle.com  Thu Jun  6 10:07:16 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 06 Jun 2013 14:07:16 +0400
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B056B0.5010201@gmail.com>
References: <51B056B0.5010201@gmail.com>
Message-ID: <51B05F54.1040300@oracle.com>

Hi, Andreas.
This is a known issue in the latest jdk8 build.
JDK-8015853

On 06.06.2013 13:30, Andreas Rieber wrote:
> Hi,
>
> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both the 
> jconsole throws now exceptions. It did work the day before. OS ubuntu 
> 12.04.
>
> Andreas
>
> Exception in thread "AWT-EventQueue-0" 
> java.lang.ArrayIndexOutOfBoundsException: 11
>     at javax.swing.text.CompositeView.getView(CompositeView.java:160)
>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>     at javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>     at javax.swing.text.View.changedUpdate(View.java:788)
>     at javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>     at javax.swing.text.View.changedUpdate(View.java:788)
>     at javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>     at javax.swing.text.View.changedUpdate(View.java:788)
>     at javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>     at 
> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>     at 
> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>     at 
> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>     at 
> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>     at 
> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>     at 
> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>     at javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>     at 
> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>     at sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>     at 
> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>     at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>     at java.security.AccessController.doPrivileged(Native Method)
>     at 
> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>     at 
> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
> ...
>
>


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Thu Jun  6 10:10:43 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 06 Jun 2013 14:10:43 +0400
Subject: <Swing Dev> [8] Review request for 8015853:
 java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo
In-Reply-To: <51ADF115.2050308@oracle.com>
References: <51ADF115.2050308@oracle.com>
Message-ID: <51B06023.70903@oracle.com>

Hi, Dmitry.

   24  * @test
   25  * @bug 8015853
   26  * @summary  Tests the rendering of a large HTML document
   27  * @author Dmitry Markov
   28  * @run main bug8015853

I suggest to remove this tags from the txt files.

On 04.06.2013 17:52, dmitry markov wrote:
> Hello,
>
> Could you review the fix:
>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015853
>     webrev: http://cr.openjdk.java.net/~vkarnauk/8015853/webrev.00/
>
> The calculation of index1 variable in the View.forwardUpdate() method 
> is not correct. The method getViewCount() should be used instead of 
> getViewIndex() to calculate the correct index1 value.
>
> Thanks,
> Dmitry.


-- 
Best regards, Sergey.



From konstantin.shefov at oracle.com  Thu Jun  6 10:25:10 2013
From: konstantin.shefov at oracle.com (Konstantin Shefov)
Date: Thu, 06 Jun 2013 14:25:10 +0400
Subject: <Swing Dev> [8] Review request for CR 7105030 [TEST_BUG] [macosx]
 The tests never finishes
Message-ID: <51B06386.4060102@oracle.com>

Hello,

Please review a fix for the issue:

7105030 [TEST_BUG] [macosx] The tests never finishes

Test bug fix. Fix and move from closed to open JDK.

http://bugs.sun.com/view_bug.do?bug_id=7105030

The webrev is: http://cr.openjdk.java.net/~kshefov/7105030/webrev.00
The diff with closed is: 
http://cr.openjdk.java.net/~kshefov/7105030/webrev.diff

Thanks,
Konstantin


From Sergey.Bylokhov at oracle.com  Thu Jun  6 10:29:53 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 06 Jun 2013 14:29:53 +0400
Subject: <Swing Dev> [8] Review request for CR 7105030 [TEST_BUG]
 [macosx] The tests never finishes
In-Reply-To: <51B06386.4060102@oracle.com>
References: <51B06386.4060102@oracle.com>
Message-ID: <51B064A1.5030601@oracle.com>

Hi, Konstantin.
Fix looks good.

On 06.06.2013 14:25, Konstantin Shefov wrote:
> Hello,
>
> Please review a fix for the issue:
>
> 7105030 [TEST_BUG] [macosx] The tests never finishes
>
> Test bug fix. Fix and move from closed to open JDK.
>
> http://bugs.sun.com/view_bug.do?bug_id=7105030
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/7105030/webrev.00
> The diff with closed is: 
> http://cr.openjdk.java.net/~kshefov/7105030/webrev.diff
>
> Thanks,
> Konstantin


-- 
Best regards, Sergey.



From dmitry.markov at oracle.com  Thu Jun  6 12:43:41 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Thu, 06 Jun 2013 16:43:41 +0400
Subject: <Swing Dev> [8] Review request for 8015853:
 java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo
In-Reply-To: <51B06023.70903@oracle.com>
References: <51ADF115.2050308@oracle.com> <51B06023.70903@oracle.com>
Message-ID: <51B083FD.8030200@oracle.com>

Hi, Sergey,

I removed the tags, as you requested.
Please find new webrev at: 
http://cr.openjdk.java.net/~dmarkov/8015853/webrev.01/

Thanks,
Dmitry

On 06/06/2013 14:10, Sergey Bylokhov wrote:
> Hi, Dmitry.
>
>   24  * @test
>   25  * @bug 8015853
>   26  * @summary  Tests the rendering of a large HTML document
>   27  * @author Dmitry Markov
>   28  * @run main bug8015853
>
> I suggest to remove this tags from the txt files.
>
> On 04.06.2013 17:52, dmitry markov wrote:
>> Hello,
>>
>> Could you review the fix:
>>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015853
>>     webrev: http://cr.openjdk.java.net/~vkarnauk/8015853/webrev.00/
>>
>> The calculation of index1 variable in the View.forwardUpdate() method 
>> is not correct. The method getViewCount() should be used instead of 
>> getViewIndex() to calculate the correct index1 value.
>>
>> Thanks,
>> Dmitry.
>
>



From Sergey.Bylokhov at oracle.com  Thu Jun  6 12:58:03 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 06 Jun 2013 16:58:03 +0400
Subject: <Swing Dev> [8] Review request for 8015853:
 java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo
In-Reply-To: <51B083FD.8030200@oracle.com>
References: <51ADF115.2050308@oracle.com> <51B06023.70903@oracle.com>
	<51B083FD.8030200@oracle.com>
Message-ID: <51B0875B.7080401@oracle.com>

Fix looks good to me.

On 06.06.2013 16:43, dmitry markov wrote:
> Hi, Sergey,
>
> I removed the tags, as you requested.
> Please find new webrev at: 
> http://cr.openjdk.java.net/~dmarkov/8015853/webrev.01/
>
> Thanks,
> Dmitry
>
> On 06/06/2013 14:10, Sergey Bylokhov wrote:
>> Hi, Dmitry.
>>
>>   24  * @test
>>   25  * @bug 8015853
>>   26  * @summary  Tests the rendering of a large HTML document
>>   27  * @author Dmitry Markov
>>   28  * @run main bug8015853
>>
>> I suggest to remove this tags from the txt files.
>>
>> On 04.06.2013 17:52, dmitry markov wrote:
>>> Hello,
>>>
>>> Could you review the fix:
>>>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015853
>>>     webrev: http://cr.openjdk.java.net/~vkarnauk/8015853/webrev.00/
>>>
>>> The calculation of index1 variable in the View.forwardUpdate() 
>>> method is not correct. The method getViewCount() should be used 
>>> instead of getViewIndex() to calculate the correct index1 value.
>>>
>>> Thanks,
>>> Dmitry.
>>
>>
>


-- 
Best regards, Sergey.



From alexander.potochkin at oracle.com  Thu Jun  6 13:20:29 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Thu, 6 Jun 2013 06:20:29 -0700 (PDT)
Subject: <Swing Dev> [8] Review request for 8015853:
 java.lang.ArrayIndexOutOfBoundsException when running SwingSet2 demo
In-Reply-To: <51B083FD.8030200@oracle.com>
References: <51ADF115.2050308@oracle.com> <51B06023.70903@oracle.com>
	<51B083FD.8030200@oracle.com>
Message-ID: <51B08C9D.7040103@oracle.com>

Hello Dmitry

Looks good!

Thanks
alexp

> Hi, Sergey,
>
> I removed the tags, as you requested.
> Please find new webrev at: 
> http://cr.openjdk.java.net/~dmarkov/8015853/webrev.01/
>
> Thanks,
> Dmitry
>
> On 06/06/2013 14:10, Sergey Bylokhov wrote:
>> Hi, Dmitry.
>>
>>   24  * @test
>>   25  * @bug 8015853
>>   26  * @summary  Tests the rendering of a large HTML document
>>   27  * @author Dmitry Markov
>>   28  * @run main bug8015853
>>
>> I suggest to remove this tags from the txt files.
>>
>> On 04.06.2013 17:52, dmitry markov wrote:
>>> Hello,
>>>
>>> Could you review the fix:
>>>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015853
>>>     webrev: http://cr.openjdk.java.net/~vkarnauk/8015853/webrev.00/
>>>
>>> The calculation of index1 variable in the View.forwardUpdate() 
>>> method is not correct. The method getViewCount() should be used 
>>> instead of getViewIndex() to calculate the correct index1 value.
>>>
>>> Thanks,
>>> Dmitry.
>>
>>
>



From sergey.malenkov at oracle.com  Thu Jun  6 17:02:31 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Thu, 06 Jun 2013 21:02:31 +0400
Subject: <Swing Dev> [8] Review request for 8015336: BasicComboBoxEditor
	throws NullPointerException
Message-ID: <51B0C0A7.3070103@oracle.com>

Hello,

Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8015336.8.0/ 
<http://cr.openjdk.java.net/%7Emalenkov/8015336.8.0/>
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015336 
<http://cr.openjdk.java.net/%7Emalenkov/8015336.8.0/>

This is a rare situation when toString() returns null.

Thanks,
SAM


From rieberandreas at gmail.com  Fri Jun  7 10:58:45 2013
From: rieberandreas at gmail.com (Andreas Rieber)
Date: Fri, 07 Jun 2013 12:58:45 +0200
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B060DE.1050802@gmail.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com>
Message-ID: <51B1BCE5.3040008@gmail.com>

Hi Sergey,

it is actually the change from JDK-8014863 causing the new exceptions. 
When i comment that line out the exceptions are gone.

Andreas

changeset:   7194:c8a0abc1fd2d
user:        mcherkas
date:        Wed May 29 18:40:02 2013 +0400
summary:     8014863: Line break calculations in Java 7 are incorrect.

diff -r 1f0628078531 -r c8a0abc1fd2d 
src/share/classes/javax/swing/text/View.java
--- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
12:10:49 2013 +0400
+++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
18:40:02 2013 +0400
@@ -1,5 +1,5 @@
  /*
- * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights 
reserved.
+ * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights 
reserved.
   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
   *
   * This code is free software; you can redistribute it and/or modify it
@@ -1174,6 +1174,7 @@
          // formed by added elements (i.e. they will be updated
          // by initialization.
          index0 = Math.max(index0, 0);
+        index1 = getViewIndex(elem.getDocument().getLength(), 
Position.Bias.Forward);
          for (int i = index0; i <= index1; i++) {
              if (! ((i >= hole0) && (i <= hole1))) {
                  v = getView(i);




On 06.06.13 12:13, Andreas Rieber wrote:
> OK, thanks. i didn't find that issue.
>
> On 06.06.13 12:07, Sergey Bylokhov wrote:
>> Hi, Andreas.
>> This is a known issue in the latest jdk8 build.
>> JDK-8015853
>>
>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>> Hi,
>>>
>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both the 
>>> jconsole throws now exceptions. It did work the day before. OS 
>>> ubuntu 12.04.
>>>
>>> Andreas
>>>
>>> Exception in thread "AWT-EventQueue-0" 
>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>     at javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>     at 
>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>     at 
>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>     at 
>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>     at 
>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>     at 
>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>     at 
>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>     at 
>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>     at 
>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>     at 
>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>     at 
>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>     at javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>     at 
>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>     at 
>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>     at 
>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>     at 
>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>     at 
>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>     at 
>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>> ...
>>>


From alexandr.scherbatiy at oracle.com  Fri Jun  7 13:57:01 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 7 Jun 2013 06:57:01 -0700 (PDT)
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1BCE5.3040008@gmail.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
Message-ID: <51B1E6AD.3050403@oracle.com>

On 6/7/2013 2:58 PM, Andreas Rieber wrote:
> Hi Sergey,
>
> it is actually the change from JDK-8014863 causing the new exceptions. 
> When i comment that line out the exceptions are gone.
>

     The issue 8014863 should be already fixed in JDK 8: 
hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752

     Could you update the sources and rebuilt it.

    Thanks,
    Alexandr.

> Andreas
>
> changeset:   7194:c8a0abc1fd2d
> user:        mcherkas
> date:        Wed May 29 18:40:02 2013 +0400
> summary:     8014863: Line break calculations in Java 7 are incorrect.
>
> diff -r 1f0628078531 -r c8a0abc1fd2d 
> src/share/classes/javax/swing/text/View.java
> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
> 12:10:49 2013 +0400
> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
> 18:40:02 2013 +0400
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All rights 
> reserved.
> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All rights 
> reserved.
>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>   *
>   * This code is free software; you can redistribute it and/or modify it
> @@ -1174,6 +1174,7 @@
>          // formed by added elements (i.e. they will be updated
>          // by initialization.
>          index0 = Math.max(index0, 0);
> +        index1 = getViewIndex(elem.getDocument().getLength(), 
> Position.Bias.Forward);
>          for (int i = index0; i <= index1; i++) {
>              if (! ((i >= hole0) && (i <= hole1))) {
>                  v = getView(i);
>
>
>
>
> On 06.06.13 12:13, Andreas Rieber wrote:
>> OK, thanks. i didn't find that issue.
>>
>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>> Hi, Andreas.
>>> This is a known issue in the latest jdk8 build.
>>> JDK-8015853
>>>
>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>> Hi,
>>>>
>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>> the jconsole throws now exceptions. It did work the day before. OS 
>>>> ubuntu 12.04.
>>>>
>>>> Andreas
>>>>
>>>> Exception in thread "AWT-EventQueue-0" 
>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>     at javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>     at 
>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>     at 
>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>     at 
>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>     at 
>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>     at 
>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>     at 
>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>     at 
>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>     at 
>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>     at 
>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>     at 
>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>     at 
>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>     at 
>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>     at 
>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>     at 
>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>     at 
>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>     at 
>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>     at 
>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>> ...
>>>>



From rieberandreas at gmail.com  Fri Jun  7 14:04:18 2013
From: rieberandreas at gmail.com (Andreas Rieber)
Date: Fri, 07 Jun 2013 16:04:18 +0200
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1E6AD.3050403@oracle.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com>
Message-ID: <51B1E862.4010807@gmail.com>

Hi Alexander,

i know that this fix is in, but it causes now the mentioned exceptions. 
In case of jconsole it pops up the error window with the exception all 
the time.
So i commented that fix out and the exceptions stop, meaning the fix 
causes just other problems (also JDK-8015853).

Andreas


On 07.06.13 15:57, Alexander Scherbatiy wrote:
> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>> Hi Sergey,
>>
>> it is actually the change from JDK-8014863 causing the new 
>> exceptions. When i comment that line out the exceptions are gone.
>>
>
>     The issue 8014863 should be already fixed in JDK 8: 
> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>
>     Could you update the sources and rebuilt it.
>
>    Thanks,
>    Alexandr.
>
>> Andreas
>>
>> changeset:   7194:c8a0abc1fd2d
>> user:        mcherkas
>> date:        Wed May 29 18:40:02 2013 +0400
>> summary:     8014863: Line break calculations in Java 7 are incorrect.
>>
>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>> src/share/classes/javax/swing/text/View.java
>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>> 12:10:49 2013 +0400
>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>> 18:40:02 2013 +0400
>> @@ -1,5 +1,5 @@
>>  /*
>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>> rights reserved.
>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>> rights reserved.
>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>   *
>>   * This code is free software; you can redistribute it and/or modify it
>> @@ -1174,6 +1174,7 @@
>>          // formed by added elements (i.e. they will be updated
>>          // by initialization.
>>          index0 = Math.max(index0, 0);
>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>> Position.Bias.Forward);
>>          for (int i = index0; i <= index1; i++) {
>>              if (! ((i >= hole0) && (i <= hole1))) {
>>                  v = getView(i);
>>
>>
>>
>>
>> On 06.06.13 12:13, Andreas Rieber wrote:
>>> OK, thanks. i didn't find that issue.
>>>
>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>> Hi, Andreas.
>>>> This is a known issue in the latest jdk8 build.
>>>> JDK-8015853
>>>>
>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>> Hi,
>>>>>
>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>>> the jconsole throws now exceptions. It did work the day before. OS 
>>>>> ubuntu 12.04.
>>>>>
>>>>> Andreas
>>>>>
>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>     at javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>     at 
>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>     at 
>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>     at 
>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>     at 
>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>     at 
>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>     at 
>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>     at 
>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>     at 
>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>     at 
>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>     at 
>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>     at 
>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>     at 
>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>     at 
>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>     at 
>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>     at 
>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>     at 
>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>     at 
>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>> ...
>>>>>
>



From alexandr.scherbatiy at oracle.com  Fri Jun  7 14:02:42 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 7 Jun 2013 07:02:42 -0700 (PDT)
Subject: <Swing Dev> [8] Review request for CR 7105030 [TEST_BUG]
 [macosx] The tests never finishes
In-Reply-To: <51B06386.4060102@oracle.com>
References: <51B06386.4060102@oracle.com>
Message-ID: <51B1E802.8000407@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/6/2013 2:25 PM, Konstantin Shefov wrote:
> Hello,
>
> Please review a fix for the issue:
>
> 7105030 [TEST_BUG] [macosx] The tests never finishes
>
> Test bug fix. Fix and move from closed to open JDK.
>
> http://bugs.sun.com/view_bug.do?bug_id=7105030
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/7105030/webrev.00
> The diff with closed is: 
> http://cr.openjdk.java.net/~kshefov/7105030/webrev.diff
>
> Thanks,
> Konstantin



From alexandr.scherbatiy at oracle.com  Fri Jun  7 14:29:55 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 07 Jun 2013 18:29:55 +0400
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1E862.4010807@gmail.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com> <51B1E862.4010807@gmail.com>
Message-ID: <51B1EE63.4000706@oracle.com>

On 6/7/2013 6:04 PM, Andreas Rieber wrote:
> Hi Alexander,
>
> i know that this fix is in, but it causes now the mentioned 
> exceptions. In case of jconsole it pops up the error window with the 
> exception all the time.
> So i commented that fix out and the exceptions stop, meaning the fix 
> causes just other problems (also JDK-8015853).

    It is strange. I just rebuild the JDK 8 with the index1 that is 
calculated as
        index1 = Math.max((getViewCount() - 1), 0);
    and run jconsole on Ubuntu.  I do not see the 
ArrayIndexOutOfBoundsException.

   Could you give more details bout the jconsole exception. Is it thrown 
just after the jconsole starting or do I need to connect to a process 
and select a tab?

   Thanks,
   Alexandr.

>
> Andreas
>
>
> On 07.06.13 15:57, Alexander Scherbatiy wrote:
>> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>>> Hi Sergey,
>>>
>>> it is actually the change from JDK-8014863 causing the new 
>>> exceptions. When i comment that line out the exceptions are gone.
>>>
>>
>>     The issue 8014863 should be already fixed in JDK 8: 
>> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>>
>>     Could you update the sources and rebuilt it.
>>
>>    Thanks,
>>    Alexandr.
>>
>>> Andreas
>>>
>>> changeset:   7194:c8a0abc1fd2d
>>> user:        mcherkas
>>> date:        Wed May 29 18:40:02 2013 +0400
>>> summary:     8014863: Line break calculations in Java 7 are incorrect.
>>>
>>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>>> src/share/classes/javax/swing/text/View.java
>>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>> 12:10:49 2013 +0400
>>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>> 18:40:02 2013 +0400
>>> @@ -1,5 +1,5 @@
>>>  /*
>>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>>> rights reserved.
>>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>>> rights reserved.
>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>   *
>>>   * This code is free software; you can redistribute it and/or 
>>> modify it
>>> @@ -1174,6 +1174,7 @@
>>>          // formed by added elements (i.e. they will be updated
>>>          // by initialization.
>>>          index0 = Math.max(index0, 0);
>>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>>> Position.Bias.Forward);
>>>          for (int i = index0; i <= index1; i++) {
>>>              if (! ((i >= hole0) && (i <= hole1))) {
>>>                  v = getView(i);
>>>
>>>
>>>
>>>
>>> On 06.06.13 12:13, Andreas Rieber wrote:
>>>> OK, thanks. i didn't find that issue.
>>>>
>>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>>> Hi, Andreas.
>>>>> This is a known issue in the latest jdk8 build.
>>>>> JDK-8015853
>>>>>
>>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>>> Hi,
>>>>>>
>>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>>>> the jconsole throws now exceptions. It did work the day before. 
>>>>>> OS ubuntu 12.04.
>>>>>>
>>>>>> Andreas
>>>>>>
>>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>>     at 
>>>>>> javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at 
>>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>     at 
>>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>>     at 
>>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>>     at 
>>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>>     at 
>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>>     at 
>>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>>     at 
>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>>     at 
>>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>>     at 
>>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>>     at 
>>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>>> ...
>>>>>>
>>
>



From rieberandreas at gmail.com  Fri Jun  7 15:42:20 2013
From: rieberandreas at gmail.com (Andreas Rieber)
Date: Fri, 07 Jun 2013 17:42:20 +0200
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1EE63.4000706@oracle.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com> <51B1E862.4010807@gmail.com>
	<51B1EE63.4000706@oracle.com>
Message-ID: <51B1FF5C.1040301@gmail.com>

Hi Alexander,

you need to connect to a process. I used a tomcat but any other has same 
problem. The exception details are below in the followups.

Andreas

On 07.06.13 16:29, Alexander Scherbatiy wrote:
> On 6/7/2013 6:04 PM, Andreas Rieber wrote:
>> Hi Alexander,
>>
>> i know that this fix is in, but it causes now the mentioned 
>> exceptions. In case of jconsole it pops up the error window with the 
>> exception all the time.
>> So i commented that fix out and the exceptions stop, meaning the fix 
>> causes just other problems (also JDK-8015853).
>
>    It is strange. I just rebuild the JDK 8 with the index1 that is 
> calculated as
>        index1 = Math.max((getViewCount() - 1), 0);
>    and run jconsole on Ubuntu.  I do not see the 
> ArrayIndexOutOfBoundsException.
>
>   Could you give more details bout the jconsole exception. Is it 
> thrown just after the jconsole starting or do I need to connect to a 
> process and select a tab?
>
>   Thanks,
>   Alexandr.
>
>>
>> Andreas
>>
>>
>> On 07.06.13 15:57, Alexander Scherbatiy wrote:
>>> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>>>> Hi Sergey,
>>>>
>>>> it is actually the change from JDK-8014863 causing the new 
>>>> exceptions. When i comment that line out the exceptions are gone.
>>>>
>>>
>>>     The issue 8014863 should be already fixed in JDK 8: 
>>> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>>>
>>>     Could you update the sources and rebuilt it.
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>>> Andreas
>>>>
>>>> changeset:   7194:c8a0abc1fd2d
>>>> user:        mcherkas
>>>> date:        Wed May 29 18:40:02 2013 +0400
>>>> summary:     8014863: Line break calculations in Java 7 are incorrect.
>>>>
>>>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>>>> src/share/classes/javax/swing/text/View.java
>>>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>> 12:10:49 2013 +0400
>>>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>> 18:40:02 2013 +0400
>>>> @@ -1,5 +1,5 @@
>>>>  /*
>>>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>>>> rights reserved.
>>>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>>>> rights reserved.
>>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>>   *
>>>>   * This code is free software; you can redistribute it and/or 
>>>> modify it
>>>> @@ -1174,6 +1174,7 @@
>>>>          // formed by added elements (i.e. they will be updated
>>>>          // by initialization.
>>>>          index0 = Math.max(index0, 0);
>>>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>>>> Position.Bias.Forward);
>>>>          for (int i = index0; i <= index1; i++) {
>>>>              if (! ((i >= hole0) && (i <= hole1))) {
>>>>                  v = getView(i);
>>>>
>>>>
>>>>
>>>>
>>>> On 06.06.13 12:13, Andreas Rieber wrote:
>>>>> OK, thanks. i didn't find that issue.
>>>>>
>>>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>>>> Hi, Andreas.
>>>>>> This is a known issue in the latest jdk8 build.
>>>>>> JDK-8015853
>>>>>>
>>>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>>>>> the jconsole throws now exceptions. It did work the day before. 
>>>>>>> OS ubuntu 12.04.
>>>>>>>
>>>>>>> Andreas
>>>>>>>
>>>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>>>     at 
>>>>>>> javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>     at 
>>>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>>>     at 
>>>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>>>     at 
>>>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>>>     at 
>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>>>     at 
>>>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>>>     at 
>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>>>     at 
>>>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>>>     at 
>>>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>>>     at 
>>>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>>>> ...
>>>>>>>
>>>
>>
>



From dmitry.markov at oracle.com  Mon Jun 10 09:58:32 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Mon, 10 Jun 2013 13:58:32 +0400
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1FF5C.1040301@gmail.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com> <51B1E862.4010807@gmail.com>
	<51B1EE63.4000706@oracle.com> <51B1FF5C.1040301@gmail.com>
Message-ID: <51B5A348.6000607@oracle.com>

Hi Andreas,

I built JDK 8 with the fix made under 8015853 and ran jconsole as you 
described below (connect to the process, etc.). I did not observe any 
ArrayIndexOutOfBoundsException.

It seems to me, you have to replace the following line:
     index1 = getViewIndex(elem.getDocument().getLength(), 
Position.Bias.Forward);
by this one
     index1 = Math.max((getViewCount() - 1), 0);
and then re-build the JDK 8. This should fix the problem with 
ArrayIndexOutOfBoundsException.

Thanks,
Dmitry

On 07/06/2013 19:42, Andreas Rieber wrote:
> Hi Alexander,
>
> you need to connect to a process. I used a tomcat but any other has 
> same problem. The exception details are below in the followups.
>
> Andreas
>
> On 07.06.13 16:29, Alexander Scherbatiy wrote:
>> On 6/7/2013 6:04 PM, Andreas Rieber wrote:
>>> Hi Alexander,
>>>
>>> i know that this fix is in, but it causes now the mentioned 
>>> exceptions. In case of jconsole it pops up the error window with the 
>>> exception all the time.
>>> So i commented that fix out and the exceptions stop, meaning the fix 
>>> causes just other problems (also JDK-8015853).
>>
>>    It is strange. I just rebuild the JDK 8 with the index1 that is 
>> calculated as
>>        index1 = Math.max((getViewCount() - 1), 0);
>>    and run jconsole on Ubuntu.  I do not see the 
>> ArrayIndexOutOfBoundsException.
>>
>>   Could you give more details bout the jconsole exception. Is it 
>> thrown just after the jconsole starting or do I need to connect to a 
>> process and select a tab?
>>
>>   Thanks,
>>   Alexandr.
>>
>>>
>>> Andreas
>>>
>>>
>>> On 07.06.13 15:57, Alexander Scherbatiy wrote:
>>>> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>>>>> Hi Sergey,
>>>>>
>>>>> it is actually the change from JDK-8014863 causing the new 
>>>>> exceptions. When i comment that line out the exceptions are gone.
>>>>>
>>>>
>>>>     The issue 8014863 should be already fixed in JDK 8: 
>>>> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>>>>
>>>>     Could you update the sources and rebuilt it.
>>>>
>>>>    Thanks,
>>>>    Alexandr.
>>>>
>>>>> Andreas
>>>>>
>>>>> changeset:   7194:c8a0abc1fd2d
>>>>> user:        mcherkas
>>>>> date:        Wed May 29 18:40:02 2013 +0400
>>>>> summary:     8014863: Line break calculations in Java 7 are 
>>>>> incorrect.
>>>>>
>>>>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>>>>> src/share/classes/javax/swing/text/View.java
>>>>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>>> 12:10:49 2013 +0400
>>>>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>>> 18:40:02 2013 +0400
>>>>> @@ -1,5 +1,5 @@
>>>>>  /*
>>>>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>>>>> rights reserved.
>>>>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>>>>> rights reserved.
>>>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>>>   *
>>>>>   * This code is free software; you can redistribute it and/or 
>>>>> modify it
>>>>> @@ -1174,6 +1174,7 @@
>>>>>          // formed by added elements (i.e. they will be updated
>>>>>          // by initialization.
>>>>>          index0 = Math.max(index0, 0);
>>>>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>>>>> Position.Bias.Forward);
>>>>>          for (int i = index0; i <= index1; i++) {
>>>>>              if (! ((i >= hole0) && (i <= hole1))) {
>>>>>                  v = getView(i);
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On 06.06.13 12:13, Andreas Rieber wrote:
>>>>>> OK, thanks. i didn't find that issue.
>>>>>>
>>>>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>>>>> Hi, Andreas.
>>>>>>> This is a known issue in the latest jdk8 build.
>>>>>>> JDK-8015853
>>>>>>>
>>>>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in 
>>>>>>>> both the jconsole throws now exceptions. It did work the day 
>>>>>>>> before. OS ubuntu 12.04.
>>>>>>>>
>>>>>>>> Andreas
>>>>>>>>
>>>>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>>>>     at 
>>>>>>>> javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>>     at 
>>>>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>>>>     at 
>>>>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>>>>     at 
>>>>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>>>>     at 
>>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>>>>     at 
>>>>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>>>>     at 
>>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>>>>     at 
>>>>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>>>>     at 
>>>>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>>>>     at 
>>>>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>>>>> ...
>>>>>>>>
>>>>
>>>
>>
>



From alexandr.scherbatiy at oracle.com  Mon Jun 10 10:56:48 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 10 Jun 2013 14:56:48 +0400
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B1E862.4010807@gmail.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com> <51B1E862.4010807@gmail.com>
Message-ID: <51B5B0F0.1070108@oracle.com>

On 6/7/2013 6:04 PM, Andreas Rieber wrote:
> Hi Alexander,
>
> i know that this fix is in, but it causes now the mentioned 
> exceptions. In case of jconsole it pops up the error window with the 
> exception all the time.
> So i commented that fix out and the exceptions stop, meaning the fix 
> causes just other problems (also JDK-8015853).

    The JDK-8015853 "java.lang.ArrayIndexOutOfBoundsException when 
running SwingSet2 demo" issue has been already fixed:
       hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752

   Could you check that you see the ArrayIndexOutOfBoundsException with 
this fix also?

   Thanks,
   Alexandr.

>
> Andreas
>
>
> On 07.06.13 15:57, Alexander Scherbatiy wrote:
>> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>>> Hi Sergey,
>>>
>>> it is actually the change from JDK-8014863 causing the new 
>>> exceptions. When i comment that line out the exceptions are gone.
>>>
>>
>>     The issue 8014863 should be already fixed in JDK 8: 
>> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>>
>>     Could you update the sources and rebuilt it.
>>
>>    Thanks,
>>    Alexandr.
>>
>>> Andreas
>>>
>>> changeset:   7194:c8a0abc1fd2d
>>> user:        mcherkas
>>> date:        Wed May 29 18:40:02 2013 +0400
>>> summary:     8014863: Line break calculations in Java 7 are incorrect.
>>>
>>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>>> src/share/classes/javax/swing/text/View.java
>>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>> 12:10:49 2013 +0400
>>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>> 18:40:02 2013 +0400
>>> @@ -1,5 +1,5 @@
>>>  /*
>>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>>> rights reserved.
>>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>>> rights reserved.
>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>   *
>>>   * This code is free software; you can redistribute it and/or 
>>> modify it
>>> @@ -1174,6 +1174,7 @@
>>>          // formed by added elements (i.e. they will be updated
>>>          // by initialization.
>>>          index0 = Math.max(index0, 0);
>>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>>> Position.Bias.Forward);
>>>          for (int i = index0; i <= index1; i++) {
>>>              if (! ((i >= hole0) && (i <= hole1))) {
>>>                  v = getView(i);
>>>
>>>
>>>
>>>
>>> On 06.06.13 12:13, Andreas Rieber wrote:
>>>> OK, thanks. i didn't find that issue.
>>>>
>>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>>> Hi, Andreas.
>>>>> This is a known issue in the latest jdk8 build.
>>>>> JDK-8015853
>>>>>
>>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>>> Hi,
>>>>>>
>>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>>>> the jconsole throws now exceptions. It did work the day before. 
>>>>>> OS ubuntu 12.04.
>>>>>>
>>>>>> Andreas
>>>>>>
>>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>>     at 
>>>>>> javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at 
>>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>     at 
>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>     at 
>>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>>     at 
>>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>>     at 
>>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>>     at 
>>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>>     at 
>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>>     at 
>>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>>     at 
>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>>     at 
>>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>>     at 
>>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>>     at 
>>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>>> ...
>>>>>>
>>
>



From alexandr.scherbatiy at oracle.com  Mon Jun 10 11:12:57 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 10 Jun 2013 15:12:57 +0400
Subject: <Swing Dev> [8] Review request for 8015336: BasicComboBoxEditor
 throws NullPointerException
In-Reply-To: <51B0C0A7.3070103@oracle.com>
References: <51B0C0A7.3070103@oracle.com>
Message-ID: <51B5B4B9.2000207@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/6/2013 9:02 PM, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8015336.8.0/ 
> <http://cr.openjdk.java.net/%7Emalenkov/8015336.8.0/>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8015336 
> <http://cr.openjdk.java.net/%7Emalenkov/8015336.8.0/>
>
> This is a rare situation when toString() returns null.
>
> Thanks,
> SAM



From rieberandreas at gmail.com  Mon Jun 10 12:14:03 2013
From: rieberandreas at gmail.com (Andreas Rieber)
Date: Mon, 10 Jun 2013 14:14:03 +0200
Subject: <Swing Dev> jconsole exceptions
In-Reply-To: <51B5B0F0.1070108@oracle.com>
References: <51B056B0.5010201@gmail.com> <51B05F54.1040300@oracle.com>
	<51B060DE.1050802@gmail.com> <51B1BCE5.3040008@gmail.com>
	<51B1E6AD.3050403@oracle.com> <51B1E862.4010807@gmail.com>
	<51B5B0F0.1070108@oracle.com>
Message-ID: <51B5C30B.2070105@gmail.com>

Hi Alexander and Dmitry,

i just did a clean build of jdk8 with that fix and the jconsole 
exceptions are gone.

thanks
Andreas

On 10.06.13 12:56, Alexander Scherbatiy wrote:
> On 6/7/2013 6:04 PM, Andreas Rieber wrote:
>> Hi Alexander,
>>
>> i know that this fix is in, but it causes now the mentioned 
>> exceptions. In case of jconsole it pops up the error window with the 
>> exception all the time.
>> So i commented that fix out and the exceptions stop, meaning the fix 
>> causes just other problems (also JDK-8015853).
>
>    The JDK-8015853 "java.lang.ArrayIndexOutOfBoundsException when 
> running SwingSet2 demo" issue has been already fixed:
>       hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>
>   Could you check that you see the ArrayIndexOutOfBoundsException with 
> this fix also?
>
>   Thanks,
>   Alexandr.
>
>>
>> Andreas
>>
>>
>> On 07.06.13 15:57, Alexander Scherbatiy wrote:
>>> On 6/7/2013 2:58 PM, Andreas Rieber wrote:
>>>> Hi Sergey,
>>>>
>>>> it is actually the change from JDK-8014863 causing the new 
>>>> exceptions. When i comment that line out the exceptions are gone.
>>>>
>>>
>>>     The issue 8014863 should be already fixed in JDK 8: 
>>> hg.openjdk.java.net/jdk8/awt/jdk/rev/cb7f711e1752
>>>
>>>     Could you update the sources and rebuilt it.
>>>
>>>    Thanks,
>>>    Alexandr.
>>>
>>>> Andreas
>>>>
>>>> changeset:   7194:c8a0abc1fd2d
>>>> user:        mcherkas
>>>> date:        Wed May 29 18:40:02 2013 +0400
>>>> summary:     8014863: Line break calculations in Java 7 are incorrect.
>>>>
>>>> diff -r 1f0628078531 -r c8a0abc1fd2d 
>>>> src/share/classes/javax/swing/text/View.java
>>>> --- a/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>> 12:10:49 2013 +0400
>>>> +++ b/src/share/classes/javax/swing/text/View.java    Wed May 29 
>>>> 18:40:02 2013 +0400
>>>> @@ -1,5 +1,5 @@
>>>>  /*
>>>> - * Copyright (c) 1997, 2011, Oracle and/or its affiliates. All 
>>>> rights reserved.
>>>> + * Copyright (c) 1997, 2013, Oracle and/or its affiliates. All 
>>>> rights reserved.
>>>>   * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
>>>>   *
>>>>   * This code is free software; you can redistribute it and/or 
>>>> modify it
>>>> @@ -1174,6 +1174,7 @@
>>>>          // formed by added elements (i.e. they will be updated
>>>>          // by initialization.
>>>>          index0 = Math.max(index0, 0);
>>>> +        index1 = getViewIndex(elem.getDocument().getLength(), 
>>>> Position.Bias.Forward);
>>>>          for (int i = index0; i <= index1; i++) {
>>>>              if (! ((i >= hole0) && (i <= hole1))) {
>>>>                  v = getView(i);
>>>>
>>>>
>>>>
>>>>
>>>> On 06.06.13 12:13, Andreas Rieber wrote:
>>>>> OK, thanks. i didn't find that issue.
>>>>>
>>>>> On 06.06.13 12:07, Sergey Bylokhov wrote:
>>>>>> Hi, Andreas.
>>>>>> This is a known issue in the latest jdk8 build.
>>>>>> JDK-8015853
>>>>>>
>>>>>> On 06.06.2013 13:30, Andreas Rieber wrote:
>>>>>>> Hi,
>>>>>>>
>>>>>>> i did a new build 1 hour ago of latest jdk8 and jdk8-tl, in both 
>>>>>>> the jconsole throws now exceptions. It did work the day before. 
>>>>>>> OS ubuntu 12.04.
>>>>>>>
>>>>>>> Andreas
>>>>>>>
>>>>>>> Exception in thread "AWT-EventQueue-0" 
>>>>>>> java.lang.ArrayIndexOutOfBoundsException: 11
>>>>>>>     at 
>>>>>>> javax.swing.text.CompositeView.getView(CompositeView.java:160)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1151)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.TableView.forwardUpdate(TableView.java:894)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.TableView.changedUpdate(TableView.java:889)
>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>     at javax.swing.text.View.forwardUpdateToView(View.java:1212)
>>>>>>>     at javax.swing.text.View.forwardUpdate(View.java:1183)
>>>>>>>     at javax.swing.text.BoxView.forwardUpdate(BoxView.java:240)
>>>>>>>     at javax.swing.text.View.changedUpdate(View.java:788)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.BlockView.changedUpdate(BlockView.java:341)
>>>>>>>     at 
>>>>>>> javax.swing.plaf.basic.BasicTextUI$RootView.changedUpdate(BasicTextUI.java:1630)
>>>>>>>     at 
>>>>>>> javax.swing.plaf.basic.BasicTextUI$UpdateHandler.changedUpdate(BasicTextUI.java:1891)
>>>>>>>     at 
>>>>>>> javax.swing.text.AbstractDocument.fireChangedUpdate(AbstractDocument.java:230)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument.fireChangedUpdate(HTMLDocument.java:1729)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.adjustEndElement(HTMLDocument.java:2470)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLDocument$HTMLReader.flush(HTMLDocument.java:2525)
>>>>>>>     at 
>>>>>>> javax.swing.text.html.HTMLEditorKit.read(HTMLEditorKit.java:263)
>>>>>>>     at javax.swing.JEditorPane.setText(JEditorPane.java:1415)
>>>>>>>     at sun.tools.jconsole.HTMLPane.setText(HTMLPane.java:62)
>>>>>>>     at sun.tools.jconsole.SummaryTab$1.done(SummaryTab.java:95)
>>>>>>>     at javax.swing.SwingWorker$5.run(SwingWorker.java:737)
>>>>>>>     at 
>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.run(SwingWorker.java:832)
>>>>>>>     at 
>>>>>>> sun.swing.AccumulativeRunnable.run(AccumulativeRunnable.java:112)
>>>>>>>     at 
>>>>>>> javax.swing.SwingWorker$DoSubmitAccumulativeRunnable.actionPerformed(SwingWorker.java:842)
>>>>>>>     at javax.swing.Timer.fireActionPerformed(Timer.java:313)
>>>>>>>     at javax.swing.Timer$DoPostEvent.run(Timer.java:245)
>>>>>>>     at 
>>>>>>> java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:251)
>>>>>>>     at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:726)
>>>>>>>     at java.awt.EventQueue.access$200(EventQueue.java:103)
>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:687)
>>>>>>>     at java.awt.EventQueue$3.run(EventQueue.java:685)
>>>>>>>     at java.security.AccessController.doPrivileged(Native Method)
>>>>>>>     at 
>>>>>>> java.security.ProtectionDomain$1.doIntersectionPrivilege(ProtectionDomain.java:75)
>>>>>>>     at java.awt.EventQueue.dispatchEvent(EventQueue.java:696)
>>>>>>>     at 
>>>>>>> java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:220)
>>>>>>> ...
>>>>>>>
>>>
>>
>



From konstantin.shefov at oracle.com  Tue Jun 11 09:43:28 2013
From: konstantin.shefov at oracle.com (Konstantin Shefov)
Date: Tue, 11 Jun 2013 13:43:28 +0400
Subject: <Swing Dev> [8] Review request for CR 7184908 TEST_BUG: [macosx]
 closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails
Message-ID: <51B6F140.6070603@oracle.com>

Hello,

Please review a fix for the issue:

7184908 TEST_BUG: [macosx] 
closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails

Test bug fix. Move from closed to openjdk repo.

http://bugs.sun.com/view_bug.do?bug_id=7184908

The webrev is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.00
Diff is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.closed.open

Thanks,
Konstantin


From Sergey.Bylokhov at oracle.com  Tue Jun 11 09:46:46 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 11 Jun 2013 13:46:46 +0400
Subject: <Swing Dev> [8] Review request for CR 7184908 TEST_BUG:
 [macosx] closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails
In-Reply-To: <51B6F140.6070603@oracle.com>
References: <51B6F140.6070603@oracle.com>
Message-ID: <51B6F206.6030405@oracle.com>

Hi, Konstantin.
Fix looks good.

On 11.06.2013 13:43, Konstantin Shefov wrote:
> Hello,
>
> Please review a fix for the issue:
>
> 7184908 TEST_BUG: [macosx] 
> closed/com/sun/java/swing/plaf/gtk/4928019/bug4928019.java fails
>
> Test bug fix. Move from closed to openjdk repo.
>
> http://bugs.sun.com/view_bug.do?bug_id=7184908
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.00
> Diff is: http://cr.openjdk.java.net/~kshefov/7184908/webrev.closed.open
>
> Thanks,
> Konstantin


-- 
Best regards, Sergey.



From sergey.malenkov at oracle.com  Fri Jun 14 16:42:37 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Fri, 14 Jun 2013 20:42:37 +0400
Subject: <Swing Dev> [8] Review request for 8013571: TreeModelEvent doesn't
 accept " null " for root as Javadoc specifies.
Message-ID: <51BB47FD.5070506@oracle.com>

Hello,

Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8013571.8.0 
<http://cr.openjdk.java.net/%7Emalenkov/8013571.8.0/>
bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013571

The behavior fixed according to JavaDoc.

Thanks,
SAM


From alexandr.scherbatiy at oracle.com  Mon Jun 17 11:29:06 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 17 Jun 2013 15:29:06 +0400
Subject: <Swing Dev> [8] Review request for 8013571: TreeModelEvent
 doesn't accept " null " for root as Javadoc specifies.
In-Reply-To: <51BB47FD.5070506@oracle.com>
References: <51BB47FD.5070506@oracle.com>
Message-ID: <51BEF302.7030607@oracle.com>

On 6/14/2013 8:42 PM, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8013571.8.0 
> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.0/>
> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013571

    It is better to move the "TreePath getTreePath(TreeModelEvent 
event)"  method to sun.swing.SwingUtilities2 class.

    All others looks good for me.

   Thanks,
   Alexandr.
>
> The behavior fixed according to JavaDoc.
>
> Thanks,
> SAM



From sergey.malenkov at oracle.com  Mon Jun 17 13:45:42 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Mon, 17 Jun 2013 17:45:42 +0400
Subject: <Swing Dev> [8] Review request for 8013571: TreeModelEvent
 doesn't accept " null " for root as Javadoc specifies.
In-Reply-To: <51BEF302.7030607@oracle.com>
References: <51BB47FD.5070506@oracle.com> <51BEF302.7030607@oracle.com>
Message-ID: <51BF1306.7030902@oracle.com>


On 17.06.2013 15:29, Alexander Scherbatiy wrote:
> On 6/14/2013 8:42 PM, sergey malenkov wrote:
>> Could you please review the following fix:
>> fix: http://cr.openjdk.java.net/~malenkov/8013571.8.0 
>> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.0/>
>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013571
>
>    It is better to move the "TreePath getTreePath(TreeModelEvent 
> event)"  method to sun.swing.SwingUtilities2 class.

Could you please review the second version of the fix:
http://cr.openjdk.java.net/~malenkov/8013571.8.1 
<http://cr.openjdk.java.net/%7Emalenkov/8013571.8.1/>
I moved the getTreePath method to the SwingUtilities2 class
with needed changes in it.

Thanks,
SAM


From alexandr.scherbatiy at oracle.com  Mon Jun 17 14:03:33 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Mon, 17 Jun 2013 18:03:33 +0400
Subject: <Swing Dev> [8] Review request for 8013571: TreeModelEvent
 doesn't accept " null " for root as Javadoc specifies.
In-Reply-To: <51BF1306.7030902@oracle.com>
References: <51BB47FD.5070506@oracle.com> <51BEF302.7030607@oracle.com>
	<51BF1306.7030902@oracle.com>
Message-ID: <51BF1735.9050908@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/17/2013 5:45 PM, sergey malenkov wrote:
>
> On 17.06.2013 15:29, Alexander Scherbatiy wrote:
>> On 6/14/2013 8:42 PM, sergey malenkov wrote:
>>> Could you please review the following fix:
>>> fix: http://cr.openjdk.java.net/~malenkov/8013571.8.0 
>>> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.0/>
>>> bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013571
>>
>>    It is better to move the "TreePath getTreePath(TreeModelEvent 
>> event)"  method to sun.swing.SwingUtilities2 class.
>
> Could you please review the second version of the fix:
> http://cr.openjdk.java.net/~malenkov/8013571.8.1 
> <http://cr.openjdk.java.net/%7Emalenkov/8013571.8.1/>
> I moved the getTreePath method to the SwingUtilities2 class
> with needed changes in it.
>
> Thanks,
> SAM



From sergey.malenkov at oracle.com  Tue Jun 18 13:09:54 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Tue, 18 Jun 2013 17:09:54 +0400
Subject: <Swing Dev> [8] Review request for 8013442: No file filter selected
 in file type combo box when using JFileChooser
Message-ID: <51C05C22.9040001@oracle.com>

Hello,

Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8013442.8.0/ 
<http://cr.openjdk.java.net/%7Emalenkov/8013442.8.0/>
bug: 
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013442<https://jbs.oracle.com/bugs/browse/JDK-8013442>

Actually, blank filter must not be selected by default.
To show all files the setAcceptAllFileFilterUsed property must be set.
This fix updates the selected filter correctly if it is removed.

Thanks,
SAM


From alexandr.scherbatiy at oracle.com  Wed Jun 19 09:58:34 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 19 Jun 2013 13:58:34 +0400
Subject: <Swing Dev> [8] Review request for 8013442: No file filter
 selected in file type combo box when using JFileChooser
In-Reply-To: <51C05C22.9040001@oracle.com>
References: <51C05C22.9040001@oracle.com>
Message-ID: <51C180CA.2070900@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 6/18/2013 5:09 PM, sergey malenkov wrote:
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8013442.8.0/ 
> <http://cr.openjdk.java.net/%7Emalenkov/8013442.8.0/>
> bug: 
> http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8013442<https://jbs.oracle.com/bugs/browse/JDK-8013442>
>
> Actually, blank filter must not be selected by default.
> To show all files the setAcceptAllFileFilterUsed property must be set.
> This fix updates the selected filter correctly if it is removed.
>
> Thanks,
> SAM



From konstantin.shefov at oracle.com  Wed Jun 19 10:01:48 2013
From: konstantin.shefov at oracle.com (Konstantin Shefov)
Date: Wed, 19 Jun 2013 14:01:48 +0400
Subject: <Swing Dev> [8] Review request for CR 8006087 [TEST_BUG] The
 BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button,
 the case pass automatically.
Message-ID: <51C1818C.5090001@oracle.com>

Hello,

Please review a fix for the issue:

8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 
'cancel' and 'DONE' button, the case pass automatically.

Test bug fix.

http://bugs.sun.com/view_bug.do?bug_id=8006087

The webrev is: http://cr.openjdk.java.net/~kshefov/8006087/webrev.00

Thanks,
Konstantin


From alexandr.scherbatiy at oracle.com  Wed Jun 19 14:17:44 2013
From: alexandr.scherbatiy at oracle.com (Alexandr Scherbatiy)
Date: Wed, 19 Jun 2013 18:17:44 +0400
Subject: <Swing Dev> [8] Review request for CR 8006087 [TEST_BUG] The
 BACKSPACE key doesn't work and after pressing 'cancel' and 'DONE' button,
 the case pass automatically.
In-Reply-To: <51C1818C.5090001@oracle.com>
References: <51C1818C.5090001@oracle.com>
Message-ID: <51C1BD88.4040801@oracle.com>

The fix looks good for me.

Thanks,
Alexandr.

19.06.2013 14:01, Konstantin Shefov ?????:
> Hello,
>
> Please review a fix for the issue:
>
> 8006087 [TEST_BUG] The BACKSPACE key doesn't work and after pressing 
> 'cancel' and 'DONE' button, the case pass automatically.
>
> Test bug fix.
>
> http://bugs.sun.com/view_bug.do?bug_id=8006087
>
> The webrev is: http://cr.openjdk.java.net/~kshefov/8006087/webrev.00
>
> Thanks,
> Konstantin



From anton.nashatyrev at oracle.com  Thu Jun 20 10:41:35 2013
From: anton.nashatyrev at oracle.com (anton nashatyrev)
Date: Thu, 20 Jun 2013 14:41:35 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
Message-ID: <51C2DC5F.9060709@oracle.com>

Hello,
     could you please review the following fix:

fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
<http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
bug: http://bugs.sun.com/view_bug.do?bug_id=8016833

The reason of such behavior is that the superscripted GlyphView requested
increased vertical span, since the alignment of value 1.0
(GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to paint 
it as
high as required.
(BTW, for subscripted text setting the alignment is enough)

GlyphView.paintTextUsingColor() calculates the Y position of the underscore
as following:

   int y = alloc.y + alloc.height - (int) painter.getDescent(this);

but here alloc.height means the space _reserved_ for glyphs and not the
actual boundary of the painted text. To fix that we need to substitute
alloc.height with painter.getHeight(this).

The fix looks safe since the GlyphView preferred vertical span is initially
requested from the GlyphPainter.

Thanks!
Anton.


From dmitry.markov at oracle.com  Thu Jun 20 10:49:27 2013
From: dmitry.markov at oracle.com (dmitry markov)
Date: Thu, 20 Jun 2013 14:49:27 +0400
Subject: <Swing Dev> [8] Review request for 8016534:
 javax/swing/text/View/8014863/bug8014863.java failed
Message-ID: <51C2DE37.8050809@oracle.com>

Hello,

Could you review the fix:
     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016534
     webrev: http://cr.openjdk.java.net/~dmarkov/8016534/webrev.00/

The fix adds a calculation of the frame's width which is based on the 
font metrics for the current OS.

Thanks,
Dmitry


From alexandr.scherbatiy at oracle.com  Thu Jun 20 14:57:05 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 20 Jun 2013 18:57:05 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C2DC5F.9060709@oracle.com>
References: <51C2DC5F.9060709@oracle.com>
Message-ID: <51C31841.30703@oracle.com>

On 6/20/2013 2:41 PM, anton nashatyrev wrote:
> Hello,
>     could you please review the following fix:
>
> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>
     It seem that there is the same problem with the background color:
         Style style = comp.addStyle("underlined superscript", null);
         StyleConstants.setBackground(style, Color.BLUE);
         ...
             doc.insertString(doc.getLength(), "hello", style);

     because paint(Graphics g, Shape a) method in GlyphView uses the 
alloc.height in the same way.


   Could invoke all Swing methods on EDT and remove the comments from 
the test:

  266 //        bug8016833 b = new bug8016833();
  267 //        b.demo();

Thanks,
    Alexandr.

> The reason of such behavior is that the superscripted GlyphView requested
> increased vertical span, since the alignment of value 1.0
> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to paint 
> it as
> high as required.
> (BTW, for subscripted text setting the alignment is enough)
>
> GlyphView.paintTextUsingColor() calculates the Y position of the 
> underscore
> as following:
>
>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>
> but here alloc.height means the space _reserved_ for glyphs and not the
> actual boundary of the painted text. To fix that we need to substitute
> alloc.height with painter.getHeight(this).
>
> The fix looks safe since the GlyphView preferred vertical span is 
> initially
> requested from the GlyphPainter.
>
> Thanks!
> Anton.



From alexandr.scherbatiy at oracle.com  Thu Jun 20 15:01:05 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 20 Jun 2013 19:01:05 +0400
Subject: <Swing Dev> [8] Review request for 8016534:
 javax/swing/text/View/8014863/bug8014863.java failed
In-Reply-To: <51C2DE37.8050809@oracle.com>
References: <51C2DE37.8050809@oracle.com>
Message-ID: <51C31931.3030706@oracle.com>

  The fix looks good for me.

  Thanks,
  Alexandr.

On 6/20/2013 2:49 PM, dmitry markov wrote:
> Hello,
>
> Could you review the fix:
>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016534
>     webrev: http://cr.openjdk.java.net/~dmarkov/8016534/webrev.00/
>
> The fix adds a calculation of the frame's width which is based on the 
> font metrics for the current OS.
>
> Thanks,
> Dmitry



From anton.nashatyrev at oracle.com  Fri Jun 21 11:00:08 2013
From: anton.nashatyrev at oracle.com (anton nashatyrev)
Date: Fri, 21 Jun 2013 15:00:08 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C31841.30703@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
Message-ID: <51C43238.3090709@oracle.com>

Hello, Alexander,

     thanks for your suggestion, though I'm not sure drawing a 
background has the same semantics as drawing underline. The latter may 
be though of as a part of glyph while for background it is ok to 
'highlight' the space _reserved_ for a View. Also the taller highlight 
is almost not visible to a user comparing to incorrectly painted underline.
     I'd prefer either not to fix this at all or at least not to include 
the fix to this customer issue.

     Had fixed the EDT issue in the test.

Thanks,
Anton.

On 20.06.2013 18:57, Alexander Scherbatiy wrote:
> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>> Hello,
>>     could you please review the following fix:
>>
>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>
>     It seem that there is the same problem with the background color:
>         Style style = comp.addStyle("underlined superscript", null);
>         StyleConstants.setBackground(style, Color.BLUE);
>         ...
>             doc.insertString(doc.getLength(), "hello", style);
>
>     because paint(Graphics g, Shape a) method in GlyphView uses the 
> alloc.height in the same way.
>
>
>   Could invoke all Swing methods on EDT and remove the comments from 
> the test:
>
>  266 //        bug8016833 b = new bug8016833();
>  267 //        b.demo();
>
> Thanks,
>    Alexandr.
>
>> The reason of such behavior is that the superscripted GlyphView 
>> requested
>> increased vertical span, since the alignment of value 1.0
>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>> paint it as
>> high as required.
>> (BTW, for subscripted text setting the alignment is enough)
>>
>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>> underscore
>> as following:
>>
>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>
>> but here alloc.height means the space _reserved_ for glyphs and not the
>> actual boundary of the painted text. To fix that we need to substitute
>> alloc.height with painter.getHeight(this).
>>
>> The fix looks safe since the GlyphView preferred vertical span is 
>> initially
>> requested from the GlyphPainter.
>>
>> Thanks!
>> Anton.
>
>
>



From alexandr.scherbatiy at oracle.com  Fri Jun 21 11:16:55 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 21 Jun 2013 15:16:55 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C43238.3090709@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com>
Message-ID: <51C43627.7030507@oracle.com>

On 6/21/2013 3:00 PM, anton nashatyrev wrote:
> Hello, Alexander,
>
>     thanks for your suggestion, though I'm not sure drawing a 
> background has the same semantics as drawing underline. The latter may 
> be though of as a part of glyph while for background it is ok to 
> 'highlight' the space _reserved_ for a View. Also the taller highlight 
> is almost not visible to a user comparing to incorrectly painted 
> underline.
>     I'd prefer either not to fix this at all or at least not to 
> include the fix to this customer issue.
       It could be filled as a separate issue.
>
>     Had fixed the EDT issue in the test.
    Could you send the updated webrev?

    Thanks,
    Alexandr.
>
> Thanks,
> Anton.
>
> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>> Hello,
>>>     could you please review the following fix:
>>>
>>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>
>>     It seem that there is the same problem with the background color:
>>         Style style = comp.addStyle("underlined superscript", null);
>>         StyleConstants.setBackground(style, Color.BLUE);
>>         ...
>>             doc.insertString(doc.getLength(), "hello", style);
>>
>>     because paint(Graphics g, Shape a) method in GlyphView uses the 
>> alloc.height in the same way.
>>
>>
>>   Could invoke all Swing methods on EDT and remove the comments from 
>> the test:
>>
>>  266 //        bug8016833 b = new bug8016833();
>>  267 //        b.demo();
>>
>> Thanks,
>>    Alexandr.
>>
>>> The reason of such behavior is that the superscripted GlyphView 
>>> requested
>>> increased vertical span, since the alignment of value 1.0
>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>> paint it as
>>> high as required.
>>> (BTW, for subscripted text setting the alignment is enough)
>>>
>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>> underscore
>>> as following:
>>>
>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>
>>> but here alloc.height means the space _reserved_ for glyphs and not the
>>> actual boundary of the painted text. To fix that we need to substitute
>>> alloc.height with painter.getHeight(this).
>>>
>>> The fix looks safe since the GlyphView preferred vertical span is 
>>> initially
>>> requested from the GlyphPainter.
>>>
>>> Thanks!
>>> Anton.
>>
>>
>>
>



From anton.nashatyrev at oracle.com  Fri Jun 21 12:59:16 2013
From: anton.nashatyrev at oracle.com (anton nashatyrev)
Date: Fri, 21 Jun 2013 16:59:16 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C43627.7030507@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com> <51C43627.7030507@oracle.com>
Message-ID: <51C44E24.4010706@oracle.com>

Alexander,

     here is the separate issue for background: 
bugs.sun.com/view_bug.do?bug_id=8017266

     fixed webrev is here: 
http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.01/

Thanks!
Anton.

On 21.06.2013 15:16, Alexander Scherbatiy wrote:
> On 6/21/2013 3:00 PM, anton nashatyrev wrote:
>> Hello, Alexander,
>>
>>     thanks for your suggestion, though I'm not sure drawing a 
>> background has the same semantics as drawing underline. The latter 
>> may be though of as a part of glyph while for background it is ok to 
>> 'highlight' the space _reserved_ for a View. Also the taller 
>> highlight is almost not visible to a user comparing to incorrectly 
>> painted underline.
>>     I'd prefer either not to fix this at all or at least not to 
>> include the fix to this customer issue.
>       It could be filled as a separate issue.
>>
>>     Had fixed the EDT issue in the test.
>    Could you send the updated webrev?
>
>    Thanks,
>    Alexandr.
>>
>> Thanks,
>> Anton.
>>
>> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>>> Hello,
>>>>     could you please review the following fix:
>>>>
>>>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>>
>>>     It seem that there is the same problem with the background color:
>>>         Style style = comp.addStyle("underlined superscript", null);
>>>         StyleConstants.setBackground(style, Color.BLUE);
>>>         ...
>>>             doc.insertString(doc.getLength(), "hello", style);
>>>
>>>     because paint(Graphics g, Shape a) method in GlyphView uses the 
>>> alloc.height in the same way.
>>>
>>>
>>>   Could invoke all Swing methods on EDT and remove the comments from 
>>> the test:
>>>
>>>  266 //        bug8016833 b = new bug8016833();
>>>  267 //        b.demo();
>>>
>>> Thanks,
>>>    Alexandr.
>>>
>>>> The reason of such behavior is that the superscripted GlyphView 
>>>> requested
>>>> increased vertical span, since the alignment of value 1.0
>>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>>> paint it as
>>>> high as required.
>>>> (BTW, for subscripted text setting the alignment is enough)
>>>>
>>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>>> underscore
>>>> as following:
>>>>
>>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>>
>>>> but here alloc.height means the space _reserved_ for glyphs and not 
>>>> the
>>>> actual boundary of the painted text. To fix that we need to substitute
>>>> alloc.height with painter.getHeight(this).
>>>>
>>>> The fix looks safe since the GlyphView preferred vertical span is 
>>>> initially
>>>> requested from the GlyphPainter.
>>>>
>>>> Thanks!
>>>> Anton.
>>>
>>>
>>>
>>
>
>
>



From alexandr.scherbatiy at oracle.com  Fri Jun 21 13:06:08 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 21 Jun 2013 17:06:08 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C44E24.4010706@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com> <51C43627.7030507@oracle.com>
	<51C44E24.4010706@oracle.com>
Message-ID: <51C44FC0.3040005@oracle.com>


  The fix looks good for me.

   Thanks,
   Alexandr.

On 6/21/2013 4:59 PM, anton nashatyrev wrote:
> Alexander,
>
>     here is the separate issue for background: 
> bugs.sun.com/view_bug.do?bug_id=8017266
>
>     fixed webrev is here: 
> http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.01/
>
> Thanks!
> Anton.
>
> On 21.06.2013 15:16, Alexander Scherbatiy wrote:
>> On 6/21/2013 3:00 PM, anton nashatyrev wrote:
>>> Hello, Alexander,
>>>
>>>     thanks for your suggestion, though I'm not sure drawing a 
>>> background has the same semantics as drawing underline. The latter 
>>> may be though of as a part of glyph while for background it is ok to 
>>> 'highlight' the space _reserved_ for a View. Also the taller 
>>> highlight is almost not visible to a user comparing to incorrectly 
>>> painted underline.
>>>     I'd prefer either not to fix this at all or at least not to 
>>> include the fix to this customer issue.
>>       It could be filled as a separate issue.
>>>
>>>     Had fixed the EDT issue in the test.
>>    Could you send the updated webrev?
>>
>>    Thanks,
>>    Alexandr.
>>>
>>> Thanks,
>>> Anton.
>>>
>>> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>>>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>>>> Hello,
>>>>>     could you please review the following fix:
>>>>>
>>>>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>>>
>>>>     It seem that there is the same problem with the background color:
>>>>         Style style = comp.addStyle("underlined superscript", null);
>>>>         StyleConstants.setBackground(style, Color.BLUE);
>>>>         ...
>>>>             doc.insertString(doc.getLength(), "hello", style);
>>>>
>>>>     because paint(Graphics g, Shape a) method in GlyphView uses the 
>>>> alloc.height in the same way.
>>>>
>>>>
>>>>   Could invoke all Swing methods on EDT and remove the comments 
>>>> from the test:
>>>>
>>>>  266 //        bug8016833 b = new bug8016833();
>>>>  267 //        b.demo();
>>>>
>>>> Thanks,
>>>>    Alexandr.
>>>>
>>>>> The reason of such behavior is that the superscripted GlyphView 
>>>>> requested
>>>>> increased vertical span, since the alignment of value 1.0
>>>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>>>> paint it as
>>>>> high as required.
>>>>> (BTW, for subscripted text setting the alignment is enough)
>>>>>
>>>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>>>> underscore
>>>>> as following:
>>>>>
>>>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>>>
>>>>> but here alloc.height means the space _reserved_ for glyphs and 
>>>>> not the
>>>>> actual boundary of the painted text. To fix that we need to 
>>>>> substitute
>>>>> alloc.height with painter.getHeight(this).
>>>>>
>>>>> The fix looks safe since the GlyphView preferred vertical span is 
>>>>> initially
>>>>> requested from the GlyphPainter.
>>>>>
>>>>> Thanks!
>>>>> Anton.
>>>>
>>>>
>>>>
>>>
>>
>>
>>
>



From Sergey.Bylokhov at oracle.com  Fri Jun 21 13:26:07 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 21 Jun 2013 17:26:07 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C44E24.4010706@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com> <51C43627.7030507@oracle.com>
	<51C44E24.4010706@oracle.com>
Message-ID: <51C4546F.5010701@oracle.com>

Hi, Anton.
Can you run swing's tests from the jdk and jck and check that there is 
no new regressions.
Thanks.

On 21.06.2013 16:59, anton nashatyrev wrote:
> Alexander,
>
>     here is the separate issue for background: 
> bugs.sun.com/view_bug.do?bug_id=8017266
>
>     fixed webrev is here: 
> http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.01/
>
> Thanks!
> Anton.
>
> On 21.06.2013 15:16, Alexander Scherbatiy wrote:
>> On 6/21/2013 3:00 PM, anton nashatyrev wrote:
>>> Hello, Alexander,
>>>
>>>     thanks for your suggestion, though I'm not sure drawing a 
>>> background has the same semantics as drawing underline. The latter 
>>> may be though of as a part of glyph while for background it is ok to 
>>> 'highlight' the space _reserved_ for a View. Also the taller 
>>> highlight is almost not visible to a user comparing to incorrectly 
>>> painted underline.
>>>     I'd prefer either not to fix this at all or at least not to 
>>> include the fix to this customer issue.
>>       It could be filled as a separate issue.
>>>
>>>     Had fixed the EDT issue in the test.
>>    Could you send the updated webrev?
>>
>>    Thanks,
>>    Alexandr.
>>>
>>> Thanks,
>>> Anton.
>>>
>>> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>>>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>>>> Hello,
>>>>>     could you please review the following fix:
>>>>>
>>>>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>>>
>>>>     It seem that there is the same problem with the background color:
>>>>         Style style = comp.addStyle("underlined superscript", null);
>>>>         StyleConstants.setBackground(style, Color.BLUE);
>>>>         ...
>>>>             doc.insertString(doc.getLength(), "hello", style);
>>>>
>>>>     because paint(Graphics g, Shape a) method in GlyphView uses the 
>>>> alloc.height in the same way.
>>>>
>>>>
>>>>   Could invoke all Swing methods on EDT and remove the comments 
>>>> from the test:
>>>>
>>>>  266 //        bug8016833 b = new bug8016833();
>>>>  267 //        b.demo();
>>>>
>>>> Thanks,
>>>>    Alexandr.
>>>>
>>>>> The reason of such behavior is that the superscripted GlyphView 
>>>>> requested
>>>>> increased vertical span, since the alignment of value 1.0
>>>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>>>> paint it as
>>>>> high as required.
>>>>> (BTW, for subscripted text setting the alignment is enough)
>>>>>
>>>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>>>> underscore
>>>>> as following:
>>>>>
>>>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>>>
>>>>> but here alloc.height means the space _reserved_ for glyphs and 
>>>>> not the
>>>>> actual boundary of the painted text. To fix that we need to 
>>>>> substitute
>>>>> alloc.height with painter.getHeight(this).
>>>>>
>>>>> The fix looks safe since the GlyphView preferred vertical span is 
>>>>> initially
>>>>> requested from the GlyphPainter.
>>>>>
>>>>> Thanks!
>>>>> Anton.
>>>>
>>>>
>>>>
>>>
>>
>>
>>
>


-- 
Best regards, Sergey.



From anton.nashatyrev at oracle.com  Mon Jun 24 12:44:11 2013
From: anton.nashatyrev at oracle.com (anton nashatyrev)
Date: Mon, 24 Jun 2013 16:44:11 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C4546F.5010701@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com> <51C43627.7030507@oracle.com>
	<51C44E24.4010706@oracle.com> <51C4546F.5010701@oracle.com>
Message-ID: <51C83F1B.6050804@oracle.com>

Hello, Sergey

     swing regression tests are all passed,
     some of swing JCK tests failed but the fail set is the same before 
and after fix.

Regards,
Anton.

On 21.06.2013 17:26, Sergey Bylokhov wrote:
> Hi, Anton.
> Can you run swing's tests from the jdk and jck and check that there is 
> no new regressions.
> Thanks.
>
> On 21.06.2013 16:59, anton nashatyrev wrote:
>> Alexander,
>>
>>     here is the separate issue for background: 
>> bugs.sun.com/view_bug.do?bug_id=8017266
>>
>>     fixed webrev is here: 
>> http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.01/
>>
>> Thanks!
>> Anton.
>>
>> On 21.06.2013 15:16, Alexander Scherbatiy wrote:
>>> On 6/21/2013 3:00 PM, anton nashatyrev wrote:
>>>> Hello, Alexander,
>>>>
>>>>     thanks for your suggestion, though I'm not sure drawing a 
>>>> background has the same semantics as drawing underline. The latter 
>>>> may be though of as a part of glyph while for background it is ok 
>>>> to 'highlight' the space _reserved_ for a View. Also the taller 
>>>> highlight is almost not visible to a user comparing to incorrectly 
>>>> painted underline.
>>>>     I'd prefer either not to fix this at all or at least not to 
>>>> include the fix to this customer issue.
>>>       It could be filled as a separate issue.
>>>>
>>>>     Had fixed the EDT issue in the test.
>>>    Could you send the updated webrev?
>>>
>>>    Thanks,
>>>    Alexandr.
>>>>
>>>> Thanks,
>>>> Anton.
>>>>
>>>> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>>>>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>>>>> Hello,
>>>>>>     could you please review the following fix:
>>>>>>
>>>>>> fix: http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>>>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>>>>
>>>>>     It seem that there is the same problem with the background color:
>>>>>         Style style = comp.addStyle("underlined superscript", null);
>>>>>         StyleConstants.setBackground(style, Color.BLUE);
>>>>>         ...
>>>>>             doc.insertString(doc.getLength(), "hello", style);
>>>>>
>>>>>     because paint(Graphics g, Shape a) method in GlyphView uses 
>>>>> the alloc.height in the same way.
>>>>>
>>>>>
>>>>>   Could invoke all Swing methods on EDT and remove the comments 
>>>>> from the test:
>>>>>
>>>>>  266 //        bug8016833 b = new bug8016833();
>>>>>  267 //        b.demo();
>>>>>
>>>>> Thanks,
>>>>>    Alexandr.
>>>>>
>>>>>> The reason of such behavior is that the superscripted GlyphView 
>>>>>> requested
>>>>>> increased vertical span, since the alignment of value 1.0
>>>>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>>>>> paint it as
>>>>>> high as required.
>>>>>> (BTW, for subscripted text setting the alignment is enough)
>>>>>>
>>>>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>>>>> underscore
>>>>>> as following:
>>>>>>
>>>>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>>>>
>>>>>> but here alloc.height means the space _reserved_ for glyphs and 
>>>>>> not the
>>>>>> actual boundary of the painted text. To fix that we need to 
>>>>>> substitute
>>>>>> alloc.height with painter.getHeight(this).
>>>>>>
>>>>>> The fix looks safe since the GlyphView preferred vertical span is 
>>>>>> initially
>>>>>> requested from the GlyphPainter.
>>>>>>
>>>>>> Thanks!
>>>>>> Anton.
>>>>>
>>>>>
>>>>>
>>>>
>>>
>>>
>>>
>>
>
>



From alexander.potochkin at oracle.com  Mon Jun 24 13:55:03 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Mon, 24 Jun 2013 17:55:03 +0400
Subject: <Swing Dev> [8] Review request for 8016534:
 javax/swing/text/View/8014863/bug8014863.java failed
In-Reply-To: <51C2DE37.8050809@oracle.com>
References: <51C2DE37.8050809@oracle.com>
Message-ID: <51C84FB7.8030805@oracle.com>

Hello Dmitry

Looks fine

Thanks
alexp

> Hello,
>
> Could you review the fix:
>     bug: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8016534
>     webrev: http://cr.openjdk.java.net/~dmarkov/8016534/webrev.00/
>
> The fix adds a calculation of the frame's width which is based on the 
> font metrics for the current OS.
>
> Thanks,
> Dmitry



From alexander.potochkin at oracle.com  Tue Jun 25 18:25:38 2013
From: alexander.potochkin at oracle.com (Alexander Potochkin)
Date: Tue, 25 Jun 2013 22:25:38 +0400
Subject: <Swing Dev> CFV: New Swing Group Member: Artem Ananiev
Message-ID: <51C9E0A2.5060209@oracle.com>

I hereby nominate Artem Ananiev to the Membership in the Swing Group.

Artem is greatly experienced in every brick of the JDK client library
and has effectively been a member of the Swing group for a long time.

http://openjdk.java.net/census#art

I attached some of his contributions to the Swing/AWT area for JDK7 and 
JDK8.

Votes are due by Jul 9, 2013.

Only current Members of the Swing Group [1] are eligible
to vote on this nomination.

For Lazy Consensus voting instructions, see [2].

Thanks
Alexander Potochkin

[1] http://openjdk.java.net/census#swing
[2] http://openjdk.java.net/groups/#member-vote|
-------------- next part --------------
changeset:   2853:1b658b8bd49d
parent:      2776:d147113a36fd
user:        art
date:        Tue Oct 05 18:12:04 2010 +0400
summary:     6829546: Modal dialog causes underlying parent JFrame to be set to "Always on top".

changeset:   2772:8afd49c55619
user:        art
date:        Thu Sep 30 21:06:53 2010 +0400
summary:     6860270: JVM crash is occuring when verifying whether Browse action is supported on WinVista 64 bit

changeset:   2767:40fa33254fc6
user:        art
date:        Tue Sep 28 14:57:23 2010 +0400
summary:     6987896: Modal dialogs resumes the calling thread before it's hidden

changeset:   2695:7e26538596be
parent:      2631:3b0abcb51280
user:        art
date:        Tue Aug 24 12:54:46 2010 +0400
summary:     6949936: Provide API for running nested events loops, similar to what modal dialogs do

changeset:   2518:bccf2a4ee318
user:        art
date:        Tue Jul 06 17:59:56 2010 +0400
summary:     6424157: java.awt.EventQueue push/pop might cause threading issues

changeset:   2327:0c3c502b9a84
parent:      2288:ba8ecdbf0b88
user:        art
date:        Tue Apr 27 18:08:26 2010 +0400
summary:     6880336: SwingWorker deadlocks due one thread in the swingworker-pool

changeset:   1970:e6b46fc235b0
user:        art
date:        Fri Nov 27 15:26:07 2009 +0300
summary:     4913324: Deadlock when using two event queues

changeset:   1498:4b498e41c1c2
user:        art
date:        Wed May 06 15:17:22 2009 +0400
summary:     6656586: Cursor.predefined is protected static mutable (findbugs)

changeset:   1441:f214db928124
parent:      1403:4cd623432e7d
user:        art
date:        Fri Jul 17 15:40:19 2009 +0400
summary:     6844297: java/awt/EventQueue/6638195/bug6638195.java test failed in jdk7 on Windows just on b59,passed on b57

changeset:   1222:b33466bb2fed
user:        art
date:        Thu May 21 12:29:25 2009 +0400
summary:     6794764: Translucent windows are completely repainted on every paint event, on Windows

changeset:   1216:f62f7fcc9965
parent:      1198:b28b073e72b6
user:        art
date:        Fri May 15 15:40:35 2009 +0400
summary:     6678385: Random java.lang.StackOverflowError from various JDKs

changeset:   1197:ba95c9101e50
user:        art
date:        Wed May 06 12:39:23 2009 +0400
summary:     6837004: java.awt.GraphicsDevice.setFullScreenWindow throws NPE for windows with background color not set

changeset:   1165:7601454859c2
parent:      1091:1729e34a0287
user:        art
date:        Fri Apr 17 12:46:24 2009 +0400
summary:     6829923: Test javax/swing/system/6799345/TestShutdown.java fails on X11 platforms

changeset:   1079:794e786306c1
user:        art
date:        Thu Feb 12 14:19:06 2009 +0300
summary:     6799345: JFC demos threw exception in the Java Console when applets are closed

changeset:   1057:e7205c5dd3b7
user:        art
date:        Wed Mar 04 18:10:48 2009 +0300
summary:     6784816: Remove AWT tree lock from Container methods: getComponent, getComponents, getComponentCount

changeset:   1048:03276203c39c
user:        art
date:        Tue Feb 17 10:42:12 2009 +0300
summary:     6806035: Fix for 6804680 is incomplete

changeset:   1046:d78988dd5659
user:        art
date:        Thu Feb 12 17:27:39 2009 +0300
summary:     6804680: Solaris AMD64 build fails after the fix for 6633275/7

changeset:   1045:d0b6e69791c8
parent:      886:f36e9200cb85
user:        art
date:        Wed Feb 11 17:07:06 2009 +0300
summary:     6633275: Need to support shaped/translucent windows

changeset:   885:9fa2e56c8a30
user:        art
date:        Thu Jan 29 14:58:12 2009 +0300
summary:     6721088: Bad window size calculation after using pack()

changeset:   882:d5bf2dd61ed5
user:        art
date:        Fri Dec 19 16:04:04 2008 +0300
summary:     6773985: OutOfMemory (PermGen space) under Linux / Firefox when switching bw. applets

changeset:   881:9daa41eca0d9
user:        art
date:        Wed Nov 26 16:25:16 2008 +0300
summary:     6699589: java/awt/EventQueue/PostEventOrderingTest.java fails

changeset:   880:7406833af6e4
user:        art
date:        Tue Oct 28 17:06:12 2008 +0300
summary:     6758673: WeakReference leak in Window.ownedWindowList

changeset:   869:b0c557c745e8
user:        art
date:        Thu Sep 11 10:38:00 2008 +0400
summary:     6727884: Some Uncaught Exceptions are no longer getting sent to the Uncaught Exception Handlers

changeset:   864:39c8e06919a9
user:        art
date:        Mon Sep 01 17:41:45 2008 +0400
summary:     6707023: Chenese Characters in JTextPane Cause Pane to Hang

changeset:   863:95a618c79382
user:        art
date:        Tue Aug 26 16:31:13 2008 +0400
summary:     6741364: Some input method problems after the fix for 6585765

changeset:   862:75755e92430c
parent:      563:e8301d67f7fa
user:        art
date:        Tue Aug 26 13:09:34 2008 +0400
summary:     6585765: RFE: Remove Unicows-related code from AWT

changeset:   562:99658a8d42fa
user:        art
date:        Thu Aug 14 12:58:51 2008 +0400
summary:     6708392: Provide internal API to create OverrideRedirect windows, XToolkit

changeset:   561:5e61b8180623
user:        art
date:        Tue Aug 12 12:00:46 2008 +0400
summary:     6735584: XNETProtocol:setStateHelper() produces bad _NET_WM_STATE messages

changeset:   558:250129565224
user:        art
date:        Fri Jul 25 15:19:11 2008 +0400
summary:     6235443: REG:Overlapping a swing app with an AWT app causes flickering in the background swing app on Windows

changeset:   4788:7dbc53242c2a
user:        art
date:        Wed Dec 07 17:45:22 2011 +0400
summary:     7117008: Warnings cleanup day: reduce number of javac warnings in the sun.awt package

changeset:   3070:9af8c8d2b2e7
user:        art
date:        Thu Nov 25 13:23:49 2010 +0300
summary:     6993784: Clarification to shaped/translucent windows specification is required

changeset:   3022:65bd45308475
user:        art
date:        Tue Nov 09 14:02:54 2010 +0300
summary:     6984039: awt source rebranding vendor changes needed (jdk7 only)

changeset:   2859:c595c2730226
user:        art
date:        Thu Oct 14 14:07:50 2010 +0400
summary:     6989721: awt native code compiler warnings

changeset:   2855:16265781795b
user:        art
date:        Wed Oct 06 16:42:15 2010 +0400
summary:     6979541: closed/javax/swing/plaf/basic/AWTEventListenerLeak/AWTEventListenerLeak.java fails

changeset:   2854:e804b396307b
user:        art
date:        Tue Oct 05 18:13:52 2010 +0400
summary:     6828273: javax/swing/system/6799345/TestShutdown.java test fails with RuntimeException.

-------------- next part --------------
changeset:   3070:9af8c8d2b2e7
user:        art
date:        Thu Nov 25 13:23:49 2010 +0300
summary:     6993784: Clarification to shaped/translucent windows specification is required

changeset:   3022:65bd45308475
user:        art
date:        Tue Nov 09 14:02:54 2010 +0300
summary:     6984039: awt source rebranding vendor changes needed (jdk7 only)

changeset:   2859:c595c2730226
user:        art
date:        Thu Oct 14 14:07:50 2010 +0400
summary:     6989721: awt native code compiler warnings

changeset:   2855:16265781795b
user:        art
date:        Wed Oct 06 16:42:15 2010 +0400
summary:     6979541: closed/javax/swing/plaf/basic/AWTEventListenerLeak/AWTEventListenerLeak.java fails

changeset:   2854:e804b396307b
user:        art
date:        Tue Oct 05 18:13:52 2010 +0400
summary:     6828273: javax/swing/system/6799345/TestShutdown.java test fails with RuntimeException.

changeset:   2853:1b658b8bd49d
parent:      2776:d147113a36fd
user:        art
date:        Tue Oct 05 18:12:04 2010 +0400
summary:     6829546: Modal dialog causes underlying parent JFrame to be set to "Always on top".

changeset:   2772:8afd49c55619
user:        art
date:        Thu Sep 30 21:06:53 2010 +0400
summary:     6860270: JVM crash is occuring when verifying whether Browse action is supported on WinVista 64 bit

changeset:   2767:40fa33254fc6
user:        art
date:        Tue Sep 28 14:57:23 2010 +0400
summary:     6987896: Modal dialogs resumes the calling thread before it's hidden

changeset:   2695:7e26538596be
parent:      2631:3b0abcb51280
user:        art
date:        Tue Aug 24 12:54:46 2010 +0400
summary:     6949936: Provide API for running nested events loops, similar to what modal dialogs do

changeset:   2518:bccf2a4ee318
user:        art
date:        Tue Jul 06 17:59:56 2010 +0400
summary:     6424157: java.awt.EventQueue push/pop might cause threading issues

changeset:   2327:0c3c502b9a84
parent:      2288:ba8ecdbf0b88
user:        art
date:        Tue Apr 27 18:08:26 2010 +0400
summary:     6880336: SwingWorker deadlocks due one thread in the swingworker-pool

changeset:   1498:4b498e41c1c2
user:        art
date:        Wed May 06 15:17:22 2009 +0400
summary:     6656586: Cursor.predefined is protected static mutable (findbugs)

changeset:   1441:f214db928124
parent:      1403:4cd623432e7d
user:        art
date:        Fri Jul 17 15:40:19 2009 +0400
summary:     6844297: java/awt/EventQueue/6638195/bug6638195.java test failed in jdk7 on Windows just on b59,passed on b57

changeset:   1222:b33466bb2fed
user:        art
date:        Thu May 21 12:29:25 2009 +0400
summary:     6794764: Translucent windows are completely repainted on every paint event, on Windows

changeset:   1216:f62f7fcc9965
parent:      1198:b28b073e72b6
user:        art
date:        Fri May 15 15:40:35 2009 +0400
summary:     6678385: Random java.lang.StackOverflowError from various JDKs

changeset:   1197:ba95c9101e50
user:        art
date:        Wed May 06 12:39:23 2009 +0400
summary:     6837004: java.awt.GraphicsDevice.setFullScreenWindow throws NPE for windows with background color not set

changeset:   1165:7601454859c2
parent:      1091:1729e34a0287
user:        art
date:        Fri Apr 17 12:46:24 2009 +0400
summary:     6829923: Test javax/swing/system/6799345/TestShutdown.java fails on X11 platforms

changeset:   1079:794e786306c1
user:        art
date:        Thu Feb 12 14:19:06 2009 +0300
summary:     6799345: JFC demos threw exception in the Java Console when applets are closed

changeset:   1057:e7205c5dd3b7
user:        art
date:        Wed Mar 04 18:10:48 2009 +0300
summary:     6784816: Remove AWT tree lock from Container methods: getComponent, getComponents, getComponentCount

changeset:   1048:03276203c39c
user:        art
date:        Tue Feb 17 10:42:12 2009 +0300
summary:     6806035: Fix for 6804680 is incomplete

changeset:   1046:d78988dd5659
user:        art
date:        Thu Feb 12 17:27:39 2009 +0300
summary:     6804680: Solaris AMD64 build fails after the fix for 6633275/7

changeset:   1045:d0b6e69791c8
parent:      886:f36e9200cb85
user:        art
date:        Wed Feb 11 17:07:06 2009 +0300
summary:     6633275: Need to support shaped/translucent windows

changeset:   885:9fa2e56c8a30
user:        art
date:        Thu Jan 29 14:58:12 2009 +0300
summary:     6721088: Bad window size calculation after using pack()

changeset:   882:d5bf2dd61ed5
user:        art
date:        Fri Dec 19 16:04:04 2008 +0300
summary:     6773985: OutOfMemory (PermGen space) under Linux / Firefox when switching bw. applets

changeset:   881:9daa41eca0d9
user:        art
date:        Wed Nov 26 16:25:16 2008 +0300
summary:     6699589: java/awt/EventQueue/PostEventOrderingTest.java fails

changeset:   880:7406833af6e4
user:        art
date:        Tue Oct 28 17:06:12 2008 +0300
summary:     6758673: WeakReference leak in Window.ownedWindowList

changeset:   869:b0c557c745e8
user:        art
date:        Thu Sep 11 10:38:00 2008 +0400
summary:     6727884: Some Uncaught Exceptions are no longer getting sent to the Uncaught Exception Handlers

changeset:   864:39c8e06919a9
user:        art
date:        Mon Sep 01 17:41:45 2008 +0400
summary:     6707023: Chenese Characters in JTextPane Cause Pane to Hang

changeset:   863:95a618c79382
user:        art
date:        Tue Aug 26 16:31:13 2008 +0400
summary:     6741364: Some input method problems after the fix for 6585765

changeset:   862:75755e92430c
parent:      563:e8301d67f7fa
user:        art
date:        Tue Aug 26 13:09:34 2008 +0400
summary:     6585765: RFE: Remove Unicows-related code from AWT

changeset:   562:99658a8d42fa
user:        art
date:        Thu Aug 14 12:58:51 2008 +0400
summary:     6708392: Provide internal API to create OverrideRedirect windows, XToolkit

changeset:   561:5e61b8180623
user:        art
date:        Tue Aug 12 12:00:46 2008 +0400
summary:     6735584: XNETProtocol:setStateHelper() produces bad _NET_WM_STATE messages

changeset:   558:250129565224
user:        art
date:        Fri Jul 25 15:19:11 2008 +0400
summary:     6235443: REG:Overlapping a swing app with an AWT app causes flickering in the background swing app on Windows


From Sergey.Bylokhov at oracle.com  Sat Jun 29 20:43:40 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Sun, 30 Jun 2013 00:43:40 +0400
Subject: <Swing Dev> [8] Review request for 8016833: Underlines and
 strikethrough not rendering correctly
In-Reply-To: <51C83F1B.6050804@oracle.com>
References: <51C2DC5F.9060709@oracle.com> <51C31841.30703@oracle.com>
	<51C43238.3090709@oracle.com> <51C43627.7030507@oracle.com>
	<51C44E24.4010706@oracle.com> <51C4546F.5010701@oracle.com>
	<51C83F1B.6050804@oracle.com>
Message-ID: <51CF46FC.5020204@oracle.com>

Hi, Anton.
Fix looks good.
Thanks.
On 24.06.2013 16:44, anton nashatyrev wrote:
> Hello, Sergey
>
>     swing regression tests are all passed,
>     some of swing JCK tests failed but the fail set is the same before 
> and after fix.
>
> Regards,
> Anton.
>
> On 21.06.2013 17:26, Sergey Bylokhov wrote:
>> Hi, Anton.
>> Can you run swing's tests from the jdk and jck and check that there 
>> is no new regressions.
>> Thanks.
>>
>> On 21.06.2013 16:59, anton nashatyrev wrote:
>>> Alexander,
>>>
>>>     here is the separate issue for background: 
>>> bugs.sun.com/view_bug.do?bug_id=8017266
>>>
>>>     fixed webrev is here: 
>>> http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.01/
>>>
>>> Thanks!
>>> Anton.
>>>
>>> On 21.06.2013 15:16, Alexander Scherbatiy wrote:
>>>> On 6/21/2013 3:00 PM, anton nashatyrev wrote:
>>>>> Hello, Alexander,
>>>>>
>>>>>     thanks for your suggestion, though I'm not sure drawing a 
>>>>> background has the same semantics as drawing underline. The latter 
>>>>> may be though of as a part of glyph while for background it is ok 
>>>>> to 'highlight' the space _reserved_ for a View. Also the taller 
>>>>> highlight is almost not visible to a user comparing to incorrectly 
>>>>> painted underline.
>>>>>     I'd prefer either not to fix this at all or at least not to 
>>>>> include the fix to this customer issue.
>>>>       It could be filled as a separate issue.
>>>>>
>>>>>     Had fixed the EDT issue in the test.
>>>>    Could you send the updated webrev?
>>>>
>>>>    Thanks,
>>>>    Alexandr.
>>>>>
>>>>> Thanks,
>>>>> Anton.
>>>>>
>>>>> On 20.06.2013 18:57, Alexander Scherbatiy wrote:
>>>>>> On 6/20/2013 2:41 PM, anton nashatyrev wrote:
>>>>>>> Hello,
>>>>>>>     could you please review the following fix:
>>>>>>>
>>>>>>> fix: 
>>>>>>> http://cr.openjdk.java.net/~vkarnauk/8016833/jdk8/webrev.00/ 
>>>>>>> <http://cr.openjdk.java.net/%7Evkarnauk/8016833/jdk8/webrev.00/>
>>>>>>> bug: http://bugs.sun.com/view_bug.do?bug_id=8016833
>>>>>>>
>>>>>>     It seem that there is the same problem with the background 
>>>>>> color:
>>>>>>         Style style = comp.addStyle("underlined superscript", null);
>>>>>>         StyleConstants.setBackground(style, Color.BLUE);
>>>>>>         ...
>>>>>>             doc.insertString(doc.getLength(), "hello", style);
>>>>>>
>>>>>>     because paint(Graphics g, Shape a) method in GlyphView uses 
>>>>>> the alloc.height in the same way.
>>>>>>
>>>>>>
>>>>>>   Could invoke all Swing methods on EDT and remove the comments 
>>>>>> from the test:
>>>>>>
>>>>>>  266 //        bug8016833 b = new bug8016833();
>>>>>>  267 //        b.demo();
>>>>>>
>>>>>> Thanks,
>>>>>>    Alexandr.
>>>>>>
>>>>>>> The reason of such behavior is that the superscripted GlyphView 
>>>>>>> requested
>>>>>>> increased vertical span, since the alignment of value 1.0
>>>>>>> (GlyphView.getAligment(View.Y_AXIS) returns 1.0) isn't enough to 
>>>>>>> paint it as
>>>>>>> high as required.
>>>>>>> (BTW, for subscripted text setting the alignment is enough)
>>>>>>>
>>>>>>> GlyphView.paintTextUsingColor() calculates the Y position of the 
>>>>>>> underscore
>>>>>>> as following:
>>>>>>>
>>>>>>>   int y = alloc.y + alloc.height - (int) painter.getDescent(this);
>>>>>>>
>>>>>>> but here alloc.height means the space _reserved_ for glyphs and 
>>>>>>> not the
>>>>>>> actual boundary of the painted text. To fix that we need to 
>>>>>>> substitute
>>>>>>> alloc.height with painter.getHeight(this).
>>>>>>>
>>>>>>> The fix looks safe since the GlyphView preferred vertical span 
>>>>>>> is initially
>>>>>>> requested from the GlyphPainter.
>>>>>>>
>>>>>>> Thanks!
>>>>>>> Anton.
>>>>>>
>>>>>>
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>
>>
>>
>


-- 
Best regards, Sergey.