From Sergey.Bylokhov at oracle.com  Fri Nov  1 11:18:24 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 01 Nov 2013 15:18:24 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright header
	in the tests
Message-ID: <52738E00.2070806@oracle.com>

Hello.
Please review the fix for jdk 8.
Most of tests in the sound area, and some tests in the client, 
java.lang, security, jmx etc has incorrect copyright.
According to the http://openjdk.java.net/faq
"GPL v2 + the Classpath exception for the class libraries and those 
parts of the virtual machine that expose public APIs"

But currently our tests mix gpl+cp and gpl or has no header at all.
Tests with "/nodynamiccopyright/", with other company's copyright, or 
other gpl templates were not updated.

Also it would be good if in the faq we explicitly mention about 
copyright of the tests.

Bug: https://bugs.openjdk.java.net/browse/JDK-8027696
Webrev can be found at: http://cr.openjdk.java.net/~serb/8027696/webrev.00

-- 
Best regards, Sergey.



From Alan.Bateman at oracle.com  Sat Nov  2 11:37:35 2013
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Sat, 02 Nov 2013 11:37:35 +0000
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <52738E00.2070806@oracle.com>
References: <52738E00.2070806@oracle.com>
Message-ID: <5274E3FF.3070807@oracle.com>

On 01/11/2013 11:18, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
> Most of tests in the sound area, and some tests in the client, 
> java.lang, security, jmx etc has incorrect copyright.
> According to the http://openjdk.java.net/faq
> "GPL v2 + the Classpath exception for the class libraries and those 
> parts of the virtual machine that expose public APIs"
>
> But currently our tests mix gpl+cp and gpl or has no header at all.
> Tests with "/nodynamiccopyright/", with other company's copyright, or 
> other gpl templates were not updated.
>
> Also it would be good if in the faq we explicitly mention about 
> copyright of the tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027696
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8027696/webrev.00
>
Thanks for doing this. I sampled a few of the files in the webrev and 
the changes mostly look okay.

The only thing is that I'm not sure about is the dates that you've put 
on tests that were missing a header. For example, 
test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java 
was added in 2013 but the header proposed in the webrev has 2012. Does 
your script to fix up these headers look at the hg log to get the date 
range?

I see you've changed jdk/test/Makefile to have the GPL header. I don't 
know what the right header is for that (as the rest of the Makefiles 
have the GPL + Classpath exception).

One other question is whether this is a one-off effort by yourself or 
whether this is part of an effort to keep us in check on a continuous 
basis. Periodically David Katleman brings up malformed headers on 
jdk8-dev. I assume these are caught by something that checks the headers 
on a weekly or continuous basis. Maybe there is an opportunity to 
combine efforts and also have these scripts run on a continuous basis on 
jdk8/tl, jdk8/awt and the other forests that collect changes.

-Alan.


From Sergey.Bylokhov at oracle.com  Sat Nov  2 15:53:25 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Sat, 02 Nov 2013 19:53:25 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <5274E3FF.3070807@oracle.com>
References: <52738E00.2070806@oracle.com> <5274E3FF.3070807@oracle.com>
Message-ID: <52751FF5.5070503@oracle.com>

On 02.11.2013 15:37, Alan Bateman wrote:
> On 01/11/2013 11:18, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 8.
>> Most of tests in the sound area, and some tests in the client, 
>> java.lang, security, jmx etc has incorrect copyright.
>> According to the http://openjdk.java.net/faq
>> "GPL v2 + the Classpath exception for the class libraries and those 
>> parts of the virtual machine that expose public APIs"
>>
>> But currently our tests mix gpl+cp and gpl or has no header at all.
>> Tests with "/nodynamiccopyright/", with other company's copyright, or 
>> other gpl templates were not updated.
>>
>> Also it would be good if in the faq we explicitly mention about 
>> copyright of the tests.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027696
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8027696/webrev.00
>>
> Thanks for doing this. I sampled a few of the files in the webrev and 
> the changes mostly look okay.
>
> The only thing is that I'm not sure about is the dates that you've put 
> on tests that were missing a header. For example, 
> test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java 
> was added in 2013 but the header proposed in the webrev has 2012. Does 
> your script to fix up these headers look at the hg log to get the date 
> range?
After the absent headers were added, I manually verify them and looks 
like in this case my eye was hackneyed and I change it to 2012. I'll 
additionally recheck them again.
>
> I see you've changed jdk/test/Makefile to have the GPL header. I don't 
> know what the right header is for that (as the rest of the Makefiles 
> have the GPL + Classpath exception).
I would be good to have one rule for all files under tests directory.
>
> One other question is whether this is a one-off effort by yourself or 
> whether this is part of an effort to keep us in check on a continuous 
> basis. Periodically David Katleman brings up malformed headers on 
> jdk8-dev. I assume these are caught by something that checks the 
> headers on a weekly or continuous basis. Maybe there is an opportunity 
> to combine efforts and also have these scripts run on a continuous 
> basis on jdk8/tl, jdk8/awt and the other forests that collect changes.
It is one time effort. My main goal was to update tests in sound and 
client area.
>
> -Alan.


-- 
Best regards, Sergey.



From sergey.malenkov at oracle.com  Tue Nov  5 09:38:47 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Tue, 05 Nov 2013 13:38:47 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <52738E00.2070806@oracle.com>
References: <52738E00.2070806@oracle.com>
Message-ID: <5278BCA7.1080206@oracle.com>

Hi Sergey,

There is a leading space added in the following files:
test/java/io/FileInputStream/OpsAfterClose.java
test/sun/util/resources/Locale/Bug6275682.java

The following file does not show 15 modified lines:
test/java/net/URLClassLoader/closetest/build.sh

Other looks fine.

SAM

On 01.11.2013 15:18, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
> Most of tests in the sound area, and some tests in the client, 
> java.lang, security, jmx etc has incorrect copyright.
> According to the http://openjdk.java.net/faq
> "GPL v2 + the Classpath exception for the class libraries and those 
> parts of the virtual machine that expose public APIs"
>
> But currently our tests mix gpl+cp and gpl or has no header at all.
> Tests with "/nodynamiccopyright/", with other company's copyright, or 
> other gpl templates were not updated.
>
> Also it would be good if in the faq we explicitly mention about 
> copyright of the tests.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8027696
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8027696/webrev.00
>



From Sergey.Bylokhov at oracle.com  Tue Nov  5 16:28:03 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Tue, 05 Nov 2013 20:28:03 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <5274E3FF.3070807@oracle.com>
References: <52738E00.2070806@oracle.com> <5274E3FF.3070807@oracle.com>
Message-ID: <52791C93.1060600@oracle.com>

Hello,
Updated version:
http://cr.openjdk.java.net/~serb/8027696/webrev.01/
Dates and spaces were fixed.

On 02.11.2013 15:37, Alan Bateman wrote:
> On 01/11/2013 11:18, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 8.
>> Most of tests in the sound area, and some tests in the client, 
>> java.lang, security, jmx etc has incorrect copyright.
>> According to the http://openjdk.java.net/faq
>> "GPL v2 + the Classpath exception for the class libraries and those 
>> parts of the virtual machine that expose public APIs"
>>
>> But currently our tests mix gpl+cp and gpl or has no header at all.
>> Tests with "/nodynamiccopyright/", with other company's copyright, or 
>> other gpl templates were not updated.
>>
>> Also it would be good if in the faq we explicitly mention about 
>> copyright of the tests.
>>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8027696
>> Webrev can be found at: 
>> http://cr.openjdk.java.net/~serb/8027696/webrev.00
>>
> Thanks for doing this. I sampled a few of the files in the webrev and 
> the changes mostly look okay.
>
> The only thing is that I'm not sure about is the dates that you've put 
> on tests that were missing a header. For example, 
> test/com/sun/jmx/remote/NotificationMarshalVersions/TestSerializationMismatch.java 
> was added in 2013 but the header proposed in the webrev has 2012. Does 
> your script to fix up these headers look at the hg log to get the date 
> range?
>
> I see you've changed jdk/test/Makefile to have the GPL header. I don't 
> know what the right header is for that (as the rest of the Makefiles 
> have the GPL + Classpath exception).
>
> One other question is whether this is a one-off effort by yourself or 
> whether this is part of an effort to keep us in check on a continuous 
> basis. Periodically David Katleman brings up malformed headers on 
> jdk8-dev. I assume these are caught by something that checks the 
> headers on a weekly or continuous basis. Maybe there is an opportunity 
> to combine efforts and also have these scripts run on a continuous 
> basis on jdk8/tl, jdk8/awt and the other forests that collect changes.
>
> -Alan.


-- 
Best regards, Sergey.



From alexandr.scherbatiy at oracle.com  Wed Nov  6 14:37:55 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 06 Nov 2013 18:37:55 +0400
Subject: <Swing Dev> RFR: JDK-8027406 - JDK demos are missing source
	files
In-Reply-To: <527A24B9.9050100@oracle.com>
References: <527A24B9.9050100@oracle.com>
Message-ID: <527A5443.9050407@oracle.com>

On 11/6/2013 3:15 PM, Erik Joelsson wrote:
> Please review this minor fix for jdk demos MoleculeViewer and 
> WireFrameTest. In JDK-8020060, these were changed to build 
> differently. This had the side effect of putting the source files in a 
> src.zip. It seems that the fixer made an effort to still copy some 
> source files into the demo dir to retain some of the old file layout, 
> but not all the source files were included. This fix changes that so 
> that all source files are included like before.
>

   Will all source file be placed only in zip file or they also be 
located in the file system as it was before the previous fix?

   Thanks,
   Alexandr.

> Posting inline since it's small and cr.openjdk.java.net is down atm.
>
> diff -r f26a0c8071bd makefiles/CompileDemos.gmk
> --- a/makefiles/CompileDemos.gmk
> +++ b/makefiles/CompileDemos.gmk
> @@ -157,8 +157,8 @@
>
>  BUILD_DEMOS += $(JDK_OUTPUTDIR)/demo/jfc/CodePointIM/_the.services
>
> -$(eval $(call 
> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html 
> XYZApp.java))
> -$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
> ThreeD.java))
> +$(eval $(call 
> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html *.java))
> +$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
> *.java))
>  $(eval $(call SetupDemo,FileChooserDemo,jfc,,FileChooserDemo,,,README*))
>  $(eval $(call SetupDemo,Font2DTest,jfc,,Font2DTest,,,*.html *.txt))
>  $(eval $(call SetupDemo,Metalworks,jfc,,Metalworks,,,README*))
>
>
> /Erik



From erik.joelsson at oracle.com  Wed Nov  6 11:15:05 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Wed, 06 Nov 2013 12:15:05 +0100
Subject: <Swing Dev> RFR: JDK-8027406 - JDK demos are missing source files
Message-ID: <527A24B9.9050100@oracle.com>

Please review this minor fix for jdk demos MoleculeViewer and 
WireFrameTest. In JDK-8020060, these were changed to build differently. 
This had the side effect of putting the source files in a src.zip. It 
seems that the fixer made an effort to still copy some source files into 
the demo dir to retain some of the old file layout, but not all the 
source files were included. This fix changes that so that all source 
files are included like before.

Posting inline since it's small and cr.openjdk.java.net is down atm.

diff -r f26a0c8071bd makefiles/CompileDemos.gmk
--- a/makefiles/CompileDemos.gmk
+++ b/makefiles/CompileDemos.gmk
@@ -157,8 +157,8 @@

  BUILD_DEMOS += $(JDK_OUTPUTDIR)/demo/jfc/CodePointIM/_the.services

-$(eval $(call 
SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html XYZApp.java))
-$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
ThreeD.java))
+$(eval $(call 
SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html *.java))
+$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html *.java))
  $(eval $(call SetupDemo,FileChooserDemo,jfc,,FileChooserDemo,,,README*))
  $(eval $(call SetupDemo,Font2DTest,jfc,,Font2DTest,,,*.html *.txt))
  $(eval $(call SetupDemo,Metalworks,jfc,,Metalworks,,,README*))


/Erik


From erik.joelsson at oracle.com  Wed Nov  6 15:29:40 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Wed, 06 Nov 2013 16:29:40 +0100
Subject: <Swing Dev> RFR: JDK-8027406 - JDK demos are missing source
	files
In-Reply-To: <527A5443.9050407@oracle.com>
References: <527A24B9.9050100@oracle.com> <527A5443.9050407@oracle.com>
Message-ID: <527A6064.3030905@oracle.com>

On 2013-11-06 15:37, Alexander Scherbatiy wrote:
> On 11/6/2013 3:15 PM, Erik Joelsson wrote:
>> Please review this minor fix for jdk demos MoleculeViewer and 
>> WireFrameTest. In JDK-8020060, these were changed to build 
>> differently. This had the side effect of putting the source files in 
>> a src.zip. It seems that the fixer made an effort to still copy some 
>> source files into the demo dir to retain some of the old file layout, 
>> but not all the source files were included. This fix changes that so 
>> that all source files are included like before.
>>
>
>   Will all source file be placed only in zip file or they also be 
> located in the file system as it was before the previous fix?
>
Both in the zip file and in the file system with this fix.

/Erik
> Thanks,
>   Alexandr.
>
>> Posting inline since it's small and cr.openjdk.java.net is down atm.
>>
>> diff -r f26a0c8071bd makefiles/CompileDemos.gmk
>> --- a/makefiles/CompileDemos.gmk
>> +++ b/makefiles/CompileDemos.gmk
>> @@ -157,8 +157,8 @@
>>
>>  BUILD_DEMOS += $(JDK_OUTPUTDIR)/demo/jfc/CodePointIM/_the.services
>>
>> -$(eval $(call 
>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html 
>> XYZApp.java))
>> -$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>> ThreeD.java))
>> +$(eval $(call 
>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html *.java))
>> +$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>> *.java))
>>  $(eval $(call 
>> SetupDemo,FileChooserDemo,jfc,,FileChooserDemo,,,README*))
>>  $(eval $(call SetupDemo,Font2DTest,jfc,,Font2DTest,,,*.html *.txt))
>>  $(eval $(call SetupDemo,Metalworks,jfc,,Metalworks,,,README*))
>>
>>
>> /Erik
>



From alexandr.scherbatiy at oracle.com  Thu Nov  7 10:04:53 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 07 Nov 2013 14:04:53 +0400
Subject: <Swing Dev> RFR: JDK-8027406 - JDK demos are missing source
	files
In-Reply-To: <527A6064.3030905@oracle.com>
References: <527A24B9.9050100@oracle.com> <527A5443.9050407@oracle.com>
	<527A6064.3030905@oracle.com>
Message-ID: <527B65C5.7010504@oracle.com>

On 11/6/2013 7:29 PM, Erik Joelsson wrote:
> On 2013-11-06 15:37, Alexander Scherbatiy wrote:
>> On 11/6/2013 3:15 PM, Erik Joelsson wrote:
>>> Please review this minor fix for jdk demos MoleculeViewer and 
>>> WireFrameTest. In JDK-8020060, these were changed to build 
>>> differently. This had the side effect of putting the source files in 
>>> a src.zip. It seems that the fixer made an effort to still copy some 
>>> source files into the demo dir to retain some of the old file 
>>> layout, but not all the source files were included. This fix changes 
>>> that so that all source files are included like before.
>>>
>>
>>   Will all source file be placed only in zip file or they also be 
>> located in the file system as it was before the previous fix?
>>
> Both in the zip file and in the file system with this fix.

    The fix looks good for me.

   Could you upload the webrev to the http://cr.openjdk.java.net ? It 
should work now.

   Thanks,
   Alexandr.

>
> /Erik
>> Thanks,
>>   Alexandr.
>>
>>> Posting inline since it's small and cr.openjdk.java.net is down atm.
>>>
>>> diff -r f26a0c8071bd makefiles/CompileDemos.gmk
>>> --- a/makefiles/CompileDemos.gmk
>>> +++ b/makefiles/CompileDemos.gmk
>>> @@ -157,8 +157,8 @@
>>>
>>>  BUILD_DEMOS += $(JDK_OUTPUTDIR)/demo/jfc/CodePointIM/_the.services
>>>
>>> -$(eval $(call 
>>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html 
>>> XYZApp.java))
>>> -$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>>> ThreeD.java))
>>> +$(eval $(call 
>>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html *.java))
>>> +$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>>> *.java))
>>>  $(eval $(call 
>>> SetupDemo,FileChooserDemo,jfc,,FileChooserDemo,,,README*))
>>>  $(eval $(call SetupDemo,Font2DTest,jfc,,Font2DTest,,,*.html *.txt))
>>>  $(eval $(call SetupDemo,Metalworks,jfc,,Metalworks,,,README*))
>>>
>>>
>>> /Erik
>>
>



From erik.joelsson at oracle.com  Thu Nov  7 10:27:57 2013
From: erik.joelsson at oracle.com (Erik Joelsson)
Date: Thu, 07 Nov 2013 11:27:57 +0100
Subject: <Swing Dev> RFR: JDK-8027406 - JDK demos are missing source
	files
In-Reply-To: <527B65C5.7010504@oracle.com>
References: <527A24B9.9050100@oracle.com> <527A5443.9050407@oracle.com>
	<527A6064.3030905@oracle.com> <527B65C5.7010504@oracle.com>
Message-ID: <527B6B2D.6080803@oracle.com>


On 2013-11-07 11:04, Alexander Scherbatiy wrote:
> On 11/6/2013 7:29 PM, Erik Joelsson wrote:
>> On 2013-11-06 15:37, Alexander Scherbatiy wrote:
>>> On 11/6/2013 3:15 PM, Erik Joelsson wrote:
>>>> Please review this minor fix for jdk demos MoleculeViewer and 
>>>> WireFrameTest. In JDK-8020060, these were changed to build 
>>>> differently. This had the side effect of putting the source files 
>>>> in a src.zip. It seems that the fixer made an effort to still copy 
>>>> some source files into the demo dir to retain some of the old file 
>>>> layout, but not all the source files were included. This fix 
>>>> changes that so that all source files are included like before.
>>>>
>>>
>>>   Will all source file be placed only in zip file or they also be 
>>> located in the file system as it was before the previous fix?
>>>
>> Both in the zip file and in the file system with this fix.
>
>    The fix looks good for me.
>
Thanks!
> Could you upload the webrev to the http://cr.openjdk.java.net ? It 
> should work now.
>
Sure, here it is: http://cr.openjdk.java.net/~erikj/8027406/webrev.jdk.01/

/Erik
> Thanks,
>   Alexandr.
>
>>
>> /Erik
>>> Thanks,
>>>   Alexandr.
>>>
>>>> Posting inline since it's small and cr.openjdk.java.net is down atm.
>>>>
>>>> diff -r f26a0c8071bd makefiles/CompileDemos.gmk
>>>> --- a/makefiles/CompileDemos.gmk
>>>> +++ b/makefiles/CompileDemos.gmk
>>>> @@ -157,8 +157,8 @@
>>>>
>>>>  BUILD_DEMOS += $(JDK_OUTPUTDIR)/demo/jfc/CodePointIM/_the.services
>>>>
>>>> -$(eval $(call 
>>>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html 
>>>> XYZApp.java))
>>>> -$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>>>> ThreeD.java))
>>>> +$(eval $(call 
>>>> SetupDemo,MoleculeViewer,applets,,XYZChemModel,,,example*.html 
>>>> *.java))
>>>> +$(eval $(call SetupDemo,WireFrame,applets,,ThreeD,,,example*.html 
>>>> *.java))
>>>>  $(eval $(call 
>>>> SetupDemo,FileChooserDemo,jfc,,FileChooserDemo,,,README*))
>>>>  $(eval $(call SetupDemo,Font2DTest,jfc,,Font2DTest,,,*.html *.txt))
>>>>  $(eval $(call SetupDemo,Metalworks,jfc,,Metalworks,,,README*))
>>>>
>>>>
>>>> /Erik
>>>
>>
>



From Alan.Bateman at oracle.com  Thu Nov  7 11:22:24 2013
From: Alan.Bateman at oracle.com (Alan Bateman)
Date: Thu, 07 Nov 2013 11:22:24 +0000
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <52791C93.1060600@oracle.com>
References: <52738E00.2070806@oracle.com> <5274E3FF.3070807@oracle.com>
	<52791C93.1060600@oracle.com>
Message-ID: <527B77F0.4050109@oracle.com>

On 05/11/2013 16:28, Sergey Bylokhov wrote:
> Hello,
> Updated version:
> http://cr.openjdk.java.net/~serb/8027696/webrev.01/
> Dates and spaces were fixed.
Thanks Sergey, I sampled a few and they look correct.

The only thing is that I'm not sure about is test/Makefile, it's just 
not clear whether which header this should have.

-Alan


From Sergey.Bylokhov at oracle.com  Thu Nov  7 13:46:37 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 07 Nov 2013 17:46:37 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <527B77F0.4050109@oracle.com>
References: <52738E00.2070806@oracle.com>
	<5274E3FF.3070807@oracle.com>	<52791C93.1060600@oracle.com>
	<527B77F0.4050109@oracle.com>
Message-ID: <527B99BD.8050401@oracle.com>

On 07.11.2013 15:22, Alan Bateman wrote:
> Thanks Sergey, I sampled a few and they look correct.
>
> The only thing is that I'm not sure about is test/Makefile, it's just 
> not clear whether which header this should have.
I can skip it this time.

-- 
Best regards, Sergey.



From roger.riggs at oracle.com  Thu Nov  7 22:02:14 2013
From: roger.riggs at oracle.com (roger riggs)
Date: Thu, 07 Nov 2013 17:02:14 -0500
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
Message-ID: <527C0DE6.1070609@oracle.com>

This changeset addresses the warnings and errors of doclint and
improves the quality of the generated html.
No spec or implementation is changed by this changeset

The changes address issues including html syntax, accessibility issues,
and improper html tag use. Refer to the error log attached to the bug 
report [1] for details.

Please review:
    http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/

Thanks, Roger


[1] https://bugs.openjdk.java.net/browse/JDK-8028018


From alexandr.scherbatiy at oracle.com  Fri Nov  8 10:40:45 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Fri, 8 Nov 2013 02:40:45 -0800 (PST)
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527C0DE6.1070609@oracle.com>
References: <527C0DE6.1070609@oracle.com>
Message-ID: <527CBFAD.5060200@oracle.com>


Could you include the bug id to the subject like:  [8] Review request 
for BugID Bug title.

AbstractButton.java
-     * @exception   IllegalArgumentException if threshhold < 0
+     * @exception   IllegalArgumentException if threshhold {@literal > 0}

JMenu.java
-     *                  <code>pos</code> < 0
+     *                  <code>pos</code> {@literal > 0}

It seems that right condition should be {@literal < 0}.

In some places a whole operator is included in to the literal like "View 
(JTable) {@literal ->} model."
In others places only part of an operator is included "0.0f -{@literal 
 >} 1.0f"
May be it is better to use an uniform style for all cases.

Thanks,
Alexandr.


On 11/8/2013 2:02 AM, roger riggs wrote:
> This changeset addresses the warnings and errors of doclint and
> improves the quality of the generated html.
> No spec or implementation is changed by this changeset
>
> The changes address issues including html syntax, accessibility issues,
> and improper html tag use. Refer to the error log attached to the bug 
> report [1] for details.
>
> Please review:
>    http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>
> Thanks, Roger
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8028018



From sergey.malenkov at oracle.com  Fri Nov  8 11:41:06 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Fri, 08 Nov 2013 15:41:06 +0400
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527C0DE6.1070609@oracle.com>
References: <527C0DE6.1070609@oracle.com>
Message-ID: <527CCDD2.9060800@oracle.com>

Hi Roger,

Seems some of your changes conflict with the following fix:
https://bugs.openjdk.java.net/browse/JDK-8025234
Be ready to merge swing files.

Thanks,
SAM

On 08.11.2013 2:02, roger riggs wrote:
> This changeset addresses the warnings and errors of doclint and
> improves the quality of the generated html.
> No spec or implementation is changed by this changeset
>
> The changes address issues including html syntax, accessibility issues,
> and improper html tag use. Refer to the error log attached to the bug 
> report [1] for details.
>
> Please review:
>    http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>
> Thanks, Roger
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8028018



From yuri.nesterenko at oracle.com  Fri Nov  8 11:46:38 2013
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Fri, 08 Nov 2013 15:46:38 +0400
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527C0DE6.1070609@oracle.com>
References: <527C0DE6.1070609@oracle.com>
Message-ID: <527CCF1E.7000606@oracle.com>

Hi Roger,

I'm afraid you'll have to merge with D.Ginzburg's change

http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b8eb21e93fa7

He was someway late to push it but properly received approvals.
Note that the change is in awt+swing team repository. Sorry about that!

Thanks,
-yan

On 11/08/2013 02:02 AM, roger riggs wrote:
> This changeset addresses the warnings and errors of doclint and
> improves the quality of the generated html.
> No spec or implementation is changed by this changeset
>
> The changes address issues including html syntax, accessibility issues,
> and improper html tag use. Refer to the error log attached to the bug
> report [1] for details.
>
> Please review:
>     http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>
> Thanks, Roger
>
>
> [1] https://bugs.openjdk.java.net/browse/JDK-8028018



From roger.riggs at oracle.com  Fri Nov  8 14:53:12 2013
From: roger.riggs at oracle.com (roger riggs)
Date: Fri, 08 Nov 2013 09:53:12 -0500
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527CBFAD.5060200@oracle.com>
References: <527C0DE6.1070609@oracle.com> <527CBFAD.5060200@oracle.com>
Message-ID: <527CFAD8.10904@oracle.com>

Hi Alexandr,

I'll fixup these cases,  the bulk of the changes were generated from a 
script/program
that focused on the bad markup. Including the longer literal reduces the 
interruption
when reading.

Thanks, Roger

On 11/8/2013 5:40 AM, Alexander Scherbatiy wrote:
>
> Could you include the bug id to the subject like:  [8] Review request 
> for BugID Bug title.
>
> AbstractButton.java
> -     * @exception   IllegalArgumentException if threshhold < 0
> +     * @exception   IllegalArgumentException if threshhold {@literal 
> > 0}
>
> JMenu.java
> -     *                  <code>pos</code> < 0
> +     *                  <code>pos</code> {@literal > 0}
>
> It seems that right condition should be {@literal < 0}.
>
> In some places a whole operator is included in to the literal like 
> "View (JTable) {@literal ->} model."
> In others places only part of an operator is included "0.0f -{@literal 
> >} 1.0f"
> May be it is better to use an uniform style for all cases.
>
> Thanks,
> Alexandr.
>
>
> On 11/8/2013 2:02 AM, roger riggs wrote:
>> This changeset addresses the warnings and errors of doclint and
>> improves the quality of the generated html.
>> No spec or implementation is changed by this changeset
>>
>> The changes address issues including html syntax, accessibility issues,
>> and improper html tag use. Refer to the error log attached to the bug 
>> report [1] for details.
>>
>> Please review:
>>    http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>>
>> Thanks, Roger
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8028018
>



From roger.riggs at oracle.com  Fri Nov  8 15:20:14 2013
From: roger.riggs at oracle.com (roger riggs)
Date: Fri, 08 Nov 2013 10:20:14 -0500
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527CCF1E.7000606@oracle.com>
References: <527C0DE6.1070609@oracle.com> <527CCF1E.7000606@oracle.com>
Message-ID: <527D012E.4060204@oracle.com>

Hi Yuri,

My changes may be completely covered already.

I'll recheck against the AWT forest and see if there is anything left to 
fix.

BTW, theAWT project page <http://openjdk.java.net/groups/awt/> on 
openjdk does not provide the link to the awt forest.
And I'm not sure I'm up to the testing requirements on all platforms/all 
tests.

Thanks, Roger

On 11/8/2013 6:46 AM, Yuri Nesterenko wrote:
> Hi Roger,
>
> I'm afraid you'll have to merge with D.Ginzburg's change
>
> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b8eb21e93fa7
>
> He was someway late to push it but properly received approvals.
> Note that the change is in awt+swing team repository. Sorry about that!
>
> Thanks,
> -yan
>
> On 11/08/2013 02:02 AM, roger riggs wrote:
>> This changeset addresses the warnings and errors of doclint and
>> improves the quality of the generated html.
>> No spec or implementation is changed by this changeset
>>
>> The changes address issues including html syntax, accessibility issues,
>> and improper html tag use. Refer to the error log attached to the bug
>> report [1] for details.
>>
>> Please review:
>> http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>>
>> Thanks, Roger
>>
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8028018
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.openjdk.java.net/pipermail/swing-dev/attachments/20131108/1eeaf8fd/attachment.html>

From yuri.nesterenko at oracle.com  Fri Nov  8 15:42:56 2013
From: yuri.nesterenko at oracle.com (Yuri Nesterenko)
Date: Fri, 08 Nov 2013 19:42:56 +0400
Subject: <Swing Dev> RFR Doclint cleanup of javax.swing
In-Reply-To: <527D012E.4060204@oracle.com>
References: <527C0DE6.1070609@oracle.com> <527CCF1E.7000606@oracle.com>
	<527D012E.4060204@oracle.com>
Message-ID: <527D0680.5020006@oracle.com>

Roger,

I understand that we've decided lately to use tl forest for doc
changes so you do this right. These our fixes in awt+swing are
rather stale, otherwise they would be also in tl.

As to the awt team forest, look in
http://hg.openjdk.java.net for jdk8/awt/ stuff -- currently 2d
is apart, and awt and swing together (in awt).

Thanks,
-yan

On 11/08/2013 07:20 PM, roger riggs wrote:
> Hi Yuri,
>
> My changes may be completely covered already.
>
> I'll recheck against the AWT forest and see if there is anything left to
> fix.
>
> BTW, theAWT project page <http://openjdk.java.net/groups/awt/> on
> openjdk does not provide the link to the awt forest.
> And I'm not sure I'm up to the testing requirements on all platforms/all
> tests.
>
> Thanks, Roger
>
> On 11/8/2013 6:46 AM, Yuri Nesterenko wrote:
>> Hi Roger,
>>
>> I'm afraid you'll have to merge with D.Ginzburg's change
>>
>> http://hg.openjdk.java.net/jdk8/awt/jdk/rev/b8eb21e93fa7
>>
>> He was someway late to push it but properly received approvals.
>> Note that the change is in awt+swing team repository. Sorry about that!
>>
>> Thanks,
>> -yan
>>
>> On 11/08/2013 02:02 AM, roger riggs wrote:
>>> This changeset addresses the warnings and errors of doclint and
>>> improves the quality of the generated html.
>>> No spec or implementation is changed by this changeset
>>>
>>> The changes address issues including html syntax, accessibility issues,
>>> and improper html tag use. Refer to the error log attached to the bug
>>> report [1] for details.
>>>
>>> Please review:
>>> http://cr.openjdk.java.net/~rriggs/webrev-lint-swing-8028018/
>>>
>>> Thanks, Roger
>>>
>>>
>>> [1] https://bugs.openjdk.java.net/browse/JDK-8028018
>>
>



From Sergey.Bylokhov at oracle.com  Mon Nov 11 13:39:24 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Mon, 11 Nov 2013 17:39:24 +0400
Subject: <Swing Dev> [8] Review Request: 8027696 Incorrect copyright
 header in the tests
In-Reply-To: <527B99BD.8050401@oracle.com>
References: <52738E00.2070806@oracle.com>
	<5274E3FF.3070807@oracle.com>	<52791C93.1060600@oracle.com>
	<527B77F0.4050109@oracle.com> <527B99BD.8050401@oracle.com>
Message-ID: <5280DE0C.7000503@oracle.com>

Hello.
I'll push the changes, if there are no new objections.

On 07.11.2013 17:46, Sergey Bylokhov wrote:
> On 07.11.2013 15:22, Alan Bateman wrote:
>> Thanks Sergey, I sampled a few and they look correct.
>>
>> The only thing is that I'm not sure about is test/Makefile, it's just 
>> not clear whether which header this should have.
> I can skip it this time.
>


-- 
Best regards, Sergey.



From yhlee at infopro.com.my  Wed Nov 13 05:57:38 2013
From: yhlee at infopro.com.my (yhlee)
Date: Tue, 12 Nov 2013 21:57:38 -0800 (PST)
Subject: <Swing Dev> Seems like JDK-4625667 can be closed now. But can we
 replicate the fix using Java 6?
Message-ID: <1384322258027-166606.post@n7.nabble.com>

Hi,

Seems like  JDK-4625667 (Strange FOCUS_GAINED event is sent to application)
<https://bugs.openjdk.java.net/browse/JDK-4625667>   can be closed now.

The problem occurs if using JDK 1.6 (tested up to update 45), but it does
not occur if using JDK 1.7 (tested update 15 and 40). In JDK 1.6, the
JButton at the bottom of the form gains focus wrongly. In JDK 1.7, the
JTabbedPane gains focus correctly.

I need to ask:
1) How was this fixed? (e.g. which classes/methods were modified to change
this focus traversal behavior?)
2) Is it possible to replicate this fix while still using JDK 1.6?

I'm asking because we need to stick with JDK 1.6 for certain reasons, and
the bug JDK-4625667 causes various issues if we apply auto-scrolling.
Details can be found in this post:
https://forums.oracle.com/thread/2591042
<https://forums.oracle.com/thread/2591042>  

Thanks in advance.


Cheers,
James Lee



--
View this message in context: http://openjdk.5641.n7.nabble.com/Seems-like-JDK-4625667-can-be-closed-now-But-can-we-replicate-the-fix-using-Java-6-tp166606.html
Sent from the OpenJDK Swing Development mailing list archive at Nabble.com.


From sergey.malenkov at oracle.com  Thu Nov 14 13:50:58 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Thu, 14 Nov 2013 17:50:58 +0400
Subject: <Swing Dev> [8] Review request for 8028054:
 com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map
Message-ID: <5284D542.2060102@oracle.com>


Hello,

Could you please review the following fix:
fix: http://cr.openjdk.java.net/~malenkov/8028054.8.0/
bug: https://bugs.openjdk.java.net/browse/JDK-8028054

There is an unsynchronized access to internal caches.
I've synchronized both caches (for methods and constructors) .

The 8023310 issue shows how is slow a simple synchronization.
So I've created the Cache class that is similar to WeakIdentityMap.
Later we could remove WeakIdentityMap which is a special case of Cache.

Thanks,
SAM



From alexandr.scherbatiy at oracle.com  Wed Nov 20 09:04:39 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 20 Nov 2013 13:04:39 +0400
Subject: <Swing Dev> CFV: New Swing Group Member: Petr Pchelko
Message-ID: <528C7B27.7000207@oracle.com>


I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to 
Membership in the Swing Group.

Petr has contributed several changes in Swing, which are a part of JDK8.
Here is the list of fixes:

http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=pchelko

Votes are due by Dec 05, 2013.

Only current Members of the Swing  Group [1] are eligible
to vote on this nomination.

For Lazy Consensus voting instructions, see [2].

Thanks,
Alexandr.

[1] http://openjdk.java.net/census#swing
[2] http://openjdk.java.net/groups/#member-vote



From artem.ananiev at oracle.com  Wed Nov 20 09:18:35 2013
From: artem.ananiev at oracle.com (Artem Ananiev)
Date: Wed, 20 Nov 2013 13:18:35 +0400
Subject: <Swing Dev> CFV: New Swing Group Member: Petr Pchelko
In-Reply-To: <528C7B27.7000207@oracle.com>
References: <528C7B27.7000207@oracle.com>
Message-ID: <528C7E6B.2040102@oracle.com>


Vote: yes.

Artem

On 11/20/2013 1:04 PM, Alexander Scherbatiy wrote:
>
> I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to
> Membership in the Swing Group.
>
> Petr has contributed several changes in Swing, which are a part of JDK8.
> Here is the list of fixes:
>
> http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=pchelko
>
> Votes are due by Dec 05, 2013.
>
> Only current Members of the Swing  Group [1] are eligible
> to vote on this nomination.
>
> For Lazy Consensus voting instructions, see [2].
>
> Thanks,
> Alexandr.
>
> [1] http://openjdk.java.net/census#swing
> [2] http://openjdk.java.net/groups/#member-vote
>


From sergey.malenkov at oracle.com  Wed Nov 20 12:22:24 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Wed, 20 Nov 2013 16:22:24 +0400
Subject: <Swing Dev> CFV: New Swing Group Member: Petr Pchelko
In-Reply-To: <528C7B27.7000207@oracle.com>
References: <528C7B27.7000207@oracle.com>
Message-ID: <528CA980.6030406@oracle.com>

Vote: YES

SAM

On 20.11.2013 13:04, Alexander Scherbatiy wrote:
>
> I hereby nominate Petr Pchelko (OpenJDK user name: pchelko) to 
> Membership in the Swing Group.
>
> Petr has contributed several changes in Swing, which are a part of JDK8.
> Here is the list of fixes:
>
> http://hg.openjdk.java.net/jdk8/awt/jdk/log?rev=pchelko
>
> Votes are due by Dec 05, 2013.
>
> Only current Members of the Swing  Group [1] are eligible
> to vote on this nomination.
>
> For Lazy Consensus voting instructions, see [2].
>
> Thanks,
> Alexandr.
>
> [1] http://openjdk.java.net/census#swing
> [2] http://openjdk.java.net/groups/#member-vote
>



From alexandr.scherbatiy at oracle.com  Thu Nov 21 12:12:30 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 21 Nov 2013 16:12:30 +0400
Subject: <Swing Dev> [8] Review request for 8028054:
 com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map
In-Reply-To: <5284D542.2060102@oracle.com>
References: <5284D542.2060102@oracle.com>
Message-ID: <528DF8AE.6070204@oracle.com>


   The fix looks good for me.

   Thanks,
   Alexandr.

On 11/14/2013 5:50 PM, sergey malenkov wrote:
>
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8028054.8.0/
> bug: https://bugs.openjdk.java.net/browse/JDK-8028054
>
> There is an unsynchronized access to internal caches.
> I've synchronized both caches (for methods and constructors) .
>
> The 8023310 issue shows how is slow a simple synchronization.
> So I've created the Cache class that is similar to WeakIdentityMap.
> Later we could remove WeakIdentityMap which is a special case of Cache.
>
> Thanks,
> SAM
>



From Sergey.Bylokhov at oracle.com  Fri Nov 22 12:50:03 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 22 Nov 2013 16:50:03 +0400
Subject: <Swing Dev> [8] Review request for 8028054:
 com.sun.beans.finder.MethodFinder has unsynchronized access to a static Map
In-Reply-To: <5284D542.2060102@oracle.com>
References: <5284D542.2060102@oracle.com>
Message-ID: <528F52FB.4080101@oracle.com>

Hi, Sergey.
The fix looks good.

On 14.11.2013 17:50, sergey malenkov wrote:
>
> Hello,
>
> Could you please review the following fix:
> fix: http://cr.openjdk.java.net/~malenkov/8028054.8.0/
> bug: https://bugs.openjdk.java.net/browse/JDK-8028054
>
> There is an unsynchronized access to internal caches.
> I've synchronized both caches (for methods and constructors) .
>
> The 8023310 issue shows how is slow a simple synchronization.
> So I've created the Cache class that is similar to WeakIdentityMap.
> Later we could remove WeakIdentityMap which is a special case of Cache.
>
> Thanks,
> SAM
>


-- 
Best regards, Sergey.



From Sergey.Bylokhov at oracle.com  Wed Nov 27 11:30:44 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Wed, 27 Nov 2013 15:30:44 +0400
Subject: <Swing Dev> [8] Review Request: 8029024 [TEST_BUG ]
 java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java fails
Message-ID: <5295D7E4.3080708@oracle.com>

Hello.
Please review the fix for jdk 8.
  - Click coordinates was corrected. Size of the frame was increased. 
Timeouts increased. Now the test passes on jdk 8 and fails on jdk7.

Bug: https://bugs.openjdk.java.net/browse/JDK-8029024
Webrev can be found at: http://cr.openjdk.java.net/~serb/8029024/webrev.00

-- 
Best regards, Sergey.


From alexandr.scherbatiy at oracle.com  Wed Nov 27 12:33:26 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Wed, 27 Nov 2013 16:33:26 +0400
Subject: <Swing Dev> [8] Review Request: 8029024 [TEST_BUG ]
 java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java fails
In-Reply-To: <5295D7E4.3080708@oracle.com>
References: <5295D7E4.3080708@oracle.com>
Message-ID: <5295E696.6030206@oracle.com>


    The fix looks good for me.

    It seems that AWT alias is more suitable for this issue.

    Thanks,
    Alexandr.

On 11/27/2013 3:30 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
>  - Click coordinates was corrected. Size of the frame was increased. 
> Timeouts increased. Now the test passes on jdk 8 and fails on jdk7.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8029024
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8029024/webrev.00
>



From sergey.malenkov at oracle.com  Wed Nov 27 12:40:24 2013
From: sergey.malenkov at oracle.com (sergey malenkov)
Date: Wed, 27 Nov 2013 16:40:24 +0400
Subject: <Swing Dev> [8] Review Request: 8029024 [TEST_BUG ]
 java/awt/Modal/ModalDialogOrderingTest/ModalDialogOrderingTest.java fails
In-Reply-To: <5295D7E4.3080708@oracle.com>
References: <5295D7E4.3080708@oracle.com>
Message-ID: <5295E838.7010102@oracle.com>

The fix looks good.

Thanks,
SAM

On 27.11.2013 15:30, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
>  - Click coordinates was corrected. Size of the frame was increased. 
> Timeouts increased. Now the test passes on jdk 8 and fails on jdk7.
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8029024
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8029024/webrev.00
>



From Sergey.Bylokhov at oracle.com  Thu Nov 28 12:56:48 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Thu, 28 Nov 2013 16:56:48 +0400
Subject: <Swing Dev> [8] Review Request: 8029010 [macosx] Need test for
	JDK-7124513
Message-ID: <52973D90.5080107@oracle.com>

Hello.
Please review the fix for jdk 8.
The test is for "apple.awt.brushMetalLook" and "Window.style", which 
were added in the JDK-7124513

Bug: https://bugs.openjdk.java.net/browse/JDK-8029010
Webrev can be found at: http://cr.openjdk.java.net/~serb/8029010/webrev.00

-- 
Best regards, Sergey.



From alexandr.scherbatiy at oracle.com  Thu Nov 28 13:52:57 2013
From: alexandr.scherbatiy at oracle.com (Alexander Scherbatiy)
Date: Thu, 28 Nov 2013 17:52:57 +0400
Subject: <Swing Dev> [8] Review Request: 8029010 [macosx] Need test for
 JDK-7124513
In-Reply-To: <52973D90.5080107@oracle.com>
References: <52973D90.5080107@oracle.com>
Message-ID: <52974AB9.2000102@oracle.com>


  The fix looks good for me.

  Thanks,
  Alexandr.

On 11/28/2013 4:56 PM, Sergey Bylokhov wrote:
> Hello.
> Please review the fix for jdk 8.
> The test is for "apple.awt.brushMetalLook" and "Window.style", which 
> were added in the JDK-7124513
>
> Bug: https://bugs.openjdk.java.net/browse/JDK-8029010
> Webrev can be found at: 
> http://cr.openjdk.java.net/~serb/8029010/webrev.00
>



From petr.pchelko at oracle.com  Fri Nov 29 10:10:13 2013
From: petr.pchelko at oracle.com (Petr Pchelko)
Date: Fri, 29 Nov 2013 14:10:13 +0400
Subject: <Swing Dev> [8] Review Request: 8029010 [macosx] Need test for
	JDK-7124513
In-Reply-To: <52974AB9.2000102@oracle.com>
References: <52973D90.5080107@oracle.com> <52974AB9.2000102@oracle.com>
Message-ID: <C1858737-5B1C-4C6A-BA55-33928DEB32F4@oracle.com>

Hello, Sergey.

The fix looks good, just 2 tiny comments:

line 64: you have a typo: shuould
line 65: testImages(images[1], images[1], false) - I believe this is also a typo, you are comparing the same images, so the second 1 should be changed to 2.

With best regards. Petr.

On 28.11.2013, at 17:52, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:

> 
> The fix looks good for me.
> 
> Thanks,
> Alexandr.
> 
> On 11/28/2013 4:56 PM, Sergey Bylokhov wrote:
>> Hello.
>> Please review the fix for jdk 8.
>> The test is for "apple.awt.brushMetalLook" and "Window.style", which were added in the JDK-7124513
>> 
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029010
>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8029010/webrev.00
>> 
> 



From Sergey.Bylokhov at oracle.com  Fri Nov 29 10:08:27 2013
From: Sergey.Bylokhov at oracle.com (Sergey Bylokhov)
Date: Fri, 29 Nov 2013 14:08:27 +0400
Subject: <Swing Dev> [8] Review Request: 8029010 [macosx] Need test for
 JDK-7124513
In-Reply-To: <C1858737-5B1C-4C6A-BA55-33928DEB32F4@oracle.com>
References: <52973D90.5080107@oracle.com> <52974AB9.2000102@oracle.com>
	<C1858737-5B1C-4C6A-BA55-33928DEB32F4@oracle.com>
Message-ID: <5298679B.4090501@oracle.com>

On 11/29/13 2:10 PM, Petr Pchelko wrote:
> Hello, Sergey.
>
> The fix looks good, just 2 tiny comments:
Big thanks! Will fix that.

>
> line 64: you have a typo: shuould
> line 65: testImages(images[1], images[1], false) - I believe this is also a typo, you are comparing the same images, so the second 1 should be changed to 2.
>
> With best regards. Petr.
>
> On 28.11.2013, at 17:52, Alexander Scherbatiy <alexandr.scherbatiy at oracle.com> wrote:
>
>> The fix looks good for me.
>>
>> Thanks,
>> Alexandr.
>>
>> On 11/28/2013 4:56 PM, Sergey Bylokhov wrote:
>>> Hello.
>>> Please review the fix for jdk 8.
>>> The test is for "apple.awt.brushMetalLook" and "Window.style", which were added in the JDK-7124513
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8029010
>>> Webrev can be found at: http://cr.openjdk.java.net/~serb/8029010/webrev.00
>>>


-- 
Best regards, Sergey.