<Swing Dev> [9] Review Request for 8078269: JTabbedPane UI Property TabbedPane.tabAreaBackground no longer works

[Semyon Sadetsky]

Sergey,

Why the component background priority looks reasonable for you?
A component has only one background color which is set by L&F to the 
default value. But it is not enough for the tabbed pane component which 
has more then one background surfaces and L&F can define more background 
colors to paint tabbed pane more precisely. In this case the common 
component background should have second priority.

--Semyon

On 5/14/2015 5:39 PM, Sergey Bylokhov wrote:
> Hi, Semyon.
> Usage of background(if it was set) instead of property looks 
> reasonable. Please clarify who sets default color of component 
> explicitly to the value other than from UI property?
>
> On 14.05.15 17:12, Semyon Sadetsky wrote:
>> Hello,
>>
>> Please review fix for JDK9:
>>
>> bug: https://bugs.openjdk.java.net/browse/JDK-8078269
>> webrev: http://cr.openjdk.java.net/~ssadetsky/8078269/webrev.00/
>>
>> This is regression of the 8007563 which was incorrect fix of the 
>> 4690946 regression.
>> Actually the 4690946 was a test bug because tab area's background can 
>> be controlled separately using "TabbedPane.tabAreaBackground" property.
>> Presence of "TabbedPane.tabAreaBackground" depends on L&F. Test of 
>> the 4690946 is fixed to take this into account.
>>
>> Also inappropriate design chosen for the 8007563 reg test code 
>> affected test results stability. It also has been fixed.
>>
>> --Semyon
>
>