<Swing Dev> [8u-dev] Review request for 8080628: No mnemonics on Open and Save buttons in JFileChooser

Alexander Scherbatiy alexandr.scherbatiy at oracle.com
Tue May 26 13:59:29 UTC 2015

   The fix looks good to me.


On 5/26/2015 4:54 PM, Alexey Ivanov wrote:
> Hello Swing team,
> Could you please review the fix for JDK 8:
>     bug: https://bugs.openjdk.java.net/browse/JDK-8080628
>     webrev: http://cr.openjdk.java.net/~aivanov/8080628/jdk8/webrev.00/
> JDK9 code review: 
> http://mail.openjdk.java.net/pipermail/swing-dev/2015-May/004547.html
> The changes in JDK 8 are the same as in JDK 9, yet there are more 
> files that need to be updated: basic_ja.properties, 
> basic_ko.properties, basic_zh_CN.properties, basic_zh_TW.properties.
> For completeness, here's the information from JDK 9 code review:
> Description:
> Since Open and Save buttons in JFileChooser are default ones, 
> mnemonics are redundant on these buttons.
> There's no mnemonic on Open and Save buttons in Metal Look-and-Feel 
> but it's displayed on Open button when a directory is selected in the 
> file list. This is inconsistent.
> The fix:
> Remove mnemonics in JFileChooser from basic.properties which is used 
> as the base for translation updates.
> Remove separate JFileChooser keys from metal.properties since they're 
> the same as in basic.properties now.
> The test:
> Regression test checks Open, Save, and Cancel buttons in JFileChooser 
> have no mnemonics in all the supported localizations in all the 
> installed look-and-feels.
> Thanks,
> Alexey

More information about the swing-dev mailing list