<Swing Dev> RFR: 8041705 Bugs in DefaultTreeCellRenderer.updateUI()

Tejpal Rebari tejpal.rebari at oracle.com
Fri Jun 26 05:42:03 UTC 2020


Hi All,
Please review the following fix for jdk16.

Bug : https://bugs.openjdk.java.net/browse/JDK-8041705 <https://bugs.openjdk.java.net/browse/JDK-8041705>
Webrev : http://cr.openjdk.java.net/~trebari/swing/8041705/webrev00/ <http://cr.openjdk.java.net/~trebari/swing/8041705/webrev00/>

Issue : The issue is that, border in DefaultTreeCellRenderer is not removed 
if the margin is null.If we set the Nimbus LAF and then switch to  metal LAF 
nimbus border persists.

Fix : Added else part of the if(margins != null) , which will set border with margin
(0, 0, 0, 0) when the DefaultLookup.getInsets(this, ui, "Tree.rendererMargins”) returns  null,
removing the previous margin.

Test : Added an automated test.
Tested on all the three platforms. Mach5 link is in JBS.


Regards
Tejpal
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.java.net/pipermail/swing-dev/attachments/20200626/78b74a99/attachment.htm>


More information about the swing-dev mailing list