<Swing Dev> RFR: 8272148: JDesktopPane:getComponentCount() returns one extra than expected with GTKLookAndFeel

Pankaj Bansal pbansal at openjdk.java.net
Thu Aug 19 19:48:27 UTC 2021


On Thu, 19 Aug 2021 12:11:23 GMT, Prasanta Sadhukhan <psadhukhan at openjdk.org> wrote:

> > The "InternalFrame.useTaskBar" is set true in case of GTKL&F only,
> 
> What if we set this property to false and only set under some condition for GTK L&F, what sort of problem we can expect? Does any jtreg/jck test gets affected if we set it to false?

I just ran a mach5 job with the "InternalFrame.useTaskBar" set to true with GTKL&F. Link in JBS. I do not see any issue due to this. The failures are not related to this change.

My point is that, as discussed in the meeting, this is not related to GTKL&F. Anyone can make a custom container and add some default components and this test will fail for that container. So rather than setting "InternalFrame.useTaskBar" to TRUE for GTL L&F just to solve this issue quickly but wrong way, we should make changes to the spec and state that this is allowed. Similar things could have been done in other components for other L&Fs, which may have not yet been reported.

-------------

PR: https://git.openjdk.java.net/jdk/pull/5121


More information about the swing-dev mailing list