RFR 8183130: [MVT] Implement intrinsics for Q-typed LambdaForms
Maurizio Cimadamore
maurizio.cimadamore at oracle.com
Wed Jul 5 12:19:34 UTC 2017
Hi,
I've done a bigger rewriting of the patch, (and I also removed the
assertion). Now the organization is such that the intrinsic code can
take more advantage of the fluent style of code builders - this is
particularly evident in emitSelectAlternatives (but emitLoop has
improved too).
http://cr.openjdk.java.net/~mcimadamore/8183130_v2
Maurizio
On 03/07/17 22:11, Maurizio Cimadamore wrote:
> I've missed that, sorry - I will remove the assertion
>
> Maurizio
>
>
> On 03/07/17 22:00, Vladimir Ivanov wrote:
>> From correctness POV, it's perfectly fine to miss an intrinsic
>> opportunity. So, I'd prefer to avoid throwing an error until all
>> intrinsics are implemented:
>>
>> + default: {
>> + throw newInternalError("Unknown intrinsic: "+intr);
>> + }
>>
>> Otherwise, looks good.
>>
>> Best regards,
>> Vladimir Ivanov
>>
>> On 7/3/17 5:27 PM, Maurizio Cimadamore wrote:
>>> Hi,
>>> This patch adds support for intrinsic in LambdaFormBuilder. More
>>> intrinsics to come in separate followup patches.
>>>
>>> http://cr.openjdk.java.net/~mcimadamore/8183130/
>>>
>>> Thanks
>>> Maurizio
>>>
>>>
>
More information about the valhalla-dev
mailing list