RFR(XS): 8183233: [MVT] "unexpected value type klass" assert in ValueTypeNode::is_loaded()
tobias.hartmann at oracle.com
Wed Jul 5 14:23:36 UTC 2017
On 05.07.2017 15:46, Karen Kinnear wrote:
> It seems wrong to me to enable MVT if CompileTheWorld is true.
> It makes more sense to me to explicitly disable compiling java.lang.__Value if !EnableMVT && !EnableValhalla.
Yes, that's correct but I was concerned that there are other points of friction where we may encounter __Value although MVT/Valhalla is not enabled. For example, in Class::isValueClass() we reference __Value . Looking at it again, it shouldn't be a problem (it actually is the same with -Xcomp).
That said, I agree that we should probably just disable compilation of __Value if CompileTheWorld is true. I'll prepare a new fix.
>> On Jul 5, 2017, at 9:18 AM, Tobias Hartmann <tobias.hartmann at oracle.com> wrote:
>> Thanks Roland!
>> (I'll look at your changes as soon as possible, just very busy with other stuff atm).
>> Best regards,
>> On 05.07.2017 15:09, Roland Westrelin wrote:
>>> Looks ok to me.
More information about the valhalla-dev